From: Kees Cook <keescook@chromium.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
Masanari Iida <standby24x7@gmail.com>,
linux-doc <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v2] checkpatch: look for common misspellings
Date: Thu, 11 Sep 2014 07:12:24 -0700 [thread overview]
Message-ID: <CAGXu5jKndemuqx=uFXSSEgD9v2U4b4E8Eh6O=FFNw+GL7fixxA@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdUvBdEKCYezARJ8PvuQPQbi+Wq-fwO+Z2cxYXOtVzp5GQ@mail.gmail.com>
On Thu, Sep 11, 2014 at 12:19 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Thu, Sep 11, 2014 at 12:52 AM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
>> On Mon, 8 Sep 2014 11:15:24 -0700 Kees Cook <keescook@chromium.org> wrote:
>>
>>> Check for misspellings, based on Debian's lintian list. Several false
>>> positives were removed, and several additional words added that were
>>> common in the kernel:
>>>
>>> backword backwords
>>> invalide valide
>>> recieves
>>> singed unsinged
>>>
>>> While going back and fixing existing spelling mistakes isn't a high
>>> priority, it'd be nice to try to catch them before they hit the tree.
>>
>> I have a feeling this is going to be a rat hole and that
>> scripts/spelling.txt will grow to consume the planet. Oh well, whatev.
>
> What about making checkpatch use the codespell dictionay if codespell
> is installed?
>
> Codespell is in Ubuntu 14.04LTS (but not in 12.04LTS).
It's probably not a bad idea, but given the level of pruning that's
been needed already to keep down the false positive rate, I'm nervous
about a larger "general" corpus.
-Kees
--
Kees Cook
Chrome OS Security
next prev parent reply other threads:[~2014-09-11 14:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 18:15 [PATCH v2] checkpatch: look for common misspellings Kees Cook
2014-09-08 18:48 ` Joe Perches
2014-09-10 4:37 ` Masanari Iida
2014-09-10 7:00 ` Joe Perches
2014-09-10 22:52 ` Andrew Morton
2014-09-11 2:10 ` Joe Perches
2014-09-11 7:19 ` Geert Uytterhoeven
2014-09-11 14:12 ` Kees Cook [this message]
2014-09-11 14:15 ` Joe Perches
2014-09-12 4:09 ` Masanari Iida
2014-09-12 4:45 ` Joe Perches
2014-09-12 10:30 ` Masanari Iida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5jKndemuqx=uFXSSEgD9v2U4b4E8Eh6O=FFNw+GL7fixxA@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=geert@linux-m68k.org \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=standby24x7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.