From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752439AbbKMXqM (ORCPT ); Fri, 13 Nov 2015 18:46:12 -0500 Received: from mail-ig0-f180.google.com ([209.85.213.180]:33237 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071AbbKMXqK (ORCPT ); Fri, 13 Nov 2015 18:46:10 -0500 MIME-Version: 1.0 In-Reply-To: <27017B294887C64C94ACAE870D1C65952A977B13@DEMUMBX013.nsn-intra.net> References: <27017B294887C64C94ACAE870D1C65952A977B13@DEMUMBX013.nsn-intra.net> Date: Fri, 13 Nov 2015 15:46:09 -0800 X-Google-Sender-Auth: be96La66-JUNmN8iDKkjYd8ftow Message-ID: Subject: Re: [PATCH] pstore: add support for 64 Bit address space From: Kees Cook To: "Wiebe, Wladislav (Nokia - DE/Ulm)" Cc: "anton@enomsg.org" , "ccross@android.com" , "tony.luck@intel.com" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 13, 2015 at 4:10 AM, Wiebe, Wladislav (Nokia - DE/Ulm) wrote: > Some architectures has there reserved RAM in 64 Bit address space. > Therefore converting mem_address module parameter to ullong. > > Signed-off-by: Wladislav Wiebe If this works correctly, I have no objection. :) Acked-by: Kees Cook Thanks! -Kees > --- > fs/pstore/ram.c | 4 ++-- > include/linux/pstore_ram.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c > index 319c3a6..bd9812e 100644 > --- a/fs/pstore/ram.c > +++ b/fs/pstore/ram.c > @@ -55,8 +55,8 @@ static ulong ramoops_pmsg_size = MIN_MEM_SIZE; > module_param_named(pmsg_size, ramoops_pmsg_size, ulong, 0400); > MODULE_PARM_DESC(pmsg_size, "size of user space message log"); > > -static ulong mem_address; > -module_param(mem_address, ulong, 0400); > +static unsigned long long mem_address; > +module_param(mem_address, ullong, 0400); > MODULE_PARM_DESC(mem_address, > "start of reserved RAM used to store oops/panic logs"); > > diff --git a/include/linux/pstore_ram.h b/include/linux/pstore_ram.h > index 9c9d6c1..4660aaa 100644 > --- a/include/linux/pstore_ram.h > +++ b/include/linux/pstore_ram.h > @@ -76,7 +76,7 @@ ssize_t persistent_ram_ecc_string(struct persistent_ram_zone *prz, > > struct ramoops_platform_data { > unsigned long mem_size; > - unsigned long mem_address; > + phys_addr_t mem_address; > unsigned int mem_type; > unsigned long record_size; > unsigned long console_size; > -- > 1.7.1 > > Regards, > Wladislav Wiebe > > -- Kees Cook Chrome OS Security