From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755444AbdKJBEE (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Nov 2017 20:04:04 -0500
Received: from mail-io0-f182.google.com ([209.85.223.182]:50534 "EHLO
        mail-io0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755136AbdKJBED (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Nov 2017 20:04:03 -0500
X-Google-Smtp-Source: AGs4zMbI3zWMLEnjxwnIM2FgWQ4mGPzqQvPcRDVyN5PlULVOAEWrJYfEUZVJsXLFJhMhbM6u3mRl5qYZ8oefAcDWmxo=
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1711100144410.2690@nanos>
References: <20171108160056.3042976-1-arnd@arndb.de> <CAGXu5jJuCQvLmsBdtASPx5hLDBYYLb6p8r_H09N8o8EZLy+SMg@mail.gmail.com>
 <CAK8P3a2WQGzVd3p-Ps9RaFNasSKiNm9pZEb8hxZt=42QXNH_mQ@mail.gmail.com>
 <alpine.DEB.2.20.1711092338470.2690@nanos> <CAK8P3a1TWCSMoApGqEdmkLHVLgFdG0Zj2cg3B2hFLX-x5_5ueA@mail.gmail.com>
 <alpine.DEB.2.20.1711100144410.2690@nanos>
From: Kees Cook <keescook@chromium.org>
Date: Thu, 9 Nov 2017 17:04:01 -0800
X-Google-Sender-Auth: nEooBeVDW5i29Kt4E4fmwhIEinE
Message-ID: <CAGXu5jKs2UWcjLwMq+_94etrQhiZs=x79tL251d1L=5t4DYkUg@mail.gmail.com>
Subject: Re: [PATCH] pstore: use ktime_get_real_fast_ns() instead of __getnstimeofday()
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Arnd Bergmann <arnd@arndb.de>, Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
        John Stultz <john.stultz@linaro.org>,
        Stephen Boyd <sboyd@codeaurora.org>, Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 9, 2017 at 4:46 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Fri, 10 Nov 2017, Arnd Bergmann wrote:
>> On Fri, Nov 10, 2017 at 12:00 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
>> > Hmm, no. None of the regular accessor functions can be called from NMI
>> > context safely.
>>
>> Right, that's what I mean: it must not get called from NMI context, but it
>> currently is, at least for this case:
>>
>> NMI handler:
>>   something bad
>>     panic()
>>       kmsg_dump()
>>         pstore_dump()
>>            pstore_record_init()
>>              __getnstimeofday()
>>
>> I should probably add that to the changelog text ;-)
>
> Indeed.

Er, so, is this safe to call there? I've had to fix this a few times
now, so if using ktime_get_real_fast_ns() can be used here (and
doesn't return 0) then this is easily an improvement over the existing
"maybe read 0" case pstore has now.

-Kees


-- 
Kees Cook
Pixel Security