From: Kees Cook <keescook@chromium.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Hector Marco-Gisbert <hecmargi@upv.es>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
Ismael Ripoll Ripoll <iripoll@upv.es>,
Harvey Harrison <harvey.harrison@gmail.com>
Subject: Re: [PATCH] x86: Enable full randomization on i386 and X86_32.
Date: Fri, 11 Mar 2016 08:19:49 -0800 [thread overview]
Message-ID: <CAGXu5jKyxQ+7rJAhs_O3sGHxXP7Te81mEJ4HJ+f8zBbu1PpZSw@mail.gmail.com> (raw)
In-Reply-To: <20160311085301.GB29750@gmail.com>
On Fri, Mar 11, 2016 at 12:53 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Kees Cook <keescook@chromium.org> wrote:
>
>> On Thu, Mar 10, 2016 at 12:53 PM, Arjan van de Ven
>> <arjan@linux.intel.com> wrote:
>> >> Arjan, or other folks, can you remember why x86_32 disabled mmap
>> >> randomization here? There doesn't seem to be a good reason for it that
>> >> I see.
>> >
>> >
>> > for unlimited stack it got really messy with threaded apps.
>>
>> Seems like it'd only cause problems for really really giant processes?
>> (I think it's telling that the other 32-bit archs don't disable ASLR
>> in this case...)
>
> IIRC there was some sort of specific breakage with unlimited stack apps - I don't
> remember the exact details.
>
>> > anyway, I don't mind seeing if this will indeed work, with time running out
>> > where 32 bit is going extinct... in a few years we just won't have enough
>> > testing on this kind of change anymore.
>>
>> Sounds good. Ingo, can you pull this in and we can try it for -next?
>
> Ok, we can certainly try. If there's breakage with old distros then we might need
> to put this behind a legacy Kconfig switch.
Okay, sounds good. Thanks!
-Kees
--
Kees Cook
Chrome OS & Brillo Security
next prev parent reply other threads:[~2016-03-11 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 19:51 [PATCH] x86: Enable full randomization on i386 and X86_32 Hector Marco-Gisbert
2016-03-10 20:23 ` Kees Cook
2016-03-10 20:53 ` Arjan van de Ven
2016-03-10 21:05 ` Kees Cook
2016-03-11 8:53 ` Ingo Molnar
2016-03-11 16:19 ` Kees Cook [this message]
2016-03-11 8:51 ` Ingo Molnar
2016-03-12 15:15 ` [tip:x86/mm] x86/mm/32: " tip-bot for Hector Marco-Gisbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jKyxQ+7rJAhs_O3sGHxXP7Te81mEJ4HJ+f8zBbu1PpZSw@mail.gmail.com \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=harvey.harrison@gmail.com \
--cc=hecmargi@upv.es \
--cc=hpa@zytor.com \
--cc=iripoll@upv.es \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.