Re: [RFC PATCH -tip 0/5] kprobes: Abolish jprobe APIs

From: Kees Cook <keescook@chromium.org>
To: Ingo Molnar <mingo@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
	"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
	"David S . Miller" <davem@davemloft.net>,
	Ian McDonald <ian.mcdonald@jandi.co.nz>,
	Vlad Yasevich <vyasevich@gmail.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [RFC PATCH -tip 0/5] kprobes: Abolish jprobe APIs
Date: Fri, 20 Oct 2017 09:28:33 -0700	[thread overview]
Message-ID: <CAGXu5jLEhV+f-+1muz8nN0cWRvKP0aEEgG6X=5DOASY=MGmgzA@mail.gmail.com> (raw)
In-Reply-To: <20171020151751.drjmkxkt2orbteag@gmail.com>

On Fri, Oct 20, 2017 at 8:17 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Kees Cook <keescook@chromium.org> wrote:
>
>> On Fri, Oct 20, 2017 at 5:22 AM, Ingo Molnar <mingo@kernel.org> wrote:
>> >
>> > Ok, could we now also fix these:
>> >
>> > net/dccp/probe.c:166:2: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > net/dccp/probe.c:170:4: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > net/dccp/probe.c:190:2: warning: ‘unregister_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > drivers/misc/lkdtm_core.c:317:3: warning: ‘unregister_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > drivers/misc/lkdtm_core.c:322:2: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > drivers/misc/lkdtm_core.c:560:3: warning: ‘unregister_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > net/sctp/probe.c:189:2: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > net/sctp/probe.c:194:3: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > net/sctp/probe.c:240:2: warning: ‘unregister_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > net/ipv4/tcp_probe.c:280:2: warning: ‘register_jprobe’ is deprecated [-Wdeprecated-declarations]
>> > net/ipv4/tcp_probe.c:298:2: warning: ‘unregister_jprobe’ is deprecated [-Wdeprecated-declarations]
>> >
>> > I'd suggest removing the networking ones and Cc:-ing it to the networking folks -
>> > I strongly doubt anyone is using that functionality for real.
>> >
>> > The LKDTM one Kees had some ideas (patches?) for?
>>
>> Oops, yes, I've sent this patch to Greg now. I had let it sit for a
>> few days of 0-day testing and promptly forgot about it. ;)
>
> Could we, as a special exception, carry this patch in -tip, so that the probes
> related changes stay togher - or is it too distruptive to the flow of other
> in-flight LKDTM patches, creating conflicts, etc.?

I have no problem with that, sure; these were the only outstanding
lkdtm patches (one for jprobes removal, and another for const
clean-ups noticed during the first patch's work). However, Greg pulled
them to his -testing tree already, so I guess it's up to him. Just let
me know what I can do to help. :)

-Kees

-- 
Kees Cook
Pixel Security