From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751836AbdGaWUA (ORCPT ); Mon, 31 Jul 2017 18:20:00 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:34130 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751339AbdGaWT6 (ORCPT ); Mon, 31 Jul 2017 18:19:58 -0400 MIME-Version: 1.0 In-Reply-To: <20170724190757.11278-11-brijesh.singh@amd.com> References: <20170724190757.11278-1-brijesh.singh@amd.com> <20170724190757.11278-11-brijesh.singh@amd.com> From: Kees Cook Date: Mon, 31 Jul 2017 15:19:56 -0700 X-Google-Sender-Auth: Co4SkvMT6e5_u2rdiJikziAcOx4 Message-ID: Subject: Re: [RFC Part1 PATCH v3 10/17] resource: Provide resource struct in resource walk callback To: Brijesh Singh Cc: LKML , "x86@kernel.org" , "linux-efi@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , KVM , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Borislav Petkov , Andy Lutomirski , Tony Luck , Piotr Luc , Tom Lendacky , Fenghua Yu , Lu Baolu , Reza Arbab , David Howells , Matt Fleming , "Kirill A . Shutemov" , Laura Abbott , Ard Biesheuvel , Andrew Morton , Eric Biederman , Benjamin Herrenschmidt , Paul Mackerras , Konrad Rzeszutek Wilk , Jonathan Corbet , Dave Airlie , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Arnd Bergmann , Tejun Heo , Christoph Lameter Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 24, 2017 at 12:07 PM, Brijesh Singh wrote: > From: Tom Lendacky > > In prep for a new function that will need additional resource information > during the resource walk, update the resource walk callback to pass the > resource structure. Since the current callback start and end arguments > are pulled from the resource structure, the callback functions can obtain > them from the resource structure directly. > > Signed-off-by: Tom Lendacky > Signed-off-by: Brijesh Singh This is a nice clean up even without the refactoring need. :) Reviewed-by: Kees Cook Thanks! -Kees -- Kees Cook Pixel Security From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [RFC Part1 PATCH v3 10/17] resource: Provide resource struct in resource walk callback Date: Mon, 31 Jul 2017 15:19:56 -0700 Message-ID: References: <20170724190757.11278-1-brijesh.singh@amd.com> <20170724190757.11278-11-brijesh.singh@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20170724190757.11278-11-brijesh.singh@amd.com> Sender: linux-kernel-owner@vger.kernel.org To: Brijesh Singh Cc: LKML , "x86@kernel.org" , "linux-efi@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , KVM , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Borislav Petkov , Andy Lutomirski , Tony Luck , Piotr Luc , Tom Lendacky , Fenghua Yu , Lu Baolu , Reza Arbab , David Howells , Matt Fleming , "Kirill A . Shutemov" Laura Abbott List-Id: linux-efi@vger.kernel.org On Mon, Jul 24, 2017 at 12:07 PM, Brijesh Singh wrote: > From: Tom Lendacky > > In prep for a new function that will need additional resource information > during the resource walk, update the resource walk callback to pass the > resource structure. Since the current callback start and end arguments > are pulled from the resource structure, the callback functions can obtain > them from the resource structure directly. > > Signed-off-by: Tom Lendacky > Signed-off-by: Brijesh Singh This is a nice clean up even without the refactoring need. :) Reviewed-by: Kees Cook Thanks! -Kees -- Kees Cook Pixel Security From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [RFC Part1 PATCH v3 10/17] resource: Provide resource struct in resource walk callback Date: Mon, 31 Jul 2017 15:19:56 -0700 Message-ID: References: <20170724190757.11278-1-brijesh.singh@amd.com> <20170724190757.11278-11-brijesh.singh@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: LKML , "x86@kernel.org" , "linux-efi@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , KVM , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Borislav Petkov , Andy Lutomirski , Tony Luck , Piotr Luc , Tom Lendacky , Fenghua Yu , Lu Baolu , Reza Arbab , David Howells , Matt Fleming , "Kirill A . Shutemov" , Laura Abbott Return-path: In-Reply-To: <20170724190757.11278-11-brijesh.singh@amd.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Mon, Jul 24, 2017 at 12:07 PM, Brijesh Singh wrote: > From: Tom Lendacky > > In prep for a new function that will need additional resource information > during the resource walk, update the resource walk callback to pass the > resource structure. Since the current callback start and end arguments > are pulled from the resource structure, the callback functions can obtain > them from the resource structure directly. > > Signed-off-by: Tom Lendacky > Signed-off-by: Brijesh Singh This is a nice clean up even without the refactoring need. :) Reviewed-by: Kees Cook Thanks! -Kees -- Kees Cook Pixel Security