From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751423AbcGMWEg (ORCPT ); Wed, 13 Jul 2016 18:04:36 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:37842 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751272AbcGMWEa (ORCPT ); Wed, 13 Jul 2016 18:04:30 -0400 MIME-Version: 1.0 In-Reply-To: References: <1468446964-22213-1-git-send-email-keescook@chromium.org> <1468446964-22213-2-git-send-email-keescook@chromium.org> From: Kees Cook Date: Wed, 13 Jul 2016 15:04:26 -0700 X-Google-Sender-Auth: 6wCAL58PLgAONHDK9tR0YNU_0LI Message-ID: Subject: Re: [PATCH v2 01/11] mm: Implement stack frame object validation To: Andy Lutomirski Cc: "linux-kernel@vger.kernel.org" , Rik van Riel , Casey Schaufler , PaX Team , Brad Spengler , Russell King , Catalin Marinas , Will Deacon , Ard Biesheuvel , Benjamin Herrenschmidt , Michael Ellerman , Tony Luck , Fenghua Yu , "David S. Miller" , X86 ML , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Andy Lutomirski , Borislav Petkov , Mathias Krause , Jan Kara , Vitaly Wool , Andrea Arcangeli , Dmitry Vyukov , Laura Abbott , "linux-arm-kernel@lists.infradead.org" , "linux-ia64@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , sparclinux , linux-arch , "linux-mm@kvack.org" , "kernel-hardening@lists.openwall.com" , Josh Poimboeuf Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 13, 2016 at 3:01 PM, Andy Lutomirski wrote: > On Wed, Jul 13, 2016 at 2:55 PM, Kees Cook wrote: >> This creates per-architecture function arch_within_stack_frames() that >> should validate if a given object is contained by a kernel stack frame. >> Initial implementation is on x86. >> >> This is based on code from PaX. >> > > This, along with Josh's livepatch work, are two examples of unwinders > that matter for correctness instead of just debugging. ISTM this > should just use Josh's code directly once it's been written. Do you have URL for Josh's code? I'd love to see what happening there. In the meantime, usercopy can use this... -Kees -- Kees Cook Chrome OS & Brillo Security From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH v2 01/11] mm: Implement stack frame object validation Date: Wed, 13 Jul 2016 15:04:26 -0700 Message-ID: References: <1468446964-22213-1-git-send-email-keescook@chromium.org> <1468446964-22213-2-git-send-email-keescook@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: owner-linux-mm@kvack.org To: Andy Lutomirski Cc: "linux-kernel@vger.kernel.org" , Rik van Riel , Casey Schaufler , PaX Team , Brad Spengler , Russell King , Catalin Marinas , Will Deacon , Ard Biesheuvel , Benjamin Herrenschmidt , Michael Ellerman , Tony Luck , Fenghua Yu , "David S. Miller" , X86 ML , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Andy Lutomirski , Borislav Petkov , Mathias Krause List-Id: linux-arch.vger.kernel.org On Wed, Jul 13, 2016 at 3:01 PM, Andy Lutomirski wrote: > On Wed, Jul 13, 2016 at 2:55 PM, Kees Cook wrote: >> This creates per-architecture function arch_within_stack_frames() that >> should validate if a given object is contained by a kernel stack frame. >> Initial implementation is on x86. >> >> This is based on code from PaX. >> > > This, along with Josh's livepatch work, are two examples of unwinders > that matter for correctness instead of just debugging. ISTM this > should just use Josh's code directly once it's been written. Do you have URL for Josh's code? I'd love to see what happening there. In the meantime, usercopy can use this... -Kees -- Kees Cook Chrome OS & Brillo Security -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com ([74.125.82.47]:37843 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751272AbcGMWEo (ORCPT ); Wed, 13 Jul 2016 18:04:44 -0400 Received: by mail-wm0-f47.google.com with SMTP id i5so88801860wmg.0 for ; Wed, 13 Jul 2016 15:04:33 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1468446964-22213-1-git-send-email-keescook@chromium.org> <1468446964-22213-2-git-send-email-keescook@chromium.org> From: Kees Cook Date: Wed, 13 Jul 2016 15:04:26 -0700 Message-ID: Subject: Re: [PATCH v2 01/11] mm: Implement stack frame object validation Content-Type: text/plain; charset=UTF-8 Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andy Lutomirski Cc: "linux-kernel@vger.kernel.org" , Rik van Riel , Casey Schaufler , PaX Team , Brad Spengler , Russell King , Catalin Marinas , Will Deacon , Ard Biesheuvel , Benjamin Herrenschmidt , Michael Ellerman , Tony Luck , Fenghua Yu , "David S. Miller" , X86 ML , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Andy Lutomirski , Borislav Petkov , Mathias Krause , Jan Kara , Vitaly Wool , Andrea Arcangeli , Dmitry Vyukov , Laura Abbott , "linux-arm-kernel@lists.infradead.org" , "linux-ia64@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , sparclinux , linux-arch , "linux-mm@kvack.org" , "kernel-hardening@lists.openwall.com" , Josh Poimboeuf Message-ID: <20160713220426.-gL4ZS_mCt3eRrW5BGWXVDS2fkwxqimAD7c0gH5j8gs@z> On Wed, Jul 13, 2016 at 3:01 PM, Andy Lutomirski wrote: > On Wed, Jul 13, 2016 at 2:55 PM, Kees Cook wrote: >> This creates per-architecture function arch_within_stack_frames() that >> should validate if a given object is contained by a kernel stack frame. >> Initial implementation is on x86. >> >> This is based on code from PaX. >> > > This, along with Josh's livepatch work, are two examples of unwinders > that matter for correctness instead of just debugging. ISTM this > should just use Josh's code directly once it's been written. Do you have URL for Josh's code? I'd love to see what happening there. In the meantime, usercopy can use this... -Kees -- Kees Cook Chrome OS & Brillo Security From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Date: Wed, 13 Jul 2016 22:04:26 +0000 Subject: Re: [PATCH v2 01/11] mm: Implement stack frame object validation Message-Id: List-Id: References: <1468446964-22213-1-git-send-email-keescook@chromium.org> <1468446964-22213-2-git-send-email-keescook@chromium.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andy Lutomirski Cc: "linux-kernel@vger.kernel.org" , Rik van Riel , Casey Schaufler , PaX Team , Brad Spengler , Russell King , Catalin Marinas , Will Deacon , Ard Biesheuvel , Benjamin Herrenschmidt , Michael Ellerman , Tony Luck , Fenghua Yu , "David S. Miller" , X86 ML , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Andy Lutomirski , Borislav Petkov , Mathias Krause , Jan Kara , Vitaly Wool , Andrea Arcangeli , Dmitry Vyukov , Laura Abbott , "linux-arm-kernel@lists.infradead.org" , "linux-ia64@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , sparclinux , linux-arch , "linux-mm@kvack.org" , "kernel-hardening@lists.openwall.com" , Josh Poimboeuf On Wed, Jul 13, 2016 at 3:01 PM, Andy Lutomirski wrote: > On Wed, Jul 13, 2016 at 2:55 PM, Kees Cook wrote: >> This creates per-architecture function arch_within_stack_frames() that >> should validate if a given object is contained by a kernel stack frame. >> Initial implementation is on x86. >> >> This is based on code from PaX. >> > > This, along with Josh's livepatch work, are two examples of unwinders > that matter for correctness instead of just debugging. ISTM this > should just use Josh's code directly once it's been written. Do you have URL for Josh's code? I'd love to see what happening there. In the meantime, usercopy can use this... -Kees -- Kees Cook Chrome OS & Brillo Security From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f70.google.com (mail-lf0-f70.google.com [209.85.215.70]) by kanga.kvack.org (Postfix) with ESMTP id ED6B86B0260 for ; Wed, 13 Jul 2016 18:04:28 -0400 (EDT) Received: by mail-lf0-f70.google.com with SMTP id g18so41063496lfg.2 for ; Wed, 13 Jul 2016 15:04:28 -0700 (PDT) Received: from mail-wm0-x22a.google.com (mail-wm0-x22a.google.com. [2a00:1450:400c:c09::22a]) by mx.google.com with ESMTPS id x82si24884226wmb.139.2016.07.13.15.04.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Jul 2016 15:04:27 -0700 (PDT) Received: by mail-wm0-x22a.google.com with SMTP id o80so88839502wme.1 for ; Wed, 13 Jul 2016 15:04:27 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1468446964-22213-1-git-send-email-keescook@chromium.org> <1468446964-22213-2-git-send-email-keescook@chromium.org> From: Kees Cook Date: Wed, 13 Jul 2016 15:04:26 -0700 Message-ID: Subject: Re: [PATCH v2 01/11] mm: Implement stack frame object validation Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Andy Lutomirski Cc: "linux-kernel@vger.kernel.org" , Rik van Riel , Casey Schaufler , PaX Team , Brad Spengler , Russell King , Catalin Marinas , Will Deacon , Ard Biesheuvel , Benjamin Herrenschmidt , Michael Ellerman , Tony Luck , Fenghua Yu , "David S. Miller" , X86 ML , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Andy Lutomirski , Borislav Petkov , Mathias Krause , Jan Kara , Vitaly Wool , Andrea Arcangeli , Dmitry Vyukov , Laura Abbott , "linux-arm-kernel@lists.infradead.org" , "linux-ia64@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , sparclinux , linux-arch , "linux-mm@kvack.org" , "kernel-hardening@lists.openwall.com" , Josh Poimboeuf On Wed, Jul 13, 2016 at 3:01 PM, Andy Lutomirski wrote: > On Wed, Jul 13, 2016 at 2:55 PM, Kees Cook wrote: >> This creates per-architecture function arch_within_stack_frames() that >> should validate if a given object is contained by a kernel stack frame. >> Initial implementation is on x86. >> >> This is based on code from PaX. >> > > This, along with Josh's livepatch work, are two examples of unwinders > that matter for correctness instead of just debugging. ISTM this > should just use Josh's code directly once it's been written. Do you have URL for Josh's code? I'd love to see what happening there. In the meantime, usercopy can use this... -Kees -- Kees Cook Chrome OS & Brillo Security -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: keescook@chromium.org (Kees Cook) Date: Wed, 13 Jul 2016 15:04:26 -0700 Subject: [PATCH v2 01/11] mm: Implement stack frame object validation In-Reply-To: References: <1468446964-22213-1-git-send-email-keescook@chromium.org> <1468446964-22213-2-git-send-email-keescook@chromium.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jul 13, 2016 at 3:01 PM, Andy Lutomirski wrote: > On Wed, Jul 13, 2016 at 2:55 PM, Kees Cook wrote: >> This creates per-architecture function arch_within_stack_frames() that >> should validate if a given object is contained by a kernel stack frame. >> Initial implementation is on x86. >> >> This is based on code from PaX. >> > > This, along with Josh's livepatch work, are two examples of unwinders > that matter for correctness instead of just debugging. ISTM this > should just use Josh's code directly once it's been written. Do you have URL for Josh's code? I'd love to see what happening there. In the meantime, usercopy can use this... -Kees -- Kees Cook Chrome OS & Brillo Security From mboxrd@z Thu Jan 1 00:00:00 1970 Reply-To: kernel-hardening@lists.openwall.com MIME-Version: 1.0 Sender: keescook@google.com In-Reply-To: References: <1468446964-22213-1-git-send-email-keescook@chromium.org> <1468446964-22213-2-git-send-email-keescook@chromium.org> From: Kees Cook Date: Wed, 13 Jul 2016 15:04:26 -0700 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: [kernel-hardening] Re: [PATCH v2 01/11] mm: Implement stack frame object validation To: Andy Lutomirski Cc: "linux-kernel@vger.kernel.org" , Rik van Riel , Casey Schaufler , PaX Team , Brad Spengler , Russell King , Catalin Marinas , Will Deacon , Ard Biesheuvel , Benjamin Herrenschmidt , Michael Ellerman , Tony Luck , Fenghua Yu , "David S. Miller" , X86 ML , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Andy Lutomirski , Borislav Petkov , Mathias Krause , Jan Kara , Vitaly Wool , Andrea Arcangeli , Dmitry Vyukov , Laura Abbott , "linux-arm-kernel@lists.infradead.org" , "linux-ia64@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , sparclinux , linux-arch , "linux-mm@kvack.org" , "kernel-hardening@lists.openwall.com" , Josh Poimboeuf List-ID: On Wed, Jul 13, 2016 at 3:01 PM, Andy Lutomirski wrote: > On Wed, Jul 13, 2016 at 2:55 PM, Kees Cook wrote: >> This creates per-architecture function arch_within_stack_frames() that >> should validate if a given object is contained by a kernel stack frame. >> Initial implementation is on x86. >> >> This is based on code from PaX. >> > > This, along with Josh's livepatch work, are two examples of unwinders > that matter for correctness instead of just debugging. ISTM this > should just use Josh's code directly once it's been written. Do you have URL for Josh's code? I'd love to see what happening there. In the meantime, usercopy can use this... -Kees -- Kees Cook Chrome OS & Brillo Security