From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752787AbdK2WZk (ORCPT ); Wed, 29 Nov 2017 17:25:40 -0500 Received: from mail-ua0-f175.google.com ([209.85.217.175]:35940 "EHLO mail-ua0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752384AbdK2WZi (ORCPT ); Wed, 29 Nov 2017 17:25:38 -0500 X-Google-Smtp-Source: AGs4zMbmHjDKG7VuC9mMshxnNxHJxnzB34esRt3PYNG+XHigErv2mtEOP3Wzk8xJ7FBIoVF2AfP3JTodZMWuCUoMpKc= MIME-Version: 1.0 In-Reply-To: <20171129144219.22867-1-mhocko@kernel.org> References: <20171129144219.22867-1-mhocko@kernel.org> From: Kees Cook Date: Wed, 29 Nov 2017 14:25:36 -0800 X-Google-Sender-Auth: pfvaq27mQ8kYDdA3jYwGfIW6QdQ Message-ID: Subject: Re: [PATCH 0/2] mm: introduce MAP_FIXED_SAFE To: Michal Hocko Cc: Linux API , Khalid Aziz , Michael Ellerman , Andrew Morton , Russell King - ARM Linux , Andrea Arcangeli , Linux-MM , LKML , linux-arch , Florian Weimer , John Hubbard , Abdul Haleem , Joel Stanley , Michal Hocko Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 29, 2017 at 6:42 AM, Michal Hocko wrote: > The first patch introduced MAP_FIXED_SAFE which enforces the given > address but unlike MAP_FIXED it fails with ENOMEM if the given range > conflicts with an existing one. The flag is introduced as a completely I still think this name should be better. "SAFE" doesn't say what it's safe from... MAP_FIXED_UNIQUE MAP_FIXED_ONCE MAP_FIXED_FRESH ? -Kees -- Kees Cook Pixel Security From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f69.google.com (mail-vk0-f69.google.com [209.85.213.69]) by kanga.kvack.org (Postfix) with ESMTP id 9F63E6B0253 for ; Wed, 29 Nov 2017 17:25:38 -0500 (EST) Received: by mail-vk0-f69.google.com with SMTP id w136so1491423vkd.14 for ; Wed, 29 Nov 2017 14:25:38 -0800 (PST) Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id y1sor1095172uae.297.2017.11.29.14.25.37 for (Google Transport Security); Wed, 29 Nov 2017 14:25:37 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20171129144219.22867-1-mhocko@kernel.org> References: <20171129144219.22867-1-mhocko@kernel.org> From: Kees Cook Date: Wed, 29 Nov 2017 14:25:36 -0800 Message-ID: Subject: Re: [PATCH 0/2] mm: introduce MAP_FIXED_SAFE Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Linux API , Khalid Aziz , Michael Ellerman , Andrew Morton , Russell King - ARM Linux , Andrea Arcangeli , Linux-MM , LKML , linux-arch , Florian Weimer , John Hubbard , Abdul Haleem , Joel Stanley , Michal Hocko On Wed, Nov 29, 2017 at 6:42 AM, Michal Hocko wrote: > The first patch introduced MAP_FIXED_SAFE which enforces the given > address but unlike MAP_FIXED it fails with ENOMEM if the given range > conflicts with an existing one. The flag is introduced as a completely I still think this name should be better. "SAFE" doesn't say what it's safe from... MAP_FIXED_UNIQUE MAP_FIXED_ONCE MAP_FIXED_FRESH ? -Kees -- Kees Cook Pixel Security -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org