From: Kees Cook <email@example.com> To: Peter Zijlstra <firstname.lastname@example.org>, John Dias <email@example.com> Cc: LKML <firstname.lastname@example.org>, Ingo Molnar <email@example.com>, Arnaldo Carvalho de Melo <firstname.lastname@example.org>, Alexander Shishkin <email@example.com>, Min Chong <firstname.lastname@example.org> Subject: Re: [PATCH] perf: protect group_leader from races that cause ctx Date: Fri, 6 Jan 2017 12:39:17 -0800 [thread overview] Message-ID: <CAGXu5jLp10K0X182YVeKXa=wc_TYuLfne4Wa8n82uX8iX1Aemail@example.com> (raw) In-Reply-To: <20170106131444.GZ3174@twins.programming.kicks-ass.net> On Fri, Jan 6, 2017 at 5:14 AM, Peter Zijlstra <firstname.lastname@example.org> wrote: > On Fri, Jan 06, 2017 at 10:32:51AM +0100, Peter Zijlstra wrote: >> On Thu, Jan 05, 2017 at 03:14:29PM -0800, Kees Cook wrote: >> > From: John Dias <email@example.com> >> > >> > When moving a group_leader perf event from a software-context to >> > a hardware-context, there's a race in checking and updating that >> > context. The existing locking solution doesn't work; note that it tries >> > to grab a lock inside the group_leader's context object, which you can >> > only get at by going through a pointer that should be protected from these >> > races. If two threads trigger this operation simultaneously, the refcount >> > of 'perf_event_context' will fall to zero and the object may be freed. >> > >> > To avoid that problem, and to produce a simple solution, we can just >> > use a lock per group_leader to protect all checks on the group_leader's >> > context. The new lock is grabbed and released when no context locks are >> > held. >> >> This Changelog really stinks. I'll go try and reverse engineer the thing >> :-( Sorry! I tried to merge John's changelog with details from the original internal bug report. I guess I failed. :P > So the fundamental problem is a race of two sys_perf_event_open() calls > trying to move the same (software) group, nothing else, the rest of the > text above is misdirection and side effects. > > And instead of applying the existing locking rules for this exact > scenario, it invents extra locking :-( > > Ok so I came up with the following, compile tested only, since no > reproducer and being fairly grumpy for having to spend entirely too much > time reconstructing the problem. John, are you able to test this solution? IIUC, you've got a reproducer handy? Thanks for digging into this Peter! > [...] > Reported-by: Kees Cook <firstname.lastname@example.org> I was just relaying a fix. I noted the original reporter in the first patch, how they asked to be credited: Reported-by: Di Shen (@returnsme) of KeenLab (@keen_lab), Tencent -Kees -- Kees Cook Nexus Security
next prev parent reply other threads:[~2017-01-06 20:39 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-05 23:14 Kees Cook 2017-01-06 9:32 ` Peter Zijlstra 2017-01-06 13:14 ` Peter Zijlstra 2017-01-06 20:39 ` Kees Cook [this message] 2017-01-07 16:29 ` John Dias 2017-01-09 23:16 ` Kees Cook 2017-01-10 8:46 ` Peter Zijlstra 2017-01-10 10:16 ` Ingo Molnar 2017-01-10 23:54 ` Kees Cook 2017-01-14 12:28 ` [tip:perf/urgent] perf/core: Fix concurrent sys_perf_event_open() vs. 'move_group' race tip-bot for Peter Zijlstra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGXu5jLp10K0X182YVeKXa=wc_TYuLfne4Wa8n82uX8iX1Aemail@example.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] perf: protect group_leader from races that cause ctx' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.