From: Kees Cook <keescook@chromium.org> To: Cyril Hrubis <chrubis@suse.cz> Cc: Pavel Machek <pavel@ucw.cz>, Michal Hocko <mhocko@kernel.org>, Michael Kerrisk <mtk.manpages@gmail.com>, Linux API <linux-api@vger.kernel.org>, Khalid Aziz <khalid.aziz@oracle.com>, Michael Ellerman <mpe@ellerman.id.au>, Andrew Morton <akpm@linux-foundation.org>, Russell King - ARM Linux <linux@armlinux.org.uk>, Andrea Arcangeli <aarcange@redhat.com>, Linux-MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, linux-arch <linux-arch@vger.kernel.org>, Florian Weimer <fweimer@redhat.com>, John Hubbard <jhubbard@nvidia.com>, Matthew Wilcox <willy@infradead.org>, Jann Horn <jannh@google.com>, Mike Rapoport <rppt@linux.vnet.ibm.com> Subject: Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation Date: Wed, 13 Dec 2017 15:19:00 -0800 [thread overview] Message-ID: <CAGXu5jLqE6cUxk-Girx6PG7upEzz8jmu1OH_3LVC26iJc2vTxQ@mail.gmail.com> (raw) In-Reply-To: <20171213144050.GG11493@rei> On Wed, Dec 13, 2017 at 6:40 AM, Cyril Hrubis <chrubis@suse.cz> wrote: > Hi! >> You selected stupid name for a flag. Everyone and their dog agrees >> with that. There's even consensus on better name (and everyone agrees >> it is better than .._SAFE). Of course, we could have debate if it is >> NOREPLACE or NOREMOVE or ... and that would be bikeshed. This was just >> poor naming on your part. > > Well while everybody agrees that the name is so bad that basically > anything else would be better, there does not seem to be consensus on > which one to pick. I do understand that this frustrating and fruitless. Based on the earlier threads where I tried to end the bikeshedding, it seemed like MAP_FIXED_NOREPLACE was the least bad option. > So what do we do now, roll a dice to choose new name? > > Or do we ask BFDL[1] to choose the name? I'd like to hear feedback from Michael Kerrisk, as he's had to deal with these kinds of choices in the past. I'm fine to ask Linus too. I just want to get past the name since the feature is quite valuable. And if Michal doesn't want to touch this patch any more, I'm happy to do the search/replace/resend. :P -Kees -- Kees Cook Pixel Security
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org> To: Cyril Hrubis <chrubis@suse.cz> Cc: Pavel Machek <pavel@ucw.cz>, Michal Hocko <mhocko@kernel.org>, Michael Kerrisk <mtk.manpages@gmail.com>, Linux API <linux-api@vger.kernel.org>, Khalid Aziz <khalid.aziz@oracle.com>, Michael Ellerman <mpe@ellerman.id.au>, Andrew Morton <akpm@linux-foundation.org>, Russell King - ARM Linux <linux@armlinux.org.uk>, Andrea Arcangeli <aarcange@redhat.com>, Linux-MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>, linux-arch <linux-arch@vger.kernel.org>, Florian Weimer <fweimer@redhat.com>, John Hubbard <jhubbard@nvidia.com>, Matthew Wilcox <willy@infradead.org>, Jann Horn <jannh@google.com>, Mike Rapoport <rppt@linux.vnet.ibm.com> Subject: Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation Date: Wed, 13 Dec 2017 15:19:00 -0800 [thread overview] Message-ID: <CAGXu5jLqE6cUxk-Girx6PG7upEzz8jmu1OH_3LVC26iJc2vTxQ@mail.gmail.com> (raw) In-Reply-To: <20171213144050.GG11493@rei> On Wed, Dec 13, 2017 at 6:40 AM, Cyril Hrubis <chrubis@suse.cz> wrote: > Hi! >> You selected stupid name for a flag. Everyone and their dog agrees >> with that. There's even consensus on better name (and everyone agrees >> it is better than .._SAFE). Of course, we could have debate if it is >> NOREPLACE or NOREMOVE or ... and that would be bikeshed. This was just >> poor naming on your part. > > Well while everybody agrees that the name is so bad that basically > anything else would be better, there does not seem to be consensus on > which one to pick. I do understand that this frustrating and fruitless. Based on the earlier threads where I tried to end the bikeshedding, it seemed like MAP_FIXED_NOREPLACE was the least bad option. > So what do we do now, roll a dice to choose new name? > > Or do we ask BFDL[1] to choose the name? I'd like to hear feedback from Michael Kerrisk, as he's had to deal with these kinds of choices in the past. I'm fine to ask Linus too. I just want to get past the name since the feature is quite valuable. And if Michal doesn't want to touch this patch any more, I'm happy to do the search/replace/resend. :P -Kees -- Kees Cook Pixel Security -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-12-13 23:20 UTC|newest] Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-13 9:25 [PATCH v2 0/2] mm: introduce MAP_FIXED_SAFE Michal Hocko 2017-12-13 9:25 ` Michal Hocko 2017-12-13 9:25 ` Michal Hocko 2017-12-13 9:25 ` [PATCH 1/2] " Michal Hocko 2017-12-13 9:25 ` Michal Hocko 2017-12-13 9:25 ` Michal Hocko 2017-12-13 12:50 ` Matthew Wilcox 2017-12-13 12:50 ` Matthew Wilcox 2017-12-13 12:50 ` Matthew Wilcox 2017-12-13 13:01 ` Michal Hocko 2017-12-13 13:01 ` Michal Hocko 2017-12-13 9:25 ` [PATCH 2/2] fs, elf: drop MAP_FIXED usage from elf_map Michal Hocko 2017-12-13 9:25 ` Michal Hocko 2017-12-13 9:25 ` Michal Hocko 2017-12-16 0:49 ` [2/2] " Andrei Vagin 2017-12-18 9:13 ` Michal Hocko 2017-12-18 9:13 ` Michal Hocko 2017-12-18 18:12 ` Andrei Vagin 2017-12-18 18:12 ` Andrei Vagin 2017-12-18 18:49 ` [PATCH] mm: don't use the same value for MAP_FIXED_SAFE and MAP_SYNC Andrei Vagin 2017-12-18 18:49 ` Andrei Vagin 2017-12-18 20:41 ` Michal Hocko 2017-12-18 20:41 ` Michal Hocko 2018-04-18 10:51 ` [PATCH 2/2] fs, elf: drop MAP_FIXED usage from elf_map Tetsuo Handa 2018-04-18 10:51 ` Tetsuo Handa 2018-04-18 11:33 ` Michal Hocko 2018-04-18 11:43 ` Tetsuo Handa 2018-04-18 11:55 ` Michal Hocko 2018-04-18 14:07 ` [PATCH v2] fs, elf: don't complain MAP_FIXED_NOREPLACE unless -EEXIST error Tetsuo Handa 2018-04-19 5:57 ` Michal Hocko 2017-12-13 9:31 ` [PATCH 1/2] mmap.2: document new MAP_FIXED_SAFE flag Michal Hocko 2017-12-13 9:31 ` Michal Hocko 2017-12-13 9:31 ` Michal Hocko 2017-12-13 9:31 ` [PATCH 2/2] mmap.2: MAP_FIXED updated documentation Michal Hocko 2017-12-13 9:31 ` Michal Hocko 2017-12-13 9:31 ` Michal Hocko 2017-12-13 12:55 ` Pavel Machek 2017-12-13 13:03 ` Cyril Hrubis 2017-12-13 13:03 ` Cyril Hrubis 2017-12-13 13:03 ` Cyril Hrubis 2017-12-13 13:04 ` Michal Hocko 2017-12-13 13:04 ` Michal Hocko 2017-12-13 13:09 ` Pavel Machek 2017-12-13 13:16 ` Michal Hocko 2017-12-13 13:16 ` Michal Hocko 2017-12-13 13:21 ` Pavel Machek 2017-12-13 13:21 ` Pavel Machek 2017-12-13 13:35 ` Michal Hocko 2017-12-13 13:35 ` Michal Hocko 2017-12-13 14:40 ` Cyril Hrubis 2017-12-13 14:40 ` Cyril Hrubis 2017-12-13 14:40 ` Cyril Hrubis 2017-12-13 23:19 ` Kees Cook [this message] 2017-12-13 23:19 ` Kees Cook 2017-12-14 7:07 ` Michal Hocko 2017-12-14 7:07 ` Michal Hocko 2017-12-14 7:07 ` Michal Hocko 2017-12-18 19:12 ` Michael Kerrisk (man-pages) 2017-12-18 19:12 ` Michael Kerrisk (man-pages) 2017-12-18 20:19 ` Kees Cook 2017-12-18 20:19 ` Kees Cook 2017-12-18 20:33 ` Matthew Wilcox 2017-12-18 20:33 ` Matthew Wilcox 2017-12-21 12:38 ` Michael Ellerman 2017-12-21 12:38 ` Michael Ellerman 2017-12-21 12:38 ` Michael Ellerman 2017-12-21 12:38 ` Michael Ellerman 2017-12-21 14:59 ` known bad patch in -mm tree was " Pavel Machek 2017-12-21 15:08 ` Michal Hocko 2017-12-21 15:08 ` Michal Hocko 2017-12-21 22:24 ` Andrew Morton 2017-12-21 22:24 ` Andrew Morton 2017-12-21 22:24 ` Andrew Morton 2017-12-22 0:06 ` Michael Ellerman 2017-12-22 0:06 ` Michael Ellerman 2017-12-22 0:06 ` Michael Ellerman 2017-12-14 2:52 ` Jann Horn 2017-12-14 2:52 ` Jann Horn 2017-12-14 5:28 ` John Hubbard 2017-12-14 5:28 ` John Hubbard 2017-12-14 5:28 ` John Hubbard 2017-12-14 5:28 ` John Hubbard 2017-12-14 23:06 ` John Hubbard 2017-12-14 23:06 ` John Hubbard 2017-12-14 23:06 ` John Hubbard 2017-12-14 23:10 ` Jann Horn 2017-12-14 23:10 ` Jann Horn 2017-12-14 23:10 ` Jann Horn 2017-12-13 12:25 ` [PATCH v2 0/2] mm: introduce MAP_FIXED_SAFE Matthew Wilcox 2017-12-13 12:25 ` Matthew Wilcox 2017-12-13 12:25 ` Matthew Wilcox 2017-12-13 12:34 ` Michal Hocko 2017-12-13 12:34 ` Michal Hocko 2017-12-13 17:13 ` Kees Cook 2017-12-13 17:13 ` Kees Cook 2017-12-13 17:13 ` Kees Cook 2017-12-15 9:02 ` Michael Ellerman 2017-12-15 9:02 ` Michael Ellerman 2017-12-14 0:32 ` Andrew Morton 2017-12-14 0:32 ` Andrew Morton 2017-12-14 0:32 ` Andrew Morton 2017-12-14 0:32 ` Andrew Morton 2017-12-14 1:35 ` David Goldblatt 2017-12-14 1:42 ` David Goldblatt 2017-12-14 1:42 ` David Goldblatt 2017-12-14 12:44 ` Edward Napierala 2017-12-14 13:15 ` Michal Hocko 2017-12-14 13:15 ` Michal Hocko 2017-12-14 14:54 ` Edward Napierala 2017-12-14 14:54 ` Edward Napierala 2017-12-19 12:40 ` David Laight 2017-12-19 12:40 ` David Laight 2017-12-19 12:46 ` Michal Hocko 2017-12-19 12:46 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAGXu5jLqE6cUxk-Girx6PG7upEzz8jmu1OH_3LVC26iJc2vTxQ@mail.gmail.com \ --to=keescook@chromium.org \ --cc=aarcange@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=chrubis@suse.cz \ --cc=fweimer@redhat.com \ --cc=jannh@google.com \ --cc=jhubbard@nvidia.com \ --cc=khalid.aziz@oracle.com \ --cc=linux-api@vger.kernel.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux@armlinux.org.uk \ --cc=mhocko@kernel.org \ --cc=mpe@ellerman.id.au \ --cc=mtk.manpages@gmail.com \ --cc=pavel@ucw.cz \ --cc=rppt@linux.vnet.ibm.com \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.