From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752102AbdLMXUO (ORCPT ); Wed, 13 Dec 2017 18:20:14 -0500 Received: from mail-vk0-f68.google.com ([209.85.213.68]:38213 "EHLO mail-vk0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751588AbdLMXTC (ORCPT ); Wed, 13 Dec 2017 18:19:02 -0500 X-Google-Smtp-Source: ACJfBovPnjkcr0647Vw6ZcNNqdguRhZphWbYPeE9NsCg99GdMLHmE71OnCBEgmwzfZBPnDf5IvwjxtppjOacc2LQPGk= MIME-Version: 1.0 In-Reply-To: <20171213144050.GG11493@rei> References: <20171213092550.2774-1-mhocko@kernel.org> <20171213093110.3550-1-mhocko@kernel.org> <20171213093110.3550-2-mhocko@kernel.org> <20171213125540.GA18897@amd> <20171213130458.GI25185@dhcp22.suse.cz> <20171213130900.GA19932@amd> <20171213131640.GJ25185@dhcp22.suse.cz> <20171213132105.GA20517@amd> <20171213144050.GG11493@rei> From: Kees Cook Date: Wed, 13 Dec 2017 15:19:00 -0800 X-Google-Sender-Auth: G7v-O5Kn9E8SNHQKhVfRUnDdneg Message-ID: Subject: Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation To: Cyril Hrubis Cc: Pavel Machek , Michal Hocko , Michael Kerrisk , Linux API , Khalid Aziz , Michael Ellerman , Andrew Morton , Russell King - ARM Linux , Andrea Arcangeli , Linux-MM , LKML , linux-arch , Florian Weimer , John Hubbard , Matthew Wilcox , Jann Horn , Mike Rapoport Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 13, 2017 at 6:40 AM, Cyril Hrubis wrote: > Hi! >> You selected stupid name for a flag. Everyone and their dog agrees >> with that. There's even consensus on better name (and everyone agrees >> it is better than .._SAFE). Of course, we could have debate if it is >> NOREPLACE or NOREMOVE or ... and that would be bikeshed. This was just >> poor naming on your part. > > Well while everybody agrees that the name is so bad that basically > anything else would be better, there does not seem to be consensus on > which one to pick. I do understand that this frustrating and fruitless. Based on the earlier threads where I tried to end the bikeshedding, it seemed like MAP_FIXED_NOREPLACE was the least bad option. > So what do we do now, roll a dice to choose new name? > > Or do we ask BFDL[1] to choose the name? I'd like to hear feedback from Michael Kerrisk, as he's had to deal with these kinds of choices in the past. I'm fine to ask Linus too. I just want to get past the name since the feature is quite valuable. And if Michal doesn't want to touch this patch any more, I'm happy to do the search/replace/resend. :P -Kees -- Kees Cook Pixel Security From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation Date: Wed, 13 Dec 2017 15:19:00 -0800 Message-ID: References: <20171213092550.2774-1-mhocko@kernel.org> <20171213093110.3550-1-mhocko@kernel.org> <20171213093110.3550-2-mhocko@kernel.org> <20171213125540.GA18897@amd> <20171213130458.GI25185@dhcp22.suse.cz> <20171213130900.GA19932@amd> <20171213131640.GJ25185@dhcp22.suse.cz> <20171213132105.GA20517@amd> <20171213144050.GG11493@rei> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20171213144050.GG11493@rei> Sender: owner-linux-mm@kvack.org To: Cyril Hrubis Cc: Pavel Machek , Michal Hocko , Michael Kerrisk , Linux API , Khalid Aziz , Michael Ellerman , Andrew Morton , Russell King - ARM Linux , Andrea Arcangeli , Linux-MM , LKML , linux-arch , Florian Weimer , John Hubbard , Matthew Wilcox , Jann Horn , Mike Rapoport List-Id: linux-api@vger.kernel.org On Wed, Dec 13, 2017 at 6:40 AM, Cyril Hrubis wrote: > Hi! >> You selected stupid name for a flag. Everyone and their dog agrees >> with that. There's even consensus on better name (and everyone agrees >> it is better than .._SAFE). Of course, we could have debate if it is >> NOREPLACE or NOREMOVE or ... and that would be bikeshed. This was just >> poor naming on your part. > > Well while everybody agrees that the name is so bad that basically > anything else would be better, there does not seem to be consensus on > which one to pick. I do understand that this frustrating and fruitless. Based on the earlier threads where I tried to end the bikeshedding, it seemed like MAP_FIXED_NOREPLACE was the least bad option. > So what do we do now, roll a dice to choose new name? > > Or do we ask BFDL[1] to choose the name? I'd like to hear feedback from Michael Kerrisk, as he's had to deal with these kinds of choices in the past. I'm fine to ask Linus too. I just want to get past the name since the feature is quite valuable. And if Michal doesn't want to touch this patch any more, I'm happy to do the search/replace/resend. :P -Kees -- Kees Cook Pixel Security -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org