* [PATCH v2 1/4] media/v4l2-core: Add enum V4L2_FWNODE_BUS_TYPE_DPI
@ 2022-04-22 8:47 Xin Ji
2022-04-22 8:47 ` [PATCH v2 2/4] dt-bindings: media: video-interfaces: Add new bus-type Xin Ji
` (3 more replies)
0 siblings, 4 replies; 42+ messages in thread
From: Xin Ji @ 2022-04-22 8:47 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: robert.foss, bliang, qwen, Xin Ji, linux-media, linux-kernel
As V4L2_FWNODE_BUS_TYPE_PARALLEL is not used for DPI interface, this
patch add V4L2_FWNODE_BUS_TYPE_DPI for video DPI interface.
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
drivers/media/v4l2-core/v4l2-fwnode.c | 4 ++++
include/media/v4l2-fwnode.h | 2 ++
include/media/v4l2-mediabus.h | 2 ++
3 files changed, 8 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c
index afceb35e500c..3d85a8600f57 100644
--- a/drivers/media/v4l2-core/v4l2-fwnode.c
+++ b/drivers/media/v4l2-core/v4l2-fwnode.c
@@ -61,6 +61,10 @@ static const struct v4l2_fwnode_bus_conv {
V4L2_FWNODE_BUS_TYPE_BT656,
V4L2_MBUS_BT656,
"Bt.656",
+ }, {
+ V4L2_FWNODE_BUS_TYPE_DPI,
+ V4L2_MBUS_DPI,
+ "DPI",
}
};
diff --git a/include/media/v4l2-fwnode.h b/include/media/v4l2-fwnode.h
index feb132df45a3..15e4ab672223 100644
--- a/include/media/v4l2-fwnode.h
+++ b/include/media/v4l2-fwnode.h
@@ -173,6 +173,7 @@ struct v4l2_fwnode_connector {
* @V4L2_FWNODE_BUS_TYPE_CSI2_DPHY: MIPI CSI-2 bus, D-PHY physical layer
* @V4L2_FWNODE_BUS_TYPE_PARALLEL: Camera Parallel Interface bus
* @V4L2_FWNODE_BUS_TYPE_BT656: BT.656 video format bus-type
+ * @V4L2_FWNODE_BUS_TYPE_DPI: Video Parallel Interface bus
* @NR_OF_V4L2_FWNODE_BUS_TYPE: Number of bus-types
*/
enum v4l2_fwnode_bus_type {
@@ -183,6 +184,7 @@ enum v4l2_fwnode_bus_type {
V4L2_FWNODE_BUS_TYPE_CSI2_DPHY,
V4L2_FWNODE_BUS_TYPE_PARALLEL,
V4L2_FWNODE_BUS_TYPE_BT656,
+ V4L2_FWNODE_BUS_TYPE_DPI,
NR_OF_V4L2_FWNODE_BUS_TYPE
};
diff --git a/include/media/v4l2-mediabus.h b/include/media/v4l2-mediabus.h
index e0db3bcff9ed..f67a74daf799 100644
--- a/include/media/v4l2-mediabus.h
+++ b/include/media/v4l2-mediabus.h
@@ -129,6 +129,7 @@ struct v4l2_mbus_config_mipi_csi1 {
* @V4L2_MBUS_CCP2: CCP2 (Compact Camera Port 2)
* @V4L2_MBUS_CSI2_DPHY: MIPI CSI-2 serial interface, with D-PHY
* @V4L2_MBUS_CSI2_CPHY: MIPI CSI-2 serial interface, with C-PHY
+ * @V4L2_MBUS_DPI: MIPI VIDEO DPI interface
* @V4L2_MBUS_INVALID: invalid bus type (keep as last)
*/
enum v4l2_mbus_type {
@@ -139,6 +140,7 @@ enum v4l2_mbus_type {
V4L2_MBUS_CCP2,
V4L2_MBUS_CSI2_DPHY,
V4L2_MBUS_CSI2_CPHY,
+ V4L2_MBUS_DPI,
V4L2_MBUS_INVALID,
};
--
2.25.1
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2 2/4] dt-bindings: media: video-interfaces: Add new bus-type
2022-04-22 8:47 [PATCH v2 1/4] media/v4l2-core: Add enum V4L2_FWNODE_BUS_TYPE_DPI Xin Ji
@ 2022-04-22 8:47 ` Xin Ji
2022-04-22 14:03 ` Robert Foss
2022-04-22 8:47 ` Xin Ji
` (2 subsequent siblings)
3 siblings, 1 reply; 42+ messages in thread
From: Xin Ji @ 2022-04-22 8:47 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Sakari Ailus, Laurent Pinchart
Cc: robert.foss, bliang, qwen, Xin Ji, Rob Herring, linux-media,
devicetree, linux-kernel
No properly bus-type for DPI video bus, add bus-type 7 for it.
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
Documentation/devicetree/bindings/media/video-interfaces.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/video-interfaces.yaml b/Documentation/devicetree/bindings/media/video-interfaces.yaml
index 4391dce2caee..68c3b9871cf3 100644
--- a/Documentation/devicetree/bindings/media/video-interfaces.yaml
+++ b/Documentation/devicetree/bindings/media/video-interfaces.yaml
@@ -93,6 +93,7 @@ properties:
- 4 # MIPI CSI-2 D-PHY
- 5 # Parallel
- 6 # BT.656
+ - 7 # DPI
description:
Data bus type.
--
2.25.1
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2 3/4] dt-bindings:drm/bridge:anx7625: add port@0 property
2022-04-22 8:47 [PATCH v2 1/4] media/v4l2-core: Add enum V4L2_FWNODE_BUS_TYPE_DPI Xin Ji
@ 2022-04-22 8:47 ` Xin Ji
2022-04-22 8:47 ` Xin Ji
` (2 subsequent siblings)
3 siblings, 0 replies; 42+ messages in thread
From: Xin Ji @ 2022-04-22 8:47 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Xin Ji
Cc: bliang, qwen, dri-devel, devicetree, linux-kernel
Add 'bus-type' and 'data-lanes' define, bus-type 7 for MIPI DPI
input, others for DSI input.
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
V1 -> V2: rebase on the latest code.
---
.../display/bridge/analogix,anx7625.yaml | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
index 35a48515836e..4590186c4a0b 100644
--- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
@@ -94,7 +94,22 @@ properties:
$ref: /schemas/graph.yaml#/$defs/port-base
unevaluatedProperties: false
description:
- Video port for MIPI DSI input.
+ MIPI DSI/DPI input.
+
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ type: object
+ additionalProperties: false
+
+ properties:
+ remote-endpoint: true
+
+ bus-type:
+ enum: [7]
+ default: 1
+
+ data-lanes: true
port@1:
$ref: /schemas/graph.yaml#/properties/port
@@ -143,6 +158,8 @@ examples:
reg = <0>;
anx7625_in: endpoint {
remote-endpoint = <&mipi_dsi>;
+ bus-type = <7>;
+ data-lanes = <0 1 2 3>;
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2 3/4] dt-bindings:drm/bridge:anx7625: add port@0 property
@ 2022-04-22 8:47 ` Xin Ji
0 siblings, 0 replies; 42+ messages in thread
From: Xin Ji @ 2022-04-22 8:47 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Xin Ji
Cc: devicetree, qwen, bliang, linux-kernel, dri-devel
Add 'bus-type' and 'data-lanes' define, bus-type 7 for MIPI DPI
input, others for DSI input.
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
V1 -> V2: rebase on the latest code.
---
.../display/bridge/analogix,anx7625.yaml | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
index 35a48515836e..4590186c4a0b 100644
--- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
@@ -94,7 +94,22 @@ properties:
$ref: /schemas/graph.yaml#/$defs/port-base
unevaluatedProperties: false
description:
- Video port for MIPI DSI input.
+ MIPI DSI/DPI input.
+
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ type: object
+ additionalProperties: false
+
+ properties:
+ remote-endpoint: true
+
+ bus-type:
+ enum: [7]
+ default: 1
+
+ data-lanes: true
port@1:
$ref: /schemas/graph.yaml#/properties/port
@@ -143,6 +158,8 @@ examples:
reg = <0>;
anx7625_in: endpoint {
remote-endpoint = <&mipi_dsi>;
+ bus-type = <7>;
+ data-lanes = <0 1 2 3>;
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
2022-04-22 8:47 [PATCH v2 1/4] media/v4l2-core: Add enum V4L2_FWNODE_BUS_TYPE_DPI Xin Ji
@ 2022-04-22 8:47 ` Xin Ji
2022-04-22 8:47 ` Xin Ji
` (2 subsequent siblings)
3 siblings, 0 replies; 42+ messages in thread
From: Xin Ji @ 2022-04-22 8:47 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Xin Ji
Cc: bliang, qwen, dri-devel, linux-kernel
As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 376da01243a3..71df977e8f53 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
anx7625_get_swing_setting(dev, pdata);
- pdata->is_dpi = 1; /* default dpi mode */
+ pdata->is_dpi = 0; /* default dsi mode */
pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
if (!pdata->mipi_host_node) {
DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
return -ENODEV;
}
- bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
+ bus_type = 0;
mipi_lanes = MAX_LANES_SUPPORT;
ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
if (ep0) {
@@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
}
- if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
- pdata->is_dpi = 0;
+ if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
+ pdata->is_dpi = 1;
pdata->mipi_lanes = mipi_lanes;
if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
--
2.25.1
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
@ 2022-04-22 8:47 ` Xin Ji
0 siblings, 0 replies; 42+ messages in thread
From: Xin Ji @ 2022-04-22 8:47 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Xin Ji
Cc: qwen, bliang, linux-kernel, dri-devel
As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
Signed-off-by: Xin Ji <xji@analogixsemi.com>
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 376da01243a3..71df977e8f53 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
anx7625_get_swing_setting(dev, pdata);
- pdata->is_dpi = 1; /* default dpi mode */
+ pdata->is_dpi = 0; /* default dsi mode */
pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
if (!pdata->mipi_host_node) {
DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
return -ENODEV;
}
- bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
+ bus_type = 0;
mipi_lanes = MAX_LANES_SUPPORT;
ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
if (ep0) {
@@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
}
- if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
- pdata->is_dpi = 0;
+ if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
+ pdata->is_dpi = 1;
pdata->mipi_lanes = mipi_lanes;
if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
--
2.25.1
^ permalink raw reply related [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
2022-04-22 8:47 ` Xin Ji
@ 2022-04-22 14:01 ` Robert Foss
-1 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-04-22 14:01 UTC (permalink / raw)
To: Xin Ji
Cc: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, bliang, qwen,
dri-devel, linux-kernel
On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
>
> As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
>
> Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 376da01243a3..71df977e8f53 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
>
> anx7625_get_swing_setting(dev, pdata);
>
> - pdata->is_dpi = 1; /* default dpi mode */
> + pdata->is_dpi = 0; /* default dsi mode */
> pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> if (!pdata->mipi_host_node) {
> DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> return -ENODEV;
> }
>
> - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> + bus_type = 0;
> mipi_lanes = MAX_LANES_SUPPORT;
> ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> if (ep0) {
> @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> }
>
> - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> - pdata->is_dpi = 0;
> + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> + pdata->is_dpi = 1;
>
> pdata->mipi_lanes = mipi_lanes;
> if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
@ 2022-04-22 14:01 ` Robert Foss
0 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-04-22 14:01 UTC (permalink / raw)
To: Xin Ji
Cc: dri-devel, Jonas Karlman, David Airlie, qwen, Neil Armstrong,
linux-kernel, Jernej Skrabec, Laurent Pinchart, Andrzej Hajda,
bliang
On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
>
> As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
>
> Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 376da01243a3..71df977e8f53 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
>
> anx7625_get_swing_setting(dev, pdata);
>
> - pdata->is_dpi = 1; /* default dpi mode */
> + pdata->is_dpi = 0; /* default dsi mode */
> pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> if (!pdata->mipi_host_node) {
> DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> return -ENODEV;
> }
>
> - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> + bus_type = 0;
> mipi_lanes = MAX_LANES_SUPPORT;
> ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> if (ep0) {
> @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> }
>
> - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> - pdata->is_dpi = 0;
> + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> + pdata->is_dpi = 1;
>
> pdata->mipi_lanes = mipi_lanes;
> if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 3/4] dt-bindings:drm/bridge:anx7625: add port@0 property
2022-04-22 8:47 ` Xin Ji
@ 2022-04-22 14:03 ` Robert Foss
-1 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-04-22 14:03 UTC (permalink / raw)
To: Xin Ji
Cc: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, bliang, qwen, dri-devel, devicetree,
linux-kernel
On Fri, 22 Apr 2022 at 10:48, Xin Ji <xji@analogixsemi.com> wrote:
>
> Add 'bus-type' and 'data-lanes' define, bus-type 7 for MIPI DPI
> input, others for DSI input.
>
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
>
> ---
> V1 -> V2: rebase on the latest code.
> ---
> .../display/bridge/analogix,anx7625.yaml | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 35a48515836e..4590186c4a0b 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -94,7 +94,22 @@ properties:
> $ref: /schemas/graph.yaml#/$defs/port-base
> unevaluatedProperties: false
> description:
> - Video port for MIPI DSI input.
> + MIPI DSI/DPI input.
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + type: object
> + additionalProperties: false
> +
> + properties:
> + remote-endpoint: true
> +
> + bus-type:
> + enum: [7]
> + default: 1
> +
> + data-lanes: true
>
> port@1:
> $ref: /schemas/graph.yaml#/properties/port
> @@ -143,6 +158,8 @@ examples:
> reg = <0>;
> anx7625_in: endpoint {
> remote-endpoint = <&mipi_dsi>;
> + bus-type = <7>;
> + data-lanes = <0 1 2 3>;
> };
> };
>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 3/4] dt-bindings:drm/bridge:anx7625: add port@0 property
@ 2022-04-22 14:03 ` Robert Foss
0 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-04-22 14:03 UTC (permalink / raw)
To: Xin Ji
Cc: dri-devel, devicetree, Jonas Karlman, David Airlie, qwen,
Neil Armstrong, linux-kernel, Jernej Skrabec, Rob Herring,
Laurent Pinchart, Andrzej Hajda, Krzysztof Kozlowski, bliang
On Fri, 22 Apr 2022 at 10:48, Xin Ji <xji@analogixsemi.com> wrote:
>
> Add 'bus-type' and 'data-lanes' define, bus-type 7 for MIPI DPI
> input, others for DSI input.
>
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
>
> ---
> V1 -> V2: rebase on the latest code.
> ---
> .../display/bridge/analogix,anx7625.yaml | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 35a48515836e..4590186c4a0b 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -94,7 +94,22 @@ properties:
> $ref: /schemas/graph.yaml#/$defs/port-base
> unevaluatedProperties: false
> description:
> - Video port for MIPI DSI input.
> + MIPI DSI/DPI input.
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + type: object
> + additionalProperties: false
> +
> + properties:
> + remote-endpoint: true
> +
> + bus-type:
> + enum: [7]
> + default: 1
> +
> + data-lanes: true
>
> port@1:
> $ref: /schemas/graph.yaml#/properties/port
> @@ -143,6 +158,8 @@ examples:
> reg = <0>;
> anx7625_in: endpoint {
> remote-endpoint = <&mipi_dsi>;
> + bus-type = <7>;
> + data-lanes = <0 1 2 3>;
> };
> };
>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 2/4] dt-bindings: media: video-interfaces: Add new bus-type
2022-04-22 8:47 ` [PATCH v2 2/4] dt-bindings: media: video-interfaces: Add new bus-type Xin Ji
@ 2022-04-22 14:03 ` Robert Foss
0 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-04-22 14:03 UTC (permalink / raw)
To: Xin Ji
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Sakari Ailus, Laurent Pinchart, bliang, qwen, Rob Herring,
linux-media, devicetree, linux-kernel
On Fri, 22 Apr 2022 at 10:48, Xin Ji <xji@analogixsemi.com> wrote:
>
> No properly bus-type for DPI video bus, add bus-type 7 for it.
>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> Documentation/devicetree/bindings/media/video-interfaces.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.yaml b/Documentation/devicetree/bindings/media/video-interfaces.yaml
> index 4391dce2caee..68c3b9871cf3 100644
> --- a/Documentation/devicetree/bindings/media/video-interfaces.yaml
> +++ b/Documentation/devicetree/bindings/media/video-interfaces.yaml
> @@ -93,6 +93,7 @@ properties:
> - 4 # MIPI CSI-2 D-PHY
> - 5 # Parallel
> - 6 # BT.656
> + - 7 # DPI
> description:
> Data bus type.
>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 1/4] media/v4l2-core: Add enum V4L2_FWNODE_BUS_TYPE_DPI
2022-04-22 8:47 [PATCH v2 1/4] media/v4l2-core: Add enum V4L2_FWNODE_BUS_TYPE_DPI Xin Ji
` (2 preceding siblings ...)
2022-04-22 8:47 ` Xin Ji
@ 2022-04-22 14:10 ` Robert Foss
3 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-04-22 14:10 UTC (permalink / raw)
To: Xin Ji; +Cc: Mauro Carvalho Chehab, bliang, qwen, linux-media, linux-kernel
On Fri, 22 Apr 2022 at 10:48, Xin Ji <xji@analogixsemi.com> wrote:
>
> As V4L2_FWNODE_BUS_TYPE_PARALLEL is not used for DPI interface, this
> patch add V4L2_FWNODE_BUS_TYPE_DPI for video DPI interface.
>
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
> ---
> drivers/media/v4l2-core/v4l2-fwnode.c | 4 ++++
> include/media/v4l2-fwnode.h | 2 ++
> include/media/v4l2-mediabus.h | 2 ++
> 3 files changed, 8 insertions(+)
>
> diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c
> index afceb35e500c..3d85a8600f57 100644
> --- a/drivers/media/v4l2-core/v4l2-fwnode.c
> +++ b/drivers/media/v4l2-core/v4l2-fwnode.c
> @@ -61,6 +61,10 @@ static const struct v4l2_fwnode_bus_conv {
> V4L2_FWNODE_BUS_TYPE_BT656,
> V4L2_MBUS_BT656,
> "Bt.656",
> + }, {
> + V4L2_FWNODE_BUS_TYPE_DPI,
> + V4L2_MBUS_DPI,
> + "DPI",
> }
> };
>
> diff --git a/include/media/v4l2-fwnode.h b/include/media/v4l2-fwnode.h
> index feb132df45a3..15e4ab672223 100644
> --- a/include/media/v4l2-fwnode.h
> +++ b/include/media/v4l2-fwnode.h
> @@ -173,6 +173,7 @@ struct v4l2_fwnode_connector {
> * @V4L2_FWNODE_BUS_TYPE_CSI2_DPHY: MIPI CSI-2 bus, D-PHY physical layer
> * @V4L2_FWNODE_BUS_TYPE_PARALLEL: Camera Parallel Interface bus
> * @V4L2_FWNODE_BUS_TYPE_BT656: BT.656 video format bus-type
> + * @V4L2_FWNODE_BUS_TYPE_DPI: Video Parallel Interface bus
> * @NR_OF_V4L2_FWNODE_BUS_TYPE: Number of bus-types
> */
> enum v4l2_fwnode_bus_type {
> @@ -183,6 +184,7 @@ enum v4l2_fwnode_bus_type {
> V4L2_FWNODE_BUS_TYPE_CSI2_DPHY,
> V4L2_FWNODE_BUS_TYPE_PARALLEL,
> V4L2_FWNODE_BUS_TYPE_BT656,
> + V4L2_FWNODE_BUS_TYPE_DPI,
> NR_OF_V4L2_FWNODE_BUS_TYPE
> };
>
> diff --git a/include/media/v4l2-mediabus.h b/include/media/v4l2-mediabus.h
> index e0db3bcff9ed..f67a74daf799 100644
> --- a/include/media/v4l2-mediabus.h
> +++ b/include/media/v4l2-mediabus.h
> @@ -129,6 +129,7 @@ struct v4l2_mbus_config_mipi_csi1 {
> * @V4L2_MBUS_CCP2: CCP2 (Compact Camera Port 2)
> * @V4L2_MBUS_CSI2_DPHY: MIPI CSI-2 serial interface, with D-PHY
> * @V4L2_MBUS_CSI2_CPHY: MIPI CSI-2 serial interface, with C-PHY
> + * @V4L2_MBUS_DPI: MIPI VIDEO DPI interface
> * @V4L2_MBUS_INVALID: invalid bus type (keep as last)
> */
> enum v4l2_mbus_type {
> @@ -139,6 +140,7 @@ enum v4l2_mbus_type {
> V4L2_MBUS_CCP2,
> V4L2_MBUS_CSI2_DPHY,
> V4L2_MBUS_CSI2_CPHY,
> + V4L2_MBUS_DPI,
> V4L2_MBUS_INVALID,
> };
>
I'm not seeing any issues with this patch (or the rest of the series),
so I'll add my r-b. But I would like to see another review by someone
more familiar with the media subsystem.
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 3/4] dt-bindings:drm/bridge:anx7625: add port@0 property
2022-04-22 14:03 ` Robert Foss
@ 2022-04-22 14:10 ` Robert Foss
-1 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-04-22 14:10 UTC (permalink / raw)
To: Xin Ji
Cc: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, Rob Herring,
Krzysztof Kozlowski, bliang, qwen, dri-devel, devicetree,
linux-kernel
Acked-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 3/4] dt-bindings:drm/bridge:anx7625: add port@0 property
@ 2022-04-22 14:10 ` Robert Foss
0 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-04-22 14:10 UTC (permalink / raw)
To: Xin Ji
Cc: dri-devel, devicetree, Jonas Karlman, David Airlie, qwen,
Neil Armstrong, linux-kernel, Jernej Skrabec, Rob Herring,
Laurent Pinchart, Andrzej Hajda, Krzysztof Kozlowski, bliang
Acked-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
2022-04-22 14:01 ` Robert Foss
@ 2022-04-22 14:13 ` Robert Foss
-1 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-04-22 14:13 UTC (permalink / raw)
To: Xin Ji
Cc: Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter, bliang, qwen,
dri-devel, linux-kernel
On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
>
> On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> >
> > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> >
> > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index 376da01243a3..71df977e8f53 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> >
> > anx7625_get_swing_setting(dev, pdata);
> >
> > - pdata->is_dpi = 1; /* default dpi mode */
> > + pdata->is_dpi = 0; /* default dsi mode */
> > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > if (!pdata->mipi_host_node) {
> > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > return -ENODEV;
> > }
> >
> > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > + bus_type = 0;
> > mipi_lanes = MAX_LANES_SUPPORT;
> > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > if (ep0) {
> > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > }
> >
> > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > - pdata->is_dpi = 0;
> > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > + pdata->is_dpi = 1;
> >
> > pdata->mipi_lanes = mipi_lanes;
> > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
>
> Reviewed-by: Robert Foss <robert.foss@linaro.org>
Acked-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
@ 2022-04-22 14:13 ` Robert Foss
0 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-04-22 14:13 UTC (permalink / raw)
To: Xin Ji
Cc: dri-devel, Jonas Karlman, David Airlie, qwen, Neil Armstrong,
linux-kernel, Jernej Skrabec, Laurent Pinchart, Andrzej Hajda,
bliang
On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
>
> On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> >
> > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> >
> > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index 376da01243a3..71df977e8f53 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> >
> > anx7625_get_swing_setting(dev, pdata);
> >
> > - pdata->is_dpi = 1; /* default dpi mode */
> > + pdata->is_dpi = 0; /* default dsi mode */
> > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > if (!pdata->mipi_host_node) {
> > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > return -ENODEV;
> > }
> >
> > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > + bus_type = 0;
> > mipi_lanes = MAX_LANES_SUPPORT;
> > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > if (ep0) {
> > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > }
> >
> > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > - pdata->is_dpi = 0;
> > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > + pdata->is_dpi = 1;
> >
> > pdata->mipi_lanes = mipi_lanes;
> > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
>
> Reviewed-by: Robert Foss <robert.foss@linaro.org>
Acked-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
2022-04-22 14:13 ` Robert Foss
@ 2022-04-25 8:24 ` Chen-Yu Tsai
-1 siblings, 0 replies; 42+ messages in thread
From: Chen-Yu Tsai @ 2022-04-25 8:24 UTC (permalink / raw)
To: Robert Foss, Xin Ji
Cc: Neil Armstrong, David Airlie, qwen, Jonas Karlman, linux-kernel,
dri-devel, Jernej Skrabec, Andrzej Hajda, bliang,
Laurent Pinchart
On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
>
> On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> >
> > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > >
> > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > >
> > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > ---
> > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > index 376da01243a3..71df977e8f53 100644
> > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > >
> > > anx7625_get_swing_setting(dev, pdata);
> > >
> > > - pdata->is_dpi = 1; /* default dpi mode */
> > > + pdata->is_dpi = 0; /* default dsi mode */
> > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > if (!pdata->mipi_host_node) {
> > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > return -ENODEV;
> > > }
> > >
> > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > + bus_type = 0;
> > > mipi_lanes = MAX_LANES_SUPPORT;
> > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > if (ep0) {
> > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > }
> > >
> > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > - pdata->is_dpi = 0;
> > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > + pdata->is_dpi = 1;
> > >
> > > pdata->mipi_lanes = mipi_lanes;
> > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> >
> > Reviewed-by: Robert Foss <robert.foss@linaro.org>
>
> Acked-by: Robert Foss <robert.foss@linaro.org>
Tested-by: Chen-Yu Tsai <wenst@chromium.org>
Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
mainline (next-20220422).
Xin, in the future, please send the whole series to all recipients of
all patches listed by get_maintainers.pl, not just the recipients of
each patch. In the case of this series, they should have been sent
to all of the mailing lists (media, devicetree, dri-devel) so that
everyone has the same, full view of the patches.
ChenYu
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
@ 2022-04-25 8:24 ` Chen-Yu Tsai
0 siblings, 0 replies; 42+ messages in thread
From: Chen-Yu Tsai @ 2022-04-25 8:24 UTC (permalink / raw)
To: Robert Foss, Xin Ji
Cc: dri-devel, Jonas Karlman, David Airlie, qwen, Neil Armstrong,
linux-kernel, Jernej Skrabec, Laurent Pinchart, Andrzej Hajda,
bliang
On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
>
> On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> >
> > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > >
> > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > >
> > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > ---
> > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > index 376da01243a3..71df977e8f53 100644
> > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > >
> > > anx7625_get_swing_setting(dev, pdata);
> > >
> > > - pdata->is_dpi = 1; /* default dpi mode */
> > > + pdata->is_dpi = 0; /* default dsi mode */
> > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > if (!pdata->mipi_host_node) {
> > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > return -ENODEV;
> > > }
> > >
> > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > + bus_type = 0;
> > > mipi_lanes = MAX_LANES_SUPPORT;
> > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > if (ep0) {
> > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > }
> > >
> > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > - pdata->is_dpi = 0;
> > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > + pdata->is_dpi = 1;
> > >
> > > pdata->mipi_lanes = mipi_lanes;
> > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> >
> > Reviewed-by: Robert Foss <robert.foss@linaro.org>
>
> Acked-by: Robert Foss <robert.foss@linaro.org>
Tested-by: Chen-Yu Tsai <wenst@chromium.org>
Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
mainline (next-20220422).
Xin, in the future, please send the whole series to all recipients of
all patches listed by get_maintainers.pl, not just the recipients of
each patch. In the case of this series, they should have been sent
to all of the mailing lists (media, devicetree, dri-devel) so that
everyone has the same, full view of the patches.
ChenYu
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
2022-04-25 8:24 ` Chen-Yu Tsai
@ 2022-04-25 8:29 ` Chen-Yu Tsai
-1 siblings, 0 replies; 42+ messages in thread
From: Chen-Yu Tsai @ 2022-04-25 8:29 UTC (permalink / raw)
To: Robert Foss, Xin Ji
Cc: Neil Armstrong, David Airlie, qwen, Jonas Karlman, linux-kernel,
dri-devel, Jernej Skrabec, Andrzej Hajda, bliang,
Laurent Pinchart
On Mon, Apr 25, 2022 at 4:24 PM Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> >
> > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > >
> > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > >
> > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > >
> > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > ---
> > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > index 376da01243a3..71df977e8f53 100644
> > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > >
> > > > anx7625_get_swing_setting(dev, pdata);
> > > >
> > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > if (!pdata->mipi_host_node) {
> > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > return -ENODEV;
> > > > }
> > > >
> > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > + bus_type = 0;
> > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > if (ep0) {
> > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > }
> > > >
> > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > - pdata->is_dpi = 0;
> > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > + pdata->is_dpi = 1;
> > > >
> > > > pdata->mipi_lanes = mipi_lanes;
> > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > >
> > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> >
> > Acked-by: Robert Foss <robert.foss@linaro.org>
>
> Tested-by: Chen-Yu Tsai <wenst@chromium.org>
>
> Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> mainline (next-20220422).
Forgot to mention, this device uses the already supported but broken (by
previous DPI patch) DSI interface.
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
@ 2022-04-25 8:29 ` Chen-Yu Tsai
0 siblings, 0 replies; 42+ messages in thread
From: Chen-Yu Tsai @ 2022-04-25 8:29 UTC (permalink / raw)
To: Robert Foss, Xin Ji
Cc: dri-devel, Jonas Karlman, David Airlie, qwen, Neil Armstrong,
linux-kernel, Jernej Skrabec, Laurent Pinchart, Andrzej Hajda,
bliang
On Mon, Apr 25, 2022 at 4:24 PM Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> >
> > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > >
> > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > >
> > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > >
> > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > ---
> > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > index 376da01243a3..71df977e8f53 100644
> > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > >
> > > > anx7625_get_swing_setting(dev, pdata);
> > > >
> > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > if (!pdata->mipi_host_node) {
> > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > return -ENODEV;
> > > > }
> > > >
> > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > + bus_type = 0;
> > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > if (ep0) {
> > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > }
> > > >
> > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > - pdata->is_dpi = 0;
> > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > + pdata->is_dpi = 1;
> > > >
> > > > pdata->mipi_lanes = mipi_lanes;
> > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > >
> > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> >
> > Acked-by: Robert Foss <robert.foss@linaro.org>
>
> Tested-by: Chen-Yu Tsai <wenst@chromium.org>
>
> Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> mainline (next-20220422).
Forgot to mention, this device uses the already supported but broken (by
previous DPI patch) DSI interface.
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
2022-04-25 8:24 ` Chen-Yu Tsai
@ 2022-04-25 9:14 ` Xin Ji
-1 siblings, 0 replies; 42+ messages in thread
From: Xin Ji @ 2022-04-25 9:14 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Jernej Skrabec, Neil Armstrong, David Airlie, qwen,
Jonas Karlman, linux-kernel, dri-devel, Robert Foss,
Andrzej Hajda, bliang, Laurent Pinchart
On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> >
> > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > >
> > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > >
> > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > >
> > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > ---
> > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > index 376da01243a3..71df977e8f53 100644
> > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > >
> > > > anx7625_get_swing_setting(dev, pdata);
> > > >
> > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > if (!pdata->mipi_host_node) {
> > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > return -ENODEV;
> > > > }
> > > >
> > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > + bus_type = 0;
> > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > if (ep0) {
> > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > }
> > > >
> > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > - pdata->is_dpi = 0;
> > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > + pdata->is_dpi = 1;
> > > >
> > > > pdata->mipi_lanes = mipi_lanes;
> > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > >
> > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> >
> > Acked-by: Robert Foss <robert.foss@linaro.org>
>
> Tested-by: Chen-Yu Tsai <wenst@chromium.org>
>
> Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> mainline (next-20220422).
>
> Xin, in the future, please send the whole series to all recipients of
> all patches listed by get_maintainers.pl, not just the recipients of
> each patch. In the case of this series, they should have been sent
> to all of the mailing lists (media, devicetree, dri-devel) so that
> everyone has the same, full view of the patches.
Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
Thanks,
Xin
>
> ChenYu
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
@ 2022-04-25 9:14 ` Xin Ji
0 siblings, 0 replies; 42+ messages in thread
From: Xin Ji @ 2022-04-25 9:14 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Robert Foss, dri-devel, Jonas Karlman, David Airlie, qwen,
Neil Armstrong, linux-kernel, Jernej Skrabec, Laurent Pinchart,
Andrzej Hajda, bliang
On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> >
> > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > >
> > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > >
> > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > >
> > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > ---
> > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > index 376da01243a3..71df977e8f53 100644
> > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > >
> > > > anx7625_get_swing_setting(dev, pdata);
> > > >
> > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > if (!pdata->mipi_host_node) {
> > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > return -ENODEV;
> > > > }
> > > >
> > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > + bus_type = 0;
> > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > if (ep0) {
> > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > }
> > > >
> > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > - pdata->is_dpi = 0;
> > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > + pdata->is_dpi = 1;
> > > >
> > > > pdata->mipi_lanes = mipi_lanes;
> > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > >
> > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> >
> > Acked-by: Robert Foss <robert.foss@linaro.org>
>
> Tested-by: Chen-Yu Tsai <wenst@chromium.org>
>
> Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> mainline (next-20220422).
>
> Xin, in the future, please send the whole series to all recipients of
> all patches listed by get_maintainers.pl, not just the recipients of
> each patch. In the case of this series, they should have been sent
> to all of the mailing lists (media, devicetree, dri-devel) so that
> everyone has the same, full view of the patches.
Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
Thanks,
Xin
>
> ChenYu
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 3/4] dt-bindings:drm/bridge:anx7625: add port@0 property
2022-04-22 8:47 ` Xin Ji
@ 2022-05-02 21:07 ` Rob Herring
-1 siblings, 0 replies; 42+ messages in thread
From: Rob Herring @ 2022-05-02 21:07 UTC (permalink / raw)
To: Xin Ji
Cc: Jonas Karlman, Andrzej Hajda, David Airlie, Daniel Vetter,
bliang, Jernej Skrabec, Krzysztof Kozlowski, Neil Armstrong,
dri-devel, Rob Herring, qwen, linux-kernel, Laurent Pinchart,
Robert Foss, devicetree
On Fri, 22 Apr 2022 16:47:17 +0800, Xin Ji wrote:
> Add 'bus-type' and 'data-lanes' define, bus-type 7 for MIPI DPI
> input, others for DSI input.
>
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
>
> ---
> V1 -> V2: rebase on the latest code.
> ---
> .../display/bridge/analogix,anx7625.yaml | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 3/4] dt-bindings:drm/bridge:anx7625: add port@0 property
@ 2022-05-02 21:07 ` Rob Herring
0 siblings, 0 replies; 42+ messages in thread
From: Rob Herring @ 2022-05-02 21:07 UTC (permalink / raw)
To: Xin Ji
Cc: devicetree, Andrzej Hajda, Jonas Karlman, David Airlie,
Robert Foss, qwen, Neil Armstrong, linux-kernel, Jernej Skrabec,
Rob Herring, dri-devel, Krzysztof Kozlowski, bliang,
Laurent Pinchart
On Fri, 22 Apr 2022 16:47:17 +0800, Xin Ji wrote:
> Add 'bus-type' and 'data-lanes' define, bus-type 7 for MIPI DPI
> input, others for DSI input.
>
> Signed-off-by: Xin Ji <xji@analogixsemi.com>
>
> ---
> V1 -> V2: rebase on the latest code.
> ---
> .../display/bridge/analogix,anx7625.yaml | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
2022-04-25 9:14 ` Xin Ji
@ 2022-05-17 16:09 ` Robert Foss
-1 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-05-17 16:09 UTC (permalink / raw)
To: Xin Ji
Cc: Chen-Yu Tsai, dri-devel, Jonas Karlman, David Airlie, qwen,
Neil Armstrong, linux-kernel, Jernej Skrabec, Laurent Pinchart,
Andrzej Hajda, bliang
On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote:
>
> On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> > >
> > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > > >
> > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > > >
> > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > > >
> > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > > ---
> > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > index 376da01243a3..71df977e8f53 100644
> > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > > >
> > > > > anx7625_get_swing_setting(dev, pdata);
> > > > >
> > > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > > if (!pdata->mipi_host_node) {
> > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > > return -ENODEV;
> > > > > }
> > > > >
> > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > > + bus_type = 0;
> > > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > > if (ep0) {
> > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > > }
> > > > >
> > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > > - pdata->is_dpi = 0;
> > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > > + pdata->is_dpi = 1;
> > > > >
> > > > > pdata->mipi_lanes = mipi_lanes;
> > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > > >
> > > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > >
> > > Acked-by: Robert Foss <robert.foss@linaro.org>
> >
> > Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> >
> > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> > mainline (next-20220422).
> >
> > Xin, in the future, please send the whole series to all recipients of
> > all patches listed by get_maintainers.pl, not just the recipients of
> > each patch. In the case of this series, they should have been sent
> > to all of the mailing lists (media, devicetree, dri-devel) so that
> > everyone has the same, full view of the patches.
> Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
> Thanks,
> Xin
> >
> > ChenYu
Applied 3/4 + 4/4 to drm-misc-next.
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
@ 2022-05-17 16:09 ` Robert Foss
0 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-05-17 16:09 UTC (permalink / raw)
To: Xin Ji
Cc: Neil Armstrong, David Airlie, qwen, Jonas Karlman, linux-kernel,
dri-devel, Jernej Skrabec, Andrzej Hajda, Chen-Yu Tsai, bliang,
Laurent Pinchart
On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote:
>
> On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> > >
> > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > > >
> > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > > >
> > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > > >
> > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > > ---
> > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > index 376da01243a3..71df977e8f53 100644
> > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > > >
> > > > > anx7625_get_swing_setting(dev, pdata);
> > > > >
> > > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > > if (!pdata->mipi_host_node) {
> > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > > return -ENODEV;
> > > > > }
> > > > >
> > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > > + bus_type = 0;
> > > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > > if (ep0) {
> > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > > }
> > > > >
> > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > > - pdata->is_dpi = 0;
> > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > > + pdata->is_dpi = 1;
> > > > >
> > > > > pdata->mipi_lanes = mipi_lanes;
> > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > > >
> > > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > >
> > > Acked-by: Robert Foss <robert.foss@linaro.org>
> >
> > Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> >
> > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> > mainline (next-20220422).
> >
> > Xin, in the future, please send the whole series to all recipients of
> > all patches listed by get_maintainers.pl, not just the recipients of
> > each patch. In the case of this series, they should have been sent
> > to all of the mailing lists (media, devicetree, dri-devel) so that
> > everyone has the same, full view of the patches.
> Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
> Thanks,
> Xin
> >
> > ChenYu
Applied 3/4 + 4/4 to drm-misc-next.
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
2022-05-17 16:09 ` Robert Foss
@ 2022-05-21 16:07 ` Daniel Vetter
-1 siblings, 0 replies; 42+ messages in thread
From: Daniel Vetter @ 2022-05-21 16:07 UTC (permalink / raw)
To: Robert Foss
Cc: Xin Ji, Neil Armstrong, David Airlie, qwen, Jonas Karlman,
linux-kernel, dri-devel, Jernej Skrabec, Andrzej Hajda,
Chen-Yu Tsai, bliang, Laurent Pinchart
On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote:
>
> On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote:
> >
> > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > >
> > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > > > >
> > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > >
> > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > > > >
> > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > > > ---
> > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > > >
> > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > index 376da01243a3..71df977e8f53 100644
> > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > >
> > > > > > anx7625_get_swing_setting(dev, pdata);
> > > > > >
> > > > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > > > if (!pdata->mipi_host_node) {
> > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > > > return -ENODEV;
> > > > > > }
> > > > > >
> > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > > > + bus_type = 0;
> > > > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > > > if (ep0) {
> > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > > > }
> > > > > >
> > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > > > - pdata->is_dpi = 0;
> > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > > > + pdata->is_dpi = 1;
> > > > > >
> > > > > > pdata->mipi_lanes = mipi_lanes;
> > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > > > >
> > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > > >
> > > > Acked-by: Robert Foss <robert.foss@linaro.org>
> > >
> > > Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> > >
> > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> > > mainline (next-20220422).
> > >
> > > Xin, in the future, please send the whole series to all recipients of
> > > all patches listed by get_maintainers.pl, not just the recipients of
> > > each patch. In the case of this series, they should have been sent
> > > to all of the mailing lists (media, devicetree, dri-devel) so that
> > > everyone has the same, full view of the patches.
> > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
> > Thanks,
> > Xin
> > >
> > > ChenYu
>
> Applied 3/4 + 4/4 to drm-misc-next.
This patch doesn't even compile. Can you pls fix this up asap? Also
pls compile-test before pushing ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
@ 2022-05-21 16:07 ` Daniel Vetter
0 siblings, 0 replies; 42+ messages in thread
From: Daniel Vetter @ 2022-05-21 16:07 UTC (permalink / raw)
To: Robert Foss
Cc: Jonas Karlman, David Airlie, qwen, Neil Armstrong, linux-kernel,
dri-devel, Jernej Skrabec, Andrzej Hajda, Chen-Yu Tsai, bliang,
Xin Ji, Laurent Pinchart
On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote:
>
> On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote:
> >
> > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > >
> > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > > > >
> > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > >
> > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > > > >
> > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > > > ---
> > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > > >
> > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > index 376da01243a3..71df977e8f53 100644
> > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > >
> > > > > > anx7625_get_swing_setting(dev, pdata);
> > > > > >
> > > > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > > > if (!pdata->mipi_host_node) {
> > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > > > return -ENODEV;
> > > > > > }
> > > > > >
> > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > > > + bus_type = 0;
> > > > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > > > if (ep0) {
> > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > > > }
> > > > > >
> > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > > > - pdata->is_dpi = 0;
> > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > > > + pdata->is_dpi = 1;
> > > > > >
> > > > > > pdata->mipi_lanes = mipi_lanes;
> > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > > > >
> > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > > >
> > > > Acked-by: Robert Foss <robert.foss@linaro.org>
> > >
> > > Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> > >
> > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> > > mainline (next-20220422).
> > >
> > > Xin, in the future, please send the whole series to all recipients of
> > > all patches listed by get_maintainers.pl, not just the recipients of
> > > each patch. In the case of this series, they should have been sent
> > > to all of the mailing lists (media, devicetree, dri-devel) so that
> > > everyone has the same, full view of the patches.
> > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
> > Thanks,
> > Xin
> > >
> > > ChenYu
>
> Applied 3/4 + 4/4 to drm-misc-next.
This patch doesn't even compile. Can you pls fix this up asap? Also
pls compile-test before pushing ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
2022-05-21 16:07 ` Daniel Vetter
@ 2022-05-21 16:28 ` Daniel Vetter
-1 siblings, 0 replies; 42+ messages in thread
From: Daniel Vetter @ 2022-05-21 16:28 UTC (permalink / raw)
To: Robert Foss
Cc: Jonas Karlman, David Airlie, qwen, Neil Armstrong, linux-kernel,
dri-devel, Jernej Skrabec, Andrzej Hajda, Chen-Yu Tsai, bliang,
Xin Ji, Laurent Pinchart
On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote:
>
> On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote:
> >
> > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote:
> > >
> > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > > >
> > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > > > > >
> > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > > >
> > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > > > > >
> > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > > > > ---
> > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > > > >
> > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > index 376da01243a3..71df977e8f53 100644
> > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > >
> > > > > > > anx7625_get_swing_setting(dev, pdata);
> > > > > > >
> > > > > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > > > > if (!pdata->mipi_host_node) {
> > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > > > > return -ENODEV;
> > > > > > > }
> > > > > > >
> > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > > > > + bus_type = 0;
> > > > > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > > > > if (ep0) {
> > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > > > > }
> > > > > > >
> > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > > > > - pdata->is_dpi = 0;
> > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > > > > + pdata->is_dpi = 1;
> > > > > > >
> > > > > > > pdata->mipi_lanes = mipi_lanes;
> > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > > > > >
> > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > > > >
> > > > > Acked-by: Robert Foss <robert.foss@linaro.org>
> > > >
> > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> > > >
> > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> > > > mainline (next-20220422).
> > > >
> > > > Xin, in the future, please send the whole series to all recipients of
> > > > all patches listed by get_maintainers.pl, not just the recipients of
> > > > each patch. In the case of this series, they should have been sent
> > > > to all of the mailing lists (media, devicetree, dri-devel) so that
> > > > everyone has the same, full view of the patches.
> > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
> > > Thanks,
> > > Xin
> > > >
> > > > ChenYu
> >
> > Applied 3/4 + 4/4 to drm-misc-next.
>
> This patch doesn't even compile. Can you pls fix this up asap? Also
> pls compile-test before pushing ...
Marek says the prerequisite landed through linux-media, and that's why
it compilers on linux-next but not in drm-misc-next.
Don't do that.
Instead:
- merge all patches through one branch, with the foreign patches acked
for that merge patch
- wait until you can backmerge all the dependencies
- do a topic branch
This probably needs to be reverted here and instead merged through
linux-media. Or you wait until -rc1 and then apply it to
drm-misc-next.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
@ 2022-05-21 16:28 ` Daniel Vetter
0 siblings, 0 replies; 42+ messages in thread
From: Daniel Vetter @ 2022-05-21 16:28 UTC (permalink / raw)
To: Robert Foss
Cc: Xin Ji, Neil Armstrong, David Airlie, qwen, Jonas Karlman,
linux-kernel, dri-devel, Jernej Skrabec, Andrzej Hajda,
Chen-Yu Tsai, bliang, Laurent Pinchart
On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote:
>
> On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote:
> >
> > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote:
> > >
> > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > > >
> > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > > > > >
> > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > > >
> > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > > > > >
> > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > > > > ---
> > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > > > >
> > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > index 376da01243a3..71df977e8f53 100644
> > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > >
> > > > > > > anx7625_get_swing_setting(dev, pdata);
> > > > > > >
> > > > > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > > > > if (!pdata->mipi_host_node) {
> > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > > > > return -ENODEV;
> > > > > > > }
> > > > > > >
> > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > > > > + bus_type = 0;
> > > > > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > > > > if (ep0) {
> > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > > > > }
> > > > > > >
> > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > > > > - pdata->is_dpi = 0;
> > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > > > > + pdata->is_dpi = 1;
> > > > > > >
> > > > > > > pdata->mipi_lanes = mipi_lanes;
> > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > > > > >
> > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > > > >
> > > > > Acked-by: Robert Foss <robert.foss@linaro.org>
> > > >
> > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> > > >
> > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> > > > mainline (next-20220422).
> > > >
> > > > Xin, in the future, please send the whole series to all recipients of
> > > > all patches listed by get_maintainers.pl, not just the recipients of
> > > > each patch. In the case of this series, they should have been sent
> > > > to all of the mailing lists (media, devicetree, dri-devel) so that
> > > > everyone has the same, full view of the patches.
> > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
> > > Thanks,
> > > Xin
> > > >
> > > > ChenYu
> >
> > Applied 3/4 + 4/4 to drm-misc-next.
>
> This patch doesn't even compile. Can you pls fix this up asap? Also
> pls compile-test before pushing ...
Marek says the prerequisite landed through linux-media, and that's why
it compilers on linux-next but not in drm-misc-next.
Don't do that.
Instead:
- merge all patches through one branch, with the foreign patches acked
for that merge patch
- wait until you can backmerge all the dependencies
- do a topic branch
This probably needs to be reverted here and instead merged through
linux-media. Or you wait until -rc1 and then apply it to
drm-misc-next.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
2022-05-21 16:28 ` Daniel Vetter
@ 2022-05-23 3:13 ` Xin Ji
-1 siblings, 0 replies; 42+ messages in thread
From: Xin Ji @ 2022-05-23 3:13 UTC (permalink / raw)
To: Daniel Vetter
Cc: Robert Foss, Neil Armstrong, David Airlie, qwen, Jonas Karlman,
linux-kernel, dri-devel, Jernej Skrabec, Andrzej Hajda,
Chen-Yu Tsai, bliang, Laurent Pinchart
On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel Vetter wrote:
> On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote:
> >
> > On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote:
> > >
> > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote:
> > > >
> > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> > > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > > > >
> > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > >
> > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > > > >
> > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > > > > > >
> > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > > > > > ---
> > > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > > > > >
> > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > index 376da01243a3..71df977e8f53 100644
> > > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > >
> > > > > > > > anx7625_get_swing_setting(dev, pdata);
> > > > > > > >
> > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > > > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > > > > > if (!pdata->mipi_host_node) {
> > > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > > > > > return -ENODEV;
> > > > > > > > }
> > > > > > > >
> > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > > > > > + bus_type = 0;
> > > > > > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > > > > > if (ep0) {
> > > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > > > > > }
> > > > > > > >
> > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > > > > > - pdata->is_dpi = 0;
> > > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > > > > > + pdata->is_dpi = 1;
> > > > > > > >
> > > > > > > > pdata->mipi_lanes = mipi_lanes;
> > > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > > > > > >
> > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > > > > >
> > > > > > Acked-by: Robert Foss <robert.foss@linaro.org>
> > > > >
> > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> > > > >
> > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> > > > > mainline (next-20220422).
> > > > >
> > > > > Xin, in the future, please send the whole series to all recipients of
> > > > > all patches listed by get_maintainers.pl, not just the recipients of
> > > > > each patch. In the case of this series, they should have been sent
> > > > > to all of the mailing lists (media, devicetree, dri-devel) so that
> > > > > everyone has the same, full view of the patches.
> > > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
> > > > Thanks,
> > > > Xin
> > > > >
> > > > > ChenYu
> > >
> > > Applied 3/4 + 4/4 to drm-misc-next.
> >
> > This patch doesn't even compile. Can you pls fix this up asap? Also
> > pls compile-test before pushing ...
>
> Marek says the prerequisite landed through linux-media, and that's why
> it compilers on linux-next but not in drm-misc-next.
>
> Don't do that.
>
> Instead:
> - merge all patches through one branch, with the foreign patches acked
> for that merge patch
> - wait until you can backmerge all the dependencies
> - do a topic branch
>
> This probably needs to be reverted here and instead merged through
> linux-media. Or you wait until -rc1 and then apply it to
> drm-misc-next.
> -Daniel
Hi Daniel, I use git send-email to upstream patch and automatically
generated reviewer list, so patch 1/4 and 2/4 send to linux-media, and
these 2 patches already merged in linux-media.
Thanks,
Xin
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Fblog.ffwll.ch%2F&data=05%7C01%7Cxji%40analogixsemi.com%7C80ac2fb262a5407ded4208da3b46ff62%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637887473373535347%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=lYWBVSLPiHKN%2BYnyWqgeM5cgH17OjxpXGVQ1kt2bZrU%3D&reserved=0
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
@ 2022-05-23 3:13 ` Xin Ji
0 siblings, 0 replies; 42+ messages in thread
From: Xin Ji @ 2022-05-23 3:13 UTC (permalink / raw)
To: Daniel Vetter
Cc: Jernej Skrabec, Jonas Karlman, David Airlie, qwen,
Neil Armstrong, linux-kernel, Robert Foss, dri-devel,
Andrzej Hajda, Chen-Yu Tsai, bliang, Laurent Pinchart
On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel Vetter wrote:
> On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote:
> >
> > On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote:
> > >
> > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote:
> > > >
> > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> > > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > > > >
> > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > >
> > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > > > >
> > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > > > > > >
> > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > > > > > ---
> > > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > > > > >
> > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > index 376da01243a3..71df977e8f53 100644
> > > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > >
> > > > > > > > anx7625_get_swing_setting(dev, pdata);
> > > > > > > >
> > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > > > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > > > > > if (!pdata->mipi_host_node) {
> > > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > > > > > return -ENODEV;
> > > > > > > > }
> > > > > > > >
> > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > > > > > + bus_type = 0;
> > > > > > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > > > > > if (ep0) {
> > > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > > > > > }
> > > > > > > >
> > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > > > > > - pdata->is_dpi = 0;
> > > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > > > > > + pdata->is_dpi = 1;
> > > > > > > >
> > > > > > > > pdata->mipi_lanes = mipi_lanes;
> > > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > > > > > >
> > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > > > > >
> > > > > > Acked-by: Robert Foss <robert.foss@linaro.org>
> > > > >
> > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> > > > >
> > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> > > > > mainline (next-20220422).
> > > > >
> > > > > Xin, in the future, please send the whole series to all recipients of
> > > > > all patches listed by get_maintainers.pl, not just the recipients of
> > > > > each patch. In the case of this series, they should have been sent
> > > > > to all of the mailing lists (media, devicetree, dri-devel) so that
> > > > > everyone has the same, full view of the patches.
> > > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
> > > > Thanks,
> > > > Xin
> > > > >
> > > > > ChenYu
> > >
> > > Applied 3/4 + 4/4 to drm-misc-next.
> >
> > This patch doesn't even compile. Can you pls fix this up asap? Also
> > pls compile-test before pushing ...
>
> Marek says the prerequisite landed through linux-media, and that's why
> it compilers on linux-next but not in drm-misc-next.
>
> Don't do that.
>
> Instead:
> - merge all patches through one branch, with the foreign patches acked
> for that merge patch
> - wait until you can backmerge all the dependencies
> - do a topic branch
>
> This probably needs to be reverted here and instead merged through
> linux-media. Or you wait until -rc1 and then apply it to
> drm-misc-next.
> -Daniel
Hi Daniel, I use git send-email to upstream patch and automatically
generated reviewer list, so patch 1/4 and 2/4 send to linux-media, and
these 2 patches already merged in linux-media.
Thanks,
Xin
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Fblog.ffwll.ch%2F&data=05%7C01%7Cxji%40analogixsemi.com%7C80ac2fb262a5407ded4208da3b46ff62%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637887473373535347%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=lYWBVSLPiHKN%2BYnyWqgeM5cgH17OjxpXGVQ1kt2bZrU%3D&reserved=0
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
2022-05-23 3:13 ` Xin Ji
@ 2022-05-23 7:17 ` Chen-Yu Tsai
-1 siblings, 0 replies; 42+ messages in thread
From: Chen-Yu Tsai @ 2022-05-23 7:17 UTC (permalink / raw)
To: Xin Ji
Cc: Jernej Skrabec, Andrzej Hajda, Jonas Karlman, David Airlie, qwen,
Neil Armstrong, linux-kernel, Robert Foss, dri-devel, bliang,
Laurent Pinchart
On Mon, May 23, 2022 at 11:13 AM Xin Ji <xji@analogixsemi.com> wrote:
>
> On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel Vetter wrote:
> > On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote:
> > >
> > > On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote:
> > > >
> > > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote:
> > > > >
> > > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> > > > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > >
> > > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > > >
> > > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > > > > >
> > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > > > > > > >
> > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > > > > > > ---
> > > > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > > > > > >
> > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > index 376da01243a3..71df977e8f53 100644
> > > > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > >
> > > > > > > > > anx7625_get_swing_setting(dev, pdata);
> > > > > > > > >
> > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > > > > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > > > > > > if (!pdata->mipi_host_node) {
> > > > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > > > > > > return -ENODEV;
> > > > > > > > > }
> > > > > > > > >
> > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > > > > > > + bus_type = 0;
> > > > > > > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > > > > > > if (ep0) {
> > > > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > > > > > > }
> > > > > > > > >
> > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > > > > > > - pdata->is_dpi = 0;
> > > > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > > > > > > + pdata->is_dpi = 1;
> > > > > > > > >
> > > > > > > > > pdata->mipi_lanes = mipi_lanes;
> > > > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > > > > > > >
> > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > > > > > >
> > > > > > > Acked-by: Robert Foss <robert.foss@linaro.org>
> > > > > >
> > > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> > > > > >
> > > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> > > > > > mainline (next-20220422).
> > > > > >
> > > > > > Xin, in the future, please send the whole series to all recipients of
> > > > > > all patches listed by get_maintainers.pl, not just the recipients of
> > > > > > each patch. In the case of this series, they should have been sent
> > > > > > to all of the mailing lists (media, devicetree, dri-devel) so that
> > > > > > everyone has the same, full view of the patches.
> > > > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
> > > > > Thanks,
> > > > > Xin
> > > > > >
> > > > > > ChenYu
> > > >
> > > > Applied 3/4 + 4/4 to drm-misc-next.
> > >
> > > This patch doesn't even compile. Can you pls fix this up asap? Also
> > > pls compile-test before pushing ...
> >
> > Marek says the prerequisite landed through linux-media, and that's why
> > it compilers on linux-next but not in drm-misc-next.
> >
> > Don't do that.
> >
> > Instead:
> > - merge all patches through one branch, with the foreign patches acked
> > for that merge patch
> > - wait until you can backmerge all the dependencies
> > - do a topic branch
> >
> > This probably needs to be reverted here and instead merged through
> > linux-media. Or you wait until -rc1 and then apply it to
> > drm-misc-next.
> > -Daniel
> Hi Daniel, I use git send-email to upstream patch and automatically
> generated reviewer list, so patch 1/4 and 2/4 send to linux-media, and
> these 2 patches already merged in linux-media.
This is one of the reasons why you should always send the "full" series
to all recipients. That way people, especially maintainers, are more
likely to notice build time cross tree dependencies like this one, and
work towards a common resolution.
ChenYu
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
@ 2022-05-23 7:17 ` Chen-Yu Tsai
0 siblings, 0 replies; 42+ messages in thread
From: Chen-Yu Tsai @ 2022-05-23 7:17 UTC (permalink / raw)
To: Xin Ji
Cc: Daniel Vetter, Robert Foss, Neil Armstrong, David Airlie, qwen,
Jonas Karlman, linux-kernel, dri-devel, Jernej Skrabec,
Andrzej Hajda, bliang, Laurent Pinchart
On Mon, May 23, 2022 at 11:13 AM Xin Ji <xji@analogixsemi.com> wrote:
>
> On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel Vetter wrote:
> > On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote:
> > >
> > > On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote:
> > > >
> > > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote:
> > > > >
> > > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> > > > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > >
> > > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > > >
> > > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > > > > >
> > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > > > > > > >
> > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > > > > > > ---
> > > > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > > > > > >
> > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > index 376da01243a3..71df977e8f53 100644
> > > > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > >
> > > > > > > > > anx7625_get_swing_setting(dev, pdata);
> > > > > > > > >
> > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > > > > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > > > > > > if (!pdata->mipi_host_node) {
> > > > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > > > > > > return -ENODEV;
> > > > > > > > > }
> > > > > > > > >
> > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > > > > > > + bus_type = 0;
> > > > > > > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > > > > > > if (ep0) {
> > > > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > > > > > > }
> > > > > > > > >
> > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > > > > > > - pdata->is_dpi = 0;
> > > > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > > > > > > + pdata->is_dpi = 1;
> > > > > > > > >
> > > > > > > > > pdata->mipi_lanes = mipi_lanes;
> > > > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > > > > > > >
> > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > > > > > >
> > > > > > > Acked-by: Robert Foss <robert.foss@linaro.org>
> > > > > >
> > > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> > > > > >
> > > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> > > > > > mainline (next-20220422).
> > > > > >
> > > > > > Xin, in the future, please send the whole series to all recipients of
> > > > > > all patches listed by get_maintainers.pl, not just the recipients of
> > > > > > each patch. In the case of this series, they should have been sent
> > > > > > to all of the mailing lists (media, devicetree, dri-devel) so that
> > > > > > everyone has the same, full view of the patches.
> > > > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
> > > > > Thanks,
> > > > > Xin
> > > > > >
> > > > > > ChenYu
> > > >
> > > > Applied 3/4 + 4/4 to drm-misc-next.
> > >
> > > This patch doesn't even compile. Can you pls fix this up asap? Also
> > > pls compile-test before pushing ...
> >
> > Marek says the prerequisite landed through linux-media, and that's why
> > it compilers on linux-next but not in drm-misc-next.
> >
> > Don't do that.
> >
> > Instead:
> > - merge all patches through one branch, with the foreign patches acked
> > for that merge patch
> > - wait until you can backmerge all the dependencies
> > - do a topic branch
> >
> > This probably needs to be reverted here and instead merged through
> > linux-media. Or you wait until -rc1 and then apply it to
> > drm-misc-next.
> > -Daniel
> Hi Daniel, I use git send-email to upstream patch and automatically
> generated reviewer list, so patch 1/4 and 2/4 send to linux-media, and
> these 2 patches already merged in linux-media.
This is one of the reasons why you should always send the "full" series
to all recipients. That way people, especially maintainers, are more
likely to notice build time cross tree dependencies like this one, and
work towards a common resolution.
ChenYu
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
2022-05-23 7:17 ` Chen-Yu Tsai
@ 2022-05-23 8:37 ` Robert Foss
-1 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-05-23 8:37 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Xin Ji, Daniel Vetter, Neil Armstrong, David Airlie, qwen,
Jonas Karlman, linux-kernel, dri-devel, Jernej Skrabec,
Andrzej Hajda, bliang, Laurent Pinchart
On Mon, 23 May 2022 at 09:18, Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> On Mon, May 23, 2022 at 11:13 AM Xin Ji <xji@analogixsemi.com> wrote:
> >
> > On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel Vetter wrote:
> > > On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > >
> > > > On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote:
> > > > >
> > > > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > >
> > > > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> > > > > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > > >
> > > > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > > > >
> > > > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > > > > > >
> > > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > > > > > > > >
> > > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > > > > > > > ---
> > > > > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > > > > > > >
> > > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > index 376da01243a3..71df977e8f53 100644
> > > > > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > > >
> > > > > > > > > > anx7625_get_swing_setting(dev, pdata);
> > > > > > > > > >
> > > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > > > > > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > > > > > > > if (!pdata->mipi_host_node) {
> > > > > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > > > > > > > return -ENODEV;
> > > > > > > > > > }
> > > > > > > > > >
> > > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > > > > > > > + bus_type = 0;
> > > > > > > > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > > > > > > > if (ep0) {
> > > > > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > > > > > > > }
> > > > > > > > > >
> > > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > > > > > > > - pdata->is_dpi = 0;
> > > > > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > > > > > > > + pdata->is_dpi = 1;
> > > > > > > > > >
> > > > > > > > > > pdata->mipi_lanes = mipi_lanes;
> > > > > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > > > > > > > >
> > > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > > > > > > >
> > > > > > > > Acked-by: Robert Foss <robert.foss@linaro.org>
> > > > > > >
> > > > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> > > > > > >
> > > > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> > > > > > > mainline (next-20220422).
> > > > > > >
> > > > > > > Xin, in the future, please send the whole series to all recipients of
> > > > > > > all patches listed by get_maintainers.pl, not just the recipients of
> > > > > > > each patch. In the case of this series, they should have been sent
> > > > > > > to all of the mailing lists (media, devicetree, dri-devel) so that
> > > > > > > everyone has the same, full view of the patches.
> > > > > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
> > > > > > Thanks,
> > > > > > Xin
> > > > > > >
> > > > > > > ChenYu
> > > > >
> > > > > Applied 3/4 + 4/4 to drm-misc-next.
> > > >
> > > > This patch doesn't even compile. Can you pls fix this up asap? Also
> > > > pls compile-test before pushing ...
> > >
> > > Marek says the prerequisite landed through linux-media, and that's why
> > > it compilers on linux-next but not in drm-misc-next.
> > >
> > > Don't do that.
> > >
> > > Instead:
> > > - merge all patches through one branch, with the foreign patches acked
> > > for that merge patch
> > > - wait until you can backmerge all the dependencies
> > > - do a topic branch
> > >
> > > This probably needs to be reverted here and instead merged through
> > > linux-media. Or you wait until -rc1 and then apply it to
> > > drm-misc-next.
> > > -Daniel
> > Hi Daniel, I use git send-email to upstream patch and automatically
> > generated reviewer list, so patch 1/4 and 2/4 send to linux-media, and
> > these 2 patches already merged in linux-media.
>
> This is one of the reasons why you should always send the "full" series
> to all recipients. That way people, especially maintainers, are more
> likely to notice build time cross tree dependencies like this one, and
> work towards a common resolution.
This mistake is mine, and I think the best solution is to revert 3+4 until rc1.
I'll send out the revert patches to the ML right away.
Rob.
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
@ 2022-05-23 8:37 ` Robert Foss
0 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-05-23 8:37 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Andrzej Hajda, Jonas Karlman, David Airlie, qwen, Neil Armstrong,
linux-kernel, dri-devel, Jernej Skrabec, bliang, Xin Ji,
Laurent Pinchart
On Mon, 23 May 2022 at 09:18, Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> On Mon, May 23, 2022 at 11:13 AM Xin Ji <xji@analogixsemi.com> wrote:
> >
> > On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel Vetter wrote:
> > > On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > >
> > > > On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote:
> > > > >
> > > > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > >
> > > > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> > > > > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > > >
> > > > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > > > >
> > > > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > > > > > >
> > > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > > > > > > > >
> > > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > > > > > > > ---
> > > > > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > > > > > > >
> > > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > index 376da01243a3..71df977e8f53 100644
> > > > > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > > >
> > > > > > > > > > anx7625_get_swing_setting(dev, pdata);
> > > > > > > > > >
> > > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > > > > > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > > > > > > > if (!pdata->mipi_host_node) {
> > > > > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > > > > > > > return -ENODEV;
> > > > > > > > > > }
> > > > > > > > > >
> > > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > > > > > > > + bus_type = 0;
> > > > > > > > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > > > > > > > if (ep0) {
> > > > > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > > > > > > > }
> > > > > > > > > >
> > > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > > > > > > > - pdata->is_dpi = 0;
> > > > > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > > > > > > > + pdata->is_dpi = 1;
> > > > > > > > > >
> > > > > > > > > > pdata->mipi_lanes = mipi_lanes;
> > > > > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > > > > > > > >
> > > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > > > > > > >
> > > > > > > > Acked-by: Robert Foss <robert.foss@linaro.org>
> > > > > > >
> > > > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> > > > > > >
> > > > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> > > > > > > mainline (next-20220422).
> > > > > > >
> > > > > > > Xin, in the future, please send the whole series to all recipients of
> > > > > > > all patches listed by get_maintainers.pl, not just the recipients of
> > > > > > > each patch. In the case of this series, they should have been sent
> > > > > > > to all of the mailing lists (media, devicetree, dri-devel) so that
> > > > > > > everyone has the same, full view of the patches.
> > > > > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
> > > > > > Thanks,
> > > > > > Xin
> > > > > > >
> > > > > > > ChenYu
> > > > >
> > > > > Applied 3/4 + 4/4 to drm-misc-next.
> > > >
> > > > This patch doesn't even compile. Can you pls fix this up asap? Also
> > > > pls compile-test before pushing ...
> > >
> > > Marek says the prerequisite landed through linux-media, and that's why
> > > it compilers on linux-next but not in drm-misc-next.
> > >
> > > Don't do that.
> > >
> > > Instead:
> > > - merge all patches through one branch, with the foreign patches acked
> > > for that merge patch
> > > - wait until you can backmerge all the dependencies
> > > - do a topic branch
> > >
> > > This probably needs to be reverted here and instead merged through
> > > linux-media. Or you wait until -rc1 and then apply it to
> > > drm-misc-next.
> > > -Daniel
> > Hi Daniel, I use git send-email to upstream patch and automatically
> > generated reviewer list, so patch 1/4 and 2/4 send to linux-media, and
> > these 2 patches already merged in linux-media.
>
> This is one of the reasons why you should always send the "full" series
> to all recipients. That way people, especially maintainers, are more
> likely to notice build time cross tree dependencies like this one, and
> work towards a common resolution.
This mistake is mine, and I think the best solution is to revert 3+4 until rc1.
I'll send out the revert patches to the ML right away.
Rob.
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
2022-05-23 8:37 ` Robert Foss
@ 2022-05-23 8:47 ` Robert Foss
-1 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-05-23 8:47 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Xin Ji, Daniel Vetter, Neil Armstrong, David Airlie, qwen,
Jonas Karlman, linux-kernel, dri-devel, Jernej Skrabec,
Andrzej Hajda, bliang, Laurent Pinchart
https://lore.kernel.org/all/20220523084615.13510-1-robert.foss@linaro.org/
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
@ 2022-05-23 8:47 ` Robert Foss
0 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-05-23 8:47 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Andrzej Hajda, Jonas Karlman, David Airlie, qwen, Neil Armstrong,
linux-kernel, dri-devel, Jernej Skrabec, bliang, Xin Ji,
Laurent Pinchart
https://lore.kernel.org/all/20220523084615.13510-1-robert.foss@linaro.org/
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
2022-05-23 8:37 ` Robert Foss
@ 2022-06-17 10:32 ` Chen-Yu Tsai
-1 siblings, 0 replies; 42+ messages in thread
From: Chen-Yu Tsai @ 2022-06-17 10:32 UTC (permalink / raw)
To: Robert Foss
Cc: Xin Ji, Daniel Vetter, Neil Armstrong, David Airlie, qwen,
Jonas Karlman, linux-kernel, dri-devel, Jernej Skrabec,
Andrzej Hajda, bliang, Laurent Pinchart
Hi,
On Mon, May 23, 2022 at 4:37 PM Robert Foss <robert.foss@linaro.org> wrote:
>
> On Mon, 23 May 2022 at 09:18, Chen-Yu Tsai <wenst@chromium.org> wrote:
> >
> > On Mon, May 23, 2022 at 11:13 AM Xin Ji <xji@analogixsemi.com> wrote:
> > >
> > > On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel Vetter wrote:
> > > > On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > > >
> > > > > On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote:
> > > > > >
> > > > > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > > >
> > > > > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> > > > > > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > > > >
> > > > > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > > > > >
> > > > > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > > > > > > >
> > > > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > > > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > > > > > > > > >
> > > > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > > > > > > > > ---
> > > > > > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > > > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > > > > > > > >
> > > > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > > index 376da01243a3..71df977e8f53 100644
> > > > > > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > > > >
> > > > > > > > > > > anx7625_get_swing_setting(dev, pdata);
> > > > > > > > > > >
> > > > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > > > > > > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > > > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > > > > > > > > if (!pdata->mipi_host_node) {
> > > > > > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > > > > > > > > return -ENODEV;
> > > > > > > > > > > }
> > > > > > > > > > >
> > > > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > > > > > > > > + bus_type = 0;
> > > > > > > > > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > > > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > > > > > > > > if (ep0) {
> > > > > > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > > > > > > > > }
> > > > > > > > > > >
> > > > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > > > > > > > > - pdata->is_dpi = 0;
> > > > > > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > > > > > > > > + pdata->is_dpi = 1;
> > > > > > > > > > >
> > > > > > > > > > > pdata->mipi_lanes = mipi_lanes;
> > > > > > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > > > > > > > > >
> > > > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > > > > > > > >
> > > > > > > > > Acked-by: Robert Foss <robert.foss@linaro.org>
> > > > > > > >
> > > > > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> > > > > > > >
> > > > > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> > > > > > > > mainline (next-20220422).
> > > > > > > >
> > > > > > > > Xin, in the future, please send the whole series to all recipients of
> > > > > > > > all patches listed by get_maintainers.pl, not just the recipients of
> > > > > > > > each patch. In the case of this series, they should have been sent
> > > > > > > > to all of the mailing lists (media, devicetree, dri-devel) so that
> > > > > > > > everyone has the same, full view of the patches.
> > > > > > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
> > > > > > > Thanks,
> > > > > > > Xin
> > > > > > > >
> > > > > > > > ChenYu
> > > > > >
> > > > > > Applied 3/4 + 4/4 to drm-misc-next.
> > > > >
> > > > > This patch doesn't even compile. Can you pls fix this up asap? Also
> > > > > pls compile-test before pushing ...
> > > >
> > > > Marek says the prerequisite landed through linux-media, and that's why
> > > > it compilers on linux-next but not in drm-misc-next.
> > > >
> > > > Don't do that.
> > > >
> > > > Instead:
> > > > - merge all patches through one branch, with the foreign patches acked
> > > > for that merge patch
> > > > - wait until you can backmerge all the dependencies
> > > > - do a topic branch
> > > >
> > > > This probably needs to be reverted here and instead merged through
> > > > linux-media. Or you wait until -rc1 and then apply it to
> > > > drm-misc-next.
> > > > -Daniel
> > > Hi Daniel, I use git send-email to upstream patch and automatically
> > > generated reviewer list, so patch 1/4 and 2/4 send to linux-media, and
> > > these 2 patches already merged in linux-media.
> >
> > This is one of the reasons why you should always send the "full" series
> > to all recipients. That way people, especially maintainers, are more
> > likely to notice build time cross tree dependencies like this one, and
> > work towards a common resolution.
>
> This mistake is mine, and I think the best solution is to revert 3+4 until rc1.
I think we can reland the patches now?
ChenYu
> I'll send out the revert patches to the ML right away.
>
>
> Rob.
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
@ 2022-06-17 10:32 ` Chen-Yu Tsai
0 siblings, 0 replies; 42+ messages in thread
From: Chen-Yu Tsai @ 2022-06-17 10:32 UTC (permalink / raw)
To: Robert Foss
Cc: Andrzej Hajda, Jonas Karlman, David Airlie, qwen, Neil Armstrong,
linux-kernel, dri-devel, Jernej Skrabec, bliang, Xin Ji,
Laurent Pinchart
Hi,
On Mon, May 23, 2022 at 4:37 PM Robert Foss <robert.foss@linaro.org> wrote:
>
> On Mon, 23 May 2022 at 09:18, Chen-Yu Tsai <wenst@chromium.org> wrote:
> >
> > On Mon, May 23, 2022 at 11:13 AM Xin Ji <xji@analogixsemi.com> wrote:
> > >
> > > On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel Vetter wrote:
> > > > On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > > >
> > > > > On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote:
> > > > > >
> > > > > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > > >
> > > > > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> > > > > > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > > > >
> > > > > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > > > > >
> > > > > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > > > > > > >
> > > > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > > > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > > > > > > > > >
> > > > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > > > > > > > > ---
> > > > > > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > > > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > > > > > > > >
> > > > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > > index 376da01243a3..71df977e8f53 100644
> > > > > > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > > > >
> > > > > > > > > > > anx7625_get_swing_setting(dev, pdata);
> > > > > > > > > > >
> > > > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > > > > > > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > > > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > > > > > > > > if (!pdata->mipi_host_node) {
> > > > > > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > > > > > > > > return -ENODEV;
> > > > > > > > > > > }
> > > > > > > > > > >
> > > > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > > > > > > > > + bus_type = 0;
> > > > > > > > > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > > > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > > > > > > > > if (ep0) {
> > > > > > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > > > > > > > > }
> > > > > > > > > > >
> > > > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > > > > > > > > - pdata->is_dpi = 0;
> > > > > > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > > > > > > > > + pdata->is_dpi = 1;
> > > > > > > > > > >
> > > > > > > > > > > pdata->mipi_lanes = mipi_lanes;
> > > > > > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > > > > > > > > >
> > > > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > > > > > > > >
> > > > > > > > > Acked-by: Robert Foss <robert.foss@linaro.org>
> > > > > > > >
> > > > > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> > > > > > > >
> > > > > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> > > > > > > > mainline (next-20220422).
> > > > > > > >
> > > > > > > > Xin, in the future, please send the whole series to all recipients of
> > > > > > > > all patches listed by get_maintainers.pl, not just the recipients of
> > > > > > > > each patch. In the case of this series, they should have been sent
> > > > > > > > to all of the mailing lists (media, devicetree, dri-devel) so that
> > > > > > > > everyone has the same, full view of the patches.
> > > > > > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
> > > > > > > Thanks,
> > > > > > > Xin
> > > > > > > >
> > > > > > > > ChenYu
> > > > > >
> > > > > > Applied 3/4 + 4/4 to drm-misc-next.
> > > > >
> > > > > This patch doesn't even compile. Can you pls fix this up asap? Also
> > > > > pls compile-test before pushing ...
> > > >
> > > > Marek says the prerequisite landed through linux-media, and that's why
> > > > it compilers on linux-next but not in drm-misc-next.
> > > >
> > > > Don't do that.
> > > >
> > > > Instead:
> > > > - merge all patches through one branch, with the foreign patches acked
> > > > for that merge patch
> > > > - wait until you can backmerge all the dependencies
> > > > - do a topic branch
> > > >
> > > > This probably needs to be reverted here and instead merged through
> > > > linux-media. Or you wait until -rc1 and then apply it to
> > > > drm-misc-next.
> > > > -Daniel
> > > Hi Daniel, I use git send-email to upstream patch and automatically
> > > generated reviewer list, so patch 1/4 and 2/4 send to linux-media, and
> > > these 2 patches already merged in linux-media.
> >
> > This is one of the reasons why you should always send the "full" series
> > to all recipients. That way people, especially maintainers, are more
> > likely to notice build time cross tree dependencies like this one, and
> > work towards a common resolution.
>
> This mistake is mine, and I think the best solution is to revert 3+4 until rc1.
I think we can reland the patches now?
ChenYu
> I'll send out the revert patches to the ML right away.
>
>
> Rob.
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
2022-06-17 10:32 ` Chen-Yu Tsai
@ 2022-06-20 19:13 ` Robert Foss
-1 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-06-20 19:13 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Andrzej Hajda, Jonas Karlman, David Airlie, qwen, Neil Armstrong,
linux-kernel, dri-devel, Jernej Skrabec, bliang, Xin Ji,
Laurent Pinchart
On Fri, 17 Jun 2022 at 12:32, Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> Hi,
>
> On Mon, May 23, 2022 at 4:37 PM Robert Foss <robert.foss@linaro.org> wrote:
> >
> > On Mon, 23 May 2022 at 09:18, Chen-Yu Tsai <wenst@chromium.org> wrote:
> > >
> > > On Mon, May 23, 2022 at 11:13 AM Xin Ji <xji@analogixsemi.com> wrote:
> > > >
> > > > On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel Vetter wrote:
> > > > > On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > > > >
> > > > > > On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > >
> > > > > > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > > > >
> > > > > > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> > > > > > > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > > > > >
> > > > > > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > > > > > >
> > > > > > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > > > > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > > > > > > > > > >
> > > > > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > > > > > > > > > ---
> > > > > > > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > > > > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > > > > > > > > >
> > > > > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > > > index 376da01243a3..71df977e8f53 100644
> > > > > > > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > > > > >
> > > > > > > > > > > > anx7625_get_swing_setting(dev, pdata);
> > > > > > > > > > > >
> > > > > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > > > > > > > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > > > > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > > > > > > > > > if (!pdata->mipi_host_node) {
> > > > > > > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > > > > > > > > > return -ENODEV;
> > > > > > > > > > > > }
> > > > > > > > > > > >
> > > > > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > > > > > > > > > + bus_type = 0;
> > > > > > > > > > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > > > > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > > > > > > > > > if (ep0) {
> > > > > > > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > > > > > > > > > }
> > > > > > > > > > > >
> > > > > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > > > > > > > > > - pdata->is_dpi = 0;
> > > > > > > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > > > > > > > > > + pdata->is_dpi = 1;
> > > > > > > > > > > >
> > > > > > > > > > > > pdata->mipi_lanes = mipi_lanes;
> > > > > > > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > > > > > > > > > >
> > > > > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > > > > > > > > >
> > > > > > > > > > Acked-by: Robert Foss <robert.foss@linaro.org>
> > > > > > > > >
> > > > > > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> > > > > > > > >
> > > > > > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> > > > > > > > > mainline (next-20220422).
> > > > > > > > >
> > > > > > > > > Xin, in the future, please send the whole series to all recipients of
> > > > > > > > > all patches listed by get_maintainers.pl, not just the recipients of
> > > > > > > > > each patch. In the case of this series, they should have been sent
> > > > > > > > > to all of the mailing lists (media, devicetree, dri-devel) so that
> > > > > > > > > everyone has the same, full view of the patches.
> > > > > > > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
> > > > > > > > Thanks,
> > > > > > > > Xin
> > > > > > > > >
> > > > > > > > > ChenYu
> > > > > > >
> > > > > > > Applied 3/4 + 4/4 to drm-misc-next.
> > > > > >
> > > > > > This patch doesn't even compile. Can you pls fix this up asap? Also
> > > > > > pls compile-test before pushing ...
> > > > >
> > > > > Marek says the prerequisite landed through linux-media, and that's why
> > > > > it compilers on linux-next but not in drm-misc-next.
> > > > >
> > > > > Don't do that.
> > > > >
> > > > > Instead:
> > > > > - merge all patches through one branch, with the foreign patches acked
> > > > > for that merge patch
> > > > > - wait until you can backmerge all the dependencies
> > > > > - do a topic branch
> > > > >
> > > > > This probably needs to be reverted here and instead merged through
> > > > > linux-media. Or you wait until -rc1 and then apply it to
> > > > > drm-misc-next.
> > > > > -Daniel
> > > > Hi Daniel, I use git send-email to upstream patch and automatically
> > > > generated reviewer list, so patch 1/4 and 2/4 send to linux-media, and
> > > > these 2 patches already merged in linux-media.
> > >
> > > This is one of the reasons why you should always send the "full" series
> > > to all recipients. That way people, especially maintainers, are more
> > > likely to notice build time cross tree dependencies like this one, and
> > > work towards a common resolution.
> >
> > This mistake is mine, and I think the best solution is to revert 3+4 until rc1.
>
> I think we can reland the patches now?
Re-applied 3/4 + 4/4 to drm-misc-next.
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type
@ 2022-06-20 19:13 ` Robert Foss
0 siblings, 0 replies; 42+ messages in thread
From: Robert Foss @ 2022-06-20 19:13 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Xin Ji, Daniel Vetter, Neil Armstrong, David Airlie, qwen,
Jonas Karlman, linux-kernel, dri-devel, Jernej Skrabec,
Andrzej Hajda, bliang, Laurent Pinchart
On Fri, 17 Jun 2022 at 12:32, Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> Hi,
>
> On Mon, May 23, 2022 at 4:37 PM Robert Foss <robert.foss@linaro.org> wrote:
> >
> > On Mon, 23 May 2022 at 09:18, Chen-Yu Tsai <wenst@chromium.org> wrote:
> > >
> > > On Mon, May 23, 2022 at 11:13 AM Xin Ji <xji@analogixsemi.com> wrote:
> > > >
> > > > On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel Vetter wrote:
> > > > > On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > > > >
> > > > > > On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > >
> > > > > > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > > > >
> > > > > > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote:
> > > > > > > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > > > > >
> > > > > > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote:
> > > > > > > > > > >
> > > > > > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI
> > > > > > > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it.
> > > > > > > > > > > >
> > > > > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > > > > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > > > > > > > > > > > ---
> > > > > > > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
> > > > > > > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > > > > > > > > >
> > > > > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > > > index 376da01243a3..71df977e8f53 100644
> > > > > > > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > > > > > > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > > > > >
> > > > > > > > > > > > anx7625_get_swing_setting(dev, pdata);
> > > > > > > > > > > >
> > > > > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */
> > > > > > > > > > > > + pdata->is_dpi = 0; /* default dsi mode */
> > > > > > > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
> > > > > > > > > > > > if (!pdata->mipi_host_node) {
> > > > > > > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n");
> > > > > > > > > > > > return -ENODEV;
> > > > > > > > > > > > }
> > > > > > > > > > > >
> > > > > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL;
> > > > > > > > > > > > + bus_type = 0;
> > > > > > > > > > > > mipi_lanes = MAX_LANES_SUPPORT;
> > > > > > > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0);
> > > > > > > > > > > > if (ep0) {
> > > > > > > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev,
> > > > > > > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes");
> > > > > > > > > > > > }
> > > > > > > > > > > >
> > > > > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */
> > > > > > > > > > > > - pdata->is_dpi = 0;
> > > > > > > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */
> > > > > > > > > > > > + pdata->is_dpi = 1;
> > > > > > > > > > > >
> > > > > > > > > > > > pdata->mipi_lanes = mipi_lanes;
> > > > > > > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
> > > > > > > > > > >
> > > > > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org>
> > > > > > > > > >
> > > > > > > > > > Acked-by: Robert Foss <robert.foss@linaro.org>
> > > > > > > > >
> > > > > > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org>
> > > > > > > > >
> > > > > > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on
> > > > > > > > > mainline (next-20220422).
> > > > > > > > >
> > > > > > > > > Xin, in the future, please send the whole series to all recipients of
> > > > > > > > > all patches listed by get_maintainers.pl, not just the recipients of
> > > > > > > > > each patch. In the case of this series, they should have been sent
> > > > > > > > > to all of the mailing lists (media, devicetree, dri-devel) so that
> > > > > > > > > everyone has the same, full view of the patches.
> > > > > > > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time.
> > > > > > > > Thanks,
> > > > > > > > Xin
> > > > > > > > >
> > > > > > > > > ChenYu
> > > > > > >
> > > > > > > Applied 3/4 + 4/4 to drm-misc-next.
> > > > > >
> > > > > > This patch doesn't even compile. Can you pls fix this up asap? Also
> > > > > > pls compile-test before pushing ...
> > > > >
> > > > > Marek says the prerequisite landed through linux-media, and that's why
> > > > > it compilers on linux-next but not in drm-misc-next.
> > > > >
> > > > > Don't do that.
> > > > >
> > > > > Instead:
> > > > > - merge all patches through one branch, with the foreign patches acked
> > > > > for that merge patch
> > > > > - wait until you can backmerge all the dependencies
> > > > > - do a topic branch
> > > > >
> > > > > This probably needs to be reverted here and instead merged through
> > > > > linux-media. Or you wait until -rc1 and then apply it to
> > > > > drm-misc-next.
> > > > > -Daniel
> > > > Hi Daniel, I use git send-email to upstream patch and automatically
> > > > generated reviewer list, so patch 1/4 and 2/4 send to linux-media, and
> > > > these 2 patches already merged in linux-media.
> > >
> > > This is one of the reasons why you should always send the "full" series
> > > to all recipients. That way people, especially maintainers, are more
> > > likely to notice build time cross tree dependencies like this one, and
> > > work towards a common resolution.
> >
> > This mistake is mine, and I think the best solution is to revert 3+4 until rc1.
>
> I think we can reland the patches now?
Re-applied 3/4 + 4/4 to drm-misc-next.
^ permalink raw reply [flat|nested] 42+ messages in thread
end of thread, other threads:[~2022-06-20 19:14 UTC | newest]
Thread overview: 42+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-22 8:47 [PATCH v2 1/4] media/v4l2-core: Add enum V4L2_FWNODE_BUS_TYPE_DPI Xin Ji
2022-04-22 8:47 ` [PATCH v2 2/4] dt-bindings: media: video-interfaces: Add new bus-type Xin Ji
2022-04-22 14:03 ` Robert Foss
2022-04-22 8:47 ` [PATCH v2 3/4] dt-bindings:drm/bridge:anx7625: add port@0 property Xin Ji
2022-04-22 8:47 ` Xin Ji
2022-04-22 14:03 ` Robert Foss
2022-04-22 14:03 ` Robert Foss
2022-04-22 14:10 ` Robert Foss
2022-04-22 14:10 ` Robert Foss
2022-05-02 21:07 ` Rob Herring
2022-05-02 21:07 ` Rob Herring
2022-04-22 8:47 ` [PATCH v2 4/4] drm/bridge: anx7625: Use DPI bus type Xin Ji
2022-04-22 8:47 ` Xin Ji
2022-04-22 14:01 ` Robert Foss
2022-04-22 14:01 ` Robert Foss
2022-04-22 14:13 ` Robert Foss
2022-04-22 14:13 ` Robert Foss
2022-04-25 8:24 ` Chen-Yu Tsai
2022-04-25 8:24 ` Chen-Yu Tsai
2022-04-25 8:29 ` Chen-Yu Tsai
2022-04-25 8:29 ` Chen-Yu Tsai
2022-04-25 9:14 ` Xin Ji
2022-04-25 9:14 ` Xin Ji
2022-05-17 16:09 ` Robert Foss
2022-05-17 16:09 ` Robert Foss
2022-05-21 16:07 ` Daniel Vetter
2022-05-21 16:07 ` Daniel Vetter
2022-05-21 16:28 ` Daniel Vetter
2022-05-21 16:28 ` Daniel Vetter
2022-05-23 3:13 ` Xin Ji
2022-05-23 3:13 ` Xin Ji
2022-05-23 7:17 ` Chen-Yu Tsai
2022-05-23 7:17 ` Chen-Yu Tsai
2022-05-23 8:37 ` Robert Foss
2022-05-23 8:37 ` Robert Foss
2022-05-23 8:47 ` Robert Foss
2022-05-23 8:47 ` Robert Foss
2022-06-17 10:32 ` Chen-Yu Tsai
2022-06-17 10:32 ` Chen-Yu Tsai
2022-06-20 19:13 ` Robert Foss
2022-06-20 19:13 ` Robert Foss
2022-04-22 14:10 ` [PATCH v2 1/4] media/v4l2-core: Add enum V4L2_FWNODE_BUS_TYPE_DPI Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.