From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60367C07E9E for ; Fri, 9 Jul 2021 10:26:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AE05613C9 for ; Fri, 9 Jul 2021 10:26:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232050AbhGIK3F (ORCPT ); Fri, 9 Jul 2021 06:29:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232010AbhGIK3A (ORCPT ); Fri, 9 Jul 2021 06:29:00 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59F57C0613E6 for ; Fri, 9 Jul 2021 03:26:16 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id n14so22307176lfu.8 for ; Fri, 09 Jul 2021 03:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AiaAvA+vLz3FtrBULzF8WYojeUlJAsTsVtqvKG72rx8=; b=n6i8wmahbKpTtiTt0jZRJpTElaUmS8kvMSaaMepN4+Z4nT1EWnUVTcrFySgZVpkyEv 7WnelJAP3/nh8X1jVzN6ZI74Jo63Z3tjeLfj0gUuC1ngOQEQJvLLHjhKKjCggLbtlmNN wUjHJCZTwSVD0YxS2JqHVQkuEUSKGN6hGZUxE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AiaAvA+vLz3FtrBULzF8WYojeUlJAsTsVtqvKG72rx8=; b=c+yQA6MMdTFjziX6i+feyU4sOiCaUjzxXXafKWMFaL95SV0s9KfF7y3g1XsOFwV5zn Trrf8l+/YeAP4Jyxbu8ZrZgoZJWi2g7yMpTPcKAdRH43LJjWCQyT8MeBPsoZze0s0Mpa A+Mpjno4UH82EyhF1AkzYL2hp56UTgJBMjQnmZg52+v5/KwRcaw1Z4p+/xk4/U6sCFhx Wua4SV7icc9jn+WVeoRFpXrtiTEaw6WUdDbD++6KZhbt9vNqBrOgrciaSLUVgSPNJWVl VYQCu4QStdOe+/tLymsu1+BkBAEOWIOk3uxTXtUyvbwHGrMin10dpnNUFXL7GKrjYUtM SAug== X-Gm-Message-State: AOAM530GCUL3OLtrSYqV981lFJQeiPu/ciUX9Bq4fSs/a55GeWGMHc0N W70w0dbuJ2vysiDPVHxCQxllIvrJ1VKnj0z/h/FcuQ== X-Google-Smtp-Source: ABdhPJyTbIWxzkC7SuGEvymnm5fWso+1YwVVNumQfR2/BL/A4l+vH4cT2fmxdtPEjDSgvQYB1IhmFTLBsrM2cgSPZoU= X-Received: by 2002:a05:6512:39cb:: with SMTP id k11mr3933643lfu.587.1625826374731; Fri, 09 Jul 2021 03:26:14 -0700 (PDT) MIME-Version: 1.0 References: <20210616224743.5109-1-chun-jie.chen@mediatek.com> <20210616224743.5109-18-chun-jie.chen@mediatek.com> In-Reply-To: <20210616224743.5109-18-chun-jie.chen@mediatek.com> From: Chen-Yu Tsai Date: Fri, 9 Jul 2021 18:26:03 +0800 Message-ID: Subject: Re: [PATCH 17/22] clk: mediatek: Add MT8195 vencsys clock support To: Chun-Jie Chen Cc: Matthias Brugger , Stephen Boyd , Nicolas Boichat , Rob Herring , linux-arm-kernel@lists.infradead.org, LKML , linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, srv_heupstream@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 17, 2021 at 7:10 AM Chun-Jie Chen wrote: > > Add MT8195 vencsys clock providers > > Signed-off-by: Chun-Jie Chen > --- > drivers/clk/mediatek/Kconfig | 6 +++ > drivers/clk/mediatek/Makefile | 1 + > drivers/clk/mediatek/clk-mt8195-venc.c | 71 ++++++++++++++++++++++++++ > 3 files changed, 78 insertions(+) > create mode 100644 drivers/clk/mediatek/clk-mt8195-venc.c > > diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig > index 1e89c68f6c6c..3352686d98cf 100644 > --- a/drivers/clk/mediatek/Kconfig > +++ b/drivers/clk/mediatek/Kconfig > @@ -660,6 +660,12 @@ config COMMON_CLK_MT8195_VDOSYS1 > help > This driver supports MediaTek MT8195 vdosys1 clocks. > > +config COMMON_CLK_MT8195_VENCSYS > + bool "Clock driver for MediaTek MT8195 vencsys" > + depends on COMMON_CLK_MT8195 > + help > + This driver supports MediaTek MT8195 vencsys clocks. > + > config COMMON_CLK_MT8516 > bool "Clock driver for MediaTek MT8516" > depends on ARCH_MEDIATEK || COMPILE_TEST > diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile > index 76c0fa837cb0..76a6b404e34b 100644 > --- a/drivers/clk/mediatek/Makefile > +++ b/drivers/clk/mediatek/Makefile > @@ -93,5 +93,6 @@ obj-$(CONFIG_COMMON_CLK_MT8195_NNASYS) += clk-mt8195-nna.o > obj-$(CONFIG_COMMON_CLK_MT8195_VDECSYS) += clk-mt8195-vdec.o > obj-$(CONFIG_COMMON_CLK_MT8195_VDOSYS0) += clk-mt8195-vdo0.o > obj-$(CONFIG_COMMON_CLK_MT8195_VDOSYS1) += clk-mt8195-vdo1.o > +obj-$(CONFIG_COMMON_CLK_MT8195_VENCSYS) += clk-mt8195-venc.o > obj-$(CONFIG_COMMON_CLK_MT8516) += clk-mt8516.o > obj-$(CONFIG_COMMON_CLK_MT8516_AUDSYS) += clk-mt8516-aud.o > diff --git a/drivers/clk/mediatek/clk-mt8195-venc.c b/drivers/clk/mediatek/clk-mt8195-venc.c > new file mode 100644 > index 000000000000..410ca69d5759 > --- /dev/null > +++ b/drivers/clk/mediatek/clk-mt8195-venc.c > @@ -0,0 +1,71 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +// > +// Copyright (c) 2021 MediaTek Inc. > +// Author: Chun-Jie Chen > + > +#include > +#include > + > +#include "clk-mtk.h" > +#include "clk-gate.h" > + > +#include > + > +static const struct mtk_gate_regs venc_cg_regs = { > + .set_ofs = 0x4, > + .clr_ofs = 0x8, > + .sta_ofs = 0x0, > +}; > + > +#define GATE_VENC(_id, _name, _parent, _shift) \ > + GATE_MTK(_id, _name, _parent, &venc_cg_regs, _shift, &mtk_clk_gate_ops_setclr_inv) > + > +static const struct mtk_gate venc_clks[] = { > + GATE_VENC(CLK_VENC_LARB, "venc_larb", "venc_sel", 0), > + GATE_VENC(CLK_VENC_VENC, "venc_venc", "venc_sel", 4), > + GATE_VENC(CLK_VENC_JPGENC, "venc_jpgenc", "venc_sel", 8), > + GATE_VENC(CLK_VENC_JPGDEC, "venc_jpgdec", "venc_sel", 12), > + GATE_VENC(CLK_VENC_JPGDEC_C1, "venc_jpgdec_c1", "venc_sel", 16), > + GATE_VENC(CLK_VENC_GALS, "venc_gals", "venc_sel", 28), > +}; > + > +static const struct mtk_gate venc_core1_clks[] = { > + GATE_VENC(CLK_VENC_CORE1_LARB, "venc_core1_larb", "venc_sel", 0), > + GATE_VENC(CLK_VENC_CORE1_VENC, "venc_core1_venc", "venc_sel", 4), > + GATE_VENC(CLK_VENC_CORE1_JPGENC, "venc_core1_jpgenc", "venc_sel", 8), > + GATE_VENC(CLK_VENC_CORE1_JPGDEC, "venc_core1_jpgdec", "venc_sel", 12), > + GATE_VENC(CLK_VENC_CORE1_JPGDEC_C1, "venc_core1_jpgdec_c1", "venc_sel", 16), > + GATE_VENC(CLK_VENC_CORE1_GALS, "venc_core1_gals", "venc_sel", 28), > +}; So I'm not sure why there are two sets of clocks for each endpoint. Since this hardware block is not documented in the datasheet, maybe you could provide some explanation? What I'm wondering is if the first set is actually some clock gate for bus access and the second set is the main module clock that drives the internal logic. The general comments from the other patches apply as well. ChenYu > + > +static const struct mtk_clk_desc venc_desc = { > + .clks = venc_clks, > + .num_clks = ARRAY_SIZE(venc_clks), > +}; > + > +static const struct mtk_clk_desc venc_core1_desc = { > + .clks = venc_core1_clks, > + .num_clks = ARRAY_SIZE(venc_core1_clks), > +}; > + > +static const struct of_device_id of_match_clk_mt8195_venc[] = { > + { > + .compatible = "mediatek,mt8195-vencsys", > + .data = &venc_desc, > + }, { > + .compatible = "mediatek,mt8195-vencsys_core1", > + .data = &venc_core1_desc, > + }, { > + /* sentinel */ > + } > +}; > + > +static struct platform_driver clk_mt8195_venc_drv = { > + .probe = mtk_clk_simple_probe, > + .driver = { > + .name = "clk-mt8195-venc", > + .of_match_table = of_match_clk_mt8195_venc, > + }, > +}; > + > +builtin_platform_driver(clk_mt8195_venc_drv); > -- > 2.18.0 > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A60BDC07E9B for ; Fri, 9 Jul 2021 10:26:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AB7861248 for ; Fri, 9 Jul 2021 10:26:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AB7861248 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FVV9Ysk7hyvUTA32LqMl6Sdli9MmSNB6hXF7L+qv+zg=; b=Gk9MNi4LRVF69r KRqxRnAKaKN6YLArFJ/8Gyq7No0uoTn5MuTiJl9Yn/0xAjPjV2pgqLJzLrOf/iAensBQYNgKa1C4I ZIS1tFtbkLUqoKuvGlhbDLEWJy4FDoQaawkPupjBNFNeRSg0CeA4xe3DdREmf66vCF3SYCSkiVidz zNBpLeEknNEHAbULWALWM+cGv544OPW7Rw5VW1j2i5Ct761eFcJyPMnr+g16f4x4cEJukl4usYvQ5 MGD6Ul12E3aQxPQVcN+wqEZjpHh+7Ix4LQPQj2NWFVy8IgmmSIpns9NWpMA5VUwp9CSZdeO9I4cib rNgb5CDdhAmuN4d3sd+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1ni8-001VD0-9M; Fri, 09 Jul 2021 10:26:20 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1ni4-001VBt-Tw for linux-mediatek@lists.infradead.org; Fri, 09 Jul 2021 10:26:18 +0000 Received: by mail-lf1-x136.google.com with SMTP id t17so22418527lfq.0 for ; Fri, 09 Jul 2021 03:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AiaAvA+vLz3FtrBULzF8WYojeUlJAsTsVtqvKG72rx8=; b=n6i8wmahbKpTtiTt0jZRJpTElaUmS8kvMSaaMepN4+Z4nT1EWnUVTcrFySgZVpkyEv 7WnelJAP3/nh8X1jVzN6ZI74Jo63Z3tjeLfj0gUuC1ngOQEQJvLLHjhKKjCggLbtlmNN wUjHJCZTwSVD0YxS2JqHVQkuEUSKGN6hGZUxE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AiaAvA+vLz3FtrBULzF8WYojeUlJAsTsVtqvKG72rx8=; b=FSCgv5SgunEe0tqW+CTIBONiUalEJGYFvTWSWaj40v4Le4vWB5cpjlyBVgwuINnnkI s6qZ89z88qCGAWPkTFIj/pKiEKhjHYpEYSW5AKdnDet1ID8mBUESliKKD+zXc1VFvy9V 3r2NbWh6Dxd4+1gTodLQc/9VXLJZ5fPEFeGT/o6K90vgjZ6Pgz/hyKzcL8XDCuBYRMex OWfpO9rsVKicJ6wiQKaKFO1NB5FqKnciv4CzvIFSJHhc5wFed8jc23LoFgw655geELDK uL+3rKqY+LVzNkcj7W4eXk+KmPtciNupfvhJ9/f6Ub/b9gGIas4nZGMjD1/jg20MJcsb /ixg== X-Gm-Message-State: AOAM531Z+ws3wYOMjWx3diwYjro4+tEgA8l9CI4heE+BMl7TYkdK+Je7 bClPZtsm13V+V99u0Z9AQ8UkugB504nwy33gZVLqCw== X-Google-Smtp-Source: ABdhPJyTbIWxzkC7SuGEvymnm5fWso+1YwVVNumQfR2/BL/A4l+vH4cT2fmxdtPEjDSgvQYB1IhmFTLBsrM2cgSPZoU= X-Received: by 2002:a05:6512:39cb:: with SMTP id k11mr3933643lfu.587.1625826374731; Fri, 09 Jul 2021 03:26:14 -0700 (PDT) MIME-Version: 1.0 References: <20210616224743.5109-1-chun-jie.chen@mediatek.com> <20210616224743.5109-18-chun-jie.chen@mediatek.com> In-Reply-To: <20210616224743.5109-18-chun-jie.chen@mediatek.com> From: Chen-Yu Tsai Date: Fri, 9 Jul 2021 18:26:03 +0800 Message-ID: Subject: Re: [PATCH 17/22] clk: mediatek: Add MT8195 vencsys clock support To: Chun-Jie Chen Cc: Matthias Brugger , Stephen Boyd , Nicolas Boichat , Rob Herring , linux-arm-kernel@lists.infradead.org, LKML , linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, srv_heupstream@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210709_032617_030633_AAA5ED9B X-CRM114-Status: GOOD ( 25.29 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Jun 17, 2021 at 7:10 AM Chun-Jie Chen wrote: > > Add MT8195 vencsys clock providers > > Signed-off-by: Chun-Jie Chen > --- > drivers/clk/mediatek/Kconfig | 6 +++ > drivers/clk/mediatek/Makefile | 1 + > drivers/clk/mediatek/clk-mt8195-venc.c | 71 ++++++++++++++++++++++++++ > 3 files changed, 78 insertions(+) > create mode 100644 drivers/clk/mediatek/clk-mt8195-venc.c > > diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig > index 1e89c68f6c6c..3352686d98cf 100644 > --- a/drivers/clk/mediatek/Kconfig > +++ b/drivers/clk/mediatek/Kconfig > @@ -660,6 +660,12 @@ config COMMON_CLK_MT8195_VDOSYS1 > help > This driver supports MediaTek MT8195 vdosys1 clocks. > > +config COMMON_CLK_MT8195_VENCSYS > + bool "Clock driver for MediaTek MT8195 vencsys" > + depends on COMMON_CLK_MT8195 > + help > + This driver supports MediaTek MT8195 vencsys clocks. > + > config COMMON_CLK_MT8516 > bool "Clock driver for MediaTek MT8516" > depends on ARCH_MEDIATEK || COMPILE_TEST > diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile > index 76c0fa837cb0..76a6b404e34b 100644 > --- a/drivers/clk/mediatek/Makefile > +++ b/drivers/clk/mediatek/Makefile > @@ -93,5 +93,6 @@ obj-$(CONFIG_COMMON_CLK_MT8195_NNASYS) += clk-mt8195-nna.o > obj-$(CONFIG_COMMON_CLK_MT8195_VDECSYS) += clk-mt8195-vdec.o > obj-$(CONFIG_COMMON_CLK_MT8195_VDOSYS0) += clk-mt8195-vdo0.o > obj-$(CONFIG_COMMON_CLK_MT8195_VDOSYS1) += clk-mt8195-vdo1.o > +obj-$(CONFIG_COMMON_CLK_MT8195_VENCSYS) += clk-mt8195-venc.o > obj-$(CONFIG_COMMON_CLK_MT8516) += clk-mt8516.o > obj-$(CONFIG_COMMON_CLK_MT8516_AUDSYS) += clk-mt8516-aud.o > diff --git a/drivers/clk/mediatek/clk-mt8195-venc.c b/drivers/clk/mediatek/clk-mt8195-venc.c > new file mode 100644 > index 000000000000..410ca69d5759 > --- /dev/null > +++ b/drivers/clk/mediatek/clk-mt8195-venc.c > @@ -0,0 +1,71 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +// > +// Copyright (c) 2021 MediaTek Inc. > +// Author: Chun-Jie Chen > + > +#include > +#include > + > +#include "clk-mtk.h" > +#include "clk-gate.h" > + > +#include > + > +static const struct mtk_gate_regs venc_cg_regs = { > + .set_ofs = 0x4, > + .clr_ofs = 0x8, > + .sta_ofs = 0x0, > +}; > + > +#define GATE_VENC(_id, _name, _parent, _shift) \ > + GATE_MTK(_id, _name, _parent, &venc_cg_regs, _shift, &mtk_clk_gate_ops_setclr_inv) > + > +static const struct mtk_gate venc_clks[] = { > + GATE_VENC(CLK_VENC_LARB, "venc_larb", "venc_sel", 0), > + GATE_VENC(CLK_VENC_VENC, "venc_venc", "venc_sel", 4), > + GATE_VENC(CLK_VENC_JPGENC, "venc_jpgenc", "venc_sel", 8), > + GATE_VENC(CLK_VENC_JPGDEC, "venc_jpgdec", "venc_sel", 12), > + GATE_VENC(CLK_VENC_JPGDEC_C1, "venc_jpgdec_c1", "venc_sel", 16), > + GATE_VENC(CLK_VENC_GALS, "venc_gals", "venc_sel", 28), > +}; > + > +static const struct mtk_gate venc_core1_clks[] = { > + GATE_VENC(CLK_VENC_CORE1_LARB, "venc_core1_larb", "venc_sel", 0), > + GATE_VENC(CLK_VENC_CORE1_VENC, "venc_core1_venc", "venc_sel", 4), > + GATE_VENC(CLK_VENC_CORE1_JPGENC, "venc_core1_jpgenc", "venc_sel", 8), > + GATE_VENC(CLK_VENC_CORE1_JPGDEC, "venc_core1_jpgdec", "venc_sel", 12), > + GATE_VENC(CLK_VENC_CORE1_JPGDEC_C1, "venc_core1_jpgdec_c1", "venc_sel", 16), > + GATE_VENC(CLK_VENC_CORE1_GALS, "venc_core1_gals", "venc_sel", 28), > +}; So I'm not sure why there are two sets of clocks for each endpoint. Since this hardware block is not documented in the datasheet, maybe you could provide some explanation? What I'm wondering is if the first set is actually some clock gate for bus access and the second set is the main module clock that drives the internal logic. The general comments from the other patches apply as well. ChenYu > + > +static const struct mtk_clk_desc venc_desc = { > + .clks = venc_clks, > + .num_clks = ARRAY_SIZE(venc_clks), > +}; > + > +static const struct mtk_clk_desc venc_core1_desc = { > + .clks = venc_core1_clks, > + .num_clks = ARRAY_SIZE(venc_core1_clks), > +}; > + > +static const struct of_device_id of_match_clk_mt8195_venc[] = { > + { > + .compatible = "mediatek,mt8195-vencsys", > + .data = &venc_desc, > + }, { > + .compatible = "mediatek,mt8195-vencsys_core1", > + .data = &venc_core1_desc, > + }, { > + /* sentinel */ > + } > +}; > + > +static struct platform_driver clk_mt8195_venc_drv = { > + .probe = mtk_clk_simple_probe, > + .driver = { > + .name = "clk-mt8195-venc", > + .of_match_table = of_match_clk_mt8195_venc, > + }, > +}; > + > +builtin_platform_driver(clk_mt8195_venc_drv); > -- > 2.18.0 > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1A68C07E99 for ; Fri, 9 Jul 2021 10:27:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8374D613C9 for ; Fri, 9 Jul 2021 10:27:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8374D613C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zkaQUK8ns1EBGgEtV04rBVhYiqaOQFBjXjZr822Qh+c=; b=Whg+7ul4Vq0ZXt nK4qBZ4Kh0LYK2EKhFwJqlGyM9GobnXxfMPBzdEQGterT5yUD50bi2HuNtCYm+L8h3t34/p+0JSQJ U9NsvyLJW3XwG9kgkDHZ+p1vxHpOocgF7KfyY45Rfyy6PGDOznGWgovsfYyDD7j+Zs3af7BHpTE4C wGbMgx8UUNJ/vhFkQBQhvx/LBLRqd87C9Z5gg50li8KLpDyC1Hxfyz3DAF6saLvvDApojzF8Kv2nq CBJiSHMtbXWfoplCN3ZkbSWFz/F7ZGOgPPQhNduAZvZmEc9pboTMF3aomCtrYR8PDhDr5ha+3UzXO BB53vSwO17ubrbS7ovNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1niA-001VDF-SW; Fri, 09 Jul 2021 10:26:23 +0000 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1ni4-001VBs-Ty for linux-arm-kernel@lists.infradead.org; Fri, 09 Jul 2021 10:26:18 +0000 Received: by mail-lf1-x133.google.com with SMTP id p16so22419865lfc.5 for ; Fri, 09 Jul 2021 03:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AiaAvA+vLz3FtrBULzF8WYojeUlJAsTsVtqvKG72rx8=; b=n6i8wmahbKpTtiTt0jZRJpTElaUmS8kvMSaaMepN4+Z4nT1EWnUVTcrFySgZVpkyEv 7WnelJAP3/nh8X1jVzN6ZI74Jo63Z3tjeLfj0gUuC1ngOQEQJvLLHjhKKjCggLbtlmNN wUjHJCZTwSVD0YxS2JqHVQkuEUSKGN6hGZUxE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AiaAvA+vLz3FtrBULzF8WYojeUlJAsTsVtqvKG72rx8=; b=cXVo2iBW0FDCXgdhiTKnLkqcbPMfv2L+a9L4oyHr7e63TOtE9rgRzgzpnfZYS5AADt ros4bMoUAhFfPKRqOpYjgAZlTxvAwGBgsnXQhqR0bCYsrm+O21m1Xa9aV+a0NE2WDPVP Wmans/9Jtiij7GmcsJxY69xJAC8j3DaYaPfNOjDxqkO0Ege7OjfPazqGAJeYTO9G/fnz MPGSXp91LPjEmbWJ5RS8CXFu6DFozb6pZHsRA95/J+EKDWaBv/GRrgxK2roAcOK81xUi EF5sUq1QrORhe2tZuyp82N5mI+9E5gSoU2M+/Ufh6dDb01Pd70QBWHwz+3awKrEcVHZz WhEA== X-Gm-Message-State: AOAM532734rQO8UqJZSv8xQVSAmIKElBGWFgCpxpF0m0GsXyC2i7tR4c a7X9YdWS93yNxK4M7tVMZtgtdSvYeYoOnBSvilzzaw== X-Google-Smtp-Source: ABdhPJyTbIWxzkC7SuGEvymnm5fWso+1YwVVNumQfR2/BL/A4l+vH4cT2fmxdtPEjDSgvQYB1IhmFTLBsrM2cgSPZoU= X-Received: by 2002:a05:6512:39cb:: with SMTP id k11mr3933643lfu.587.1625826374731; Fri, 09 Jul 2021 03:26:14 -0700 (PDT) MIME-Version: 1.0 References: <20210616224743.5109-1-chun-jie.chen@mediatek.com> <20210616224743.5109-18-chun-jie.chen@mediatek.com> In-Reply-To: <20210616224743.5109-18-chun-jie.chen@mediatek.com> From: Chen-Yu Tsai Date: Fri, 9 Jul 2021 18:26:03 +0800 Message-ID: Subject: Re: [PATCH 17/22] clk: mediatek: Add MT8195 vencsys clock support To: Chun-Jie Chen Cc: Matthias Brugger , Stephen Boyd , Nicolas Boichat , Rob Herring , linux-arm-kernel@lists.infradead.org, LKML , linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, srv_heupstream@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210709_032617_032165_CF65C8DF X-CRM114-Status: GOOD ( 26.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 17, 2021 at 7:10 AM Chun-Jie Chen wrote: > > Add MT8195 vencsys clock providers > > Signed-off-by: Chun-Jie Chen > --- > drivers/clk/mediatek/Kconfig | 6 +++ > drivers/clk/mediatek/Makefile | 1 + > drivers/clk/mediatek/clk-mt8195-venc.c | 71 ++++++++++++++++++++++++++ > 3 files changed, 78 insertions(+) > create mode 100644 drivers/clk/mediatek/clk-mt8195-venc.c > > diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig > index 1e89c68f6c6c..3352686d98cf 100644 > --- a/drivers/clk/mediatek/Kconfig > +++ b/drivers/clk/mediatek/Kconfig > @@ -660,6 +660,12 @@ config COMMON_CLK_MT8195_VDOSYS1 > help > This driver supports MediaTek MT8195 vdosys1 clocks. > > +config COMMON_CLK_MT8195_VENCSYS > + bool "Clock driver for MediaTek MT8195 vencsys" > + depends on COMMON_CLK_MT8195 > + help > + This driver supports MediaTek MT8195 vencsys clocks. > + > config COMMON_CLK_MT8516 > bool "Clock driver for MediaTek MT8516" > depends on ARCH_MEDIATEK || COMPILE_TEST > diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile > index 76c0fa837cb0..76a6b404e34b 100644 > --- a/drivers/clk/mediatek/Makefile > +++ b/drivers/clk/mediatek/Makefile > @@ -93,5 +93,6 @@ obj-$(CONFIG_COMMON_CLK_MT8195_NNASYS) += clk-mt8195-nna.o > obj-$(CONFIG_COMMON_CLK_MT8195_VDECSYS) += clk-mt8195-vdec.o > obj-$(CONFIG_COMMON_CLK_MT8195_VDOSYS0) += clk-mt8195-vdo0.o > obj-$(CONFIG_COMMON_CLK_MT8195_VDOSYS1) += clk-mt8195-vdo1.o > +obj-$(CONFIG_COMMON_CLK_MT8195_VENCSYS) += clk-mt8195-venc.o > obj-$(CONFIG_COMMON_CLK_MT8516) += clk-mt8516.o > obj-$(CONFIG_COMMON_CLK_MT8516_AUDSYS) += clk-mt8516-aud.o > diff --git a/drivers/clk/mediatek/clk-mt8195-venc.c b/drivers/clk/mediatek/clk-mt8195-venc.c > new file mode 100644 > index 000000000000..410ca69d5759 > --- /dev/null > +++ b/drivers/clk/mediatek/clk-mt8195-venc.c > @@ -0,0 +1,71 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +// > +// Copyright (c) 2021 MediaTek Inc. > +// Author: Chun-Jie Chen > + > +#include > +#include > + > +#include "clk-mtk.h" > +#include "clk-gate.h" > + > +#include > + > +static const struct mtk_gate_regs venc_cg_regs = { > + .set_ofs = 0x4, > + .clr_ofs = 0x8, > + .sta_ofs = 0x0, > +}; > + > +#define GATE_VENC(_id, _name, _parent, _shift) \ > + GATE_MTK(_id, _name, _parent, &venc_cg_regs, _shift, &mtk_clk_gate_ops_setclr_inv) > + > +static const struct mtk_gate venc_clks[] = { > + GATE_VENC(CLK_VENC_LARB, "venc_larb", "venc_sel", 0), > + GATE_VENC(CLK_VENC_VENC, "venc_venc", "venc_sel", 4), > + GATE_VENC(CLK_VENC_JPGENC, "venc_jpgenc", "venc_sel", 8), > + GATE_VENC(CLK_VENC_JPGDEC, "venc_jpgdec", "venc_sel", 12), > + GATE_VENC(CLK_VENC_JPGDEC_C1, "venc_jpgdec_c1", "venc_sel", 16), > + GATE_VENC(CLK_VENC_GALS, "venc_gals", "venc_sel", 28), > +}; > + > +static const struct mtk_gate venc_core1_clks[] = { > + GATE_VENC(CLK_VENC_CORE1_LARB, "venc_core1_larb", "venc_sel", 0), > + GATE_VENC(CLK_VENC_CORE1_VENC, "venc_core1_venc", "venc_sel", 4), > + GATE_VENC(CLK_VENC_CORE1_JPGENC, "venc_core1_jpgenc", "venc_sel", 8), > + GATE_VENC(CLK_VENC_CORE1_JPGDEC, "venc_core1_jpgdec", "venc_sel", 12), > + GATE_VENC(CLK_VENC_CORE1_JPGDEC_C1, "venc_core1_jpgdec_c1", "venc_sel", 16), > + GATE_VENC(CLK_VENC_CORE1_GALS, "venc_core1_gals", "venc_sel", 28), > +}; So I'm not sure why there are two sets of clocks for each endpoint. Since this hardware block is not documented in the datasheet, maybe you could provide some explanation? What I'm wondering is if the first set is actually some clock gate for bus access and the second set is the main module clock that drives the internal logic. The general comments from the other patches apply as well. ChenYu > + > +static const struct mtk_clk_desc venc_desc = { > + .clks = venc_clks, > + .num_clks = ARRAY_SIZE(venc_clks), > +}; > + > +static const struct mtk_clk_desc venc_core1_desc = { > + .clks = venc_core1_clks, > + .num_clks = ARRAY_SIZE(venc_core1_clks), > +}; > + > +static const struct of_device_id of_match_clk_mt8195_venc[] = { > + { > + .compatible = "mediatek,mt8195-vencsys", > + .data = &venc_desc, > + }, { > + .compatible = "mediatek,mt8195-vencsys_core1", > + .data = &venc_core1_desc, > + }, { > + /* sentinel */ > + } > +}; > + > +static struct platform_driver clk_mt8195_venc_drv = { > + .probe = mtk_clk_simple_probe, > + .driver = { > + .name = "clk-mt8195-venc", > + .of_match_table = of_match_clk_mt8195_venc, > + }, > +}; > + > +builtin_platform_driver(clk_mt8195_venc_drv); > -- > 2.18.0 > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel