From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2EA9C4332F for ; Fri, 30 Dec 2022 04:38:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234394AbiL3EiD (ORCPT ); Thu, 29 Dec 2022 23:38:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230355AbiL3Eh6 (ORCPT ); Thu, 29 Dec 2022 23:37:58 -0500 Received: from mail-vs1-xe35.google.com (mail-vs1-xe35.google.com [IPv6:2607:f8b0:4864:20::e35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0027113D4F for ; Thu, 29 Dec 2022 20:37:56 -0800 (PST) Received: by mail-vs1-xe35.google.com with SMTP id p30so14705353vsr.1 for ; Thu, 29 Dec 2022 20:37:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7MgAHjBPKfpctKgGxDc5Wt5hmeOw7QmtnTPav7sw6ms=; b=QLFUHtQDyMevODPY+6iYPWURMALSujLCXV8b2YtZFnflNTjUZu8E6WZS/gi7HObib7 XHV93RbVPjaVZoFtXYE7ijrHqLzDm/9d7Xl9G2eHRLBzkcc86PsLUFbc2zeAlOOLf/Mn O0pkySdK91uRj3DnAWAL6TN0Yzn+ATUn/+pAs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7MgAHjBPKfpctKgGxDc5Wt5hmeOw7QmtnTPav7sw6ms=; b=uPqbW3/A1l0qHBuVNjnfHfUavcQcst/sVLiazj150w+H0g1/ux3zl1k3/Fgzgyz3vk MuZuYmuHoNPeIeMDjBLnPZVWwiN8pAK0pSBr+Eyy+Sbnp3kDE0tjgaB+E0h2nPyu+tei nwt756AkeEh1CfpiqQaGPz9Uu9nHmbGE6WC4LHa15YUhqYdMOqoIjR4lx4gPt+o1lLLN 9JVVnAj/zmFOAEO0+xKOAjnkh9qcNb8OIzGLIL+RGqOadD+LfFixpINHGOXaCA4sVmKZ F4SuZZcEd55JKJWKrtfO8APRE2eFTwgBw7m6oGxMfMU/S/FLaxVkW4W3iT752Tl4sDYA +bRg== X-Gm-Message-State: AFqh2kpI2lRA66WB22k/qf3rpVuIGnyH4Ms/70C75267mG8jnwy76Qj/ S9TaZAqeXBvYlTsRsjqoNRWFonlhHjs2lGnCFop+Og== X-Google-Smtp-Source: AMrXdXtJ9DsOgWpo3oq9cdZhqPVc/WxniGJ0388vj8r1Kf4g7Nx5veR8u/GCEefKItg3gDeGWLA9nGN5uLG06h408kk= X-Received: by 2002:a05:6102:3e06:b0:3b5:fd8:7948 with SMTP id j6-20020a0561023e0600b003b50fd87948mr3951754vsv.85.1672375075819; Thu, 29 Dec 2022 20:37:55 -0800 (PST) MIME-Version: 1.0 References: <20221223094259.87373-1-angelogioacchino.delregno@collabora.com> <20221223094259.87373-6-angelogioacchino.delregno@collabora.com> In-Reply-To: <20221223094259.87373-6-angelogioacchino.delregno@collabora.com> From: Chen-Yu Tsai Date: Fri, 30 Dec 2022 12:37:44 +0800 Message-ID: Subject: Re: [PATCH v2 05/23] clk: mediatek: clk-mtk: Propagate struct device for composites To: AngeloGioacchino Del Regno Cc: mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johnson.wang@mediatek.com, miles.chen@mediatek.com, fparent@baylibre.com, chun-jie.chen@mediatek.com, sam.shih@mediatek.com, y.oudjana@protonmail.com, nfraprado@collabora.com, rex-bc.chen@mediatek.com, ryder.lee@kernel.org, daniel@makrotopia.org, jose.exposito89@gmail.com, yangyingliang@huawei.com, pablo.sun@mediatek.com, msp@baylibre.com, weiyi.lu@mediatek.com, ikjn@chromium.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 23, 2022 at 5:43 PM AngeloGioacchino Del Regno wrote: > > Like done for cpumux clocks, propagate struct device for composite > clocks registered through clk-mtk helpers to be able to get runtime > pm support for MTK clocks. > > Signed-off-by: AngeloGioacchino Del Regno Same comment as the previous patches, could we move struct device to the first parameter? Otherwise this looks good to me. ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16E37C4332F for ; Fri, 30 Dec 2022 04:39:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jzmaYnAWYSFdFA0bP5xKsusdQHFdngLqEK+1jxTR1iQ=; b=LotwzWNaNVbqRY cq6I/7oYo47ThR2W5K137eFx4UVve84E/4DCYoztCV2no0+/0uqKurmmZZKJI4lLYNOsZ77kgu/Je 39H8fogTl2k4ohvIHlLpzqUq1TUgJzE3FPwwqtAJC2TGXWHvpPqs+331IsmwrRl5jNDBAy2RvotI6 MFtyr90M5EvIpKT0K9O6N2O/Gtrh0uifR5S5pzVIiGb30GttgM0uysBsB4Og4eIPj6JjJHi4bA1Lt qRWIjzaWVN5Z5Jrbuu3H+oTsy3PPXw3nLqydgrKt77/iDbDK4iVPam+npOCBFMCwXg63zJI7aUH3V hUd3SmszEtk7ojAVwFAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pB79f-005XnA-EI; Fri, 30 Dec 2022 04:38:03 +0000 Received: from mail-vs1-xe34.google.com ([2607:f8b0:4864:20::e34]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pB79b-005Xjg-2U for linux-arm-kernel@lists.infradead.org; Fri, 30 Dec 2022 04:38:00 +0000 Received: by mail-vs1-xe34.google.com with SMTP id a64so16826007vsc.2 for ; Thu, 29 Dec 2022 20:37:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7MgAHjBPKfpctKgGxDc5Wt5hmeOw7QmtnTPav7sw6ms=; b=QLFUHtQDyMevODPY+6iYPWURMALSujLCXV8b2YtZFnflNTjUZu8E6WZS/gi7HObib7 XHV93RbVPjaVZoFtXYE7ijrHqLzDm/9d7Xl9G2eHRLBzkcc86PsLUFbc2zeAlOOLf/Mn O0pkySdK91uRj3DnAWAL6TN0Yzn+ATUn/+pAs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7MgAHjBPKfpctKgGxDc5Wt5hmeOw7QmtnTPav7sw6ms=; b=d7AJblJOnHpDMzHgnCdL623Fn6v3Bh7VK6DZsp6sH8V4zB4DYPpm4IrXCjUxdngHyz SnVcWKhEJz3SKehNYxrK868jFu3rrUrvJ/tlKZTgQzemIrSVGjG4gzbChhs1oNQ60KB1 I3T5yhAuRQrUujUyb0Fq+NCpMpnNDRhtFiNlY8aHjmv8VPti3xI0la/4vXYwpeBPuhMZ rBQHKZJV/eSq1q+qkc0KmLuyJLzsiIat0SVlVD7OcPuyeZtC90E33LnF2HMHTT0tbsG/ zh6GOnZkUkXK1zPDOdjovUWehPYeCGvjHARpty3YAVK4qXfCyGsVl/2K/J0wWbI+C/me SQsw== X-Gm-Message-State: AFqh2koP43MGU9OwtfW9gycX/hFnTo6vbncBx3ITiM15WRW7R0ahygtM yjv4LdcPnwugNLgKF68LE6cApVnCtqsvN6d75fqE5w== X-Google-Smtp-Source: AMrXdXtJ9DsOgWpo3oq9cdZhqPVc/WxniGJ0388vj8r1Kf4g7Nx5veR8u/GCEefKItg3gDeGWLA9nGN5uLG06h408kk= X-Received: by 2002:a05:6102:3e06:b0:3b5:fd8:7948 with SMTP id j6-20020a0561023e0600b003b50fd87948mr3951754vsv.85.1672375075819; Thu, 29 Dec 2022 20:37:55 -0800 (PST) MIME-Version: 1.0 References: <20221223094259.87373-1-angelogioacchino.delregno@collabora.com> <20221223094259.87373-6-angelogioacchino.delregno@collabora.com> In-Reply-To: <20221223094259.87373-6-angelogioacchino.delregno@collabora.com> From: Chen-Yu Tsai Date: Fri, 30 Dec 2022 12:37:44 +0800 Message-ID: Subject: Re: [PATCH v2 05/23] clk: mediatek: clk-mtk: Propagate struct device for composites To: AngeloGioacchino Del Regno Cc: mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johnson.wang@mediatek.com, miles.chen@mediatek.com, fparent@baylibre.com, chun-jie.chen@mediatek.com, sam.shih@mediatek.com, y.oudjana@protonmail.com, nfraprado@collabora.com, rex-bc.chen@mediatek.com, ryder.lee@kernel.org, daniel@makrotopia.org, jose.exposito89@gmail.com, yangyingliang@huawei.com, pablo.sun@mediatek.com, msp@baylibre.com, weiyi.lu@mediatek.com, ikjn@chromium.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221229_203759_136899_D9DC508E X-CRM114-Status: UNSURE ( 8.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 23, 2022 at 5:43 PM AngeloGioacchino Del Regno wrote: > > Like done for cpumux clocks, propagate struct device for composite > clocks registered through clk-mtk helpers to be able to get runtime > pm support for MTK clocks. > > Signed-off-by: AngeloGioacchino Del Regno Same comment as the previous patches, could we move struct device to the first parameter? Otherwise this looks good to me. ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel