From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F1C7C4167B for ; Fri, 30 Dec 2022 08:13:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234524AbiL3IM7 (ORCPT ); Fri, 30 Dec 2022 03:12:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbiL3IM5 (ORCPT ); Fri, 30 Dec 2022 03:12:57 -0500 Received: from mail-vs1-xe35.google.com (mail-vs1-xe35.google.com [IPv6:2607:f8b0:4864:20::e35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42FDE192B5 for ; Fri, 30 Dec 2022 00:12:56 -0800 (PST) Received: by mail-vs1-xe35.google.com with SMTP id 3so20605720vsq.7 for ; Fri, 30 Dec 2022 00:12:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ovjF9LP8AGSgXaaf5365MzNw6zGtX3G+dhQI2d2MZj0=; b=aMTf6useIPW5ahkjqv6bsmW6ZzSOKFmJYGo1CjnRcdKkeryXRbZbItOjrvSg14iDos 9TEuP+z48lFXwYWYeXsvOUAl4v5p8GORFfq/vefBEXkVLm8yssJ2zXlS6SnDnXUFX+Re oU77MB/+WyaZj7GOn7rFf7dg0x0Mu7uOV/+QY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ovjF9LP8AGSgXaaf5365MzNw6zGtX3G+dhQI2d2MZj0=; b=rjWuImyb1BRNsMEHD9h6Rh/tR+8n0IV11gtNwGZLqMwK4lsJpChTenOCia2k6P6YS3 bIxFk/5vybRbdpRIm8pLdVuh/ZRgvjN+R+j4shEUuulJVTV++Ls1PoLmlUsPIRR1jucZ jXMvIE+UNTfJQJuTIi8h3/80t2BHmQhr4l/nbWf72ZKcJY05yrdMFpdDaBLuFAnXYq/b qjNSEdGNCNhOhJCsQ12actniiquklL4jaM88vpGMS/jEiDyT9eXFPbZr/HG7IP6BeI1B mv2A50TH6tCluh8oVWb1G6+X2Ah7c3SXcwpAnFR2A7hhLWc+SZVoJE9MPW7soEGzcqE4 QWBg== X-Gm-Message-State: AFqh2krK6LjyYXXJ9wymtQvv7Dj6o0idWlo3k3T9QGND8PhPRnjVG0pA ufH8qLJLw1PA9T7INfAp5pryCJVo14K8aOjyWWRMCA== X-Google-Smtp-Source: AMrXdXvj4BRr4R5dsv0zqB2v+B0EHWVqgAJmDHpFhhUkVRCeouysE+BnS2J/faKZK+rkLbAqbDs51urSHbAva+OZeOQ= X-Received: by 2002:a05:6102:3d9f:b0:3c4:4918:80c with SMTP id h31-20020a0561023d9f00b003c44918080cmr2676056vsv.9.1672387975420; Fri, 30 Dec 2022 00:12:55 -0800 (PST) MIME-Version: 1.0 References: <20221223094259.87373-19-angelogioacchino.delregno@collabora.com> <20221229082103.21064-1-miles.chen@mediatek.com> In-Reply-To: <20221229082103.21064-1-miles.chen@mediatek.com> From: Chen-Yu Tsai Date: Fri, 30 Dec 2022 16:12:44 +0800 Message-ID: Subject: Re: [PATCH v2 18/23] clk: mediatek: clk-mtk: Register MFG notifier in mtk_clk_simple_probe() To: Miles Chen Cc: angelogioacchino.delregno@collabora.com, chun-jie.chen@mediatek.com, daniel@makrotopia.org, devicetree@vger.kernel.org, fparent@baylibre.com, ikjn@chromium.org, johnson.wang@mediatek.com, jose.exposito89@gmail.com, kernel@collabora.com, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, msp@baylibre.com, mturquette@baylibre.com, nfraprado@collabora.com, pablo.sun@mediatek.com, rex-bc.chen@mediatek.com, robh+dt@kernel.org, ryder.lee@kernel.org, sam.shih@mediatek.com, sboyd@kernel.org, weiyi.lu@mediatek.com, y.oudjana@protonmail.com, yangyingliang@huawei.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 29, 2022 at 4:21 PM Miles Chen wrote: > > >In preparation for commonizing topckgen probe on various MediaTek SoCs > >clock drivers, add the ability to register the MFG MUX notifier in > >mtk_clk_simple_probe() by passing a custom notifier register function > >pointer, as this function will be slightly different across different > >SoCs. > > > >Signed-off-by: AngeloGioacchino Del Regno > >--- > > drivers/clk/mediatek/clk-mtk.c | 8 ++++++++ > > drivers/clk/mediatek/clk-mtk.h | 3 +++ > > 2 files changed, 11 insertions(+) > > > >diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c > >index b0a6225cd7b2..df6281492fb6 100644 > >--- a/drivers/clk/mediatek/clk-mtk.c > >+++ b/drivers/clk/mediatek/clk-mtk.c > >@@ -533,6 +533,14 @@ int mtk_clk_simple_probe(struct platform_device *pdev) > > goto unregister_composites; > > } > > > >+ if (mcd->clk_notifier_func) { > >+ struct clk *mfg_mux = clk_data->hws[mcd->mfg_clk_idx]->clk; > >+ > >+ r = mcd->clk_notifier_func(&pdev->dev, mfg_mux); > >+ if (r) > >+ goto unregister_clks; > >+ } > > Should we have a IS_ERR_OR_NULL() check for clk_data->hws[mcd->mfg_clk_idx]? With a big warning to signal that something in the driver isn't written correctly, such as no MFG clock actually being included in the driver. ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0407C4167B for ; Fri, 30 Dec 2022 08:18:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=56+IEF7JbHgIgttvmiWoL5K3FpktGM/ZbhQxzukNEeE=; b=BTMXUZlNEDlm5U uhWhQd5bmQ0rWzN14uuqPoYVLEDU7GuMWdH1UwuFoOWS20kfoCn2UTHM7PDjJb1e5HXXC8fOviXWb OAE4KFy3iVPekQoWweezjEg94rfI1g3jhlce42+GD2ktnxWIpyDJi86QynDV1YuNEH05dSvT90D4+ iounkSU0E1D7qWaHExldGL8B0SlEbRUYxBU6L8Eqt/4+lgQxeK8um0ZWosjlY7RJobbQh7G68nFX2 C61n2+0R80ykWbl+J29eDbXX+uLIMwf/KUJGV7m9pGUTDZ8MfX4h1qUMusPODltwPeY8pjUTm0MQ5 KvAG/RWl2Ylz9SNNcu/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBAZb-007D1P-MO; Fri, 30 Dec 2022 08:17:06 +0000 Received: from mail-vs1-xe2e.google.com ([2607:f8b0:4864:20::e2e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBAVc-007B9V-DQ for linux-arm-kernel@lists.infradead.org; Fri, 30 Dec 2022 08:12:58 +0000 Received: by mail-vs1-xe2e.google.com with SMTP id 128so20595515vsz.12 for ; Fri, 30 Dec 2022 00:12:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ovjF9LP8AGSgXaaf5365MzNw6zGtX3G+dhQI2d2MZj0=; b=aMTf6useIPW5ahkjqv6bsmW6ZzSOKFmJYGo1CjnRcdKkeryXRbZbItOjrvSg14iDos 9TEuP+z48lFXwYWYeXsvOUAl4v5p8GORFfq/vefBEXkVLm8yssJ2zXlS6SnDnXUFX+Re oU77MB/+WyaZj7GOn7rFf7dg0x0Mu7uOV/+QY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ovjF9LP8AGSgXaaf5365MzNw6zGtX3G+dhQI2d2MZj0=; b=LY1l2/TK+fIB+Psyy5JefblPBHyeqULhjLUAUk69+WdarGJMYb3pMqZltDx7AJ8Kig dggPqQ4h7j0ZyEq7JwgxPunzqOLuYDDpMCpJ7b3MivC+R1WqluGEZojsM8xPrF0NFhWO NbtjOG38uvQSr0S3hND6CUEs9oFck2SQx/k1Pzdh3HTnkR3HZNON6H3dEHTeFDPS/SQA OXr+7y79pd7TdpzPflpUDUWoD54yeVoNpd25uqS5YM1OQk/p9z5cJ62jnFoRjreSi4Q4 GVaRGIMKJ3zVKAtm3L1BDAsEeexHB9tx6POJ/0Sc03PCfRePuxlfM5Nk2zayfM72vD3l 4fDA== X-Gm-Message-State: AFqh2koRtggZh1Vhq4RHE9t8QHC9cdRqausbj2GA9RqfLQ0Wr7UfDmzy v9CIz7bMuR7MrOcKZjQZwSRKgiSqCcFkl2VMuraSmw== X-Google-Smtp-Source: AMrXdXvj4BRr4R5dsv0zqB2v+B0EHWVqgAJmDHpFhhUkVRCeouysE+BnS2J/faKZK+rkLbAqbDs51urSHbAva+OZeOQ= X-Received: by 2002:a05:6102:3d9f:b0:3c4:4918:80c with SMTP id h31-20020a0561023d9f00b003c44918080cmr2676056vsv.9.1672387975420; Fri, 30 Dec 2022 00:12:55 -0800 (PST) MIME-Version: 1.0 References: <20221223094259.87373-19-angelogioacchino.delregno@collabora.com> <20221229082103.21064-1-miles.chen@mediatek.com> In-Reply-To: <20221229082103.21064-1-miles.chen@mediatek.com> From: Chen-Yu Tsai Date: Fri, 30 Dec 2022 16:12:44 +0800 Message-ID: Subject: Re: [PATCH v2 18/23] clk: mediatek: clk-mtk: Register MFG notifier in mtk_clk_simple_probe() To: Miles Chen Cc: angelogioacchino.delregno@collabora.com, chun-jie.chen@mediatek.com, daniel@makrotopia.org, devicetree@vger.kernel.org, fparent@baylibre.com, ikjn@chromium.org, johnson.wang@mediatek.com, jose.exposito89@gmail.com, kernel@collabora.com, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, msp@baylibre.com, mturquette@baylibre.com, nfraprado@collabora.com, pablo.sun@mediatek.com, rex-bc.chen@mediatek.com, robh+dt@kernel.org, ryder.lee@kernel.org, sam.shih@mediatek.com, sboyd@kernel.org, weiyi.lu@mediatek.com, y.oudjana@protonmail.com, yangyingliang@huawei.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221230_001256_588837_0EE881EE X-CRM114-Status: GOOD ( 14.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 29, 2022 at 4:21 PM Miles Chen wrote: > > >In preparation for commonizing topckgen probe on various MediaTek SoCs > >clock drivers, add the ability to register the MFG MUX notifier in > >mtk_clk_simple_probe() by passing a custom notifier register function > >pointer, as this function will be slightly different across different > >SoCs. > > > >Signed-off-by: AngeloGioacchino Del Regno > >--- > > drivers/clk/mediatek/clk-mtk.c | 8 ++++++++ > > drivers/clk/mediatek/clk-mtk.h | 3 +++ > > 2 files changed, 11 insertions(+) > > > >diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c > >index b0a6225cd7b2..df6281492fb6 100644 > >--- a/drivers/clk/mediatek/clk-mtk.c > >+++ b/drivers/clk/mediatek/clk-mtk.c > >@@ -533,6 +533,14 @@ int mtk_clk_simple_probe(struct platform_device *pdev) > > goto unregister_composites; > > } > > > >+ if (mcd->clk_notifier_func) { > >+ struct clk *mfg_mux = clk_data->hws[mcd->mfg_clk_idx]->clk; > >+ > >+ r = mcd->clk_notifier_func(&pdev->dev, mfg_mux); > >+ if (r) > >+ goto unregister_clks; > >+ } > > Should we have a IS_ERR_OR_NULL() check for clk_data->hws[mcd->mfg_clk_idx]? With a big warning to signal that something in the driver isn't written correctly, such as no MFG clock actually being included in the driver. ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel