From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C325EC4332F for ; Mon, 26 Dec 2022 07:07:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231674AbiLZHH1 (ORCPT ); Mon, 26 Dec 2022 02:07:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbiLZHHX (ORCPT ); Mon, 26 Dec 2022 02:07:23 -0500 Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D1E72623 for ; Sun, 25 Dec 2022 23:07:22 -0800 (PST) Received: by mail-ua1-x934.google.com with SMTP id c26so2211502uak.5 for ; Sun, 25 Dec 2022 23:07:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Kc7UX5qQFKgxUp5GIPhkGqMn4OUOgloWMZmKzKsecYc=; b=F36ks6qgrclKiSq119LjQgu9DDYLk5CwlQlwTUbhE5kBes/fyuLFzf2adOZlVDDvZH 4pwMnuHAkPHbxR/8o/VFR5Yswpv3I4g9VXlfbDbGA015CZQY333kwSZLDrNcrlzxfxCs oHpmv6xmktdygibJiDmwyOOUKvYzvkDEUmm1k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Kc7UX5qQFKgxUp5GIPhkGqMn4OUOgloWMZmKzKsecYc=; b=RG9ZtRuggrxXfHXV6G9Rd8KIubgsUXcED/AtXZYzhkRd5Ui+wR009J/VxHiHhRWcwz 6Nl2dqRHxNyKDlGb1SdkNVQ+UIA+8N4TWYxm+OkMmmLIg1GhUtR3To2JUrSBkjzEY7Bx CD85qS31UNZV0At9CwGAruBgOUw6ZwVHcqzZJ4aFiJcMRzJOkjXTN6LUrCNX5bbFxAYB EaKKI7MyfVEJg8ctUkLBXOo8Hk3DL8won+21O7Lo5JLUmPjuQqZnX1nnHx5cM9uI9olW +zpHWAdNTXP0DbIeUD8Xdi55mc8QeMuB7/Rx4KMOKhSd8bLUfJtfjcuJ1If/jxKCUCo+ HB7g== X-Gm-Message-State: AFqh2kqzqXuMu4GhsQGHm0HYwZlCfgTy5+k+jlsqSHjheW3HP5a3DEJt XtUqLV0Whtb5N3vvZ4JDf9J+iUgfFu3S63SZmKgjEQ== X-Google-Smtp-Source: AMrXdXv2VqQXGVz7UsmxIS87BTXQNUJ4d3yeAlvbMCKPSnAPa13HYbgf2LvkaebhY9B0OY4hysESqwW4AfdqoejLjw4= X-Received: by 2002:ab0:7411:0:b0:418:b849:8187 with SMTP id r17-20020ab07411000000b00418b8498187mr1585399uap.43.1672038441665; Sun, 25 Dec 2022 23:07:21 -0800 (PST) MIME-Version: 1.0 References: <20221223094259.87373-1-angelogioacchino.delregno@collabora.com> <20221223094259.87373-5-angelogioacchino.delregno@collabora.com> In-Reply-To: <20221223094259.87373-5-angelogioacchino.delregno@collabora.com> From: Chen-Yu Tsai Date: Mon, 26 Dec 2022 15:07:10 +0800 Message-ID: Subject: Re: [PATCH v2 04/23] clk: mediatek: cpumux: Propagate struct device where possible To: AngeloGioacchino Del Regno Cc: mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johnson.wang@mediatek.com, miles.chen@mediatek.com, fparent@baylibre.com, chun-jie.chen@mediatek.com, sam.shih@mediatek.com, y.oudjana@protonmail.com, nfraprado@collabora.com, rex-bc.chen@mediatek.com, ryder.lee@kernel.org, daniel@makrotopia.org, jose.exposito89@gmail.com, yangyingliang@huawei.com, pablo.sun@mediatek.com, msp@baylibre.com, weiyi.lu@mediatek.com, ikjn@chromium.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 23, 2022 at 5:43 PM AngeloGioacchino Del Regno wrote: > > Take a pointer to a struct device in mtk_clk_register_cpumuxes() and > propagate the same to mtk_clk_register_cpumux() => clk_hw_register(). > Even though runtime pm is unlikely to be used with CPU muxes, this > helps with code consistency and possibly opens to commonization of > some mtk_clk_register_(x) functions. > > Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Chen-Yu Tsai As with the gates patch, could we make the |struct device *| parameter the first one? Also for this case I think we could even drop the |struct device_node *| parameter. Regards ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 163E8C4332F for ; Mon, 26 Dec 2022 07:08:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HipEvafCg68+cznShhdTeCRinl86cciWWZgHh3RJP8E=; b=YOYVX9OYXWJyhD f8dQBKci4BYXkMmB1fuGT46uM1BSO0QQIFTkXaPDGHHg7+wHv/slCmPZGcG3dpWSNfSBRGZ5I5P+Y V11aVfktW3fZFrISWxVZMiABrVnegpJL5ZtL9QN3uI6cxJNcUkonTZ/HB3XQh2Xn4uG2JKX/1mlaG mMRVGVl9w+Xd9x37/kYxCLe+7yYtFQYuDykaSjcLgG6vmJnIwJ58pYO+muzkPUzFgkbLcZn8LsM/u cj2Zc8mKWnKiPQMqHYFQeHpK21w1czgVvwU8pDlZQpA4Vg32Pm8JcQcwonfxY0urkxXfASm0+jNfW e36H4NQtdlW1DiuqG+Zw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p9ha3-002Ryg-AK; Mon, 26 Dec 2022 07:07:27 +0000 Received: from mail-ua1-x930.google.com ([2607:f8b0:4864:20::930]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p9hZy-002Rwe-Vh for linux-arm-kernel@lists.infradead.org; Mon, 26 Dec 2022 07:07:24 +0000 Received: by mail-ua1-x930.google.com with SMTP id d1so2210820ual.11 for ; Sun, 25 Dec 2022 23:07:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Kc7UX5qQFKgxUp5GIPhkGqMn4OUOgloWMZmKzKsecYc=; b=F36ks6qgrclKiSq119LjQgu9DDYLk5CwlQlwTUbhE5kBes/fyuLFzf2adOZlVDDvZH 4pwMnuHAkPHbxR/8o/VFR5Yswpv3I4g9VXlfbDbGA015CZQY333kwSZLDrNcrlzxfxCs oHpmv6xmktdygibJiDmwyOOUKvYzvkDEUmm1k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Kc7UX5qQFKgxUp5GIPhkGqMn4OUOgloWMZmKzKsecYc=; b=74AwKR0gQ6r8LwmBgZuxJHrbBkeUfoW21tuxdre4nyN+vaX5vvDRi0yUCE2mKiupOt HQpCnyZUTlKi0K2uPyNlEiJLRTxHH2FwmY6CfjztJT3EMACsJjkUVTS9A5wDYfkdpTxM QTw6rZxXL6ZfzVQjn2MtULRxoYZshUV87HQSg8+TZnKeEjFnKn8Owpj0ASf77ysdDl9J xVJ54fm8H1Pi3844GTomYoUqpGw6X4JNFrB7c157EhmuvBt2gBsP88SLafOuj0QpW2i9 Bc5YtJ98sR9EbLAmjZBBUMJmg0DUPwO9mbNIziDk+xpX6wQWKwfXM2tRkrYF7+RZzTzF CQdA== X-Gm-Message-State: AFqh2kroBekG9o7VQuSuflQphoY2ZPqLWTi0rFbgGgsGXVfC3ngznwTZ ENZIufmeLmX6M2utqlCoIcG6qnLtIDK5GQ8s0VvbLA== X-Google-Smtp-Source: AMrXdXv2VqQXGVz7UsmxIS87BTXQNUJ4d3yeAlvbMCKPSnAPa13HYbgf2LvkaebhY9B0OY4hysESqwW4AfdqoejLjw4= X-Received: by 2002:ab0:7411:0:b0:418:b849:8187 with SMTP id r17-20020ab07411000000b00418b8498187mr1585399uap.43.1672038441665; Sun, 25 Dec 2022 23:07:21 -0800 (PST) MIME-Version: 1.0 References: <20221223094259.87373-1-angelogioacchino.delregno@collabora.com> <20221223094259.87373-5-angelogioacchino.delregno@collabora.com> In-Reply-To: <20221223094259.87373-5-angelogioacchino.delregno@collabora.com> From: Chen-Yu Tsai Date: Mon, 26 Dec 2022 15:07:10 +0800 Message-ID: Subject: Re: [PATCH v2 04/23] clk: mediatek: cpumux: Propagate struct device where possible To: AngeloGioacchino Del Regno Cc: mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johnson.wang@mediatek.com, miles.chen@mediatek.com, fparent@baylibre.com, chun-jie.chen@mediatek.com, sam.shih@mediatek.com, y.oudjana@protonmail.com, nfraprado@collabora.com, rex-bc.chen@mediatek.com, ryder.lee@kernel.org, daniel@makrotopia.org, jose.exposito89@gmail.com, yangyingliang@huawei.com, pablo.sun@mediatek.com, msp@baylibre.com, weiyi.lu@mediatek.com, ikjn@chromium.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221225_230723_095664_0F898FCF X-CRM114-Status: GOOD ( 11.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 23, 2022 at 5:43 PM AngeloGioacchino Del Regno wrote: > > Take a pointer to a struct device in mtk_clk_register_cpumuxes() and > propagate the same to mtk_clk_register_cpumux() => clk_hw_register(). > Even though runtime pm is unlikely to be used with CPU muxes, this > helps with code consistency and possibly opens to commonization of > some mtk_clk_register_(x) functions. > > Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Chen-Yu Tsai As with the gates patch, could we make the |struct device *| parameter the first one? Also for this case I think we could even drop the |struct device_node *| parameter. Regards ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel