From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8ADAC433F5 for ; Wed, 29 Sep 2021 02:28:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBE2460EFF for ; Wed, 29 Sep 2021 02:28:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243786AbhI2C3s (ORCPT ); Tue, 28 Sep 2021 22:29:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243718AbhI2C3j (ORCPT ); Tue, 28 Sep 2021 22:29:39 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C456C061745 for ; Tue, 28 Sep 2021 19:27:59 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id x27so4259652lfa.9 for ; Tue, 28 Sep 2021 19:27:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fJjBCR4+9bCZVm0Fu8Xcmw+g/rqGltdjILLNILMG/mA=; b=gZItg880S7ngvt1ScsVFZbT92Pz35STUpkg7MtmBPG38S8oE0RNWXVxg5AsCJmsiso gjU9EtdpeqLxN8TOF5kWZEb6v6ULSNqjKWay2YeRQCSYzJo2aiENwykZpJGyAuHjhXlY nukor5W0hJzjkNO93yWm4lxshhwfHKxlrCThA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fJjBCR4+9bCZVm0Fu8Xcmw+g/rqGltdjILLNILMG/mA=; b=NdjGx7yg/GI1NgIyrpiLO9wAqfJawAnj3N+TRPYnuxdYF1m2GuB3HWNn7c+6wdtnzR CIJFY4pC1nrUKk7mOgvRid8UOCmolXlhOpWrBL0F162pYF0Y5C3SZAIEac/wvy1Jpevu OFIHA7te7qMsH7CPOXFiT2srJj5qtH3tdrPccge9t9S2VH/qYsjZItCuu96v+83JeCOn AgIT0t/epZsP3hO5NvvfGBBDmf9pNvGDQSkbgn6t7IzSssoWSrtjZpkhBBJlH/e+WkqG 8LhGmmwWVXTE468CBpzlyUQFKC3pBdquI+NVIFg1TFghbqZjqq6tPY5iYilwniy2mNcW rFuA== X-Gm-Message-State: AOAM5317zDPo96nKLE1rr4p35qHgpbWqfTxH/FfrEi5HDLRbBKH1ulfy HpUF8R4om9GSw19It3YkSmUD5lyBYTiCH+iubs0sjA== X-Google-Smtp-Source: ABdhPJxtLJKFI2ooM24bJMRumtCIgTrU9ia9VK2xsan8DKGDUzhXg/ByJkFUAByLAPwnyRDMK4Wt9rw5VOO0jFuGCL8= X-Received: by 2002:ac2:495b:: with SMTP id o27mr8638251lfi.501.1632882477417; Tue, 28 Sep 2021 19:27:57 -0700 (PDT) MIME-Version: 1.0 References: <20210928213552.1001939-1-briannorris@chromium.org> <20210928143413.v3.1.Ic2904d37f30013a7f3d8476203ad3733c186827e@changeid> In-Reply-To: <20210928143413.v3.1.Ic2904d37f30013a7f3d8476203ad3733c186827e@changeid> From: Chen-Yu Tsai Date: Wed, 29 Sep 2021 10:27:46 +0800 Message-ID: Subject: Re: [PATCH v3 1/4] drm/rockchip: dsi: Hold pm-runtime across bind/unbind To: Brian Norris Cc: =?UTF-8?Q?Heiko_St=C3=BCbner?= , LKML , dri-devel , "open list:ARM/Rockchip SoC..." , Sandy Huang , Thomas Hebb , aleksandr.o.makarov@gmail.com, stable@vger.kernel.org, =?UTF-8?B?TsOtY29sYXMgRiAuIFIgLiBBIC4gUHJhZG8=?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 29, 2021 at 5:36 AM Brian Norris wro= te: > > In commit 43c2de1002d2, we moved most HW configuration to bind(), but we > didn't move the runtime PM management. Therefore, depending on initial > boot state, runtime-PM workqueue delays, and other timing factors, we > may disable our power domain in between the hardware configuration > (bind()) and when we enable the display. This can cause us to lose > hardware state and fail to configure our display. For example: > > dw-mipi-dsi-rockchip ff968000.mipi: failed to write command FIFO > panel-innolux-p079zca ff960000.mipi.0: failed to write command 0 > > or: > > dw-mipi-dsi-rockchip ff968000.mipi: failed to write command FIFO > panel-kingdisplay-kd097d04 ff960000.mipi.0: failed write init cmds: -11= 0 > > We should match the runtime PM to the lifetime of the bind()/unbind() > cycle. > > Tested on Acer Chrometab 10 (RK3399 Gru-Scarlet), with panel drivers > built either as modules or built-in. > > Side notes: it seems one is more likely to see this problem when the > panel driver is built into the kernel. I've also seen this problem > bisect down to commits that simply changed Kconfig dependencies, because > it changed the order in which driver init functions were compiled into > the kernel, and therefore the ordering and timing of built-in device > probe. > > Fixes: 43c2de1002d2 ("drm/rockchip: dsi: move all lane config except LCDC= mux to bind()") > Link: https://lore.kernel.org/linux-rockchip/9aedfb528600ecf871885f7293ca= 4207c84d16c1.camel@gmail.com/ > Reported-by: > Cc: > Signed-off-by: Brian Norris > Tested-by: N=C3=ADcolas F. R. A. Prado Reviewed-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8096CC433F5 for ; Wed, 29 Sep 2021 02:28:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4304560EFF for ; Wed, 29 Sep 2021 02:28:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4304560EFF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UstrrN2A+ek9XD9Se2jsbFXNZBq7CLj2/mBHnSz8lXU=; b=PFy0qwvDnlzW+Z 4ElqKO4UoTNje4pv1I/diS+6YKMKhS0moeMjw4vW3hXRVO6Mt45WThAU9Lyv+liQBfdM134bRSYXC aX5cC/LjbGwkackvF8aiII37tEL8h0QG13nEdW3uIB0Rhy40Il+mVEsv2tcD2I3OYlyJIN23LUvU5 FaCmmGpP6zmXZABF5Vf9Jp7Ih0VjMpMBdVbWglDVleEAUgdy8ScLZaE+B5gaSnBGEg5ujRx5XhC+O 3ahaoKYBQtvIO9eKAvXVBmg2BBWbVj9STJTStzJKPCMLSHkfYOQEi+yidcvcUdKuOL1r6Gu9qXqIK wVGf+39pGg14jNyb20OA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVPKH-009hgp-J9; Wed, 29 Sep 2021 02:28:05 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVPKF-009hfl-0a for linux-rockchip@lists.infradead.org; Wed, 29 Sep 2021 02:28:04 +0000 Received: by mail-lf1-x12f.google.com with SMTP id i19so1430617lfu.0 for ; Tue, 28 Sep 2021 19:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fJjBCR4+9bCZVm0Fu8Xcmw+g/rqGltdjILLNILMG/mA=; b=gZItg880S7ngvt1ScsVFZbT92Pz35STUpkg7MtmBPG38S8oE0RNWXVxg5AsCJmsiso gjU9EtdpeqLxN8TOF5kWZEb6v6ULSNqjKWay2YeRQCSYzJo2aiENwykZpJGyAuHjhXlY nukor5W0hJzjkNO93yWm4lxshhwfHKxlrCThA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fJjBCR4+9bCZVm0Fu8Xcmw+g/rqGltdjILLNILMG/mA=; b=tlDTs0fWt7CtfH/BMYuulRFKyGiyKJq2Np7rekz9nWho8df4v6+XCZH4pPqW2BAKit eZqcZKq87k9GPWhIowDscztU4yohnGTPU1JZxZMiki5EfA9vOHUG8O8TYUPpDT729xAn 2wG+kfDSibp+cOcvALhDjgRW/gUjJoRWjEh6ez+l1U1cNDJLpir5MHDNlwWUdP2gLxkg wxZlz/5Vv9oCK6XuLQXgQENrfq9yw1KQf0Jm1xJSsm8GpigS8vuyIyBkH3DoHf8nBi6d r/CU3zMvscI6Fsggey9vZrMD+A4G6aCB0xKZqTFLv50+m9IPB+OUBYxp27jTURn0Vhl5 /aWQ== X-Gm-Message-State: AOAM53344K6NEKp70OEB6Q0qB1nS8/dh7vkL8XBw/1lr4Yfcu1SWiWKS xQfkLfCDcLH7n9LhwPCEnrnwb2jQPxTuSpL4S9O2NA== X-Google-Smtp-Source: ABdhPJxtLJKFI2ooM24bJMRumtCIgTrU9ia9VK2xsan8DKGDUzhXg/ByJkFUAByLAPwnyRDMK4Wt9rw5VOO0jFuGCL8= X-Received: by 2002:ac2:495b:: with SMTP id o27mr8638251lfi.501.1632882477417; Tue, 28 Sep 2021 19:27:57 -0700 (PDT) MIME-Version: 1.0 References: <20210928213552.1001939-1-briannorris@chromium.org> <20210928143413.v3.1.Ic2904d37f30013a7f3d8476203ad3733c186827e@changeid> In-Reply-To: <20210928143413.v3.1.Ic2904d37f30013a7f3d8476203ad3733c186827e@changeid> From: Chen-Yu Tsai Date: Wed, 29 Sep 2021 10:27:46 +0800 Message-ID: Subject: Re: [PATCH v3 1/4] drm/rockchip: dsi: Hold pm-runtime across bind/unbind To: Brian Norris Cc: =?UTF-8?Q?Heiko_St=C3=BCbner?= , LKML , dri-devel , "open list:ARM/Rockchip SoC..." , Sandy Huang , Thomas Hebb , aleksandr.o.makarov@gmail.com, stable@vger.kernel.org, =?UTF-8?B?TsOtY29sYXMgRiAuIFIgLiBBIC4gUHJhZG8=?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210928_192803_063689_AEAB0F75 X-CRM114-Status: GOOD ( 17.46 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gV2VkLCBTZXAgMjksIDIwMjEgYXQgNTozNiBBTSBCcmlhbiBOb3JyaXMgPGJyaWFubm9ycmlz QGNocm9taXVtLm9yZz4gd3JvdGU6Cj4KPiBJbiBjb21taXQgNDNjMmRlMTAwMmQyLCB3ZSBtb3Zl ZCBtb3N0IEhXIGNvbmZpZ3VyYXRpb24gdG8gYmluZCgpLCBidXQgd2UKPiBkaWRuJ3QgbW92ZSB0 aGUgcnVudGltZSBQTSBtYW5hZ2VtZW50LiBUaGVyZWZvcmUsIGRlcGVuZGluZyBvbiBpbml0aWFs Cj4gYm9vdCBzdGF0ZSwgcnVudGltZS1QTSB3b3JrcXVldWUgZGVsYXlzLCBhbmQgb3RoZXIgdGlt aW5nIGZhY3RvcnMsIHdlCj4gbWF5IGRpc2FibGUgb3VyIHBvd2VyIGRvbWFpbiBpbiBiZXR3ZWVu IHRoZSBoYXJkd2FyZSBjb25maWd1cmF0aW9uCj4gKGJpbmQoKSkgYW5kIHdoZW4gd2UgZW5hYmxl IHRoZSBkaXNwbGF5LiBUaGlzIGNhbiBjYXVzZSB1cyB0byBsb3NlCj4gaGFyZHdhcmUgc3RhdGUg YW5kIGZhaWwgdG8gY29uZmlndXJlIG91ciBkaXNwbGF5LiBGb3IgZXhhbXBsZToKPgo+ICAgZHct bWlwaS1kc2ktcm9ja2NoaXAgZmY5NjgwMDAubWlwaTogZmFpbGVkIHRvIHdyaXRlIGNvbW1hbmQg RklGTwo+ICAgcGFuZWwtaW5ub2x1eC1wMDc5emNhIGZmOTYwMDAwLm1pcGkuMDogZmFpbGVkIHRv IHdyaXRlIGNvbW1hbmQgMAo+Cj4gb3I6Cj4KPiAgIGR3LW1pcGktZHNpLXJvY2tjaGlwIGZmOTY4 MDAwLm1pcGk6IGZhaWxlZCB0byB3cml0ZSBjb21tYW5kIEZJRk8KPiAgIHBhbmVsLWtpbmdkaXNw bGF5LWtkMDk3ZDA0IGZmOTYwMDAwLm1pcGkuMDogZmFpbGVkIHdyaXRlIGluaXQgY21kczogLTEx MAo+Cj4gV2Ugc2hvdWxkIG1hdGNoIHRoZSBydW50aW1lIFBNIHRvIHRoZSBsaWZldGltZSBvZiB0 aGUgYmluZCgpL3VuYmluZCgpCj4gY3ljbGUuCj4KPiBUZXN0ZWQgb24gQWNlciBDaHJvbWV0YWIg MTAgKFJLMzM5OSBHcnUtU2NhcmxldCksIHdpdGggcGFuZWwgZHJpdmVycwo+IGJ1aWx0IGVpdGhl ciBhcyBtb2R1bGVzIG9yIGJ1aWx0LWluLgo+Cj4gU2lkZSBub3RlczogaXQgc2VlbXMgb25lIGlz IG1vcmUgbGlrZWx5IHRvIHNlZSB0aGlzIHByb2JsZW0gd2hlbiB0aGUKPiBwYW5lbCBkcml2ZXIg aXMgYnVpbHQgaW50byB0aGUga2VybmVsLiBJJ3ZlIGFsc28gc2VlbiB0aGlzIHByb2JsZW0KPiBi aXNlY3QgZG93biB0byBjb21taXRzIHRoYXQgc2ltcGx5IGNoYW5nZWQgS2NvbmZpZyBkZXBlbmRl bmNpZXMsIGJlY2F1c2UKPiBpdCBjaGFuZ2VkIHRoZSBvcmRlciBpbiB3aGljaCBkcml2ZXIgaW5p dCBmdW5jdGlvbnMgd2VyZSBjb21waWxlZCBpbnRvCj4gdGhlIGtlcm5lbCwgYW5kIHRoZXJlZm9y ZSB0aGUgb3JkZXJpbmcgYW5kIHRpbWluZyBvZiBidWlsdC1pbiBkZXZpY2UKPiBwcm9iZS4KPgo+ IEZpeGVzOiA0M2MyZGUxMDAyZDIgKCJkcm0vcm9ja2NoaXA6IGRzaTogbW92ZSBhbGwgbGFuZSBj b25maWcgZXhjZXB0IExDREMgbXV4IHRvIGJpbmQoKSIpCj4gTGluazogaHR0cHM6Ly9sb3JlLmtl cm5lbC5vcmcvbGludXgtcm9ja2NoaXAvOWFlZGZiNTI4NjAwZWNmODcxODg1ZjcyOTNjYTQyMDdj ODRkMTZjMS5jYW1lbEBnbWFpbC5jb20vCj4gUmVwb3J0ZWQtYnk6IDxhbGVrc2FuZHIuby5tYWth cm92QGdtYWlsLmNvbT4KPiBDYzogPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+Cj4gU2lnbmVkLW9m Zi1ieTogQnJpYW4gTm9ycmlzIDxicmlhbm5vcnJpc0BjaHJvbWl1bS5vcmc+Cj4gVGVzdGVkLWJ5 OiBOw61jb2xhcyBGLiBSLiBBLiBQcmFkbyA8bmZyYXByYWRvQGNvbGxhYm9yYS5jb20+CgpSZXZp ZXdlZC1ieTogQ2hlbi1ZdSBUc2FpIDx3ZW5zdEBjaHJvbWl1bS5vcmc+CgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5n IGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg==