From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6F7AC4332F for ; Fri, 30 Dec 2022 04:44:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234430AbiL3EoD (ORCPT ); Thu, 29 Dec 2022 23:44:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230261AbiL3En6 (ORCPT ); Thu, 29 Dec 2022 23:43:58 -0500 Received: from mail-ua1-x935.google.com (mail-ua1-x935.google.com [IPv6:2607:f8b0:4864:20::935]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C85415FC6 for ; Thu, 29 Dec 2022 20:43:57 -0800 (PST) Received: by mail-ua1-x935.google.com with SMTP id e24so4576346uam.10 for ; Thu, 29 Dec 2022 20:43:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Hzc2DHU2nXa3yiV9mMwKUPwKVgPRmW21x4yoJc20iDQ=; b=O+5j9m2EbbdN1CTgzG9n6p7QaEu/2bzOyhgVdgBnfNFK3U7HDhsFqkDYWE4gR0f0bF hW+O7JWn6lS6NF4XGdWV+bp450v7+1oB7HtLLlJr1EgBX79cN+aov/EQWlyE+fSdDHQP 62aGlzXzflNwo2OGQ77bdaJSsJ7a+AI48H8A8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Hzc2DHU2nXa3yiV9mMwKUPwKVgPRmW21x4yoJc20iDQ=; b=UmrMzI6ZcnZKgCyBwioblEUKk7NNrTQaGp3muxO3FDwz8NMAEmHWo1SJXhV6ELTprB g6ectlAgoneS8CqajiJkHWsqLoKh9fIRSROnauD8D6mHaek0ZXLybXBIUWOC54X5tXoI /AjCwpe26Bp9QfA7sKMeWVwaZ/5gK2FbuewlQHdMfW1Jxo3PxM7vVTbCvEvjHl7bhug4 ncxfVsZVWMf6k4c0iaXl042HHOcFX0KWKQGLeohroq8no/e0pqavD+kOzFWHDMn7NCws 5nAKOIcrmwjlqLHkSHSOhgTBnht1jicZm0kmJnJbcE/7fJacg6zE6NZ29VXoybnTT4+9 KVnA== X-Gm-Message-State: AFqh2kpb5WrbkcXbCkJLXzTsvWvWRFet7CXfNzoc/2jfA9vPGVPQbXWC IljnrKXT2pq96PnQ1Uwq67v8eOEKHIxqJwMfYcvbyw== X-Google-Smtp-Source: AMrXdXtiQs6PVwO0EZw+110kG9yVpobNEk4D1l2z90lqtFZxqIG86YeOf7CwLTDHKuMvSgSq/MqegjK/bf+r4H56iww= X-Received: by 2002:a9f:386b:0:b0:419:1620:be75 with SMTP id q40-20020a9f386b000000b004191620be75mr2785460uad.78.1672375436164; Thu, 29 Dec 2022 20:43:56 -0800 (PST) MIME-Version: 1.0 References: <20221223094259.87373-1-angelogioacchino.delregno@collabora.com> <20221223094259.87373-7-angelogioacchino.delregno@collabora.com> In-Reply-To: <20221223094259.87373-7-angelogioacchino.delregno@collabora.com> From: Chen-Yu Tsai Date: Fri, 30 Dec 2022 12:43:45 +0800 Message-ID: Subject: Re: [PATCH v2 06/23] clk: mediatek: clk-mux: Propagate struct device for mtk-mux To: AngeloGioacchino Del Regno Cc: mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johnson.wang@mediatek.com, miles.chen@mediatek.com, fparent@baylibre.com, chun-jie.chen@mediatek.com, sam.shih@mediatek.com, y.oudjana@protonmail.com, nfraprado@collabora.com, rex-bc.chen@mediatek.com, ryder.lee@kernel.org, daniel@makrotopia.org, jose.exposito89@gmail.com, yangyingliang@huawei.com, pablo.sun@mediatek.com, msp@baylibre.com, weiyi.lu@mediatek.com, ikjn@chromium.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 23, 2022 at 5:43 PM AngeloGioacchino Del Regno wrote: > > Like done for other clocks, propagate struct device for mtk mux clocks > registered through clk-mux helpers to enable runtime pm support. > > Signed-off-by: AngeloGioacchino Del Regno Same comment as the previous patches, could we move struct device to the first parameter? Otherwise this looks good to me. ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CE52C4332F for ; Fri, 30 Dec 2022 04:45:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BITYOiuzOLsz6u02m/O9ug/pTgzaMu+UVzUnk9YA9pI=; b=fK42Rq8qE3+6U+ OXcNl5F0tootjH1A13WvPX0Finv2GUvUHbiqg3DOFBbU8VHMHY7Tq/5NWRIjc6wxJX/dSWVa7q47a Z+I4uQJMitXys91VHzSmnwanwdwZQW88zdxzZTkWswkBc+aYTLvwfgJlX6scVOwLWIGY4j1mliRB1 f4uhaN7nu8pHXZbJZkKFcNXNAcP+iWeLhN5s2g4/Pryjzb/EONW94hbLydi0vuFSWH0J19ocPWXb2 ha2vNHoTQ1ltvfB9Jk5K3Cz2lKF88y4sTH4Z6/zrXY/sE9PR9Yy3BYY7SUkKkiTZEFkt1HtYfmaPW rQhCsbqCpxC22wFSjv8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pB7FY-005b6g-02; Fri, 30 Dec 2022 04:44:08 +0000 Received: from mail-ua1-x934.google.com ([2607:f8b0:4864:20::934]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pB7FP-005b1R-A1 for linux-arm-kernel@lists.infradead.org; Fri, 30 Dec 2022 04:44:00 +0000 Received: by mail-ua1-x934.google.com with SMTP id d1so4579224ual.11 for ; Thu, 29 Dec 2022 20:43:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Hzc2DHU2nXa3yiV9mMwKUPwKVgPRmW21x4yoJc20iDQ=; b=O+5j9m2EbbdN1CTgzG9n6p7QaEu/2bzOyhgVdgBnfNFK3U7HDhsFqkDYWE4gR0f0bF hW+O7JWn6lS6NF4XGdWV+bp450v7+1oB7HtLLlJr1EgBX79cN+aov/EQWlyE+fSdDHQP 62aGlzXzflNwo2OGQ77bdaJSsJ7a+AI48H8A8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Hzc2DHU2nXa3yiV9mMwKUPwKVgPRmW21x4yoJc20iDQ=; b=pZyUrJcgD32M1OtQopwQ8ckTV7vvCNAyzfZWFGaWOYQmhOABLm7h4DuSffoKKSSIeD Bmp6o8wzRhbRZsGvMOqVH/OwL7g9mH1vw6CKbn8a3bKPWpVMvRCOyWQ9q1z4CAp/phQ/ gm9yzLk4+HvH9ZUVoFQCRttuHq4Se7DR84AwRjbKsJFUtV1L8Lhyh4+Pz2U4qigjTzZ+ FjuwNUYXztZ6jm8LMDaRYSLFFQaJ2Dz5mSsx1HvlQzuC4quBawmrtAkoNR9nK89vLw3o Rj+ErbrfMtg/YKqw1nPn/3MxH840h2fhCl05XjjWIlXSD/3cz/EkVJVaF04OtSmU398L K/YQ== X-Gm-Message-State: AFqh2kq30vzVDwYjaPC+y71+rj480ZXAS6yfCtF2ViCQ5++WCzMj1yJ/ B1Jwv/05iHWXKX+H8ouLAGuM/ksZO4i5vEoZ6dHv2g== X-Google-Smtp-Source: AMrXdXtiQs6PVwO0EZw+110kG9yVpobNEk4D1l2z90lqtFZxqIG86YeOf7CwLTDHKuMvSgSq/MqegjK/bf+r4H56iww= X-Received: by 2002:a9f:386b:0:b0:419:1620:be75 with SMTP id q40-20020a9f386b000000b004191620be75mr2785460uad.78.1672375436164; Thu, 29 Dec 2022 20:43:56 -0800 (PST) MIME-Version: 1.0 References: <20221223094259.87373-1-angelogioacchino.delregno@collabora.com> <20221223094259.87373-7-angelogioacchino.delregno@collabora.com> In-Reply-To: <20221223094259.87373-7-angelogioacchino.delregno@collabora.com> From: Chen-Yu Tsai Date: Fri, 30 Dec 2022 12:43:45 +0800 Message-ID: Subject: Re: [PATCH v2 06/23] clk: mediatek: clk-mux: Propagate struct device for mtk-mux To: AngeloGioacchino Del Regno Cc: mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johnson.wang@mediatek.com, miles.chen@mediatek.com, fparent@baylibre.com, chun-jie.chen@mediatek.com, sam.shih@mediatek.com, y.oudjana@protonmail.com, nfraprado@collabora.com, rex-bc.chen@mediatek.com, ryder.lee@kernel.org, daniel@makrotopia.org, jose.exposito89@gmail.com, yangyingliang@huawei.com, pablo.sun@mediatek.com, msp@baylibre.com, weiyi.lu@mediatek.com, ikjn@chromium.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221229_204359_424556_539409C4 X-CRM114-Status: UNSURE ( 8.23 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 23, 2022 at 5:43 PM AngeloGioacchino Del Regno wrote: > > Like done for other clocks, propagate struct device for mtk mux clocks > registered through clk-mux helpers to enable runtime pm support. > > Signed-off-by: AngeloGioacchino Del Regno Same comment as the previous patches, could we move struct device to the first parameter? Otherwise this looks good to me. ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel