From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 755CEC32771 for ; Mon, 26 Sep 2022 05:24:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230060AbiIZFYk (ORCPT ); Mon, 26 Sep 2022 01:24:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233032AbiIZFYg (ORCPT ); Mon, 26 Sep 2022 01:24:36 -0400 Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 587FBB95 for ; Sun, 25 Sep 2022 22:24:33 -0700 (PDT) Received: by mail-io1-xd34.google.com with SMTP id z191so4321550iof.10 for ; Sun, 25 Sep 2022 22:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=jEvurfgQn31+MuQ9PuCNa1QSbNB9nuSrakYO01iDa0I=; b=PBDYoF0ic9Mb/1mI1YKRHy9Z0n5FU2etf3En+x15fDRZoG29HSFX6c/LhtSQ2gawAx HUQ/P7WZ/S2t8ezXnuwLGzOntikDVgIRixZEGHOeG4xWJ1+hllfLvuURJO4X71TgFlKA 4nCik36ImKTv6m/gJcOmL5NIpO/qmKGTCTeds= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=jEvurfgQn31+MuQ9PuCNa1QSbNB9nuSrakYO01iDa0I=; b=qZ6J3tAIfMSHrLW5tvk6T2qTzu5MR4A1xn5/cvsgSPJZCEFyQ2NimDiE7QsqaAEan/ fEl1wPBl9lc19/4bwkO7c4SeQ02nr4db8n/gZuFBG0mY+/4ozcbvh2HdRgwMETIrGncw NGeJr2oiiEsjVJw1sl6DCwfwWCQY/99fuhMvIKr7KeUEDWmmL9+6P+81FN5cNVibUJSG 3lKlNs9lsErL2mUN4qaGrHNxJkUKNKU8VcjuZY968foy7K5WePPtNmVw4el8H9XbTXTX XNtxXet7oFZAMjWk/3fROw0l7aReXyTcKmlNgxA30ojZ1/waXvgqnS9NiCSaLUqBpuX2 RQew== X-Gm-Message-State: ACrzQf3oL5LklCa3XId3x7S//XxZEtkoaD/XlEEAAU6Z0qH3HM00KsE1 RwqH9/DflednrJHb5UrtMyFYmnvq20+qhgYjMmiRYQ== X-Google-Smtp-Source: AMsMyM7De/9dx5rvLkUXiEMENOXrcabNaS46duo0p3ODzyDJhzzbtcEstux2UW5Xef0qQZaCHX+iifRVf5LNG1hnmFw= X-Received: by 2002:a05:6638:12c2:b0:35a:6dc2:891 with SMTP id v2-20020a05663812c200b0035a6dc20891mr10221862jas.316.1664169872766; Sun, 25 Sep 2022 22:24:32 -0700 (PDT) MIME-Version: 1.0 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-15-4844816c9808@baylibre.com> In-Reply-To: From: Chen-Yu Tsai Date: Mon, 26 Sep 2022 13:24:20 +0800 Message-ID: Subject: Re: [PATCH v1 15/17] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8195 To: Krzysztof Kozlowski Cc: Guillaume Ranquet , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I , Matthias Brugger , devicetree@vger.kernel.org, Mattijs Korpershoek , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Pablo Sun , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 22, 2022 at 3:20 PM Krzysztof Kozlowski wrote: > > On 19/09/2022 18:56, Guillaume Ranquet wrote: > > Add dt-binding documentation of dpi for MediaTek MT8195 SoC. > > > > Signed-off-by: Guillaume Ranquet > > > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > index 5bb23e97cf33..2c7ecef54986 100644 > > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > @@ -24,6 +24,7 @@ properties: > > - mediatek,mt8183-dpi > > - mediatek,mt8186-dpi > > - mediatek,mt8192-dpi > > + - mediatek,mt8195-dpi > > - mediatek,mt8195-dp-intf > > Aren't these the same? *-dpi are MIPI DPI (as in parallel data with DDR modes) encoders. *-dp-intf are Display Port encoder. Totally distinguishable. :) The hardware blocks seem similar upon cursory comparison of the register tables, with the base layout being the same, and sharing registers for basic settings such as the display timings. The DPI ones have some extra registers, presumably to control the signals or output width. The DP one has some registers of its own that only make sense for Display Port. ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04037C6FA82 for ; Mon, 26 Sep 2022 05:24:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 433A510E229; Mon, 26 Sep 2022 05:24:36 +0000 (UTC) Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 898BE10E229 for ; Mon, 26 Sep 2022 05:24:33 +0000 (UTC) Received: by mail-io1-xd2a.google.com with SMTP id h194so4347369iof.4 for ; Sun, 25 Sep 2022 22:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=jEvurfgQn31+MuQ9PuCNa1QSbNB9nuSrakYO01iDa0I=; b=PBDYoF0ic9Mb/1mI1YKRHy9Z0n5FU2etf3En+x15fDRZoG29HSFX6c/LhtSQ2gawAx HUQ/P7WZ/S2t8ezXnuwLGzOntikDVgIRixZEGHOeG4xWJ1+hllfLvuURJO4X71TgFlKA 4nCik36ImKTv6m/gJcOmL5NIpO/qmKGTCTeds= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=jEvurfgQn31+MuQ9PuCNa1QSbNB9nuSrakYO01iDa0I=; b=ulWqw42CmPKbxh6f688yiD454sr5buboVsnGrKyMslrDW2DnqXABcnnCTgqUhQcZwe SGXValDpYL/o4dpFTBqMhea6pQF0lTspqVWxckmhaen1UmAkTEmFHhMaaZQoMQ/eENfM yYmXJleCeNq1cSTi4PGICuhHV1osWpH5pXf1Kw/+QVwKC0vnLiA7ShmTD9aw3NcX3qyZ CAUTlfIrjiLYXI8OzfXoWyl6YTIrl2OOT89nKWlfH0vbJilOl1pMfJXYgF82Nb5AmTKe /HJ+H0rlr+/ExOGXXWOwlSG5zerUo8sLJAnV7Rx3fcI9OvLxADyHLwXQ63YOdH0vpUon RW9A== X-Gm-Message-State: ACrzQf2p/nNt2YlsSFjVd+X/PHfSE1njHpb+AqayjG9dDbYenmwxYdiJ iRT7avM+tFd+ui5HHhkIaoWYClPoiWt4AfFXNpTUiw== X-Google-Smtp-Source: AMsMyM7De/9dx5rvLkUXiEMENOXrcabNaS46duo0p3ODzyDJhzzbtcEstux2UW5Xef0qQZaCHX+iifRVf5LNG1hnmFw= X-Received: by 2002:a05:6638:12c2:b0:35a:6dc2:891 with SMTP id v2-20020a05663812c200b0035a6dc20891mr10221862jas.316.1664169872766; Sun, 25 Sep 2022 22:24:32 -0700 (PDT) MIME-Version: 1.0 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-15-4844816c9808@baylibre.com> In-Reply-To: From: Chen-Yu Tsai Date: Mon, 26 Sep 2022 13:24:20 +0800 Message-ID: Subject: Re: [PATCH v1 15/17] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8195 To: Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , Michael Turquette , dri-devel@lists.freedesktop.org, Krzysztof Kozlowski , linux-phy@lists.infradead.org, linux-clk@vger.kernel.org, Kishon Vijay Abraham I , Chun-Kuang Hu , Jitao shi , Chunfeng Yun , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, Guillaume Ranquet , Stephen Boyd , Mattijs Korpershoek , linux-kernel@vger.kernel.org, Vinod Koul , Pablo Sun Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Sep 22, 2022 at 3:20 PM Krzysztof Kozlowski wrote: > > On 19/09/2022 18:56, Guillaume Ranquet wrote: > > Add dt-binding documentation of dpi for MediaTek MT8195 SoC. > > > > Signed-off-by: Guillaume Ranquet > > > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > index 5bb23e97cf33..2c7ecef54986 100644 > > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > @@ -24,6 +24,7 @@ properties: > > - mediatek,mt8183-dpi > > - mediatek,mt8186-dpi > > - mediatek,mt8192-dpi > > + - mediatek,mt8195-dpi > > - mediatek,mt8195-dp-intf > > Aren't these the same? *-dpi are MIPI DPI (as in parallel data with DDR modes) encoders. *-dp-intf are Display Port encoder. Totally distinguishable. :) The hardware blocks seem similar upon cursory comparison of the register tables, with the base layout being the same, and sharing registers for basic settings such as the display timings. The DPI ones have some extra registers, presumably to control the signals or output width. The DP one has some registers of its own that only make sense for Display Port. ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA19FC07E9D for ; Mon, 26 Sep 2022 05:24:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kyrsdbd/HJtfPca/H3tbLVXTn3u7uIIquTu5+r6UtyI=; b=FkcOPG6GE+0YGE 7mB+p1iYUE+g/lWfLW9ZXsYrvPrLSSkgZN7M8d3/02bruaVNKqtkaIXJJm72cGS6ggiFyb2zUL5lK cXMXu9IkrFNAFnYhgFN7SYTL6iWVHRk+DVcTcYk8ErGm61xuI6kwlZsPj27zq7zo653DUBc1wwOEl mmS8YHIaysZl0tvdBlKtOfaxG43vYVaI/YtpJW4ZS7yodLJX40zBSemwim+FPpmc/T7vZq9N/FRPz d5gHoJLyLX/0zdH6P+q0gVhMXDAnPkzfrdRO2e8pewsZuvyfUtJvMDJbXOuxZPI2N1RWNouleneYP x+LLsflCHVVestAPopSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocgbc-001yo0-6C; Mon, 26 Sep 2022 05:24:36 +0000 Received: from mail-io1-xd36.google.com ([2607:f8b0:4864:20::d36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocgbZ-001ymo-R7 for linux-phy@lists.infradead.org; Mon, 26 Sep 2022 05:24:35 +0000 Received: by mail-io1-xd36.google.com with SMTP id e205so4364049iof.1 for ; Sun, 25 Sep 2022 22:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=jEvurfgQn31+MuQ9PuCNa1QSbNB9nuSrakYO01iDa0I=; b=PBDYoF0ic9Mb/1mI1YKRHy9Z0n5FU2etf3En+x15fDRZoG29HSFX6c/LhtSQ2gawAx HUQ/P7WZ/S2t8ezXnuwLGzOntikDVgIRixZEGHOeG4xWJ1+hllfLvuURJO4X71TgFlKA 4nCik36ImKTv6m/gJcOmL5NIpO/qmKGTCTeds= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=jEvurfgQn31+MuQ9PuCNa1QSbNB9nuSrakYO01iDa0I=; b=O0SsYVz2PMK5HWOiFHlKL6tu4nwcAIMXTYJKA6Jhh89kvFewx2zzFke83kttRS7ZiN CYmNyI5Sb3Kqa3Q0A3xa7n1c3Ro7F/w6o9SCK4sROIrjJDmROVzxWDa18WhAvz8anZwo P5x/VZZtMBhzwn2uWi77PqrUY6GU7X6/OTHfe2r966Z+umLpgYWeS10jyWexIaIHFuau Xk44OCNxgBQxBZqBY6tbRk025B5Dm5Dv5pfSDg3p3l/KHChmEjb4vxEZV09uCIkal0x/ CLODKS8X955LlXAqXs1tE1gjozhqG0cCHJxLU/SpQ+iTgfz+FOqrE1+eVVuz+YcZLjcb Ywrg== X-Gm-Message-State: ACrzQf3jXxj69yHiEWXBc3WX6jfv0GBxRwX7o7xCs1R/z7OfcLSpUZ63 JsWBstiFW5Rs3PxfgS5vQqWr9kEkvKF3PogvuV2jQw== X-Google-Smtp-Source: AMsMyM7De/9dx5rvLkUXiEMENOXrcabNaS46duo0p3ODzyDJhzzbtcEstux2UW5Xef0qQZaCHX+iifRVf5LNG1hnmFw= X-Received: by 2002:a05:6638:12c2:b0:35a:6dc2:891 with SMTP id v2-20020a05663812c200b0035a6dc20891mr10221862jas.316.1664169872766; Sun, 25 Sep 2022 22:24:32 -0700 (PDT) MIME-Version: 1.0 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-15-4844816c9808@baylibre.com> In-Reply-To: From: Chen-Yu Tsai Date: Mon, 26 Sep 2022 13:24:20 +0800 Message-ID: Subject: Re: [PATCH v1 15/17] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8195 To: Krzysztof Kozlowski Cc: Guillaume Ranquet , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I , Matthias Brugger , devicetree@vger.kernel.org, Mattijs Korpershoek , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Pablo Sun , linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220925_222433_914414_55D91CD4 X-CRM114-Status: GOOD ( 12.42 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Thu, Sep 22, 2022 at 3:20 PM Krzysztof Kozlowski wrote: > > On 19/09/2022 18:56, Guillaume Ranquet wrote: > > Add dt-binding documentation of dpi for MediaTek MT8195 SoC. > > > > Signed-off-by: Guillaume Ranquet > > > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > index 5bb23e97cf33..2c7ecef54986 100644 > > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > @@ -24,6 +24,7 @@ properties: > > - mediatek,mt8183-dpi > > - mediatek,mt8186-dpi > > - mediatek,mt8192-dpi > > + - mediatek,mt8195-dpi > > - mediatek,mt8195-dp-intf > > Aren't these the same? *-dpi are MIPI DPI (as in parallel data with DDR modes) encoders. *-dp-intf are Display Port encoder. Totally distinguishable. :) The hardware blocks seem similar upon cursory comparison of the register tables, with the base layout being the same, and sharing registers for basic settings such as the display timings. The DPI ones have some extra registers, presumably to control the signals or output width. The DP one has some registers of its own that only make sense for Display Port. ChenYu -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B6D5C32771 for ; Mon, 26 Sep 2022 05:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mJf7Bn7Z7PJXWOAs4UiZbGyP+NKUyga8bxpooV5JTIg=; b=tb4nWdfJvl2Fxm ++EHSJ4gDJkeZ8/rFIMKmprHslaQeOTgPe5Nw/0JyYUZb14Nw614zzOP1mDXVYxPtU0hAIr5SvVcB SYdX2MvR13bPJjzC8300JuVL8xPyJ74uZcx+/zqZH/atFArtQvNsdaKkDYIUg5gbFVeFdWIL459xw 0qRZuJB65jsZzKY7qJhLrwReeiHLxVVU7l3Ofj4gw/6W38r6NGjS9o/gwe2vjVx86A//P1MBQs8Vw BOtjUfAa223i/us4Me321igZOC4WqvWub4ew+/yvbYbSYO71uDRh1+T6LdfH5I6bAxF9F2CiiRZgw 8czhHaAoYUfC4ifHTUxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocgbd-001yoY-SQ; Mon, 26 Sep 2022 05:24:38 +0000 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ocgbZ-001ymq-Td for linux-arm-kernel@lists.infradead.org; Mon, 26 Sep 2022 05:24:36 +0000 Received: by mail-io1-xd2a.google.com with SMTP id p202so4339283iod.6 for ; Sun, 25 Sep 2022 22:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=jEvurfgQn31+MuQ9PuCNa1QSbNB9nuSrakYO01iDa0I=; b=PBDYoF0ic9Mb/1mI1YKRHy9Z0n5FU2etf3En+x15fDRZoG29HSFX6c/LhtSQ2gawAx HUQ/P7WZ/S2t8ezXnuwLGzOntikDVgIRixZEGHOeG4xWJ1+hllfLvuURJO4X71TgFlKA 4nCik36ImKTv6m/gJcOmL5NIpO/qmKGTCTeds= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=jEvurfgQn31+MuQ9PuCNa1QSbNB9nuSrakYO01iDa0I=; b=V8YWcEZnEKPPU2NyMdGpg5xFANm2jpBhFpTuDLLDijwYy/uSgDQdf4kxbQHAsiGYQE HOVB8pl6UYRujw851fRc+tAkqnycDRZL8qvImzxypC2Jddn9Lp6ZjXCEDpLRThTqMhWP IZ9dxDuKwdpvUWnCerUSe9SwV6V5pyx9GbB8bUayV1ki4qh7IdTJtSfzNPxWEE9uPYij x3NkevNNhlO7pQfcw35G6tAj1nXg7D8c7ZvEOlrnSOYu39+pueGmp19LmH99fNR1NrT5 Wvn55ijQNshtsaiXzIOKlidSxjZoa9W0Sj2f1ajIWy+6bPq9YQiPLYT6yrHOw7VKUG+o p/XQ== X-Gm-Message-State: ACrzQf31uDiI/3OosP72Lyt41OG+WKg6y34GkNBwbPvRB9W0qjYm6z8C FNvfkfzUbd66n8SrgLPbV+n5j18pIVfVyMQAkW08lw== X-Google-Smtp-Source: AMsMyM7De/9dx5rvLkUXiEMENOXrcabNaS46duo0p3ODzyDJhzzbtcEstux2UW5Xef0qQZaCHX+iifRVf5LNG1hnmFw= X-Received: by 2002:a05:6638:12c2:b0:35a:6dc2:891 with SMTP id v2-20020a05663812c200b0035a6dc20891mr10221862jas.316.1664169872766; Sun, 25 Sep 2022 22:24:32 -0700 (PDT) MIME-Version: 1.0 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-15-4844816c9808@baylibre.com> In-Reply-To: From: Chen-Yu Tsai Date: Mon, 26 Sep 2022 13:24:20 +0800 Message-ID: Subject: Re: [PATCH v1 15/17] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8195 To: Krzysztof Kozlowski Cc: Guillaume Ranquet , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I , Matthias Brugger , devicetree@vger.kernel.org, Mattijs Korpershoek , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Pablo Sun , linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220925_222433_986174_DF6BBF38 X-CRM114-Status: GOOD ( 13.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 22, 2022 at 3:20 PM Krzysztof Kozlowski wrote: > > On 19/09/2022 18:56, Guillaume Ranquet wrote: > > Add dt-binding documentation of dpi for MediaTek MT8195 SoC. > > > > Signed-off-by: Guillaume Ranquet > > > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > index 5bb23e97cf33..2c7ecef54986 100644 > > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > @@ -24,6 +24,7 @@ properties: > > - mediatek,mt8183-dpi > > - mediatek,mt8186-dpi > > - mediatek,mt8192-dpi > > + - mediatek,mt8195-dpi > > - mediatek,mt8195-dp-intf > > Aren't these the same? *-dpi are MIPI DPI (as in parallel data with DDR modes) encoders. *-dp-intf are Display Port encoder. Totally distinguishable. :) The hardware blocks seem similar upon cursory comparison of the register tables, with the base layout being the same, and sharing registers for basic settings such as the display timings. The DPI ones have some extra registers, presumably to control the signals or output width. The DP one has some registers of its own that only make sense for Display Port. ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel