From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B99AC4338F for ; Mon, 26 Jul 2021 10:41:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F00C601FC for ; Mon, 26 Jul 2021 10:41:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232624AbhGZKAd (ORCPT ); Mon, 26 Jul 2021 06:00:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231639AbhGZKAc (ORCPT ); Mon, 26 Jul 2021 06:00:32 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E60D3C061757 for ; Mon, 26 Jul 2021 03:40:59 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id a26so14532570lfr.11 for ; Mon, 26 Jul 2021 03:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mp+ljmBlWVJ3FcF8TzFJ/v6DBJnSfIezbeTpHeoDqRs=; b=i/IKSBgxKVAztTwiTtgjoROmNn7HkqaBtbAlNMHjALuMoi7YisCKdKhr5rQB7PewHL 7V3M1dCz2NHL0LkV8ZUW1DZ3fIR4rWqfqYH5HfKC9+/RUbzmJjoGp7dRFdZp6FI8gxIE CBmI26l/Z/HgKqXvubpXWEgOh+/Wn+eteioPQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mp+ljmBlWVJ3FcF8TzFJ/v6DBJnSfIezbeTpHeoDqRs=; b=B6HsueajaCyHIrePg0TRdpMinVXcCCXDo9elpa4a60A8f0QnoWO1irp4Ralu7wRIxt R+SmzBBx+10iiT60E5zpW5NlgnnZ0EIA96pE/xUCFXHuZILh5SVgpZosuX6gRa1BesZo v3f1b5lTfLDtQvhgu0r0RNNNfK1TRE0L2e47fmwoqYhGvTnU0ASDqyuISuRRI66dTlUW 5cCaUF9s2c1lxy+2m4ScImCP2Dwvbsw5Rx1edYEBYpmiaYlIpVgt9BmyFTKCrRo1Yzxi w3/0pDK20qq8sbacnA1/DGNIUnfOjyXaM+VHvMqYVBpFoJXgHPUK0Ed63cT+lYc95v6s Lzeg== X-Gm-Message-State: AOAM530mXCusZZ4F4nZC8D9pHnznpDjhDQHAR3UF8MGaCpTO+GY4oh5Z sTFez5PRul7Ff2sG5wi1s9Q/sXYJeF+EuMZZvg01fQ== X-Google-Smtp-Source: ABdhPJybFZceRt4dT8AQ0A07ojtGZyNOuGQJ81eXjR+I+oeShos5q0uB3j62uLw/D28XjBH891o6E+ONKw9ot/Q+4W0= X-Received: by 2002:a05:6512:3f13:: with SMTP id y19mr12407680lfa.444.1627296058376; Mon, 26 Jul 2021 03:40:58 -0700 (PDT) MIME-Version: 1.0 References: <20210726102442.2119877-1-hsinyi@chromium.org> In-Reply-To: <20210726102442.2119877-1-hsinyi@chromium.org> From: Chen-Yu Tsai Date: Mon, 26 Jul 2021 18:40:47 +0800 Message-ID: Subject: Re: [PATCH v2] arm64: dts: mt8173: elm: Use aliases to mmc nodes To: Hsin-Yi Wang Cc: Matthias Brugger , Rob Herring , Enric Balletbo Serra , Eizan Miyamoto , Devicetree List , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Jul 26, 2021 at 6:25 PM Hsin-Yi Wang wrote: > > Use aliases to mmc nodes so the partition name for eMMC and SD card will > be consistent across boots. To be honest I think this deserves a bit more pretext: There used to be no way to specify the order of MMC controllers, and the numbering was based on how the implementations added the devices. For Linux, this changed when asynchronous probing was enabled for most drivers, resulting in mmc device numbers jumping around. With commit 1796164fac7e ("dt-bindings: mmc: document alias support"), a way to specify fixed index numbers was provided. Otherwise, Reviewed-by: Chen-Yu Tsai Same for the mt8183-kukui patch. > Signed-off-by: Hsin-Yi Wang > --- > v1->v2: skip unused mmc2. > --- > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > index 21452c51a20a8..d5a2cad39c9c7 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > @@ -10,6 +10,12 @@ > #include "mt8173.dtsi" > > / { > + aliases { > + mmc0 = &mmc0; > + mmc1 = &mmc1; > + mmc2 = &mmc3; > + }; > + > memory@40000000 { > device_type = "memory"; > reg = <0 0x40000000 0 0x80000000>; > -- > 2.32.0.432.gabb21c7263-goog > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29AFEC4338F for ; Mon, 26 Jul 2021 10:41:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB36E60F22 for ; Mon, 26 Jul 2021 10:41:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EB36E60F22 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5a8h+VBl0CIbHcUPQpriS7AcXTAqP2lmTmh2MLVh/6w=; b=tDEO7VnTaRf/Br qgvkTx7hKwUTf7H4MIPnyU/HpOofQu9/CuKpke+LjlvbWHVE3YouBcBF6OJ0uOjE7zEg0uVMGLkbG 0ZhoLTNhEvuiXN0PmqntmOB9S11i7jqhbA/8OqjGjLiBYrL3E3pqdKmV5RhOzprJJSn19sLIlvFvg kNyR1wywArcKgEVFlRAnwVVSGa7g2d/FMffEitT7KJ3JlQWPf+9ei2tyMjYXYKuChvt6ILxdi12+1 DtAF2rBkFO8bwCKh6oKxkQnDBERpGPc70soXAnuK7y+tO16FbKjrHmtsspKEGfTyaJGUypENgE4so w2Qbxc/Hgx5yXCUHhDgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7y2r-00AmSn-IU; Mon, 26 Jul 2021 10:41:13 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7y2e-00AmQS-8H for linux-mediatek@lists.infradead.org; Mon, 26 Jul 2021 10:41:01 +0000 Received: by mail-lf1-x12b.google.com with SMTP id r17so14613291lfe.2 for ; Mon, 26 Jul 2021 03:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mp+ljmBlWVJ3FcF8TzFJ/v6DBJnSfIezbeTpHeoDqRs=; b=i/IKSBgxKVAztTwiTtgjoROmNn7HkqaBtbAlNMHjALuMoi7YisCKdKhr5rQB7PewHL 7V3M1dCz2NHL0LkV8ZUW1DZ3fIR4rWqfqYH5HfKC9+/RUbzmJjoGp7dRFdZp6FI8gxIE CBmI26l/Z/HgKqXvubpXWEgOh+/Wn+eteioPQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mp+ljmBlWVJ3FcF8TzFJ/v6DBJnSfIezbeTpHeoDqRs=; b=iqd31wahy6q4oOtr3LfEm9vAQY7mPCKut7iUoQqHJJ304pwEJ7mPHfC8oFJXqDewXM KIqGYobutr3tg/ry8UTdSuc0rsaDautOL7FC7hUI8WNXx/qU1xGv1g6vAu7YJgwaUIYF olCrcq5Q+uAZgSn7SSKP5EYcHZbmVEdATz1CaAGHEv2lTSDL1uewqztRNlxS8AeSwEoR JgKWJXfq24OlG/pcr9sYrNmO9qR4gWpcbcGN9kawSIH/v5aFb528BRLYrY03Ok72xzPK rI88hYGpkuk9zWuTWtMcAPKCHBEOqIc+UJCnHlOZAPvJ3ojsonxT+hMCNUeCOnoVswp3 tmog== X-Gm-Message-State: AOAM531gxcebTlNfguObRRKgXC3IKyZAyDlwnsk93h5Hx6LlTDQZtWGW T2RcqhCl6T5mOC0IpG9PUQsYwMjuvKZidh31YeunWQ== X-Google-Smtp-Source: ABdhPJybFZceRt4dT8AQ0A07ojtGZyNOuGQJ81eXjR+I+oeShos5q0uB3j62uLw/D28XjBH891o6E+ONKw9ot/Q+4W0= X-Received: by 2002:a05:6512:3f13:: with SMTP id y19mr12407680lfa.444.1627296058376; Mon, 26 Jul 2021 03:40:58 -0700 (PDT) MIME-Version: 1.0 References: <20210726102442.2119877-1-hsinyi@chromium.org> In-Reply-To: <20210726102442.2119877-1-hsinyi@chromium.org> From: Chen-Yu Tsai Date: Mon, 26 Jul 2021 18:40:47 +0800 Message-ID: Subject: Re: [PATCH v2] arm64: dts: mt8173: elm: Use aliases to mmc nodes To: Hsin-Yi Wang Cc: Matthias Brugger , Rob Herring , Enric Balletbo Serra , Eizan Miyamoto , Devicetree List , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210726_034100_353968_BD97D04E X-CRM114-Status: GOOD ( 18.81 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, On Mon, Jul 26, 2021 at 6:25 PM Hsin-Yi Wang wrote: > > Use aliases to mmc nodes so the partition name for eMMC and SD card will > be consistent across boots. To be honest I think this deserves a bit more pretext: There used to be no way to specify the order of MMC controllers, and the numbering was based on how the implementations added the devices. For Linux, this changed when asynchronous probing was enabled for most drivers, resulting in mmc device numbers jumping around. With commit 1796164fac7e ("dt-bindings: mmc: document alias support"), a way to specify fixed index numbers was provided. Otherwise, Reviewed-by: Chen-Yu Tsai Same for the mt8183-kukui patch. > Signed-off-by: Hsin-Yi Wang > --- > v1->v2: skip unused mmc2. > --- > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > index 21452c51a20a8..d5a2cad39c9c7 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > @@ -10,6 +10,12 @@ > #include "mt8173.dtsi" > > / { > + aliases { > + mmc0 = &mmc0; > + mmc1 = &mmc1; > + mmc2 = &mmc3; > + }; > + > memory@40000000 { > device_type = "memory"; > reg = <0 0x40000000 0 0x80000000>; > -- > 2.32.0.432.gabb21c7263-goog > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C46C4338F for ; Mon, 26 Jul 2021 10:43:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5E9060F46 for ; Mon, 26 Jul 2021 10:42:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C5E9060F46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H636CaffwiVSG+NLbQacyS5yk4GhxXg4v6eWqDYqcp8=; b=4EQls0NMeEiTAW 4T1SLmIqiaeqTbFI/9sZhWdx0DDq4KF1CIlW2iCGjZbaZojhuL7va8EbZjtGSF0ukvWAlYlSN+KHZ d5s6HN6saBCN28vFVVR/0gmX4fIKLtZgCxfe704dLM5iIfGd4A7sIC0mmzXEAYeQ1vE0j6CnnuDh4 y78OUTy6v9hheQmmnXm/of1Q1IG5Tb2W+6MPSjOeNeSOfiUlkK5tJzV8ehCnltcTvzkTjfuAUKhtG l6wSGmIQNjaLbZSjqp7TOoC5rgWjgGNYloSZCWCVOKfnZIueKRnkJk4kF1ThKhCkWhI2PbWAE9fkk KM4RGCnfujBo/lY20G5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7y2i-00AmRR-1n; Mon, 26 Jul 2021 10:41:04 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7y2e-00AmQV-83 for linux-arm-kernel@lists.infradead.org; Mon, 26 Jul 2021 10:41:01 +0000 Received: by mail-lf1-x130.google.com with SMTP id g13so14547442lfj.12 for ; Mon, 26 Jul 2021 03:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mp+ljmBlWVJ3FcF8TzFJ/v6DBJnSfIezbeTpHeoDqRs=; b=i/IKSBgxKVAztTwiTtgjoROmNn7HkqaBtbAlNMHjALuMoi7YisCKdKhr5rQB7PewHL 7V3M1dCz2NHL0LkV8ZUW1DZ3fIR4rWqfqYH5HfKC9+/RUbzmJjoGp7dRFdZp6FI8gxIE CBmI26l/Z/HgKqXvubpXWEgOh+/Wn+eteioPQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mp+ljmBlWVJ3FcF8TzFJ/v6DBJnSfIezbeTpHeoDqRs=; b=aq7VxP3DTIcUL1/zr43CvGHi1kdJpS1PPDMXoZTebJ3N/76Vt5JEwFEdMQBs6DqnDF Xh8tt3+TcIURzqzQnd/zxto7pA9v2qYj/5k1BlzJRw4lXU1SFqbePsKl4lTOBANhoCyI En5jcgbc3kA8F6dq73T4CQ9IKA9XH91DsS3cA/fwxLAWW5d7GiN9+N4iTuV+ev1Rh9xA fO1hluhdU9cIq3gEeJTRrDcF35/GA1JcgtQywjmWey+zQh+cW2+9mBANurNAtFJypmfe hHihJ4k4NTmdgmgBB+tHUush1KolH6T5kfs/3Bf4WjSlsA0zdOk7hB33thu8crb9CpzV zEnw== X-Gm-Message-State: AOAM530gxfidGYyT67XxM77E0uCh6lLf3wCWGYN192v309kR92Zo+Cgi lKkHwKIR2LN9kCyQo2T+rhHET5sn4DrkOqMCNK5aFQ== X-Google-Smtp-Source: ABdhPJybFZceRt4dT8AQ0A07ojtGZyNOuGQJ81eXjR+I+oeShos5q0uB3j62uLw/D28XjBH891o6E+ONKw9ot/Q+4W0= X-Received: by 2002:a05:6512:3f13:: with SMTP id y19mr12407680lfa.444.1627296058376; Mon, 26 Jul 2021 03:40:58 -0700 (PDT) MIME-Version: 1.0 References: <20210726102442.2119877-1-hsinyi@chromium.org> In-Reply-To: <20210726102442.2119877-1-hsinyi@chromium.org> From: Chen-Yu Tsai Date: Mon, 26 Jul 2021 18:40:47 +0800 Message-ID: Subject: Re: [PATCH v2] arm64: dts: mt8173: elm: Use aliases to mmc nodes To: Hsin-Yi Wang Cc: Matthias Brugger , Rob Herring , Enric Balletbo Serra , Eizan Miyamoto , Devicetree List , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210726_034100_350806_E0A876DC X-CRM114-Status: GOOD ( 19.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, Jul 26, 2021 at 6:25 PM Hsin-Yi Wang wrote: > > Use aliases to mmc nodes so the partition name for eMMC and SD card will > be consistent across boots. To be honest I think this deserves a bit more pretext: There used to be no way to specify the order of MMC controllers, and the numbering was based on how the implementations added the devices. For Linux, this changed when asynchronous probing was enabled for most drivers, resulting in mmc device numbers jumping around. With commit 1796164fac7e ("dt-bindings: mmc: document alias support"), a way to specify fixed index numbers was provided. Otherwise, Reviewed-by: Chen-Yu Tsai Same for the mt8183-kukui patch. > Signed-off-by: Hsin-Yi Wang > --- > v1->v2: skip unused mmc2. > --- > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > index 21452c51a20a8..d5a2cad39c9c7 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > @@ -10,6 +10,12 @@ > #include "mt8173.dtsi" > > / { > + aliases { > + mmc0 = &mmc0; > + mmc1 = &mmc1; > + mmc2 = &mmc3; > + }; > + > memory@40000000 { > device_type = "memory"; > reg = <0 0x40000000 0 0x80000000>; > -- > 2.32.0.432.gabb21c7263-goog > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel