From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63B19C433EF for ; Mon, 13 Sep 2021 04:53:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4374B60F9B for ; Mon, 13 Sep 2021 04:53:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231336AbhIMEyU (ORCPT ); Mon, 13 Sep 2021 00:54:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229722AbhIMEyS (ORCPT ); Mon, 13 Sep 2021 00:54:18 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0453AC061574 for ; Sun, 12 Sep 2021 21:53:02 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id h16so18323242lfk.10 for ; Sun, 12 Sep 2021 21:53:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4GP94oI8tMu6AWKPmeh+Mi99FWEewPUjupFIyk9Vgy8=; b=dy5jiiVGzeuUU3o2/KUgrSZ5nU4dGqicgHDbYfCkZ+dTO+28QM6vPMBSnfZB9xA0vR JsrU7k163qDyuxipvfEBNOaVwCopH6Us6ZtfnezWtK6Nov6EHU1jzPll20Y6SymwwAVO /qH/doGQpsWz0mI2+fGUQJ75Vw/WLAHwY8piw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4GP94oI8tMu6AWKPmeh+Mi99FWEewPUjupFIyk9Vgy8=; b=gTnjWcdZn6h0L0PaJZ38LkjeQ1hYjeQ7X0DXGMXkNOF9g5YoAJJZo/kjg7v4QAiQBd pgOfTsifIYxPG1syxUcYOX1XNkAIk3VWNAZ0h6hiewFUKZmikMGzUNWuHBijemnvebf/ 24/bf0hFtU+yMuWeujlwubDvaFNAnxBNNOHyIX/fcCzw6H3ZZbRAzvJYd9xQALNla8hf mnwqQ4Yvp1IKGaU15V+oCOwf16ID2A8cATDYgoDYDpDACUZBOESJ/XENnaQ6BtkNjEIy O7zbmmdPXpsIGok0lskwRRMMqtWqhDHTRfdp7E3JmCxpHkEDfkNZx6RhqG1nzst8WmKe FAbg== X-Gm-Message-State: AOAM531EbiyXx0EkvttAmtMGmvX8jPFTckfHhyfBHEknwyb2VzkzRzZv w6Y6FY11Qk/u7K+cIawzJ9jWBXe1dzIOMVIJKXtlP5jJmgyJxA== X-Google-Smtp-Source: ABdhPJz/3Qrvat1JZ3K+cjHFjhNfQ1Dn3Xyi3uZH6ast4XQTlgibkT6qLsGdMg9yDmhhz9D5dLFRiduzFLzRZJkmR20= X-Received: by 2002:a05:6512:c16:: with SMTP id z22mr8054334lfu.482.1631508781305; Sun, 12 Sep 2021 21:53:01 -0700 (PDT) MIME-Version: 1.0 References: <20210908111337.v2.1.I006bb36063555079b1a88f01d20e38d7e4705ae0@changeid> In-Reply-To: From: Chen-Yu Tsai Date: Mon, 13 Sep 2021 12:52:50 +0800 Message-ID: Subject: Re: [PATCH v2 1/3] clk: rockchip: rk3399: make CPU clocks critical To: Brian Norris , Heiko Stuebner Cc: Doug Anderson , Michael Turquette , Stephen Boyd , Linux ARM , "open list:ARM/Rockchip SoC..." , linux-clk , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 9, 2021 at 3:44 AM Doug Anderson wrote: > > Hi, > > On Wed, Sep 8, 2021 at 11:14 AM Brian Norris wrote: > > > > The CPU clocks don't currently have any owner (e.g., cpufreq-dt doesn't > > enable() them -- and even if it did, it's not early enough compared to > > other consumers -- nor does arch/arm64/kernel/smp.c), and instead are > > simply assumed to be "on" all the time. > > > > They are also parents of a few other clocks which haven't been > > previously exposed for other devices to consume. If we want to expose > > those clocks, then the common clock framework may eventually choose to > > disable their parents (including the CPU PLLs) -- which is no fun for > > anyone. > > > > Thus, mark the CPU clocks as critical, to prevent them from being > > disabled implicitly. > > > > Signed-off-by: Brian Norris > > --- > > > > Changes in v2: > > - New, split from the patch that requires this change > > > > drivers/clk/rockchip/clk-rk3399.c | 11 +++++++---- > > 1 file changed, 7 insertions(+), 4 deletions(-) > > Reviewed-by: Douglas Anderson Reviewed-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B2BDC433EF for ; Mon, 13 Sep 2021 04:53:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A33A60F4C for ; Mon, 13 Sep 2021 04:53:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4A33A60F4C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4IZV8B3XYc5s9vQgPl2W7zdJUei9Ts5zWIk6CZJm+QI=; b=ubWKM8m3LqXck2 Dw2H9SEeq1Q3cX8ank7516mBwuIFpdk8k++PBz5O0/t72ERljkLqnr1FXW49nAL0GYLHRxd9JADH+ lVew+q3iP8f+i0lXQbn2FJUoj137Yqt1uDOJBrq4RDgolikzEvp66z8ZnhK4oP/vgKyVmHWFES2El kSgT/Ldvk1B5bxirmWUSOoA4VQ1Y/SqdPTOmpBNT46+xAJnGqyYQZ0NitCn9COIUPz4d2GofmiBzb AoVQFMKkpVP76l8J9NlX2cAT22TCSTi6q8I0zFFQxM73C1aV7S/bQ9jYJsBu7tvJJNEHjXE4f0D42 /zyOgcagE3AKZd994nDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPdxx-000H75-0b; Mon, 13 Sep 2021 04:53:13 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPdxu-000H6R-Mo for linux-rockchip@lists.infradead.org; Mon, 13 Sep 2021 04:53:12 +0000 Received: by mail-lf1-x12e.google.com with SMTP id bq5so18307262lfb.9 for ; Sun, 12 Sep 2021 21:53:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4GP94oI8tMu6AWKPmeh+Mi99FWEewPUjupFIyk9Vgy8=; b=dy5jiiVGzeuUU3o2/KUgrSZ5nU4dGqicgHDbYfCkZ+dTO+28QM6vPMBSnfZB9xA0vR JsrU7k163qDyuxipvfEBNOaVwCopH6Us6ZtfnezWtK6Nov6EHU1jzPll20Y6SymwwAVO /qH/doGQpsWz0mI2+fGUQJ75Vw/WLAHwY8piw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4GP94oI8tMu6AWKPmeh+Mi99FWEewPUjupFIyk9Vgy8=; b=25DssGSEOMT+7mnUOASzAeXgKBCbH699++KigmRUR87vcC8QKzXVmvrJKSVRGSZRuD 1nwwS4tvXNc8TNki23x04Y23lvJWBYpz1/sYqAWDSIbq8EWGnctg4hzqz8JnfyXWK0Bw G6yx7vEbJnxWn8ZFZXLj2ynx3AvYqyimrripZ1OPyS6sJ+loCDPzkpPYx6JYpY3Le7W2 MtNsOOvpB2HpAfmMbiJ6QXpf8+fr6PQRHpKCKQaBJM4qJVcD8+j4I1UYQa/OMuw/rygm TZZ2Tntx83iKnmck4Dbs5pJylyj5M4WuJlerTP9VtIrKiPSFA1t1Pj4OC8NvpAfLuNQd XPtg== X-Gm-Message-State: AOAM533jR99Uz57kagmO1EhANdzpbrdR4TuL7K6BeRowM2UbPTgdue1u dmI8S5nCZZ+Kz35ZWTlzbKa6DHcUH+hDxueamSk/dA== X-Google-Smtp-Source: ABdhPJz/3Qrvat1JZ3K+cjHFjhNfQ1Dn3Xyi3uZH6ast4XQTlgibkT6qLsGdMg9yDmhhz9D5dLFRiduzFLzRZJkmR20= X-Received: by 2002:a05:6512:c16:: with SMTP id z22mr8054334lfu.482.1631508781305; Sun, 12 Sep 2021 21:53:01 -0700 (PDT) MIME-Version: 1.0 References: <20210908111337.v2.1.I006bb36063555079b1a88f01d20e38d7e4705ae0@changeid> In-Reply-To: From: Chen-Yu Tsai Date: Mon, 13 Sep 2021 12:52:50 +0800 Message-ID: Subject: Re: [PATCH v2 1/3] clk: rockchip: rk3399: make CPU clocks critical To: Brian Norris , Heiko Stuebner Cc: Doug Anderson , Michael Turquette , Stephen Boyd , Linux ARM , "open list:ARM/Rockchip SoC..." , linux-clk , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210912_215310_803377_186E2200 X-CRM114-Status: GOOD ( 21.03 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Thu, Sep 9, 2021 at 3:44 AM Doug Anderson wrote: > > Hi, > > On Wed, Sep 8, 2021 at 11:14 AM Brian Norris wrote: > > > > The CPU clocks don't currently have any owner (e.g., cpufreq-dt doesn't > > enable() them -- and even if it did, it's not early enough compared to > > other consumers -- nor does arch/arm64/kernel/smp.c), and instead are > > simply assumed to be "on" all the time. > > > > They are also parents of a few other clocks which haven't been > > previously exposed for other devices to consume. If we want to expose > > those clocks, then the common clock framework may eventually choose to > > disable their parents (including the CPU PLLs) -- which is no fun for > > anyone. > > > > Thus, mark the CPU clocks as critical, to prevent them from being > > disabled implicitly. > > > > Signed-off-by: Brian Norris > > --- > > > > Changes in v2: > > - New, split from the patch that requires this change > > > > drivers/clk/rockchip/clk-rk3399.c | 11 +++++++---- > > 1 file changed, 7 insertions(+), 4 deletions(-) > > Reviewed-by: Douglas Anderson Reviewed-by: Chen-Yu Tsai _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6789EC433F5 for ; Mon, 13 Sep 2021 04:55:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FC5E60F11 for ; Mon, 13 Sep 2021 04:55:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1FC5E60F11 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PctJ+894xSWrcZyu9mw0l3jM9MsGHUikCxEZi+aCxDU=; b=3x89U1+GBeiX2g rlDkfB/QmzniQ1Z0wlWwsjX2X9WIFjCqZxYX5mOczqzoP85zS6ueBWnt7G2Kmu1TtllwosaHN+gBG RsojfjdVh2ZGmMbDTPFHNzT2Qu40YzbloLhlBkJ7c8gqKHRuesh5Uqo1T07RbpNdMoxhD1hwN5dbi vOpmOJ4yhBxA2P96x1Vap9v7UJfkKH6DewWkCgsxlt/ETy5Je4RQmVE7BnoZJ8xmG67J47XEFKhWJ 7WcaMmQVwDwmIFTK8ZZ6KJhW1XsbsxTYZLonAMvGchhdqSCXFONhzCxNrtK8fItt/EAzAp6vnVE4y 90m/T9qGIC04XqX4BPug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPdxy-000H7A-Jk; Mon, 13 Sep 2021 04:53:14 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPdxu-000H6S-O7 for linux-arm-kernel@lists.infradead.org; Mon, 13 Sep 2021 04:53:12 +0000 Received: by mail-lf1-x12d.google.com with SMTP id g1so6853229lfj.12 for ; Sun, 12 Sep 2021 21:53:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4GP94oI8tMu6AWKPmeh+Mi99FWEewPUjupFIyk9Vgy8=; b=dy5jiiVGzeuUU3o2/KUgrSZ5nU4dGqicgHDbYfCkZ+dTO+28QM6vPMBSnfZB9xA0vR JsrU7k163qDyuxipvfEBNOaVwCopH6Us6ZtfnezWtK6Nov6EHU1jzPll20Y6SymwwAVO /qH/doGQpsWz0mI2+fGUQJ75Vw/WLAHwY8piw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4GP94oI8tMu6AWKPmeh+Mi99FWEewPUjupFIyk9Vgy8=; b=Cie9oGGbckGQxAYKop89UxuQNml/WbSzQKcYROsyJyxuGrT/VInfQv9iLL7kzq8aUr PNfnRCe6+db+OzgmlVLWcDgQevaw1inxwDwXPykZOGXQ06VNBUnioiPc9Bs4ljVIRULS yKt4TfiTlBZ3iv0k9/gt4RlwcKLFciFXtnVVEXGH4405QEittw7h9yIFHULcdbvu6D52 wK0Ai/RCE2ltdzYX/iLv8u56LQsje4OlQUGUMhEYQuv6HWFu/Go7dtpMLOjH3X2+BG5N mrvoI9gGEvZomMw5kg+haUiPpyno+a6XO2hUTYV8Ki1wSgRenv5dZmiAv1ulm3NlRGGn ISyg== X-Gm-Message-State: AOAM533bW3E+HwMenySewMKyhKob05hsMJOMAIxA3bgGNh9IokM4HA3M HUlc5e0MgB0HkvJLJd5o+L6w5ydYxqnj2mvbBryZ3Q== X-Google-Smtp-Source: ABdhPJz/3Qrvat1JZ3K+cjHFjhNfQ1Dn3Xyi3uZH6ast4XQTlgibkT6qLsGdMg9yDmhhz9D5dLFRiduzFLzRZJkmR20= X-Received: by 2002:a05:6512:c16:: with SMTP id z22mr8054334lfu.482.1631508781305; Sun, 12 Sep 2021 21:53:01 -0700 (PDT) MIME-Version: 1.0 References: <20210908111337.v2.1.I006bb36063555079b1a88f01d20e38d7e4705ae0@changeid> In-Reply-To: From: Chen-Yu Tsai Date: Mon, 13 Sep 2021 12:52:50 +0800 Message-ID: Subject: Re: [PATCH v2 1/3] clk: rockchip: rk3399: make CPU clocks critical To: Brian Norris , Heiko Stuebner Cc: Doug Anderson , Michael Turquette , Stephen Boyd , Linux ARM , "open list:ARM/Rockchip SoC..." , linux-clk , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210912_215310_812111_022A1910 X-CRM114-Status: GOOD ( 22.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 9, 2021 at 3:44 AM Doug Anderson wrote: > > Hi, > > On Wed, Sep 8, 2021 at 11:14 AM Brian Norris wrote: > > > > The CPU clocks don't currently have any owner (e.g., cpufreq-dt doesn't > > enable() them -- and even if it did, it's not early enough compared to > > other consumers -- nor does arch/arm64/kernel/smp.c), and instead are > > simply assumed to be "on" all the time. > > > > They are also parents of a few other clocks which haven't been > > previously exposed for other devices to consume. If we want to expose > > those clocks, then the common clock framework may eventually choose to > > disable their parents (including the CPU PLLs) -- which is no fun for > > anyone. > > > > Thus, mark the CPU clocks as critical, to prevent them from being > > disabled implicitly. > > > > Signed-off-by: Brian Norris > > --- > > > > Changes in v2: > > - New, split from the patch that requires this change > > > > drivers/clk/rockchip/clk-rk3399.c | 11 +++++++---- > > 1 file changed, 7 insertions(+), 4 deletions(-) > > Reviewed-by: Douglas Anderson Reviewed-by: Chen-Yu Tsai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel