From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38F73C433FE for ; Mon, 17 Jan 2022 07:44:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237620AbiAQHow (ORCPT ); Mon, 17 Jan 2022 02:44:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233264AbiAQHou (ORCPT ); Mon, 17 Jan 2022 02:44:50 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6735BC061574 for ; Sun, 16 Jan 2022 23:44:50 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id bu18so31276670lfb.5 for ; Sun, 16 Jan 2022 23:44:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6QF777/sKyHmB6kHdk8pAKes+SVv1gG+ocuwj9sgpRQ=; b=KOLLcV/F7XHmTeu4hItqu7+3uEtWlS6N+dsCP614S1MOSzmMSxoYjGpur5i1Y0f5of 6R0ZuL1Gz5Mg1jiAkXKtDUZCFLosWZiLjo9xhfp6ovoAfvs4Cl/WPuvWvhJW5K/UOhW4 ++Fvm3jtJK8eWY40Gfmu6WzYuye6hLY8yTocY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6QF777/sKyHmB6kHdk8pAKes+SVv1gG+ocuwj9sgpRQ=; b=JQjpenZPX3Nmc8AFjmNtA/0PQXU80wEP102h/BCDEVdIVDapT+TfX5TzMKO+t8e9HK VpFL+/C77sAh40RcYMSt+bmI71UJqqKT1R8IlkuyzRcyc2lIu96l3ajoq3F7YZ3APKV1 Aiewe2RzPLYIs445Gr+YEY75cVDGn2ZjaR9bIA8HsaMCddoi8oHqEw+cfNHVWmakhRDr K2sX9oi+K9vpRzaBAny4/a0H6KNlZI5LKQSnZWvYeHH355UnLcDYN5IVAJopmySklxes DP1z+tk9F8UW4811HPdv8oQtkmAzYzt3BuQ1NgKCRFOH5Sk4/r6wEjuSyTf0oZuGQYMO XhPw== X-Gm-Message-State: AOAM533sLvdGcyjVlAyK9RVW59eTk+nd48n+1i4PAKOEjmtkIJKsBElJ 3gOgUzBnawgjmS2bDZlmaKTmL+wI8LMTY2msUXfUEK/9N+w= X-Google-Smtp-Source: ABdhPJy2y5w2Mgw1aXOAzh5xS6yKz737iKCVZw+kmTNKVPku08/RsSvDn73bBL7Kehh87ZNxsL8F9iFaH25KR8AyLpk= X-Received: by 2002:a2e:b8d5:: with SMTP id s21mr3530683ljp.201.1642405488740; Sun, 16 Jan 2022 23:44:48 -0800 (PST) MIME-Version: 1.0 References: <20220114230209.4091727-1-briannorris@chromium.org> <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid> In-Reply-To: <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid> From: Chen-Yu Tsai Date: Mon, 17 Jan 2022 15:44:37 +0800 Message-ID: Subject: Re: [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output To: Brian Norris , Heiko Stuebner Cc: Liam Girdwood , Mark Brown , David Airlie , Daniel Vetter , linux-rockchip@lists.infradead.org, Lin Huang , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Rob Herring , Sandy Huang , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 15, 2022 at 7:03 AM Brian Norris wrote: > > Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > switched the platform to SPDIF, but we didn't fix up the device tree. > > Drop the pinctrl settings, because the 'spdif_bus' pins are either: > * unused (on kevin, bob), so the settings is ~harmless > * used by a different function (on scarlet), which causes probe > failures (!!) I suppose that means the default pinctrl should be dropped? Or maybe this use case is the outlier. Up to Heiko? > Fixes: b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > Signed-off-by: Brian Norris Reviewed-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56090C433EF for ; Mon, 17 Jan 2022 07:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lKnXoiaJKkWmJF2IkinqjLAbTBqJu6JvP1JTzxLR/ts=; b=lihpfMrfO3z8C9 jNv3wGXZMLwbLL/Hi+wsr0nSDHWN+MARtlSq6wdQLhQqI1KLsoo/7C7MKV6NyTvMqbRjgY/iIh1Vi p/EeJYxQHQOo518yvctv7SXiy5bu/KbUY+xRnOt2NWDh2a+sW4Hm7LZqqjIo/r2oFdyh/JHo7hg6Q hhcx15FmEiV3WsrNUZlZ2X0G2iZ0FEzXkm0j7Dv/Q3FqfDNTioiDqY108/q0JQJd5MsXeWafkttC6 O4l37ZdmB2xMHn6oTJJy6p/ibmQ10a7yDRo3tT9H4vTAlJ8Y0c2/+Jy9vl5O6Wef9hQnCDNjWbeHQ KNJcAaGVvkeeR4TmsfjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9MhP-00DxXx-4C; Mon, 17 Jan 2022 07:45:07 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9MhA-00DxSg-NW for linux-rockchip@lists.infradead.org; Mon, 17 Jan 2022 07:44:54 +0000 Received: by mail-lf1-x130.google.com with SMTP id x22so54202620lfd.10 for ; Sun, 16 Jan 2022 23:44:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6QF777/sKyHmB6kHdk8pAKes+SVv1gG+ocuwj9sgpRQ=; b=KOLLcV/F7XHmTeu4hItqu7+3uEtWlS6N+dsCP614S1MOSzmMSxoYjGpur5i1Y0f5of 6R0ZuL1Gz5Mg1jiAkXKtDUZCFLosWZiLjo9xhfp6ovoAfvs4Cl/WPuvWvhJW5K/UOhW4 ++Fvm3jtJK8eWY40Gfmu6WzYuye6hLY8yTocY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6QF777/sKyHmB6kHdk8pAKes+SVv1gG+ocuwj9sgpRQ=; b=5gC1iMg4HuewpLFRQJjioBjJWZdZviiaEKAs78KSJ2AoMqpWzC/AjVXpqxjqM1t9Ku npxaVcM6cEoJwBd4KiFJC7skos/GEAQkFfn94V5xGhR3f0XJLSnAR74wXLj8dfMYZJzU Rn/Wl0pvsz3hYUiFNIjOCzk0ugONMflFrGOMCpIfh/zI4ZETtfo27OACStFIIS6ZXJlO szt8Vsp5IvsMt9xNO4AQur3LfCoPGhyQzH/uhlxBPxNJBxszfo9h2hP4F3xhGjZYO3XC 3OYBMBc7BkIcNOIV6ahr2TNnZvCGVir3Qt2xNUkxOrYLW5JEO/pJQBodi+p8mxmLAjOC 8EdQ== X-Gm-Message-State: AOAM533DWD+Rw9xXndlR5SBGpzdtOM2ZoM7zRk+PCnITEoff6UP+8PiV TadZE5eVlJizPalNOpcXeqMd+qcVhYX+5fR30+a6mw== X-Google-Smtp-Source: ABdhPJy2y5w2Mgw1aXOAzh5xS6yKz737iKCVZw+kmTNKVPku08/RsSvDn73bBL7Kehh87ZNxsL8F9iFaH25KR8AyLpk= X-Received: by 2002:a2e:b8d5:: with SMTP id s21mr3530683ljp.201.1642405488740; Sun, 16 Jan 2022 23:44:48 -0800 (PST) MIME-Version: 1.0 References: <20220114230209.4091727-1-briannorris@chromium.org> <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid> In-Reply-To: <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid> From: Chen-Yu Tsai Date: Mon, 17 Jan 2022 15:44:37 +0800 Message-ID: Subject: Re: [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output To: Brian Norris , Heiko Stuebner Cc: Liam Girdwood , Mark Brown , David Airlie , Daniel Vetter , linux-rockchip@lists.infradead.org, Lin Huang , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Rob Herring , Sandy Huang , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220116_234452_784919_8D04A2B5 X-CRM114-Status: GOOD ( 11.79 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Sat, Jan 15, 2022 at 7:03 AM Brian Norris wrote: > > Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > switched the platform to SPDIF, but we didn't fix up the device tree. > > Drop the pinctrl settings, because the 'spdif_bus' pins are either: > * unused (on kevin, bob), so the settings is ~harmless > * used by a different function (on scarlet), which causes probe > failures (!!) I suppose that means the default pinctrl should be dropped? Or maybe this use case is the outlier. Up to Heiko? > Fixes: b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > Signed-off-by: Brian Norris Reviewed-by: Chen-Yu Tsai _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44607C433EF for ; Mon, 17 Jan 2022 07:44:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 434F810E224; Mon, 17 Jan 2022 07:44:51 +0000 (UTC) Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by gabe.freedesktop.org (Postfix) with ESMTPS id 815A310E224 for ; Mon, 17 Jan 2022 07:44:50 +0000 (UTC) Received: by mail-lf1-x135.google.com with SMTP id o15so54209459lfo.11 for ; Sun, 16 Jan 2022 23:44:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6QF777/sKyHmB6kHdk8pAKes+SVv1gG+ocuwj9sgpRQ=; b=KOLLcV/F7XHmTeu4hItqu7+3uEtWlS6N+dsCP614S1MOSzmMSxoYjGpur5i1Y0f5of 6R0ZuL1Gz5Mg1jiAkXKtDUZCFLosWZiLjo9xhfp6ovoAfvs4Cl/WPuvWvhJW5K/UOhW4 ++Fvm3jtJK8eWY40Gfmu6WzYuye6hLY8yTocY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6QF777/sKyHmB6kHdk8pAKes+SVv1gG+ocuwj9sgpRQ=; b=uwKIAvfGBGwWlzIW9iI46brTmefLAm/wHsYaxFgyKtIAa7mDXpB+PZLN6rmXdUTn09 0i3kQ9Xk70QfnElW2Owfj0B/hQyIqLTI9eEf1Dy9ZlyiJghknAMnupRpYLrQOOG/zUC6 U4yC18totvSbhjmSfNymCnEEXCOHHpVyx52IF+4Imei2skd2XHjGFqwFGqCDtKUQRXwF d1hPWAtPT/V61pot6VOQNck2cWyPGQuSuQ2fuKV3V0H72u+Zh57WuTXZcuiRzpI4oAVw 3Z0geoeFw54ZyFi2LPEnHUbBxF71F0eDkPLve/ROnlgLgFox4GlW1s3dQxthOEyNjjB/ DXpA== X-Gm-Message-State: AOAM532UG46EtuDwLmLwUaAvPF7aYsUOQTX1+HgZdzDVY3bNf62sDbY9 hpdRes6lfyA0wDDMH5Carqy9ZC99E2lSUECqSeF4HA== X-Google-Smtp-Source: ABdhPJy2y5w2Mgw1aXOAzh5xS6yKz737iKCVZw+kmTNKVPku08/RsSvDn73bBL7Kehh87ZNxsL8F9iFaH25KR8AyLpk= X-Received: by 2002:a2e:b8d5:: with SMTP id s21mr3530683ljp.201.1642405488740; Sun, 16 Jan 2022 23:44:48 -0800 (PST) MIME-Version: 1.0 References: <20220114230209.4091727-1-briannorris@chromium.org> <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid> In-Reply-To: <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid> From: Chen-Yu Tsai Date: Mon, 17 Jan 2022 15:44:37 +0800 Message-ID: Subject: Re: [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output To: Brian Norris , Heiko Stuebner Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Lin Huang , David Airlie , linux-kernel@vger.kernel.org, Liam Girdwood , dri-devel@lists.freedesktop.org, Sandy Huang , linux-rockchip@lists.infradead.org, Mark Brown , Rob Herring , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Jan 15, 2022 at 7:03 AM Brian Norris wrote: > > Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > switched the platform to SPDIF, but we didn't fix up the device tree. > > Drop the pinctrl settings, because the 'spdif_bus' pins are either: > * unused (on kevin, bob), so the settings is ~harmless > * used by a different function (on scarlet), which causes probe > failures (!!) I suppose that means the default pinctrl should be dropped? Or maybe this use case is the outlier. Up to Heiko? > Fixes: b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > Signed-off-by: Brian Norris Reviewed-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 302D9C433F5 for ; Mon, 17 Jan 2022 07:45:52 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 555BC177E; Mon, 17 Jan 2022 08:45:00 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 555BC177E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1642405550; bh=JxYgoPbkndzvmKJRNxA42LNvG043BEkPzvQ8KZ9Km0A=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=qMaNVruMvISE4YNz21F/1KZ/KMbiPhH5QPwhasp2sAdtKsyz+n3hZAgIRMaAQhCo2 bMqelZwxlFV0GYBLwn+YbyXYm4oakUO1UWHKKa7j/ZW6J0Au2/jMQi9vL9IjdyfBkW ZChY5pEEFTBLCWtJ9fSaJnjFc0fF+DxKPZLZNCHQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CC201F8014B; Mon, 17 Jan 2022 08:44:59 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4F8CFF80249; Mon, 17 Jan 2022 08:44:57 +0100 (CET) Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 99329F80100 for ; Mon, 17 Jan 2022 08:44:50 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 99329F80100 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="KOLLcV/F" Received: by mail-lf1-x136.google.com with SMTP id br17so54307958lfb.6 for ; Sun, 16 Jan 2022 23:44:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6QF777/sKyHmB6kHdk8pAKes+SVv1gG+ocuwj9sgpRQ=; b=KOLLcV/F7XHmTeu4hItqu7+3uEtWlS6N+dsCP614S1MOSzmMSxoYjGpur5i1Y0f5of 6R0ZuL1Gz5Mg1jiAkXKtDUZCFLosWZiLjo9xhfp6ovoAfvs4Cl/WPuvWvhJW5K/UOhW4 ++Fvm3jtJK8eWY40Gfmu6WzYuye6hLY8yTocY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6QF777/sKyHmB6kHdk8pAKes+SVv1gG+ocuwj9sgpRQ=; b=4q/5umVgWvYPN2BHs3CPwFN0Rumb7bshgvdLMe+5weaMP6fTmMZQ8wnu2AxN/QhMzL S1xnx73FXg7I2dA2d17X3DRihrUW2oGGDj5SLSVdaIlDQw7/64zh+ZJzNYhEP+PQLEPT WGJOABtnqMM8HTEbPBj3aL22r7jpcHPDeiAsNDrYH1Q5DEHpgFQYS8C1wEu6hyL5HNKX szS3qOh+pnAtusH3tWTqbUqLgclxTMtFp5y6jPVEwUVh3NqM1tfWNlmTDLRDQNWTv2VA rVe/9+raX6FquXOZgK4bvVmfl1w50hm2WPlA2ZpW34DrLQN2lIefO3L3mBFGotL1tBNi utNw== X-Gm-Message-State: AOAM531haV6PL19vIeImKEQQ4OaZIB5mby1ICaXIPgcjErS+RykV3vq3 OwlF9ht+UPaGpjztGu3CSX0k75cxfGRsVnGGEuWKaA== X-Google-Smtp-Source: ABdhPJy2y5w2Mgw1aXOAzh5xS6yKz737iKCVZw+kmTNKVPku08/RsSvDn73bBL7Kehh87ZNxsL8F9iFaH25KR8AyLpk= X-Received: by 2002:a2e:b8d5:: with SMTP id s21mr3530683ljp.201.1642405488740; Sun, 16 Jan 2022 23:44:48 -0800 (PST) MIME-Version: 1.0 References: <20220114230209.4091727-1-briannorris@chromium.org> <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid> In-Reply-To: <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid> From: Chen-Yu Tsai Date: Mon, 17 Jan 2022 15:44:37 +0800 Message-ID: Subject: Re: [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output To: Brian Norris , Heiko Stuebner Content-Type: text/plain; charset="UTF-8" Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Lin Huang , David Airlie , linux-kernel@vger.kernel.org, Liam Girdwood , dri-devel@lists.freedesktop.org, Sandy Huang , linux-rockchip@lists.infradead.org, Mark Brown , Daniel Vetter , Rob Herring , linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, Jan 15, 2022 at 7:03 AM Brian Norris wrote: > > Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > switched the platform to SPDIF, but we didn't fix up the device tree. > > Drop the pinctrl settings, because the 'spdif_bus' pins are either: > * unused (on kevin, bob), so the settings is ~harmless > * used by a different function (on scarlet), which causes probe > failures (!!) I suppose that means the default pinctrl should be dropped? Or maybe this use case is the outlier. Up to Heiko? > Fixes: b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > Signed-off-by: Brian Norris Reviewed-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07958C433EF for ; Mon, 17 Jan 2022 07:46:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pQMOB/3bRl5xznmUd0Xr1sjbMZ2yOxjqMjXxPURHR3A=; b=4Ad3Nz4DDT+HFQ K1kdHTKTejkpF2aA1aDFggeLn/DbKZnOy5uULW4eEHcyHFPvA7QlZWQTvCArPwPv5Qhi8fEaO6LP3 1tdP99YJimoBZYw+6xDNHQL//B/S/o5kxdMHhCKZm50JXomzUp2c1gRR+4/kovZzNHxfT4tqxnhWK C+7aBeR0mFkRJGndjZZjw21+0u3mTokWRo4LaUQhosPyFQCtua9BjHNjGWuU3G+4/hpk2jZVJKFJP tTDIG2HO4X9Mfej+8YE/eMSyFCzZ4UVtfrT9m0PgnyztyesK28+8ItUtCtlE5FqNPbtuIatPeHDQW sZoyjhAXmokGw9kFlumA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9MhD-00DxUO-5Q; Mon, 17 Jan 2022 07:44:55 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9MhA-00DxSf-N7 for linux-arm-kernel@lists.infradead.org; Mon, 17 Jan 2022 07:44:53 +0000 Received: by mail-lf1-x12f.google.com with SMTP id m1so54330709lfq.4 for ; Sun, 16 Jan 2022 23:44:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6QF777/sKyHmB6kHdk8pAKes+SVv1gG+ocuwj9sgpRQ=; b=KOLLcV/F7XHmTeu4hItqu7+3uEtWlS6N+dsCP614S1MOSzmMSxoYjGpur5i1Y0f5of 6R0ZuL1Gz5Mg1jiAkXKtDUZCFLosWZiLjo9xhfp6ovoAfvs4Cl/WPuvWvhJW5K/UOhW4 ++Fvm3jtJK8eWY40Gfmu6WzYuye6hLY8yTocY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6QF777/sKyHmB6kHdk8pAKes+SVv1gG+ocuwj9sgpRQ=; b=I3HMgEZxSkJRlqObz3dQuct90gi/FP7pzj8J293QTAY1ieFLoU+SYpd4H6078XPsd3 ZiaxS383FBX5QQFFMZ3uM7RRgsaqrYGBQwJRJx7561jlxHTiuGAVHtWh2tOEZM5AHq6J xfORao1czVRsje2oTwyUKJfCZUCqqqEtCaJGJYUmXx6HwsXFspVBmgAl5CC5scrElouy ZHv9WDu8BdUT9TEalNB7WylAJetxqUAj1ZO8svnrjZeTp8a6VcGJN+PvEGTWD2zXgc7/ MXD42XYs2x+7XacXbRd9E/7lY9Ij4GiQR9ExICpvvyXsplJ02kUWvxSpAM6jC8gxeiOZ lSHQ== X-Gm-Message-State: AOAM530LqR7QJH2+opaHlcja0F5zaeponnqZicWAtyRYzSDv5wBngEoT l2RdfsVCh13gwF17ra7wiJkIuK7QwxfNIfd7PcaepA== X-Google-Smtp-Source: ABdhPJy2y5w2Mgw1aXOAzh5xS6yKz737iKCVZw+kmTNKVPku08/RsSvDn73bBL7Kehh87ZNxsL8F9iFaH25KR8AyLpk= X-Received: by 2002:a2e:b8d5:: with SMTP id s21mr3530683ljp.201.1642405488740; Sun, 16 Jan 2022 23:44:48 -0800 (PST) MIME-Version: 1.0 References: <20220114230209.4091727-1-briannorris@chromium.org> <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid> In-Reply-To: <20220114150129.v2.1.I46f64b00508d9dff34abe1c3e8d2defdab4ea1e5@changeid> From: Chen-Yu Tsai Date: Mon, 17 Jan 2022 15:44:37 +0800 Message-ID: Subject: Re: [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output To: Brian Norris , Heiko Stuebner Cc: Liam Girdwood , Mark Brown , David Airlie , Daniel Vetter , linux-rockchip@lists.infradead.org, Lin Huang , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Rob Herring , Sandy Huang , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220116_234452_773457_62499138 X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jan 15, 2022 at 7:03 AM Brian Norris wrote: > > Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > switched the platform to SPDIF, but we didn't fix up the device tree. > > Drop the pinctrl settings, because the 'spdif_bus' pins are either: > * unused (on kevin, bob), so the settings is ~harmless > * used by a different function (on scarlet), which causes probe > failures (!!) I suppose that means the default pinctrl should be dropped? Or maybe this use case is the outlier. Up to Heiko? > Fixes: b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif") > Signed-off-by: Brian Norris Reviewed-by: Chen-Yu Tsai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel