From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34E10C4332F for ; Fri, 30 Dec 2022 05:17:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234395AbiL3FRh (ORCPT ); Fri, 30 Dec 2022 00:17:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234234AbiL3FR0 (ORCPT ); Fri, 30 Dec 2022 00:17:26 -0500 Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com [IPv6:2607:f8b0:4864:20::e2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D87831838B for ; Thu, 29 Dec 2022 21:17:22 -0800 (PST) Received: by mail-vs1-xe2c.google.com with SMTP id k4so16285064vsc.4 for ; Thu, 29 Dec 2022 21:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dEYbMSY9mT2OK2c114me8utvLFZz2JqIKXFmopSmQiw=; b=RKih9fLMpxINT80ky9qXSQ53n2p/gq4DqtkictxoVB6aWfa9UX7D6geobbaZRNdi9V cD0zg7UKY1wl5gpbFTbIxiJlMqwsZOqM7dtq2O2aTqKYFqeoSA4YkrNJktTS7P3yDmJW NVl1tmtgJy8t3YgObj5WvVVF6dgavhZvjCHDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dEYbMSY9mT2OK2c114me8utvLFZz2JqIKXFmopSmQiw=; b=DIzyIYkj34eNn6UGGiYqvHjqNYFat2aYOyTdMq5iBfr2xFVWoW14ixeGEO6pHQXLn/ JZsp3jYJcUUiE9sOhMgfAlZ9p3anvBCRA+nvo5K//AUIpXJlEuVzGwpPTg/iAiyB/I4H YQFZtDXhPlPVw9JFNeE5ircRUyGX2YaVNZm1xUyUxR+uIVh5nSU7CMIw4afrCVMzNgU1 YI8VWmXhTjea+mhEUeX1PCn2fllPbpZg1VtCAdl4ovU6nJQzXnzx65nxUNXMTOYM+dRi eujGsGpT4b3p9wws5J8+Gvo2l3zLh69ws4IBgY9cbecl1wOIRhalzAMXIXXFaV3ALNBM B5MA== X-Gm-Message-State: AFqh2ko2pk20Z3LAf5innyuoQ81BwwbHpIKpZyCl3q4GWKF+rRlkOfkM sSSXM6WJdLgDGFYJINzGRXaxL3jRM6t5t4X+I5mBCQ== X-Google-Smtp-Source: AMrXdXtbyCSpMJ4eNW7yhoCCnZ4ewGuLOy71q3P5g49tLuLwFTAwiq8BtlKIVACuyhU5eRY9Mp/AdemXnMQUi2cYMbk= X-Received: by 2002:a67:f985:0:b0:3b3:7477:5aa2 with SMTP id b5-20020a67f985000000b003b374775aa2mr3636972vsq.65.1672377442038; Thu, 29 Dec 2022 21:17:22 -0800 (PST) MIME-Version: 1.0 References: <20221223094259.87373-1-angelogioacchino.delregno@collabora.com> <20221223094259.87373-15-angelogioacchino.delregno@collabora.com> In-Reply-To: <20221223094259.87373-15-angelogioacchino.delregno@collabora.com> From: Chen-Yu Tsai Date: Fri, 30 Dec 2022 13:17:11 +0800 Message-ID: Subject: Re: [PATCH v2 14/23] clk: mediatek: clk-mt8192: Move CLK_TOP_CSW_F26M_D2 in top_divs To: AngeloGioacchino Del Regno Cc: mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johnson.wang@mediatek.com, miles.chen@mediatek.com, fparent@baylibre.com, chun-jie.chen@mediatek.com, sam.shih@mediatek.com, y.oudjana@protonmail.com, nfraprado@collabora.com, rex-bc.chen@mediatek.com, ryder.lee@kernel.org, daniel@makrotopia.org, jose.exposito89@gmail.com, yangyingliang@huawei.com, pablo.sun@mediatek.com, msp@baylibre.com, weiyi.lu@mediatek.com, ikjn@chromium.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 23, 2022 at 5:43 PM AngeloGioacchino Del Regno wrote: > > This driver is registered early in clk_mt8192_top_init_early() and > then again in clk_mt8192_top_probe(): the difference between the > two is that the early one is probed with CLK_OF_DECLARE_DRIVER and > the latter is regularly probed as a platform_driver. > > Knowing that it is not necessary for this platform to register the > TOP_CSW_F26M_D2 clock that early, move it to top_divs and register > it with the others during platform_driver probe for topckgen; > > While at it, since the only reason why the early probe existed was > to register that clock, remove that entirely - leaving this driver > to use only platform_driver. > > Signed-off-by: AngeloGioacchino Del Regno I had some other changes dealing with this, but since the systimer DT fixes have been merged, and this is cleaner, Reviewed-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAF8CC4332F for ; Fri, 30 Dec 2022 05:18:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xIhTCPo6s0V5dZHXWRB2usaVUMPtb4oe0LrysGo5RWE=; b=FBtUwYznxSzKOu 6maHrbpxN+HeVZXR6i4HBjLoECrve05ALpV6r9LhvZzKkFr+PZzzjfBtRBpZk+scC/h174TgT+njt agzg+lb+QnMPI9b5TFXFJsmc+kzHyHOI751z1qDcu0/2hLFTnP3j/VB7cVdqqbHmEkWHHkSqlo94U tiRPsXjNyxgNWvgyuJsxOluj4qUXA749zXFTbCjSmvFhVKyff4W7qWbAtzTVU8rTdDY//LNmLXOw4 z6969Jho/MQ2O2Yh1lLWlgO+112RPZIpTSqVPkAj16E3vARmpU9UfZstxxV4G+3N16j33Ny+SGkWm VV8jjYt/XYZJisIQQBRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pB7lo-005smM-7E; Fri, 30 Dec 2022 05:17:28 +0000 Received: from mail-vs1-xe2c.google.com ([2607:f8b0:4864:20::e2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pB7lj-005skB-QI for linux-arm-kernel@lists.infradead.org; Fri, 30 Dec 2022 05:17:25 +0000 Received: by mail-vs1-xe2c.google.com with SMTP id x65so6865994vsb.13 for ; Thu, 29 Dec 2022 21:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dEYbMSY9mT2OK2c114me8utvLFZz2JqIKXFmopSmQiw=; b=RKih9fLMpxINT80ky9qXSQ53n2p/gq4DqtkictxoVB6aWfa9UX7D6geobbaZRNdi9V cD0zg7UKY1wl5gpbFTbIxiJlMqwsZOqM7dtq2O2aTqKYFqeoSA4YkrNJktTS7P3yDmJW NVl1tmtgJy8t3YgObj5WvVVF6dgavhZvjCHDA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dEYbMSY9mT2OK2c114me8utvLFZz2JqIKXFmopSmQiw=; b=kTTxOQR9C5DfAv/EeRGj9oLBeosqoznvWggqAzzz66GGbRoCCDTjrnrUbQJagZ0xPo aHYRM6GzYRtJC3dC7WdeYgRoQCDdWbq9fXf23WcfDcDIJSExTzD2eN0PDOr9aohxQt4V MX+4Px+071VO1//PWzqXpAxR7y2LWyBkBSctOWAVEZLVxsByIEArBFoSJvNi+sapkJT8 gs/Jz3vYEh8KoG/GXtE6BKKTPFNvXDiHJiWkydT/1isL6T0u+NbjFJl7fjkY2HXlzk+T IysH/ZsSMwNJLaGgseH1TGAZWGDgT9JvsxSRD/k0RMgUT4ta5K2d8hYPHb7hYexKNPxi r5CA== X-Gm-Message-State: AFqh2koAaew5eTG+4nrh/viyBlWew1rIXB2bH8FfaLHscE5z9Gim3s2l 0Mr6RCrjds0N1MdY084QD9tTevJqGU5+aWbnCOzVhA== X-Google-Smtp-Source: AMrXdXtbyCSpMJ4eNW7yhoCCnZ4ewGuLOy71q3P5g49tLuLwFTAwiq8BtlKIVACuyhU5eRY9Mp/AdemXnMQUi2cYMbk= X-Received: by 2002:a67:f985:0:b0:3b3:7477:5aa2 with SMTP id b5-20020a67f985000000b003b374775aa2mr3636972vsq.65.1672377442038; Thu, 29 Dec 2022 21:17:22 -0800 (PST) MIME-Version: 1.0 References: <20221223094259.87373-1-angelogioacchino.delregno@collabora.com> <20221223094259.87373-15-angelogioacchino.delregno@collabora.com> In-Reply-To: <20221223094259.87373-15-angelogioacchino.delregno@collabora.com> From: Chen-Yu Tsai Date: Fri, 30 Dec 2022 13:17:11 +0800 Message-ID: Subject: Re: [PATCH v2 14/23] clk: mediatek: clk-mt8192: Move CLK_TOP_CSW_F26M_D2 in top_divs To: AngeloGioacchino Del Regno Cc: mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johnson.wang@mediatek.com, miles.chen@mediatek.com, fparent@baylibre.com, chun-jie.chen@mediatek.com, sam.shih@mediatek.com, y.oudjana@protonmail.com, nfraprado@collabora.com, rex-bc.chen@mediatek.com, ryder.lee@kernel.org, daniel@makrotopia.org, jose.exposito89@gmail.com, yangyingliang@huawei.com, pablo.sun@mediatek.com, msp@baylibre.com, weiyi.lu@mediatek.com, ikjn@chromium.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221229_211723_858495_108E0BBC X-CRM114-Status: GOOD ( 13.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 23, 2022 at 5:43 PM AngeloGioacchino Del Regno wrote: > > This driver is registered early in clk_mt8192_top_init_early() and > then again in clk_mt8192_top_probe(): the difference between the > two is that the early one is probed with CLK_OF_DECLARE_DRIVER and > the latter is regularly probed as a platform_driver. > > Knowing that it is not necessary for this platform to register the > TOP_CSW_F26M_D2 clock that early, move it to top_divs and register > it with the others during platform_driver probe for topckgen; > > While at it, since the only reason why the early probe existed was > to register that clock, remove that entirely - leaving this driver > to use only platform_driver. > > Signed-off-by: AngeloGioacchino Del Regno I had some other changes dealing with this, but since the systimer DT fixes have been merged, and this is cleaner, Reviewed-by: Chen-Yu Tsai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel