From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D8FCC07E9B for ; Mon, 12 Jul 2021 09:39:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53E586101E for ; Mon, 12 Jul 2021 09:39:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237525AbhGLJmh (ORCPT ); Mon, 12 Jul 2021 05:42:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381969AbhGLJk5 (ORCPT ); Mon, 12 Jul 2021 05:40:57 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CAC6C0613E8 for ; Mon, 12 Jul 2021 02:38:09 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id n14so42082913lfu.8 for ; Mon, 12 Jul 2021 02:38:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fxJCUCjSlgXxGDjLXHj9U/H++hzbmhE6H12woYxnzEo=; b=kEXIVazNxdPeQjIQRJkZ34NK8TOWTN8cN3PTg4u6h+qBpMX/8NP2QnXimoDsrD47U1 Nx9WHbWZ5zUBwObZWK89MK5QKklyaL19EKODkPwj8rr8NhSRf6ZHb7DGRkq9nGOS6W6s rlmPcHBaJlpyL6qugKjw7qGyQhPNR06FjEh2o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fxJCUCjSlgXxGDjLXHj9U/H++hzbmhE6H12woYxnzEo=; b=Df1muPtx7PMlqfD9fTYZzvwkGShUTseS0lHhN+msA9WGyCPCyT04E0YNIqhNGO6YnY L7/hL68maKmejxkN2u0En+DCC4yYNmvRyJEEDYJ8h7uNU5MhfNLyc15wNEOug0RisQV3 rkxRzEWUqrpk/Kz/S1r0OtTvS9c9ylUZIwbxDTezfHWDfseS/NZo5h4xatzi9RD6nedN fxuBJIOMHBV8OSC7hpAZ99YM8qBbzcWIVIDURQlU0KxrAuCv3QOahCjfnxtEGiVhd/Rw QM6BurWAz4ILa0HvH3EL8rY6EHe1HTw9IyOAmkKhsy8OseJnkLlb+lDq7MM37p+ufYC4 b0Zw== X-Gm-Message-State: AOAM531O2phfI1X+qXgqNah4XesmVsrjiCFWHS8mLMGqCVz1NajxlgXI Ue2xxsVeHMnAjIauXH8zqh24dYchSNJvF7gWceMlJQ== X-Google-Smtp-Source: ABdhPJxQC8DmA5HEXaqu0oHdMTjSbon83tv6yVWxtwXNhe/ty5TRr6RQ+xzlTDU/2wgHcAMAinpsKbdHUu82InisZBc= X-Received: by 2002:a19:858b:: with SMTP id h133mr20580359lfd.656.1626082687405; Mon, 12 Jul 2021 02:38:07 -0700 (PDT) MIME-Version: 1.0 References: <20210616224743.5109-1-chun-jie.chen@mediatek.com> <20210616224743.5109-3-chun-jie.chen@mediatek.com> In-Reply-To: <20210616224743.5109-3-chun-jie.chen@mediatek.com> From: Chen-Yu Tsai Date: Mon, 12 Jul 2021 17:37:56 +0800 Message-ID: Subject: Re: [PATCH 02/22] clk: mediatek: Add dt-bindings of MT8195 clocks To: Chun-Jie Chen Cc: Matthias Brugger , Stephen Boyd , Nicolas Boichat , Rob Herring , linux-arm-kernel@lists.infradead.org, LKML , linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, srv_heupstream , Project_Global_Chrome_Upstream_Group Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Jun 17, 2021 at 7:02 AM Chun-Jie Chen wrote: > > Add MT8195 clock dt-bindings, include topckgen, apmixedsys, > infracfg_ao, pericfg_ao and subsystem clocks. > > Signed-off-by: Chun-Jie Chen > --- > include/dt-bindings/clock/mt8195-clk.h | 989 +++++++++++++++++++++++++ > 1 file changed, 989 insertions(+) This is a really long list. I don't think all of them need to be exposed, especially the intermediate ones in TOPCKGEN. In such cases the not-to-be- exposed clock indices could be moved to a header file in the driver directory, or simply left out. The Allwinner/sunxi-ng drivers do the former while the Rockchip drivers do the latter. The Mediatek clock drivers are more similar in structure and design to the Rockchip ones. Regards ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20F31C07E99 for ; Mon, 12 Jul 2021 09:38:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC2B36108B for ; Mon, 12 Jul 2021 09:38:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC2B36108B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dvIVckVxD1N7hGuZnMgktUVFio2oFWi3IoHwseMmZTk=; b=n1WWFyPjX091UD EDxEVt+lqQ2TnXWuHhsErTwwtyHCSdqQkUnfJyMm4TYs/gJmFgPa53X5h0Sv3+LO+AKCFFKcv1aHy EgT7qC75cmm1VkLtsnx2ubMQpu/y6cvp7WKc4qPSs5MBBAskZtYhg8Kzll1Q/OSXXoN97iDhnTLZy rAZ4p+kyUe5daTUSra+vmS4Oa/AIg+wdsHQWXWwrKxuO5hDIVs9u8QD7vsFmhuXAxtjOEPWBTEzFW Wc8PUk09+AqaM4/BN9de3FFGEgnT4E6R9zML0msdgl9q1uGgB6uolzLIwFl+fW+ajMbRG8cV8ltyI j/MtJSmtDgz+ndBBl2+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2sOM-006lZ4-NF; Mon, 12 Jul 2021 09:38:22 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2sO9-006lWn-G4 for linux-mediatek@lists.infradead.org; Mon, 12 Jul 2021 09:38:10 +0000 Received: by mail-lf1-x12f.google.com with SMTP id f30so42129192lfj.1 for ; Mon, 12 Jul 2021 02:38:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fxJCUCjSlgXxGDjLXHj9U/H++hzbmhE6H12woYxnzEo=; b=kEXIVazNxdPeQjIQRJkZ34NK8TOWTN8cN3PTg4u6h+qBpMX/8NP2QnXimoDsrD47U1 Nx9WHbWZ5zUBwObZWK89MK5QKklyaL19EKODkPwj8rr8NhSRf6ZHb7DGRkq9nGOS6W6s rlmPcHBaJlpyL6qugKjw7qGyQhPNR06FjEh2o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fxJCUCjSlgXxGDjLXHj9U/H++hzbmhE6H12woYxnzEo=; b=Yh9Mjjuyb01rYKzURpBC8W8RZaYD6gq3YaUPoBIiwcsQrEX7naJ9QFaytRTyzALSLY XPcMO1FHW+EptiFxTiDmnuDtnYO8+LVjS1C3DDoldlrrFpr20TkbWeLwPK+qeSsGw5qp jyAQ6/b0u0g9RR/TciCg73AJlaOTLhOAhLrdoKNwYUTnOqs4YxV5OQV8wY7XVVDYTc7c 5cIOuk+1i76P6SZacQeXcMglc7blrSampTsNY+gcE5p7YWvKLGgrLxFerqWFtAZwQlN6 40qyz8tbbxhqSw6Yz3UG65tY4vJeIIM92sta+zkx6Ofqp9cCwu4CQSWNfLKFo4zIF4XV QCgw== X-Gm-Message-State: AOAM532Q2gxj33Shq8rZF8a4kj+qYBbqv2vTYnDJSMpfHeZB/LHQfVjI a1tDtB8bYoWLFY9kvbHIErU5jGOp3MkrmXJghep1NQ== X-Google-Smtp-Source: ABdhPJxQC8DmA5HEXaqu0oHdMTjSbon83tv6yVWxtwXNhe/ty5TRr6RQ+xzlTDU/2wgHcAMAinpsKbdHUu82InisZBc= X-Received: by 2002:a19:858b:: with SMTP id h133mr20580359lfd.656.1626082687405; Mon, 12 Jul 2021 02:38:07 -0700 (PDT) MIME-Version: 1.0 References: <20210616224743.5109-1-chun-jie.chen@mediatek.com> <20210616224743.5109-3-chun-jie.chen@mediatek.com> In-Reply-To: <20210616224743.5109-3-chun-jie.chen@mediatek.com> From: Chen-Yu Tsai Date: Mon, 12 Jul 2021 17:37:56 +0800 Message-ID: Subject: Re: [PATCH 02/22] clk: mediatek: Add dt-bindings of MT8195 clocks To: Chun-Jie Chen Cc: Matthias Brugger , Stephen Boyd , Nicolas Boichat , Rob Herring , linux-arm-kernel@lists.infradead.org, LKML , linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, srv_heupstream , Project_Global_Chrome_Upstream_Group X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210712_023809_562851_4423EB30 X-CRM114-Status: GOOD ( 12.64 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, On Thu, Jun 17, 2021 at 7:02 AM Chun-Jie Chen wrote: > > Add MT8195 clock dt-bindings, include topckgen, apmixedsys, > infracfg_ao, pericfg_ao and subsystem clocks. > > Signed-off-by: Chun-Jie Chen > --- > include/dt-bindings/clock/mt8195-clk.h | 989 +++++++++++++++++++++++++ > 1 file changed, 989 insertions(+) This is a really long list. I don't think all of them need to be exposed, especially the intermediate ones in TOPCKGEN. In such cases the not-to-be- exposed clock indices could be moved to a header file in the driver directory, or simply left out. The Allwinner/sunxi-ng drivers do the former while the Rockchip drivers do the latter. The Mediatek clock drivers are more similar in structure and design to the Rockchip ones. Regards ChenYu _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46FD9C07E99 for ; Mon, 12 Jul 2021 09:39:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 055FB60FE9 for ; Mon, 12 Jul 2021 09:39:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 055FB60FE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YmFCbbSMyN7sZFw4mLj/7t2ZOHhO5p7LF//ua4rXLds=; b=n1EkNzAmMlsgs2 5We8MvWAOA6kcQ0VAgdjf3phv0sSClc0ZhfgOwLhsBkvVm8ozfTneQ+GNmwXvMvnub2AOQ/wWZ2eK 9WdqE8n2b0dj6Bppn89ClHC9TSyYninr4k9tM7Eb8/XWQ9fCu6LQIksou2G8gcluLhJmrRWxfeavW YxedS1jM0Bv5DSPlOytW9Y7xcUb/AkMg3kGuUPCy8jdGwXix4zFEyJguBPU3SvczapUWq+YS5yG1B nOrruppGvlbPF2VaA9LbRZS7acZvGCtyRGxQIRhXIC19kGJsh1S8ph3JSwzkSRz32hvHkz7RPom2R 2j6i/ZT2Au+VzKMDjoXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2sOD-006lXe-A3; Mon, 12 Jul 2021 09:38:13 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m2sO9-006lWo-C6 for linux-arm-kernel@lists.infradead.org; Mon, 12 Jul 2021 09:38:10 +0000 Received: by mail-lf1-x129.google.com with SMTP id i5so12273488lfe.2 for ; Mon, 12 Jul 2021 02:38:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fxJCUCjSlgXxGDjLXHj9U/H++hzbmhE6H12woYxnzEo=; b=kEXIVazNxdPeQjIQRJkZ34NK8TOWTN8cN3PTg4u6h+qBpMX/8NP2QnXimoDsrD47U1 Nx9WHbWZ5zUBwObZWK89MK5QKklyaL19EKODkPwj8rr8NhSRf6ZHb7DGRkq9nGOS6W6s rlmPcHBaJlpyL6qugKjw7qGyQhPNR06FjEh2o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fxJCUCjSlgXxGDjLXHj9U/H++hzbmhE6H12woYxnzEo=; b=N85MGF6HIRbXILl+1UEbiiVQKF+ecuuOXqCWdmumEDWpsRSv+HzpvzPnx/a6aZvUYR ZAqJG48juODPye5Cm9AcWRljqLWcHn/Vv2Yet9AwiojVIaK+2+nA5hDPSZ002nQU4mrt DQNVhfMff7UAY2lPI83fKOC9Gn4TJ9Uq+GyIZBqCYMDqG7sFDHMTSVjO/aMhJSeWuGa9 5vMYizY8IPkH4qMsOyvuNpqWBOvgOpJiNQjUJE6xc5fzQgt6jye8M+CcybGi+uBL4Z0R QA6A+DPzQwVExVbLYW7qcAjOUsvOifRDLCWNjPVOsi5i7ix5jqblJI6OdJ2wJHQUdHl6 z/lw== X-Gm-Message-State: AOAM531Ua7lUOcvj2J21wgJIQXbPhMrPO0+4QPpsrfByzA4R7NFmngM8 qwu9AtmHn3Skdgs7WXm200mdEZud15tWOUQEZpHyaQ== X-Google-Smtp-Source: ABdhPJxQC8DmA5HEXaqu0oHdMTjSbon83tv6yVWxtwXNhe/ty5TRr6RQ+xzlTDU/2wgHcAMAinpsKbdHUu82InisZBc= X-Received: by 2002:a19:858b:: with SMTP id h133mr20580359lfd.656.1626082687405; Mon, 12 Jul 2021 02:38:07 -0700 (PDT) MIME-Version: 1.0 References: <20210616224743.5109-1-chun-jie.chen@mediatek.com> <20210616224743.5109-3-chun-jie.chen@mediatek.com> In-Reply-To: <20210616224743.5109-3-chun-jie.chen@mediatek.com> From: Chen-Yu Tsai Date: Mon, 12 Jul 2021 17:37:56 +0800 Message-ID: Subject: Re: [PATCH 02/22] clk: mediatek: Add dt-bindings of MT8195 clocks To: Chun-Jie Chen Cc: Matthias Brugger , Stephen Boyd , Nicolas Boichat , Rob Herring , linux-arm-kernel@lists.infradead.org, LKML , linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, srv_heupstream , Project_Global_Chrome_Upstream_Group X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210712_023809_466214_1C99BEF6 X-CRM114-Status: GOOD ( 13.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Thu, Jun 17, 2021 at 7:02 AM Chun-Jie Chen wrote: > > Add MT8195 clock dt-bindings, include topckgen, apmixedsys, > infracfg_ao, pericfg_ao and subsystem clocks. > > Signed-off-by: Chun-Jie Chen > --- > include/dt-bindings/clock/mt8195-clk.h | 989 +++++++++++++++++++++++++ > 1 file changed, 989 insertions(+) This is a really long list. I don't think all of them need to be exposed, especially the intermediate ones in TOPCKGEN. In such cases the not-to-be- exposed clock indices could be moved to a header file in the driver directory, or simply left out. The Allwinner/sunxi-ng drivers do the former while the Rockchip drivers do the latter. The Mediatek clock drivers are more similar in structure and design to the Rockchip ones. Regards ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel