From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAB12C3DA7C for ; Fri, 30 Dec 2022 06:42:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234462AbiL3Gm5 (ORCPT ); Fri, 30 Dec 2022 01:42:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229557AbiL3Gmy (ORCPT ); Fri, 30 Dec 2022 01:42:54 -0500 Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4D78186A9 for ; Thu, 29 Dec 2022 22:42:51 -0800 (PST) Received: by mail-vs1-xe29.google.com with SMTP id 3so20473468vsq.7 for ; Thu, 29 Dec 2022 22:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XrpQaBNpbz5C7gEc30JXJD4ksBAoVukkRs4REF7J3cA=; b=ieXRxqKlr8oyA7r8oWv5vNjeFdB1A3ZleV0nsNDeN+cCb+ZLeuFA5X93VFGh/jXSpy 8vhLveMu+xVU3utEC/s5ogI75eX3T82AglX1Uu2BHmrdqEb5fqhkuelWB5l3GEOzeI0i GFlJcKDDe2AAgKzGmoaCY8hHz4nCxh5d6ERJQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XrpQaBNpbz5C7gEc30JXJD4ksBAoVukkRs4REF7J3cA=; b=vhcgB+Y4BWrQxxRil2q4cdoZhaObkjzjCMJUDr4VsqNIIUKvbBxf4W/IRnpaNcnA+F t4a7UTwMPYc+k1vMPKAxPgBbn6aR2gV4bzDCW0fU06kpH3AErU95nB1L6BxNyBTu8XPP eEp7GQdlW6fxzrrtIX1WknNQgiXLjxeTP79/ao/puMHWsr1xWrw2fvb2A1b5wVCmxw+j Ln+wsWXY1YELDOI+YBIS5z/MgJfzzV5/36px+5izOywV2s3A7UirIQyItch0ExlZW7SV gCg6oaVXFwHLqCf23ITGB9IYahP/+4PE/3DiIRLSMXaJwD0iXI2v2Mn/Zv4Jz7oeHtPG /J1A== X-Gm-Message-State: AFqh2kreEGm/iIWTGRB9Zei0LUJKwvWVPCad0pggXh61edGoAGrBZNJz vLflQ/MhaoOrZXlcM3blmtCxp+po7Hzi2VcD06TRCg== X-Google-Smtp-Source: AMrXdXvrIUXju3J24bym43P+d+BGgTRL65FUNwwpDeRTxYGdxEQI/sLV9PJ9RkGhzNeKQ2VL0EKFXN2ejtTMxQEBC1c= X-Received: by 2002:a05:6102:3d9f:b0:3c4:4918:80c with SMTP id h31-20020a0561023d9f00b003c44918080cmr2656935vsv.9.1672382570811; Thu, 29 Dec 2022 22:42:50 -0800 (PST) MIME-Version: 1.0 References: <20221223094259.87373-1-angelogioacchino.delregno@collabora.com> <20221230061309.16643-1-miles.chen@mediatek.com> In-Reply-To: <20221230061309.16643-1-miles.chen@mediatek.com> From: Chen-Yu Tsai Date: Fri, 30 Dec 2022 14:42:39 +0800 Message-ID: Subject: Re: [PATCH v2 00/23] MediaTek clocks cleanups and improvements To: Miles Chen Cc: angelogioacchino.delregno@collabora.com, chun-jie.chen@mediatek.com, daniel@makrotopia.org, devicetree@vger.kernel.org, fparent@baylibre.com, ikjn@chromium.org, johnson.wang@mediatek.com, jose.exposito89@gmail.com, kernel@collabora.com, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, msp@baylibre.com, mturquette@baylibre.com, nfraprado@collabora.com, pablo.sun@mediatek.com, rex-bc.chen@mediatek.com, robh+dt@kernel.org, ryder.lee@kernel.org, sam.shih@mediatek.com, sboyd@kernel.org, weiyi.lu@mediatek.com, y.oudjana@protonmail.com, yangyingliang@huawei.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 30, 2022 at 2:13 PM Miles Chen wrote: > > Changes in v2: > > - Moved dt-bindings CLK_DUMMY to clk-mtk.h instead > > > > > > This series performs cleanups and improvements on MediaTek clock > > drivers, greatly reducing code duplication (hence also reducing > > kernel size). > > > > There would be a lot to say about it, but summarizing: > > > > * Propagates struct device where possible in order to introduce the > > possibility of using Runtime PM on clock drivers as needed, > > possibly enhancing reliability of some platforms (obviously, this > > will do nothing unless power-domains are added to devicetree); > > > > * Cleans up some duplicated clock(s) registration attempt(s): on > > some platforms the 26M fixed factor clock is registered early, > > but then upon platform_driver probe, an attempt to re-register > > that clock was performed; > > > > * Removes some early clock registration where possible, moving > > everything to platform_driver clock probe; > > > > * Breaks down the big MT8173 clock driver in multiple ones, as it's > > already done with the others, cleans it up and adds possibility > > possibility to compile non-boot-critical clock drivers (for 8173) > > as modules; > > > > * Extends the common mtk_clk_simple_probe() function to be able to > > register multiple MediaTek clock types; > > > > * Removes duplicated [...]_probe functions from multiple MediaTek SoC > > clock drivers, migrating almost everything to the common functions > > mtk_clk_simple_probe(); > > > > * Adds a .remove() callback, pointing to the common mtk_clk_simple_remove() > > function to all clock drivers that were migrated to the common probe; > > > > * Some more spare cleanups here and there. > > > > All of this was manually tested on various Chromebooks (with different MTK > > SoCs) and no regression was detected. > > > > Cheers! > > I tested this v2 series on mt6779 and mt8192 without any problem. Please give Tested-by. :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DDE5C4332F for ; Fri, 30 Dec 2022 06:44:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s9vuCtmEFzUdBigBeaXOORX76gPPTlvXFSkvoeu2CmM=; b=iCftIoOJsVlEaJ 89HrcWMN7n9BcVYb7i0p0OcdVVllEQyqrOIsuxURjCpjUWQ9LSRoNCqx7WKWV/US3+6IftIlIigJD 4JLoCeejxA9aT03B2gHB2Ta1uRxAOISKNp3bwfOEvmPw8gO0WXaFGDZAWIA/Hqvw8U/ZryrGFP89q KJ1jGm+2QFB/IdO0LyoHbTjj7unL4XpnNCSVfMeqQuV3rUGhGisUJlk+oc7cUDCl/mLGfI/DnExk1 B/yHg4TNtRsLOC5p0oWBOCQf5hb1tTflvWwGYP5dmZmKNgMJGmNfCzKpLCGOA15akMoEQuyTDQ//C OMlnfVAtgdpBuDDrGRXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pB96k-006Y21-A6; Fri, 30 Dec 2022 06:43:11 +0000 Received: from mail-vs1-xe2c.google.com ([2607:f8b0:4864:20::e2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pB96a-006Xtw-RV for linux-arm-kernel@lists.infradead.org; Fri, 30 Dec 2022 06:43:02 +0000 Received: by mail-vs1-xe2c.google.com with SMTP id k4so16405718vsc.4 for ; Thu, 29 Dec 2022 22:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XrpQaBNpbz5C7gEc30JXJD4ksBAoVukkRs4REF7J3cA=; b=ieXRxqKlr8oyA7r8oWv5vNjeFdB1A3ZleV0nsNDeN+cCb+ZLeuFA5X93VFGh/jXSpy 8vhLveMu+xVU3utEC/s5ogI75eX3T82AglX1Uu2BHmrdqEb5fqhkuelWB5l3GEOzeI0i GFlJcKDDe2AAgKzGmoaCY8hHz4nCxh5d6ERJQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XrpQaBNpbz5C7gEc30JXJD4ksBAoVukkRs4REF7J3cA=; b=7pxk7AYLvTrbBq7GuD07YqMoiFd7S/YcYYKO13a3bOPQ4mzV0qqgK8YQs+0Sn+NBtB Nt1BtGsC1Lqzmv+Ce5EmoTOKtYdR481TGbJ0d3AcyWvndtyvROHeV4kMnR1Ad3GwUXdb HdFCHRi+ZCIwbAHjO3vNxKW9FIh7vtCl8eiscQ6Slt34f1DB6DWT24kOQFyMXiIVvBOU L/q8CY9i0NTzvDiyAycrX+9j4MODPpr6jspXRZPJxtcrnj4l/u1DYAJb3T0Vs/uXglY8 +myShji+aMKHozRLAosx/6fHhL4Lo6rXXaOX/A2KMpYR2s833B9hJ6+5SoTNRIPOqO1f F8Fw== X-Gm-Message-State: AFqh2kq4pG/VDuj2SvlbdT0TAYNYa6Y7wnnRsZmCCjYDNvOB8cp9bhtg 3eezEgNQlFVlJimxnk6Bt7dPFkTrvfYn68r0au3a1Q== X-Google-Smtp-Source: AMrXdXvrIUXju3J24bym43P+d+BGgTRL65FUNwwpDeRTxYGdxEQI/sLV9PJ9RkGhzNeKQ2VL0EKFXN2ejtTMxQEBC1c= X-Received: by 2002:a05:6102:3d9f:b0:3c4:4918:80c with SMTP id h31-20020a0561023d9f00b003c44918080cmr2656935vsv.9.1672382570811; Thu, 29 Dec 2022 22:42:50 -0800 (PST) MIME-Version: 1.0 References: <20221223094259.87373-1-angelogioacchino.delregno@collabora.com> <20221230061309.16643-1-miles.chen@mediatek.com> In-Reply-To: <20221230061309.16643-1-miles.chen@mediatek.com> From: Chen-Yu Tsai Date: Fri, 30 Dec 2022 14:42:39 +0800 Message-ID: Subject: Re: [PATCH v2 00/23] MediaTek clocks cleanups and improvements To: Miles Chen Cc: angelogioacchino.delregno@collabora.com, chun-jie.chen@mediatek.com, daniel@makrotopia.org, devicetree@vger.kernel.org, fparent@baylibre.com, ikjn@chromium.org, johnson.wang@mediatek.com, jose.exposito89@gmail.com, kernel@collabora.com, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, msp@baylibre.com, mturquette@baylibre.com, nfraprado@collabora.com, pablo.sun@mediatek.com, rex-bc.chen@mediatek.com, robh+dt@kernel.org, ryder.lee@kernel.org, sam.shih@mediatek.com, sboyd@kernel.org, weiyi.lu@mediatek.com, y.oudjana@protonmail.com, yangyingliang@huawei.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221229_224301_162697_A448998A X-CRM114-Status: GOOD ( 20.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 30, 2022 at 2:13 PM Miles Chen wrote: > > Changes in v2: > > - Moved dt-bindings CLK_DUMMY to clk-mtk.h instead > > > > > > This series performs cleanups and improvements on MediaTek clock > > drivers, greatly reducing code duplication (hence also reducing > > kernel size). > > > > There would be a lot to say about it, but summarizing: > > > > * Propagates struct device where possible in order to introduce the > > possibility of using Runtime PM on clock drivers as needed, > > possibly enhancing reliability of some platforms (obviously, this > > will do nothing unless power-domains are added to devicetree); > > > > * Cleans up some duplicated clock(s) registration attempt(s): on > > some platforms the 26M fixed factor clock is registered early, > > but then upon platform_driver probe, an attempt to re-register > > that clock was performed; > > > > * Removes some early clock registration where possible, moving > > everything to platform_driver clock probe; > > > > * Breaks down the big MT8173 clock driver in multiple ones, as it's > > already done with the others, cleans it up and adds possibility > > possibility to compile non-boot-critical clock drivers (for 8173) > > as modules; > > > > * Extends the common mtk_clk_simple_probe() function to be able to > > register multiple MediaTek clock types; > > > > * Removes duplicated [...]_probe functions from multiple MediaTek SoC > > clock drivers, migrating almost everything to the common functions > > mtk_clk_simple_probe(); > > > > * Adds a .remove() callback, pointing to the common mtk_clk_simple_remove() > > function to all clock drivers that were migrated to the common probe; > > > > * Some more spare cleanups here and there. > > > > All of this was manually tested on various Chromebooks (with different MTK > > SoCs) and no regression was detected. > > > > Cheers! > > I tested this v2 series on mt6779 and mt8192 without any problem. Please give Tested-by. :) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel