diff for duplicates of <CAGZ2q2w=RFFkWBtg0fwVzEFs_2+x39aayjHu-v6d1G1=PXWSPg@mail.gmail.com>
diff --git a/a/1.txt b/N1/1.txt
index 2e886c4..8d5955c 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -9,7 +9,7 @@
>> > associations of driver file names and corresponding CONFIG_*
>> > symbol:
>> >
->> > foo_KCONF=3DCONFIG_FOO
+>> > foo_KCONF=CONFIG_FOO
>> >
>> > This file will be further loaded by the Makefile as a
>> > configuration file: all foo_KCONF will be considered variables
@@ -19,27 +19,22 @@
>> restrictions on kconfig variable names?
>>
>
-> The file generated will always work. It's loaded with makefile's "include=
-"
+> The file generated will always work. It's loaded with makefile's "include"
> directive which is quite straightforward.
>
> If you're referring to CONFIG_* variables, I can't find any restriction
> regarding size or anything else.
-> If you're referring to the newly created makefile variable foo_KCONF I on=
-ly
+> If you're referring to the newly created makefile variable foo_KCONF I only
> found this in the documentation:
-> "A variable name may be any sequence of characters not containing =E2=80=
-=98:=E2=80=99, =E2=80=98#=E2=80=99,
-> =E2=80=98=3D=E2=80=99, or whitespace."
+> "A variable name may be any sequence of characters not containing ‘:’, ‘#’,
+> ‘=’, or whitespace."
> "It is traditional to use upper case letters in variable names, but we
> recommend using lower case letters for variable names that serve internal
> purposes in the makefile, and reserving upper case for parameters that
-> control implicit rules or for parameters that the user should override wi=
-th
+> control implicit rules or for parameters that the user should override with
> command options"
>
-> Since the module name is lowercase I put the suffix uppercase in order to=
- be
+> Since the module name is lowercase I put the suffix uppercase in order to be
> more visible.
>
>>
@@ -91,22 +86,22 @@ th
>> > index b8c7b29..686d02a 100755
>> > --- a/scripts/kconfig/streamline_config.pl
>> > +++ b/scripts/kconfig/streamline_config.pl
->> > @@ -128,9 +128,11 @@ my @config_file =3D read_config;
+>> > @@ -128,9 +128,11 @@ my @config_file = read_config;
>> > # Parse options
->> > my $localmodconfig =3D 0;
->> > my $localyesconfig =3D 0;
->> > +my $genmoduleksymb =3D 0;
+>> > my $localmodconfig = 0;
+>> > my $localyesconfig = 0;
+>> > +my $genmoduleksymb = 0;
>> >
->> > GetOptions("localmodconfig" =3D> \$localmodconfig,
->> > - "localyesconfig" =3D> \$localyesconfig);
->> > + "localyesconfig" =3D> \$localyesconfig,
->> > + "genmoduleksymb" =3D> \$genmoduleksymb);
+>> > GetOptions("localmodconfig" => \$localmodconfig,
+>> > - "localyesconfig" => \$localyesconfig);
+>> > + "localyesconfig" => \$localyesconfig,
+>> > + "genmoduleksymb" => \$genmoduleksymb);
>> >
>> > # Get the build source and top level Kconfig file (passed in)
->> > my $ksource =3D ($ARGV[0] ? $ARGV[0] : '.');
+>> > my $ksource = ($ARGV[0] ? $ARGV[0] : '.');
>> > @@ -147,6 +149,7 @@ my %objects;
>> > my $var;
->> > my $iflevel =3D 0;
+>> > my $iflevel = 0;
>> > my @ifdeps;
>> > +my @drv_objs;
>> >
@@ -118,22 +113,21 @@ th
>> >
>> > +foreach my $obj_key ( keys %objects )
>> > +{
->> > + my @config_options =3D @{$objects{$obj_key}};
+>> > + my @config_options = @{$objects{$obj_key}};
>> > + # Last index of array is 0 is equivalent to array's size is 1
->> > + if ( $#config_options =3D=3D 0) {
+>> > + if ( $#config_options == 0) {
>> > + push(@drv_objs, $obj_key);
>> > + }
>> > +}
>> > +
>> > +sub gen_module_kconfigs {
->> > + my $module_ksymb =3D $ENV{'srctree'}."/scripts/Module.ksymb";
+>> > + my $module_ksymb = $ENV{'srctree'}."/scripts/Module.ksymb";
>> > +
>> > + open(my $ksymbfile, '>', $module_ksymb) || die "Can not open
>> > $module_ksymb for writing";
>> > +
>> > + foreach (@drv_objs) {
->> > + print $ksymbfile "$_" . "_KCONF=3D" . "@{$objects{$_}}\n=
-";
+>> > + print $ksymbfile "$_" . "_KCONF=" . "@{$objects{$_}}\n";
>> > + }
>> > + close($ksymbfile);
>> > +}
@@ -155,42 +149,36 @@ th
>
> Shortly, all makefiles are parsed searching for patterns such as:
>
-> obj-$(CONFIG_FOO) :=3D obj-foo1.o obj-foo2.o ... etc.
+> obj-$(CONFIG_FOO) := obj-foo1.o obj-foo2.o ... etc.
>
> Each obj-foo is added in the hashmap as key with the value
> array(CONFIG_FOO).
-> If obj-foo already exists in the hashmap CONFIG_FOO is appended to the ar=
-ray
+> If obj-foo already exists in the hashmap CONFIG_FOO is appended to the array
> value.
>
-> I noted that there are situations where an object obj-foo has as associat=
-es
+> I noted that there are situations where an object obj-foo has as associates
> more identical CONFIG_FOOs.
> Since I select only the names which have exaclty one CONFIG_* associated
-> this is a bit confusing. I am missing one category of drivers which can b=
-e
+> this is a bit confusing. I am missing one category of drivers which can be
> found:
>
> driver-foo ---- CONFIG_FOO CONFIG_FOO
>
-> For example: nfit CONFIG_ACPI_NFIT CONFIG_ACPI_NFIT -- this actually resu=
-lts
+> For example: nfit CONFIG_ACPI_NFIT CONFIG_ACPI_NFIT -- this actually results
> in a module in /sys which does not have a content into kconfig_ksymb
> although it has exactly one match.
>
> Another thing I can think of is that sometimes we find lines such as:
>
-> foo-name-$(CONFIG_FOO) =3D obj-foo1.o obj-foo2.o obj-foo3.o
+> foo-name-$(CONFIG_FOO) = obj-foo1.o obj-foo2.o obj-foo3.o
>
-> This can be a clue that the final kernel module is named foo-name and cou=
-ld
+> This can be a clue that the final kernel module is named foo-name and could
> solve some ambiguous cases.
> This are just a few situations I can think of to be kept in mind for the
> next Module.ksymb generator
>
>>
->> The generation here is also forced, we want to enable this to be optiona=
-l
+>> The generation here is also forced, we want to enable this to be optional
>> so please consider adding a Kconfig entry for this as a feature, just as
>> the module versioning stuff has one.
>
@@ -204,6 +192,4 @@ l
Message forwarded since original message was rejected by lkml and
backports for being HTML format.
-Cristina
---
-To unsubscribe from this list: send the line "unsubscribe backports" in
\ No newline at end of file
+Cristina
\ No newline at end of file
diff --git a/a/content_digest b/N1/content_digest
index 98f4931..c9e48a6 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -49,7 +49,7 @@
">> > associations of driver file names and corresponding CONFIG_*\n",
">> > symbol:\n",
">> >\n",
- ">> > foo_KCONF=3DCONFIG_FOO\n",
+ ">> > foo_KCONF=CONFIG_FOO\n",
">> >\n",
">> > This file will be further loaded by the Makefile as a\n",
">> > configuration file: all foo_KCONF will be considered variables\n",
@@ -59,27 +59,22 @@
">> restrictions on kconfig variable names?\n",
">>\n",
">\n",
- "> The file generated will always work. It's loaded with makefile's \"include=\n",
- "\"\n",
+ "> The file generated will always work. It's loaded with makefile's \"include\"\n",
"> directive which is quite straightforward.\n",
">\n",
"> If you're referring to CONFIG_* variables, I can't find any restriction\n",
"> regarding size or anything else.\n",
- "> If you're referring to the newly created makefile variable foo_KCONF I on=\n",
- "ly\n",
+ "> If you're referring to the newly created makefile variable foo_KCONF I only\n",
"> found this in the documentation:\n",
- "> \"A variable name may be any sequence of characters not containing =E2=80=\n",
- "=98:=E2=80=99, =E2=80=98#=E2=80=99,\n",
- "> =E2=80=98=3D=E2=80=99, or whitespace.\"\n",
+ "> \"A variable name may be any sequence of characters not containing \342\200\230:\342\200\231, \342\200\230#\342\200\231,\n",
+ "> \342\200\230=\342\200\231, or whitespace.\"\n",
"> \"It is traditional to use upper case letters in variable names, but we\n",
"> recommend using lower case letters for variable names that serve internal\n",
"> purposes in the makefile, and reserving upper case for parameters that\n",
- "> control implicit rules or for parameters that the user should override wi=\n",
- "th\n",
+ "> control implicit rules or for parameters that the user should override with\n",
"> command options\"\n",
">\n",
- "> Since the module name is lowercase I put the suffix uppercase in order to=\n",
- " be\n",
+ "> Since the module name is lowercase I put the suffix uppercase in order to be\n",
"> more visible.\n",
">\n",
">>\n",
@@ -131,22 +126,22 @@
">> > index b8c7b29..686d02a 100755\n",
">> > --- a/scripts/kconfig/streamline_config.pl\n",
">> > +++ b/scripts/kconfig/streamline_config.pl\n",
- ">> > \@\@ -128,9 +128,11 \@\@ my \@config_file =3D read_config;\n",
+ ">> > \@\@ -128,9 +128,11 \@\@ my \@config_file = read_config;\n",
">> > # Parse options\n",
- ">> > my \$localmodconfig =3D 0;\n",
- ">> > my \$localyesconfig =3D 0;\n",
- ">> > +my \$genmoduleksymb =3D 0;\n",
+ ">> > my \$localmodconfig = 0;\n",
+ ">> > my \$localyesconfig = 0;\n",
+ ">> > +my \$genmoduleksymb = 0;\n",
">> >\n",
- ">> > GetOptions(\"localmodconfig\" =3D> \\\$localmodconfig,\n",
- ">> > - \"localyesconfig\" =3D> \\\$localyesconfig);\n",
- ">> > + \"localyesconfig\" =3D> \\\$localyesconfig,\n",
- ">> > + \"genmoduleksymb\" =3D> \\\$genmoduleksymb);\n",
+ ">> > GetOptions(\"localmodconfig\" => \\\$localmodconfig,\n",
+ ">> > - \"localyesconfig\" => \\\$localyesconfig);\n",
+ ">> > + \"localyesconfig\" => \\\$localyesconfig,\n",
+ ">> > + \"genmoduleksymb\" => \\\$genmoduleksymb);\n",
">> >\n",
">> > # Get the build source and top level Kconfig file (passed in)\n",
- ">> > my \$ksource =3D (\$ARGV[0] ? \$ARGV[0] : '.');\n",
+ ">> > my \$ksource = (\$ARGV[0] ? \$ARGV[0] : '.');\n",
">> > \@\@ -147,6 +149,7 \@\@ my %objects;\n",
">> > my \$var;\n",
- ">> > my \$iflevel =3D 0;\n",
+ ">> > my \$iflevel = 0;\n",
">> > my \@ifdeps;\n",
">> > +my \@drv_objs;\n",
">> >\n",
@@ -158,22 +153,21 @@
">> >\n",
">> > +foreach my \$obj_key ( keys %objects )\n",
">> > +{\n",
- ">> > + my \@config_options =3D \@{\$objects{\$obj_key}};\n",
+ ">> > + my \@config_options = \@{\$objects{\$obj_key}};\n",
">> > + # Last index of array is 0 is equivalent to array's size is 1\n",
- ">> > + if ( \$#config_options =3D=3D 0) {\n",
+ ">> > + if ( \$#config_options == 0) {\n",
">> > + push(\@drv_objs, \$obj_key);\n",
">> > + }\n",
">> > +}\n",
">> > +\n",
">> > +sub gen_module_kconfigs {\n",
- ">> > + my \$module_ksymb =3D \$ENV{'srctree'}.\"/scripts/Module.ksymb\";\n",
+ ">> > + my \$module_ksymb = \$ENV{'srctree'}.\"/scripts/Module.ksymb\";\n",
">> > +\n",
">> > + open(my \$ksymbfile, '>', \$module_ksymb) || die \"Can not open\n",
">> > \$module_ksymb for writing\";\n",
">> > +\n",
">> > + foreach (\@drv_objs) {\n",
- ">> > + print \$ksymbfile \"\$_\" . \"_KCONF=3D\" . \"\@{\$objects{\$_}}\\n=\n",
- "\";\n",
+ ">> > + print \$ksymbfile \"\$_\" . \"_KCONF=\" . \"\@{\$objects{\$_}}\\n\";\n",
">> > + }\n",
">> > + close(\$ksymbfile);\n",
">> > +}\n",
@@ -195,42 +189,36 @@
">\n",
"> Shortly, all makefiles are parsed searching for patterns such as:\n",
">\n",
- "> obj-\$(CONFIG_FOO) :=3D obj-foo1.o obj-foo2.o ... etc.\n",
+ "> obj-\$(CONFIG_FOO) := obj-foo1.o obj-foo2.o ... etc.\n",
">\n",
"> Each obj-foo is added in the hashmap as key with the value\n",
"> array(CONFIG_FOO).\n",
- "> If obj-foo already exists in the hashmap CONFIG_FOO is appended to the ar=\n",
- "ray\n",
+ "> If obj-foo already exists in the hashmap CONFIG_FOO is appended to the array\n",
"> value.\n",
">\n",
- "> I noted that there are situations where an object obj-foo has as associat=\n",
- "es\n",
+ "> I noted that there are situations where an object obj-foo has as associates\n",
"> more identical CONFIG_FOOs.\n",
"> Since I select only the names which have exaclty one CONFIG_* associated\n",
- "> this is a bit confusing. I am missing one category of drivers which can b=\n",
- "e\n",
+ "> this is a bit confusing. I am missing one category of drivers which can be\n",
"> found:\n",
">\n",
"> driver-foo ---- CONFIG_FOO CONFIG_FOO\n",
">\n",
- "> For example: nfit CONFIG_ACPI_NFIT CONFIG_ACPI_NFIT -- this actually resu=\n",
- "lts\n",
+ "> For example: nfit CONFIG_ACPI_NFIT CONFIG_ACPI_NFIT -- this actually results\n",
"> in a module in /sys which does not have a content into kconfig_ksymb\n",
"> although it has exactly one match.\n",
">\n",
"> Another thing I can think of is that sometimes we find lines such as:\n",
">\n",
- "> foo-name-\$(CONFIG_FOO) =3D obj-foo1.o obj-foo2.o obj-foo3.o\n",
+ "> foo-name-\$(CONFIG_FOO) = obj-foo1.o obj-foo2.o obj-foo3.o\n",
">\n",
- "> This can be a clue that the final kernel module is named foo-name and cou=\n",
- "ld\n",
+ "> This can be a clue that the final kernel module is named foo-name and could\n",
"> solve some ambiguous cases.\n",
"> This are just a few situations I can think of to be kept in mind for the\n",
"> next Module.ksymb generator\n",
">\n",
">>\n",
- ">> The generation here is also forced, we want to enable this to be optiona=\n",
- "l\n",
+ ">> The generation here is also forced, we want to enable this to be optional\n",
">> so please consider adding a Kconfig entry for this as a feature, just as\n",
">> the module versioning stuff has one.\n",
">\n",
@@ -244,9 +232,7 @@
"\n",
"Message forwarded since original message was rejected by lkml and\n",
"backports for being HTML format.\n",
- "Cristina\n",
- "--\n",
- "To unsubscribe from this list: send the line \"unsubscribe backports\" in"
+ "Cristina"
]
-090ddf1ae81e252b946cf58eabffa4ae3656d13a1b0eda06d2c9444e2ae165bf
+446c5e07748cf4716ea5da8186049dc62ea335a97a260eb336db6856e27a2289
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.