From: Stefan Beller <sbeller@google.com>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Jeff King <peff@peff.net>, Jens Lehmann <Jens.Lehmann@web.de>
Subject: Re: [PATCH v3 3/3] submodule: extend die message on failed checkout with depth argument
Date: Tue, 12 Jan 2016 15:32:15 -0800 [thread overview]
Message-ID: <CAGZ79kY-tzhKxYeSe_cknBP0f8hPZJ9e1+AXq88XjJevc_Dteg@mail.gmail.com> (raw)
In-Reply-To: <BCA2C81C-8DB4-4695-8A44-79B51103A684@gmail.com>
On Tue, Jan 12, 2016 at 1:29 AM, Lars Schneider
<larsxschneider@gmail.com> wrote:
>
> On 11 Jan 2016, at 17:26, Stefan Beller <sbeller@google.com> wrote:
>
>> On Sun, Dec 20, 2015 at 3:19 PM, <larsxschneider@gmail.com> wrote:
>>
>>> +test_expect_success 'submodule update clone shallow submodule on non-default branch' '
>>> + git clone cloned super4 &&
>>> + pwd=$(pwd) &&
>>> + (cd super4 &&
>>> + sed -e "s#url = ../#url = file://$pwd/#" <.gitmodules >.gitmodules.tmp &&
>>> + mv -f .gitmodules.tmp .gitmodules &&
>>> + test_must_fail git submodule update --init --depth=3 2>submodule.out &&
>>
>> Why do we choose a depth of 3 here?
> I just copied this code from the test above. Let's change that to "--depth=1" to avoid confusion.
> Should I reroll or can this be fixed in the merge?
I noticed that too after reviewing 1&2 that 3 seems to be the standard
depth in the tests,
so I'd think 3 is fine here, too. Which makes it not worth to reroll,
so I'd be fine with it as is.
>
>>
>>> + test_i18ngrep --count "Commit is probably not on the default branch." submodule.out
> I was just reading this and wonder if we should remove "--count". My initial intention was to
> make sure this error message only happens once. However, this is not checked here anyways.
>
>>> + )
>>> '
>>>
>>> test_expect_success 'submodule update --recursive drops module name before recursing' '
>
>
> Thanks,
> Lars
next prev parent reply other threads:[~2016-01-12 23:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-20 23:19 [PATCH v3 0/3] add test to demonstrate that shallow recursive clones fail larsxschneider
2015-12-20 23:19 ` [PATCH v3 1/3] submodule: " larsxschneider
2016-03-15 19:50 ` Stefan Beller
2016-03-15 20:12 ` Junio C Hamano
2016-03-20 17:05 ` Lars Schneider
2016-03-20 19:40 ` Jeff King
2016-03-20 21:27 ` Stefan Beller
2015-12-20 23:19 ` [PATCH v3 2/3] submodule: fix &&-chain breakage larsxschneider
2015-12-20 23:19 ` [PATCH v3 3/3] submodule: extend die message on failed checkout with depth argument larsxschneider
2016-01-11 16:26 ` Stefan Beller
2016-01-12 9:29 ` Lars Schneider
2016-01-12 23:32 ` Stefan Beller [this message]
2016-01-07 21:50 ` [PATCH v3 0/3] add test to demonstrate that shallow recursive clones fail Lars Schneider
2016-01-11 16:29 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kY-tzhKxYeSe_cknBP0f8hPZJ9e1+AXq88XjJevc_Dteg@mail.gmail.com \
--to=sbeller@google.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.