From: Stefan Beller <sbeller@google.com>
To: Alex Riesen <alexander.riesen@cetitec.com>
Cc: Paul Mackerras <paulus@ozlabs.org>,
Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Alex Riesen <raa.lkml@gmail.com>,
Bert Wesarg <bert.wesarg@googlemail.com>
Subject: Re: [PATCH v2 0/2] gitk: improve handling of submodules in the file list panel
Date: Wed, 9 May 2018 11:52:30 -0700 [thread overview]
Message-ID: <CAGZ79kaqp2sOU76+uQOvzvh_ojJf1O2YqmnmAU2UM-Jm+ZFQ8Q@mail.gmail.com> (raw)
In-Reply-To: <cover.1525868167.git.raa.lkml@gmail.com>
On Wed, May 9, 2018 at 5:35 AM, Alex Riesen
<alexander.riesen@cetitec.com> wrote:
> From: Alex Riesen <raa.lkml@gmail.com>
>
> Currently, the submodule entries in the file list panel are mostly ignored.
> This series attempts to improve the situation by showing part of submodule
> history when focusing it in the file list panel and by adding a menu element
> to start gitk in the submodule (similar to git gui).
>
> This iteration does not address the behaviour of file list panel in tree mode
> when gitk is started from a subdirectory (gitk strictly limits the file
> listing to the files in that repository, without a way out).
> I would like to hear some more opinions regarding changing its behaviour to
> always list the full tree.
>
> Alex Riesen (2):
> gitk: show part of submodule log instead of empty pane when listing
> trees
> gitk: add an option to run gitk on an item in the file list
both patches look ok, to my untrained eye.
next prev parent reply other threads:[~2018-05-09 18:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 12:11 [PATCH 0/2] gitk: improve handling of submodules in the file list panel Alex Riesen
2018-05-08 12:22 ` [PATCH 1/2] gitk: show part of submodule log instead of empty pane when listing trees Alex Riesen
2018-05-08 17:07 ` Stefan Beller
2018-05-09 9:01 ` Alex Riesen
2018-05-08 12:22 ` [PATCH 2/2] gitk: add an option to run gitk on an item in the file list Alex Riesen
2018-05-08 13:17 ` Bert Wesarg
2018-05-08 13:39 ` Alex Riesen
2018-05-09 7:19 ` Bert Wesarg
2018-05-09 10:59 ` [PATCH] gitk: do not limit tree mode listing in the file list panel to current sub-directory Alex Riesen
2018-05-09 12:08 ` Bert Wesarg
2018-05-09 12:14 ` Alex Riesen
2018-05-09 12:35 ` [PATCH v2 0/2] gitk: improve handling of submodules in the file list panel Alex Riesen
2018-05-09 12:35 ` [PATCH v2 1/2] gitk: show part of submodule log instead of empty pane when listing trees Alex Riesen
2018-05-09 12:35 ` [PATCH v2 2/2] gitk: add an option to run gitk on an item in the file list Alex Riesen
2018-05-09 18:52 ` Stefan Beller [this message]
2018-05-09 11:00 [PATCH v2 0/2] gitk: improve handling of submodules in the file list panel Alex Riesen
2018-05-09 11:04 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kaqp2sOU76+uQOvzvh_ojJf1O2YqmnmAU2UM-Jm+ZFQ8Q@mail.gmail.com \
--to=sbeller@google.com \
--cc=alexander.riesen@cetitec.com \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=paulus@ozlabs.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.