Re: [patch 22/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 22

From: Kate Stewart <kstewart@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-spdx@vger.kernel.org
Subject: Re: [patch 22/25] treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 22
Date: Mon, 20 May 2019 20:34:18 -0500	[thread overview]
Message-ID: <CAG_66ZQC7B696H_XiaDZA2kGc8aX0AuzzDOu6Aqud1FWd1xuBw@mail.gmail.com> (raw)
In-Reply-To: <20190519154042.707528683@linutronix.de>

Hi Thomas,
   You may want to extend your pattern for the first 3 as there is no
copyright statement so applying it will end up with :
// SPDX-License-Identifier: GPL-2.0-or-later
 /*
*/

which will look a bit weird.

Maybe break this patch up into the one with copyright, and the rest without?

Kate

On Sun, May 19, 2019 at 12:19 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> Based on 1 normalized pattern(s):
>
>   the code contained herein is licensed under the gnu general public
>   license you may obtain a copy of the gnu general public license
>   version 2 or later at the following locations
>
> extracted by the scancode license scanner the SPDX license identifier
>
>   GPL-2.0-or-later
>
> has been chosen to replace the boilerplate/reference in 4 file(s).
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> https://git.kernel.org/pub/scm/linux/kernel/git/tglx/linux-spdx.git/commit/?h=step2&id=bafe4d8bf0ca
> ---
>  arch/arm/boot/dts/ep7209.dtsi        |    4 +---
>  arch/arm/boot/dts/ep7211-edb7211.dts |    4 +---
>  arch/arm/boot/dts/ep7211.dtsi        |    4 +---
>  drivers/dma/mmp_tdma.c               |    6 +-----
>  4 files changed, 4 insertions(+), 14 deletions(-)
>
> --- a/arch/arm/boot/dts/ep7209.dtsi
> +++ b/arch/arm/boot/dts/ep7209.dtsi
> @@ -1,7 +1,5 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
>  /*
> - * The code contained herein is licensed under the GNU General Public
> - * License. You may obtain a copy of the GNU General Public License
> - * Version 2 or later at the following locations:
>   */
>
>  /dts-v1/;
> --- a/arch/arm/boot/dts/ep7211-edb7211.dts
> +++ b/arch/arm/boot/dts/ep7211-edb7211.dts
> @@ -1,7 +1,5 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
>  /*
> - * The code contained herein is licensed under the GNU General Public
> - * License. You may obtain a copy of the GNU General Public License
> - * Version 2 or later at the following locations:
>   */
>
>  #include "ep7211.dtsi"
> --- a/arch/arm/boot/dts/ep7211.dtsi
> +++ b/arch/arm/boot/dts/ep7211.dtsi
> @@ -1,7 +1,5 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
>  /*
> - * The code contained herein is licensed under the GNU General Public
> - * License. You may obtain a copy of the GNU General Public License
> - * Version 2 or later at the following locations:
>   */
>
>  #include "ep7209.dtsi"
> --- a/drivers/dma/mmp_tdma.c
> +++ b/drivers/dma/mmp_tdma.c
> @@ -1,12 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
>  /*
>   * Driver For Marvell Two-channel DMA Engine
>   *
>   * Copyright: Marvell International Ltd.
> - *
> - * The code contained herein is licensed under the GNU General Public
> - * License. You may obtain a copy of the GNU General Public License
> - * Version 2 or later at the following locations:
> - *
>   */
>
>  #include <linux/err.h>
>
>