From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99754C19F28 for ; Wed, 3 Aug 2022 09:42:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237468AbiHCJm0 (ORCPT ); Wed, 3 Aug 2022 05:42:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237460AbiHCJmY (ORCPT ); Wed, 3 Aug 2022 05:42:24 -0400 Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFD781CB12 for ; Wed, 3 Aug 2022 02:42:23 -0700 (PDT) Received: by mail-yb1-xb30.google.com with SMTP id n8so27565966yba.2 for ; Wed, 03 Aug 2022 02:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=/5J/hTicAQKvIdTCsN8vIr3eGdVqz6oWNgR8PbCUFZ0=; b=UW16xIvrWocqAhSPd2fuZKeM91zaflQgPYWDJgcud8Cri8Ym2URa03dCI1zYrFIezW fICUhA0MZ7uec2/HuZSKY8g8uGB5q9N7Au4XQr5K6FFHmZ0hO8ktztxtkSHEE/vb6IJn KEbgA906UOjZ2Rsii9K4/vyPRuud1tCOtgEnGKmFhWYZsrm+DJlhbb1l0W8029yPcEw/ 8c52Bmse7AJhuI4irdCL1QGGKXLNRBxfMKaBMuCSsl1oJGfOPZbVh8tpZKDkfDCUULtN JQPCee3tCjakxMT3yWiBiUPIVoXDmFby7RIPPsTaDJd+7IqvhfoTZn6FAP+2a7YrsBk5 gNYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=/5J/hTicAQKvIdTCsN8vIr3eGdVqz6oWNgR8PbCUFZ0=; b=z0Fs0EpFe6MuqpKki3zm2vNwqWgY6iMSRz5RcpnGS8GWqcmhAcQE9nuyj0EkESYXmP 6aS07jOiIK/PiOT8ZpVI7E1rySycMor5zDo/jUgvhnlG6XvIeEZ20AJan/6vPYJgVWCC iJuYtMUtDyu1jqeG0HXwOuZRVa9sIY3aIaf7bm4V+IHyMJOQXCq/QuT4WaA6BbSWrxQe o9yrJeB4Q3uAlZ9RsK0B3j1CP9W08wuJ2zyDB7g+HCh8CVj9HlQS7pWHmGxGvYu6iGHM pA+WPxEacRxQunozEunBOquSZRZXBS6Dpb4FCbT7uiT4MSiqa618V4MX9a+BZUdiGSuQ cIzg== X-Gm-Message-State: ACgBeo28ZxgApPY/2zcxck9E6p3BZmFG0AD3RsO4SoojC54L/KwZNuob vDlkk1jCnACw9WbNGTUJBqyjA4PrLOf1TwffbGzpmg== X-Google-Smtp-Source: AA6agR7WMDXiL70b6NLngI/XHKFbP2/r+w7WmXN1qYL7/w1ywK0n4OfWAmZKsLbnW7QxKw6oUWpd6k7KLsAW0q+NLBo= X-Received: by 2002:a25:d7d3:0:b0:671:899b:eafc with SMTP id o202-20020a25d7d3000000b00671899beafcmr18510665ybg.485.1659519742790; Wed, 03 Aug 2022 02:42:22 -0700 (PDT) MIME-Version: 1.0 References: <20220701142310.2188015-1-glider@google.com> <20220701142310.2188015-11-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Wed, 3 Aug 2022 11:41:46 +0200 Message-ID: Subject: Re: [PATCH v4 10/45] libnvdimm/pfn_dev: increase MAX_STRUCT_PAGE_SIZE To: Marco Elver , Dan Williams Cc: Alexander Viro , Alexei Starovoitov , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev , Linux Memory Management List , Linux-Arch , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (+ Dan Williams) On Mon, Jul 11, 2022 at 6:27 PM Marco Elver wrote: > > On Fri, 1 Jul 2022 at 16:23, Alexander Potapenko wrote: > > > > KMSAN adds extra metadata fields to struct page, so it does not fit into > > 64 bytes anymore. > > Does this somehow cause extra space being used in all kernel configs? > If not, it would be good to note this in the commit message. I actually couldn't verify this on QEMU, because the driver never got loaded. Looks like this increases the amount of memory used by the nvdimm driver in all kernel configs that enable it (including those that don't use KMSAN), but I am not sure how much is that. Dan, do you know how bad increasing MAX_STRUCT_PAGE_SIZE can be? > > > Signed-off-by: Alexander Potapenko > > Reviewed-by: Marco Elver