From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F7E2C4361A for ; Fri, 4 Dec 2020 12:30:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4ABC6229F0 for ; Fri, 4 Dec 2020 12:30:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729570AbgLDMaB (ORCPT ); Fri, 4 Dec 2020 07:30:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725867AbgLDM37 (ORCPT ); Fri, 4 Dec 2020 07:29:59 -0500 Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75A94C0613D1 for ; Fri, 4 Dec 2020 04:29:13 -0800 (PST) Received: by mail-qt1-x841.google.com with SMTP id o1so3730172qtp.5 for ; Fri, 04 Dec 2020 04:29:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=E+yzFXIW/SQF93FksrpbqqTewefE+vrapU8Z3tg/OfY=; b=vQyupD/hnfpF1w+LBmivJCLJbF/uyr95MEQGWWFEUS55KnvlgBibrZJ5tV2uofztNP 9wEffK+/5P3iYW5hKwx3rmO1TTRcvSS2j/fNq2BkP6tGhz/wbai7GjeJyRrRHEfxJMTz XfAoPoI9tKsoOB+uZdAdLQUToK/GXFYqOXIkGw06uZKp0mAtTtcuK9shfdwjGZik7bWB 76EPD7uyiW9hOTbMBXV3I/ZrnG+ZhvzGjupfzeAlSnQnTz9DZg/okSUa7uAdxRZCOnYD OWEiTm/bAebMah9fe/BmfT8emf8SaKenWSF7e2+15ZBr3Af4Vm6rHqmPFRTnycqqwE3p V26g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=E+yzFXIW/SQF93FksrpbqqTewefE+vrapU8Z3tg/OfY=; b=qjtsmSRVuXiWv9F5Dx9QTPbTeLmQ2ba+kaiyKP1jVH4AjjAb1NcEiDjcViF327W49F msbpCIPjDYgBOsRBeLXPpLwGYJQEAPTPaVwVgzSbaguZ5AFp1wbSFKZzGcRgj/PiOc63 OCKAmFhb3D8Uw0sORdZh8Ljbyzg05+3mMlDh8bMb4AcjoGROW7vYS/pmfFm7EH5H4VHA hRNNV+X2FXCqZUg6c9I+MNmbxEME9KFrpd7F7Nw/2QpWL+Iu1I4IqbWF4pzbZqWhaWHm iXHn0mxWo8qDGLgzg1hwcw8UfcPSlwCorDr6Lui82QGLDbnk+TxTswW+5J/qxSwIgbTv JHew== X-Gm-Message-State: AOAM531PsMAwXh4Anfvr/o5Ckm6EVhOyxWklpTwi9h98BXezQdedHy9o WN4QNQnRs4bfYdT+k+R15XB/iaLNuqDkc/jX5A7rDQ== X-Google-Smtp-Source: ABdhPJzt8D+UI/bRjnIjspRkJfEKkMKQoOvjAujo3pizFQRDHEqt6L8+g0r9NmRNjgUJQ2DgeOFcAyo1k6p0KISWCkY= X-Received: by 2002:ac8:4c89:: with SMTP id j9mr8912771qtv.8.1607084952474; Fri, 04 Dec 2020 04:29:12 -0800 (PST) MIME-Version: 1.0 References: <20201204121804.1532849-1-anders.roxell@linaro.org> In-Reply-To: <20201204121804.1532849-1-anders.roxell@linaro.org> From: Alexander Potapenko Date: Fri, 4 Dec 2020 13:29:01 +0100 Message-ID: Subject: Re: [PATCH] kfence: fix implicit function declaration To: Anders Roxell Cc: Andrew Morton , Marco Elver , Dmitriy Vyukov , Catalin Marinas , Will Deacon , kasan-dev , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 4, 2020 at 1:18 PM Anders Roxell wro= te: > > When building kfence the following error shows up: > > In file included from mm/kfence/report.c:13: > arch/arm64/include/asm/kfence.h: In function =E2=80=98kfence_protect_page= =E2=80=99: > arch/arm64/include/asm/kfence.h:12:2: error: implicit declaration of func= tion =E2=80=98set_memory_valid=E2=80=99 [-Werror=3Dimplicit-function-declar= ation] > 12 | set_memory_valid(addr, 1, !protect); > | ^~~~~~~~~~~~~~~~ > > Use the correct include both > f2b7c491916d ("set_memory: allow querying whether set_direct_map_*() is a= ctually enabled") > and 4c4c75881536 ("arm64, kfence: enable KFENCE for ARM64") went in the > same day via different trees. > > Signed-off-by: Anders Roxell Reviewed-by: Alexander Potapenko Thanks! > --- > > I got this build error in todays next-20201204. > Andrew, since both patches are in your -mm tree, I think this can be > folded into 4c4c75881536 ("arm64, kfence: enable KFENCE for ARM64") > > arch/arm64/include/asm/kfence.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/include/asm/kfence.h b/arch/arm64/include/asm/kfe= nce.h > index 6c0afeeab635..c44bb368a810 100644 > --- a/arch/arm64/include/asm/kfence.h > +++ b/arch/arm64/include/asm/kfence.h > @@ -3,7 +3,7 @@ > #ifndef __ASM_KFENCE_H > #define __ASM_KFENCE_H > > -#include > +#include > > static inline bool arch_kfence_init_pool(void) { return true; } > > -- > 2.29.2 > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9380CC4361A for ; Fri, 4 Dec 2020 12:30:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F6E4229F0 for ; Fri, 4 Dec 2020 12:30:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F6E4229F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ee6u2E9u+cw//yz0SF0DjXcfaqSyTsxPjqxINrJojlw=; b=cZj/ii9bCVFAtfkNt0vLNjQrT VJjn4zezsCrsit/l3aGvwgsWjxf/fI2T0E2GCMzEv6CNxJGFB9vvyqHD4dmqy99iW3QOK1acQ+Vrx DWmhlQa1TEIqX6OSME6LIFsLOZOD3zokipTES05uAT9kE68dRyXnd3jIwRoUN2MDWJh8usuFPnO52 bRVdjakrshDOosDL0RnlPxvuv90A9EDlyXEU+Kah4bKEF4cWNaRHYxgK71lHyXBQNN/Fyjmd6Xve8 H9ZhCJy5K2xKaUpswgaUxVtoZM6TAMnFV2iiZNQkDd5hD7tiE9Y6/VeKrKgjDlXCNbv7+UWetyK+N 1/8yRiIZw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1klAD8-0007sV-4a; Fri, 04 Dec 2020 12:29:18 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1klAD6-0007ru-A4 for linux-arm-kernel@lists.infradead.org; Fri, 04 Dec 2020 12:29:16 +0000 Received: by mail-qt1-x841.google.com with SMTP id p12so3727179qtp.7 for ; Fri, 04 Dec 2020 04:29:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=E+yzFXIW/SQF93FksrpbqqTewefE+vrapU8Z3tg/OfY=; b=vQyupD/hnfpF1w+LBmivJCLJbF/uyr95MEQGWWFEUS55KnvlgBibrZJ5tV2uofztNP 9wEffK+/5P3iYW5hKwx3rmO1TTRcvSS2j/fNq2BkP6tGhz/wbai7GjeJyRrRHEfxJMTz XfAoPoI9tKsoOB+uZdAdLQUToK/GXFYqOXIkGw06uZKp0mAtTtcuK9shfdwjGZik7bWB 76EPD7uyiW9hOTbMBXV3I/ZrnG+ZhvzGjupfzeAlSnQnTz9DZg/okSUa7uAdxRZCOnYD OWEiTm/bAebMah9fe/BmfT8emf8SaKenWSF7e2+15ZBr3Af4Vm6rHqmPFRTnycqqwE3p V26g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=E+yzFXIW/SQF93FksrpbqqTewefE+vrapU8Z3tg/OfY=; b=LT9wsf20emxN/K3lX7HYuLw6j3wxUk+e+F8euYbhBsl4TbyjDLITbVVu9mjUWcJ0VD HPvYUyhT2MwbFGP0vt33wCyGxdVMUgV3rnm+8NIecrpYtfR/Y+zUCO/mrMgXZI6caBUP Q/xsr4j6vpPYILOYithd5s9N7DhDwyvOz6sjU3x8vV8YOPVjmI191ara+aLrX7/+hHoX TGZsZFdWA+sEumlm6cAfpQRu6qOavjqoaRxDj4O7wROp7fWD3wI/gJ0aj4WjWTzWAHt7 O8iXoYqaJbU3fcWHqHR3ds3xYPwLqTSoz66/5sVmsjHMxu1GMXhBvPVBbBmK194oFY/L mnug== X-Gm-Message-State: AOAM530ViZgGiXXuO4leDkdHwmXxJRHq3kz1Xb0TstV1734Csq/ouejn kGtp+TMrkUm+ZudDsxnNM8TcPAF/V0a0HDe2pMNs2g== X-Google-Smtp-Source: ABdhPJzt8D+UI/bRjnIjspRkJfEKkMKQoOvjAujo3pizFQRDHEqt6L8+g0r9NmRNjgUJQ2DgeOFcAyo1k6p0KISWCkY= X-Received: by 2002:ac8:4c89:: with SMTP id j9mr8912771qtv.8.1607084952474; Fri, 04 Dec 2020 04:29:12 -0800 (PST) MIME-Version: 1.0 References: <20201204121804.1532849-1-anders.roxell@linaro.org> In-Reply-To: <20201204121804.1532849-1-anders.roxell@linaro.org> From: Alexander Potapenko Date: Fri, 4 Dec 2020 13:29:01 +0100 Message-ID: Subject: Re: [PATCH] kfence: fix implicit function declaration To: Anders Roxell X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201204_072916_386192_45E1D27E X-CRM114-Status: GOOD ( 20.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marco Elver , Catalin Marinas , LKML , kasan-dev , Linux ARM , Andrew Morton , Will Deacon , Dmitriy Vyukov Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBEZWMgNCwgMjAyMCBhdCAxOjE4IFBNIEFuZGVycyBSb3hlbGwgPGFuZGVycy5yb3hl bGxAbGluYXJvLm9yZz4gd3JvdGU6Cj4KPiBXaGVuIGJ1aWxkaW5nIGtmZW5jZSB0aGUgZm9sbG93 aW5nIGVycm9yIHNob3dzIHVwOgo+Cj4gSW4gZmlsZSBpbmNsdWRlZCBmcm9tIG1tL2tmZW5jZS9y ZXBvcnQuYzoxMzoKPiBhcmNoL2FybTY0L2luY2x1ZGUvYXNtL2tmZW5jZS5oOiBJbiBmdW5jdGlv biDigJhrZmVuY2VfcHJvdGVjdF9wYWdl4oCZOgo+IGFyY2gvYXJtNjQvaW5jbHVkZS9hc20va2Zl bmNlLmg6MTI6MjogZXJyb3I6IGltcGxpY2l0IGRlY2xhcmF0aW9uIG9mIGZ1bmN0aW9uIOKAmHNl dF9tZW1vcnlfdmFsaWTigJkgWy1XZXJyb3I9aW1wbGljaXQtZnVuY3Rpb24tZGVjbGFyYXRpb25d Cj4gICAgMTIgfCAgc2V0X21lbW9yeV92YWxpZChhZGRyLCAxLCAhcHJvdGVjdCk7Cj4gICAgICAg fCAgXn5+fn5+fn5+fn5+fn5+fgo+Cj4gVXNlIHRoZSBjb3JyZWN0IGluY2x1ZGUgYm90aAo+IGYy YjdjNDkxOTE2ZCAoInNldF9tZW1vcnk6IGFsbG93IHF1ZXJ5aW5nIHdoZXRoZXIgc2V0X2RpcmVj dF9tYXBfKigpIGlzIGFjdHVhbGx5IGVuYWJsZWQiKQo+IGFuZCA0YzRjNzU4ODE1MzYgKCJhcm02 NCwga2ZlbmNlOiBlbmFibGUgS0ZFTkNFIGZvciBBUk02NCIpIHdlbnQgaW4gdGhlCj4gc2FtZSBk YXkgdmlhIGRpZmZlcmVudCB0cmVlcy4KPgo+IFNpZ25lZC1vZmYtYnk6IEFuZGVycyBSb3hlbGwg PGFuZGVycy5yb3hlbGxAbGluYXJvLm9yZz4KUmV2aWV3ZWQtYnk6IEFsZXhhbmRlciBQb3RhcGVu a28gPGdsaWRlckBnb29nbGUuY29tPgoKClRoYW5rcyEKCj4gLS0tCj4KPiBJIGdvdCB0aGlzIGJ1 aWxkIGVycm9yIGluIHRvZGF5cyBuZXh0LTIwMjAxMjA0Lgo+IEFuZHJldywgc2luY2UgYm90aCBw YXRjaGVzIGFyZSBpbiB5b3VyIC1tbSB0cmVlLCBJIHRoaW5rIHRoaXMgY2FuIGJlCj4gZm9sZGVk IGludG8gNGM0Yzc1ODgxNTM2ICgiYXJtNjQsIGtmZW5jZTogZW5hYmxlIEtGRU5DRSBmb3IgQVJN NjQiKQo+Cj4gIGFyY2gvYXJtNjQvaW5jbHVkZS9hc20va2ZlbmNlLmggfCAyICstCj4gIDEgZmls ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBh L2FyY2gvYXJtNjQvaW5jbHVkZS9hc20va2ZlbmNlLmggYi9hcmNoL2FybTY0L2luY2x1ZGUvYXNt L2tmZW5jZS5oCj4gaW5kZXggNmMwYWZlZWFiNjM1Li5jNDRiYjM2OGE4MTAgMTAwNjQ0Cj4gLS0t IGEvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9rZmVuY2UuaAo+ICsrKyBiL2FyY2gvYXJtNjQvaW5j bHVkZS9hc20va2ZlbmNlLmgKPiBAQCAtMyw3ICszLDcgQEAKPiAgI2lmbmRlZiBfX0FTTV9LRkVO Q0VfSAo+ICAjZGVmaW5lIF9fQVNNX0tGRU5DRV9ICj4KPiAtI2luY2x1ZGUgPGFzbS9jYWNoZWZs dXNoLmg+Cj4gKyNpbmNsdWRlIDxhc20vc2V0X21lbW9yeS5oPgo+Cj4gIHN0YXRpYyBpbmxpbmUg Ym9vbCBhcmNoX2tmZW5jZV9pbml0X3Bvb2wodm9pZCkgeyByZXR1cm4gdHJ1ZTsgfQo+Cj4gLS0K PiAyLjI5LjIKPgoKCi0tIApBbGV4YW5kZXIgUG90YXBlbmtvClNvZnR3YXJlIEVuZ2luZWVyCgpH b29nbGUgR2VybWFueSBHbWJICkVyaWthLU1hbm4tU3RyYcOfZSwgMzMKODA2MzYgTcO8bmNoZW4K Ckdlc2Now6RmdHNmw7xocmVyOiBQYXVsIE1hbmljbGUsIEhhbGltYWggRGVMYWluZSBQcmFkbwpS ZWdpc3RlcmdlcmljaHQgdW5kIC1udW1tZXI6IEhhbWJ1cmcsIEhSQiA4Njg5MQpTaXR6IGRlciBH ZXNlbGxzY2hhZnQ6IEhhbWJ1cmcKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK