From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0D9BC388F9 for ; Wed, 11 Nov 2020 14:13:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89D0D2072C for ; Wed, 11 Nov 2020 14:13:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Xw7CFjGz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727140AbgKKON1 (ORCPT ); Wed, 11 Nov 2020 09:13:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbgKKON0 (ORCPT ); Wed, 11 Nov 2020 09:13:26 -0500 Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B906C0613D1 for ; Wed, 11 Nov 2020 06:13:26 -0800 (PST) Received: by mail-qv1-xf42.google.com with SMTP id r12so901825qvq.13 for ; Wed, 11 Nov 2020 06:13:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=aZg/3dO+K+3/7egp9giqF6NxjGJW8QC5duS9to8aMlY=; b=Xw7CFjGzL8Kjfg/8OXuLrwhbg9ZP9ZHm/ZXt4h4x8mpl0H2vS4DZiwHFDn4SKHJ0mw tyjfvfVlgZQcF1VyCUd8kEy/ehZXpKHASrIJGa9KsHxzkTWcmFgv+09aEPXfS3D2zix0 FjEtZ1so6G8zYcXxpsrnXKwYXqmUICjTddFkNf7NI22OsCfIqu1BN+i5N31nYwBl+kR+ OPwqoRtYgbsU6nwtsZ81Z5mLoLiIckYMPEkXV8cfal2djwPNI2A0CrtKjCw1dVp4KKEh VzdXTpNLJ5UB4sJaANPV3Ri2Cvz4/Nt3L82gx/cZqJCsiMM2Lsllm8UgJFczjhV/uo57 mjVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=aZg/3dO+K+3/7egp9giqF6NxjGJW8QC5duS9to8aMlY=; b=eoLbZW0DcQF4++9dMJcuM6kHnmg6rd9VMSf+43juvJdduj7wTE7T3nHKScYa6YFVhH yLklRvlrulrIWoffvQDpgjOmKryfhBD4S8xEimLaKXfOc5fGgvF5epav3pV0RCS0C/FH tjUhAb1gUUccS9e5xf6q5vqpfHo0bpCeuJhYPTwSRAhjKc4upbVyjtGdpgwuSa3AI4RM 8P28sCKnsGD2iAYnTz2xHL5F6JdGUmM1WFAnwHuzQIg5qXFmF3Ax5pPc3pCa5Gw0ys8/ 5HuX2Edo1Zw9/FXUpXVA9HmGKUZWWumYDbGGZKoaHy2rv4jYIhJolllc3+vIQ3x6AJPy 8B0A== X-Gm-Message-State: AOAM532+HCxycKZhBv5/8nZw9GXyg+GT7uOQCYEVlvvJ+2OLt/20ml/K BpitdqrET5mHA0y50A7a4pNm9Gxwwi7f417IToOR3A== X-Google-Smtp-Source: ABdhPJy0oA37tH29jq6K/3f8eXTURhzdJBnfxbCpoDa4SIF888pNpma8ToBbSmYwnn/LMwKyWPnPeW4+dy1W+1T0FZk= X-Received: by 2002:a0c:9e53:: with SMTP id z19mr24630768qve.23.1605104005104; Wed, 11 Nov 2020 06:13:25 -0800 (PST) MIME-Version: 1.0 References: <85aba371903b749412fac34e44e54c89e5ddae30.1605046192.git.andreyknvl@google.com> In-Reply-To: <85aba371903b749412fac34e44e54c89e5ddae30.1605046192.git.andreyknvl@google.com> From: Alexander Potapenko Date: Wed, 11 Nov 2020 15:13:13 +0100 Message-ID: Subject: Re: [PATCH v9 10/44] kasan: define KASAN_GRANULE_PAGE To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 11:11 PM Andrey Konovalov w= rote: > > Define KASAN_GRANULE_PAGE as (KASAN_GRANULE_SIZE << PAGE_SHIFT), which is > the same as (KASAN_GRANULE_SIZE * PAGE_SIZE), and use it across KASAN cod= e > to simplify it. What's the physical sense behind KASAN_GRANULE_PAGE? Is it something more than just a product of two constants? The name suggests it might be something page-sized, but in reality it is no= t. > > Signed-off-by: Andrey Konovalov > Signed-off-by: Vincenzo Frascino > Reviewed-by: Marco Elver > --- > Change-Id: I0b627b24187d06c8b9bb2f1d04d94b3d06945e73 > --- > mm/kasan/init.c | 10 ++++------ > mm/kasan/kasan.h | 1 + > mm/kasan/shadow.c | 16 +++++++--------- > 3 files changed, 12 insertions(+), 15 deletions(-) > > diff --git a/mm/kasan/init.c b/mm/kasan/init.c > index 1a71eaa8c5f9..26b2663b3a42 100644 > --- a/mm/kasan/init.c > +++ b/mm/kasan/init.c > @@ -441,9 +441,8 @@ void kasan_remove_zero_shadow(void *start, unsigned l= ong size) > addr =3D (unsigned long)kasan_mem_to_shadow(start); > end =3D addr + (size >> KASAN_SHADOW_SCALE_SHIFT); > > - if (WARN_ON((unsigned long)start % > - (KASAN_GRANULE_SIZE * PAGE_SIZE)) || > - WARN_ON(size % (KASAN_GRANULE_SIZE * PAGE_SIZE))) > + if (WARN_ON((unsigned long)start % KASAN_GRANULE_PAGE) || > + WARN_ON(size % KASAN_GRANULE_PAGE)) > return; > > for (; addr < end; addr =3D next) { > @@ -476,9 +475,8 @@ int kasan_add_zero_shadow(void *start, unsigned long = size) > shadow_start =3D kasan_mem_to_shadow(start); > shadow_end =3D shadow_start + (size >> KASAN_SHADOW_SCALE_SHIFT); > > - if (WARN_ON((unsigned long)start % > - (KASAN_GRANULE_SIZE * PAGE_SIZE)) || > - WARN_ON(size % (KASAN_GRANULE_SIZE * PAGE_SIZE))) > + if (WARN_ON((unsigned long)start % KASAN_GRANULE_PAGE) || > + WARN_ON(size % KASAN_GRANULE_PAGE)) > return -EINVAL; > > ret =3D kasan_populate_early_shadow(shadow_start, shadow_end); > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index c31e2c739301..1865bb92d47a 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -7,6 +7,7 @@ > > #define KASAN_GRANULE_SIZE (1UL << KASAN_SHADOW_SCALE_SHIFT) > #define KASAN_GRANULE_MASK (KASAN_GRANULE_SIZE - 1) > +#define KASAN_GRANULE_PAGE (KASAN_GRANULE_SIZE << PAGE_SHIFT) > > #define KASAN_TAG_KERNEL 0xFF /* native kernel pointers tag */ > #define KASAN_TAG_INVALID 0xFE /* inaccessible memory tag */ > diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c > index ca0cc4c31454..1fadd4930d54 100644 > --- a/mm/kasan/shadow.c > +++ b/mm/kasan/shadow.c > @@ -161,7 +161,7 @@ static int __meminit kasan_mem_notifier(struct notifi= er_block *nb, > shadow_end =3D shadow_start + shadow_size; > > if (WARN_ON(mem_data->nr_pages % KASAN_GRANULE_SIZE) || > - WARN_ON(start_kaddr % (KASAN_GRANULE_SIZE << PAGE_SHIFT))= ) > + WARN_ON(start_kaddr % KASAN_GRANULE_PAGE)) > return NOTIFY_BAD; > > switch (action) { > @@ -432,22 +432,20 @@ void kasan_release_vmalloc(unsigned long start, uns= igned long end, > unsigned long region_start, region_end; > unsigned long size; > > - region_start =3D ALIGN(start, PAGE_SIZE * KASAN_GRANULE_SIZE); > - region_end =3D ALIGN_DOWN(end, PAGE_SIZE * KASAN_GRANULE_SIZE); > + region_start =3D ALIGN(start, KASAN_GRANULE_PAGE); > + region_end =3D ALIGN_DOWN(end, KASAN_GRANULE_PAGE); > > - free_region_start =3D ALIGN(free_region_start, > - PAGE_SIZE * KASAN_GRANULE_SIZE); > + free_region_start =3D ALIGN(free_region_start, KASAN_GRANULE_PAGE= ); > > if (start !=3D region_start && > free_region_start < region_start) > - region_start -=3D PAGE_SIZE * KASAN_GRANULE_SIZE; > + region_start -=3D KASAN_GRANULE_PAGE; > > - free_region_end =3D ALIGN_DOWN(free_region_end, > - PAGE_SIZE * KASAN_GRANULE_SIZE); > + free_region_end =3D ALIGN_DOWN(free_region_end, KASAN_GRANULE_PAG= E); > > if (end !=3D region_end && > free_region_end > region_end) > - region_end +=3D PAGE_SIZE * KASAN_GRANULE_SIZE; > + region_end +=3D KASAN_GRANULE_PAGE; > > shadow_start =3D kasan_mem_to_shadow((void *)region_start); > shadow_end =3D kasan_mem_to_shadow((void *)region_end); > -- > 2.29.2.222.g5d2a92d10f8-goog > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 386E8C388F9 for ; Wed, 11 Nov 2020 14:13:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 969B42072C for ; Wed, 11 Nov 2020 14:13:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Xw7CFjGz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 969B42072C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9255F6B0078; Wed, 11 Nov 2020 09:13:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D5366B007E; Wed, 11 Nov 2020 09:13:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 750BC6B0081; Wed, 11 Nov 2020 09:13:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id 4530A6B0078 for ; Wed, 11 Nov 2020 09:13:27 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E44AC8249980 for ; Wed, 11 Nov 2020 14:13:26 +0000 (UTC) X-FDA: 77472330012.11.sheep91_4b1026a272fe Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id BCCB8180F8B86 for ; Wed, 11 Nov 2020 14:13:26 +0000 (UTC) X-HE-Tag: sheep91_4b1026a272fe X-Filterd-Recvd-Size: 8404 Received: from mail-qv1-f65.google.com (mail-qv1-f65.google.com [209.85.219.65]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 14:13:25 +0000 (UTC) Received: by mail-qv1-f65.google.com with SMTP id z17so901736qvy.11 for ; Wed, 11 Nov 2020 06:13:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=aZg/3dO+K+3/7egp9giqF6NxjGJW8QC5duS9to8aMlY=; b=Xw7CFjGzL8Kjfg/8OXuLrwhbg9ZP9ZHm/ZXt4h4x8mpl0H2vS4DZiwHFDn4SKHJ0mw tyjfvfVlgZQcF1VyCUd8kEy/ehZXpKHASrIJGa9KsHxzkTWcmFgv+09aEPXfS3D2zix0 FjEtZ1so6G8zYcXxpsrnXKwYXqmUICjTddFkNf7NI22OsCfIqu1BN+i5N31nYwBl+kR+ OPwqoRtYgbsU6nwtsZ81Z5mLoLiIckYMPEkXV8cfal2djwPNI2A0CrtKjCw1dVp4KKEh VzdXTpNLJ5UB4sJaANPV3Ri2Cvz4/Nt3L82gx/cZqJCsiMM2Lsllm8UgJFczjhV/uo57 mjVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=aZg/3dO+K+3/7egp9giqF6NxjGJW8QC5duS9to8aMlY=; b=KlAlxJIc7sm9E+anxbuRZ1hHAcLmwyEf5ZfOkkQJQW6YTuneXocGfXq4ervZz3kvjW mCjCJnTCm+y8bAFjHsLXCkPOlk0je3DC9jT4vK8hN62yKecy77qSVcWtjsuelnaoZ9ns onAa1YxuqJnC1h845ckEaluCf3sPVXBcC0x2vI9iwKip1vXdVHB52jFebE6U+FawwfSy 3c7ZmRJi1EUf0DjHRSbyeuGU55aDUefcmDAxUsv5rELuG4B08+WlLcv0geLDQiEDA3un KlHRRyGLppr4Ljsy+9OW5pEEUG5e+vzRG+s/sMGM40TiaF6wjnzTI2VgViOIMSG2aMu9 UEjw== X-Gm-Message-State: AOAM530XskzQqszf/IVThX9+FZovjKODLiTc0EuZC+SqjTeFtNcMK8Su eIMEZqtmHvfyAyP4aferptJ8k2JI/ts+Ce7aZFRCpw== X-Google-Smtp-Source: ABdhPJy0oA37tH29jq6K/3f8eXTURhzdJBnfxbCpoDa4SIF888pNpma8ToBbSmYwnn/LMwKyWPnPeW4+dy1W+1T0FZk= X-Received: by 2002:a0c:9e53:: with SMTP id z19mr24630768qve.23.1605104005104; Wed, 11 Nov 2020 06:13:25 -0800 (PST) MIME-Version: 1.0 References: <85aba371903b749412fac34e44e54c89e5ddae30.1605046192.git.andreyknvl@google.com> In-Reply-To: <85aba371903b749412fac34e44e54c89e5ddae30.1605046192.git.andreyknvl@google.com> From: Alexander Potapenko Date: Wed, 11 Nov 2020 15:13:13 +0100 Message-ID: Subject: Re: [PATCH v9 10/44] kasan: define KASAN_GRANULE_PAGE To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 11:11 PM Andrey Konovalov w= rote: > > Define KASAN_GRANULE_PAGE as (KASAN_GRANULE_SIZE << PAGE_SHIFT), which is > the same as (KASAN_GRANULE_SIZE * PAGE_SIZE), and use it across KASAN cod= e > to simplify it. What's the physical sense behind KASAN_GRANULE_PAGE? Is it something more than just a product of two constants? The name suggests it might be something page-sized, but in reality it is no= t. > > Signed-off-by: Andrey Konovalov > Signed-off-by: Vincenzo Frascino > Reviewed-by: Marco Elver > --- > Change-Id: I0b627b24187d06c8b9bb2f1d04d94b3d06945e73 > --- > mm/kasan/init.c | 10 ++++------ > mm/kasan/kasan.h | 1 + > mm/kasan/shadow.c | 16 +++++++--------- > 3 files changed, 12 insertions(+), 15 deletions(-) > > diff --git a/mm/kasan/init.c b/mm/kasan/init.c > index 1a71eaa8c5f9..26b2663b3a42 100644 > --- a/mm/kasan/init.c > +++ b/mm/kasan/init.c > @@ -441,9 +441,8 @@ void kasan_remove_zero_shadow(void *start, unsigned l= ong size) > addr =3D (unsigned long)kasan_mem_to_shadow(start); > end =3D addr + (size >> KASAN_SHADOW_SCALE_SHIFT); > > - if (WARN_ON((unsigned long)start % > - (KASAN_GRANULE_SIZE * PAGE_SIZE)) || > - WARN_ON(size % (KASAN_GRANULE_SIZE * PAGE_SIZE))) > + if (WARN_ON((unsigned long)start % KASAN_GRANULE_PAGE) || > + WARN_ON(size % KASAN_GRANULE_PAGE)) > return; > > for (; addr < end; addr =3D next) { > @@ -476,9 +475,8 @@ int kasan_add_zero_shadow(void *start, unsigned long = size) > shadow_start =3D kasan_mem_to_shadow(start); > shadow_end =3D shadow_start + (size >> KASAN_SHADOW_SCALE_SHIFT); > > - if (WARN_ON((unsigned long)start % > - (KASAN_GRANULE_SIZE * PAGE_SIZE)) || > - WARN_ON(size % (KASAN_GRANULE_SIZE * PAGE_SIZE))) > + if (WARN_ON((unsigned long)start % KASAN_GRANULE_PAGE) || > + WARN_ON(size % KASAN_GRANULE_PAGE)) > return -EINVAL; > > ret =3D kasan_populate_early_shadow(shadow_start, shadow_end); > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index c31e2c739301..1865bb92d47a 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -7,6 +7,7 @@ > > #define KASAN_GRANULE_SIZE (1UL << KASAN_SHADOW_SCALE_SHIFT) > #define KASAN_GRANULE_MASK (KASAN_GRANULE_SIZE - 1) > +#define KASAN_GRANULE_PAGE (KASAN_GRANULE_SIZE << PAGE_SHIFT) > > #define KASAN_TAG_KERNEL 0xFF /* native kernel pointers tag */ > #define KASAN_TAG_INVALID 0xFE /* inaccessible memory tag */ > diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c > index ca0cc4c31454..1fadd4930d54 100644 > --- a/mm/kasan/shadow.c > +++ b/mm/kasan/shadow.c > @@ -161,7 +161,7 @@ static int __meminit kasan_mem_notifier(struct notifi= er_block *nb, > shadow_end =3D shadow_start + shadow_size; > > if (WARN_ON(mem_data->nr_pages % KASAN_GRANULE_SIZE) || > - WARN_ON(start_kaddr % (KASAN_GRANULE_SIZE << PAGE_SHIFT))= ) > + WARN_ON(start_kaddr % KASAN_GRANULE_PAGE)) > return NOTIFY_BAD; > > switch (action) { > @@ -432,22 +432,20 @@ void kasan_release_vmalloc(unsigned long start, uns= igned long end, > unsigned long region_start, region_end; > unsigned long size; > > - region_start =3D ALIGN(start, PAGE_SIZE * KASAN_GRANULE_SIZE); > - region_end =3D ALIGN_DOWN(end, PAGE_SIZE * KASAN_GRANULE_SIZE); > + region_start =3D ALIGN(start, KASAN_GRANULE_PAGE); > + region_end =3D ALIGN_DOWN(end, KASAN_GRANULE_PAGE); > > - free_region_start =3D ALIGN(free_region_start, > - PAGE_SIZE * KASAN_GRANULE_SIZE); > + free_region_start =3D ALIGN(free_region_start, KASAN_GRANULE_PAGE= ); > > if (start !=3D region_start && > free_region_start < region_start) > - region_start -=3D PAGE_SIZE * KASAN_GRANULE_SIZE; > + region_start -=3D KASAN_GRANULE_PAGE; > > - free_region_end =3D ALIGN_DOWN(free_region_end, > - PAGE_SIZE * KASAN_GRANULE_SIZE); > + free_region_end =3D ALIGN_DOWN(free_region_end, KASAN_GRANULE_PAG= E); > > if (end !=3D region_end && > free_region_end > region_end) > - region_end +=3D PAGE_SIZE * KASAN_GRANULE_SIZE; > + region_end +=3D KASAN_GRANULE_PAGE; > > shadow_start =3D kasan_mem_to_shadow((void *)region_start); > shadow_end =3D kasan_mem_to_shadow((void *)region_end); > -- > 2.29.2.222.g5d2a92d10f8-goog > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2472C388F9 for ; Wed, 11 Nov 2020 14:13:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17AC52074B for ; Wed, 11 Nov 2020 14:13:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Mov83Vge"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="Xw7CFjGz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17AC52074B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8zv3S0YRdXleOKMwxXiwj878Uwy+Ot/WdjjtrHNDY4w=; b=Mov83Vge4OJez3kpB8YR7V49J YEiygo5T7/LawAO4aPP5ffp/q9F82jJTIyWX/he546rRSxL/aZVHk5qWqeIhZaEDQCSWJHt/FJ8bx H0ht4r9fIxmbcmowI7s11HCoBdweFTlgMdZTeoSSKT2brdlygrKVMp9EUT7kqocOSYDUynmtrk0Sp RvoVv+HKoB3BAeYazrqD3L3ovdkCJQmFSq0jGZyPxgCwIUTVDUXGUH2XVzHQrhrsJLX8fk26jHj9t SzfL9v32Tl6WXGSA3o/Fkn4N0NrIQvXd3TtCnifz47UgPv2XFeE5nuHQfmiq+D9grl1i9D16whkOL nJ6+f208g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcqsM-0004N1-Dn; Wed, 11 Nov 2020 14:13:30 +0000 Received: from mail-qv1-xf43.google.com ([2607:f8b0:4864:20::f43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcqsJ-0004Ll-B0 for linux-arm-kernel@lists.infradead.org; Wed, 11 Nov 2020 14:13:28 +0000 Received: by mail-qv1-xf43.google.com with SMTP id y11so907149qvu.10 for ; Wed, 11 Nov 2020 06:13:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=aZg/3dO+K+3/7egp9giqF6NxjGJW8QC5duS9to8aMlY=; b=Xw7CFjGzL8Kjfg/8OXuLrwhbg9ZP9ZHm/ZXt4h4x8mpl0H2vS4DZiwHFDn4SKHJ0mw tyjfvfVlgZQcF1VyCUd8kEy/ehZXpKHASrIJGa9KsHxzkTWcmFgv+09aEPXfS3D2zix0 FjEtZ1so6G8zYcXxpsrnXKwYXqmUICjTddFkNf7NI22OsCfIqu1BN+i5N31nYwBl+kR+ OPwqoRtYgbsU6nwtsZ81Z5mLoLiIckYMPEkXV8cfal2djwPNI2A0CrtKjCw1dVp4KKEh VzdXTpNLJ5UB4sJaANPV3Ri2Cvz4/Nt3L82gx/cZqJCsiMM2Lsllm8UgJFczjhV/uo57 mjVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=aZg/3dO+K+3/7egp9giqF6NxjGJW8QC5duS9to8aMlY=; b=Wk9oCT9VnLUdy8WnnqY2xDKN9U5uwkTs/nzt2DT/Qfbi2Co0r8lHkS9zV1QucmCDYD 0i84Ydp40+zrAVpji5pXnxTW3ilBIQLT1gP0Lg6gl7/bAkc8kn/uRpefCVxWczqKFTLZ 9519qK4Lpkf4j6r30b5LswO2ge+EV+WyR7YtHNDYtahw1JEJu1G7UU6BGfWdxsRx/YDn 36E8D4eVbdUnIJW9p8pMaZoDkSMWG3wvfOGjMH+Vuk61KIgjHNuE0F1FKdOIprzvGHGc ehGP+MOC+lzOuTB+kY8kt5iBD8NKiuEgwSsVUi/CDdAGWtA5zhZ3ukImxh8n7Mwag17l MZFw== X-Gm-Message-State: AOAM530kslKltAPohGzymF8h6/OvQly9CXq6kYNXvEQMf/fLAZjYKlLl 157Ygb5ajz/1pLN3Pp/xpfVe+6/+yp9Q1ofAPK3wxQ== X-Google-Smtp-Source: ABdhPJy0oA37tH29jq6K/3f8eXTURhzdJBnfxbCpoDa4SIF888pNpma8ToBbSmYwnn/LMwKyWPnPeW4+dy1W+1T0FZk= X-Received: by 2002:a0c:9e53:: with SMTP id z19mr24630768qve.23.1605104005104; Wed, 11 Nov 2020 06:13:25 -0800 (PST) MIME-Version: 1.0 References: <85aba371903b749412fac34e44e54c89e5ddae30.1605046192.git.andreyknvl@google.com> In-Reply-To: <85aba371903b749412fac34e44e54c89e5ddae30.1605046192.git.andreyknvl@google.com> From: Alexander Potapenko Date: Wed, 11 Nov 2020 15:13:13 +0100 Message-ID: Subject: Re: [PATCH v9 10/44] kasan: define KASAN_GRANULE_PAGE To: Andrey Konovalov X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201111_091327_433435_D4A64EB2 X-CRM114-Status: GOOD ( 20.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Marco Elver , Catalin Marinas , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev , LKML , Linux Memory Management List , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Dmitry Vyukov Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBOb3YgMTAsIDIwMjAgYXQgMTE6MTEgUE0gQW5kcmV5IEtvbm92YWxvdiA8YW5kcmV5 a252bEBnb29nbGUuY29tPiB3cm90ZToKPgo+IERlZmluZSBLQVNBTl9HUkFOVUxFX1BBR0UgYXMg KEtBU0FOX0dSQU5VTEVfU0laRSA8PCBQQUdFX1NISUZUKSwgd2hpY2ggaXMKPiB0aGUgc2FtZSBh cyAoS0FTQU5fR1JBTlVMRV9TSVpFICogUEFHRV9TSVpFKSwgYW5kIHVzZSBpdCBhY3Jvc3MgS0FT QU4gY29kZQo+IHRvIHNpbXBsaWZ5IGl0LgoKV2hhdCdzIHRoZSBwaHlzaWNhbCBzZW5zZSBiZWhp bmQgS0FTQU5fR1JBTlVMRV9QQUdFPyBJcyBpdCBzb21ldGhpbmcKbW9yZSB0aGFuIGp1c3QgYSBw cm9kdWN0IG9mIHR3byBjb25zdGFudHM/ClRoZSBuYW1lIHN1Z2dlc3RzIGl0IG1pZ2h0IGJlIHNv bWV0aGluZyBwYWdlLXNpemVkLCBidXQgaW4gcmVhbGl0eSBpdCBpcyBub3QuCgo+Cj4gU2lnbmVk LW9mZi1ieTogQW5kcmV5IEtvbm92YWxvdiA8YW5kcmV5a252bEBnb29nbGUuY29tPgo+IFNpZ25l ZC1vZmYtYnk6IFZpbmNlbnpvIEZyYXNjaW5vIDx2aW5jZW56by5mcmFzY2lub0Bhcm0uY29tPgo+ IFJldmlld2VkLWJ5OiBNYXJjbyBFbHZlciA8ZWx2ZXJAZ29vZ2xlLmNvbT4KPiAtLS0KPiBDaGFu Z2UtSWQ6IEkwYjYyN2IyNDE4N2QwNmM4YjliYjJmMWQwNGQ5NGIzZDA2OTQ1ZTczCj4gLS0tCj4g IG1tL2thc2FuL2luaXQuYyAgIHwgMTAgKysrKy0tLS0tLQo+ICBtbS9rYXNhbi9rYXNhbi5oICB8 ICAxICsKPiAgbW0va2FzYW4vc2hhZG93LmMgfCAxNiArKysrKysrLS0tLS0tLS0tCj4gIDMgZmls ZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0t Z2l0IGEvbW0va2FzYW4vaW5pdC5jIGIvbW0va2FzYW4vaW5pdC5jCj4gaW5kZXggMWE3MWVhYThj NWY5Li4yNmIyNjYzYjNhNDIgMTAwNjQ0Cj4gLS0tIGEvbW0va2FzYW4vaW5pdC5jCj4gKysrIGIv bW0va2FzYW4vaW5pdC5jCj4gQEAgLTQ0MSw5ICs0NDEsOCBAQCB2b2lkIGthc2FuX3JlbW92ZV96 ZXJvX3NoYWRvdyh2b2lkICpzdGFydCwgdW5zaWduZWQgbG9uZyBzaXplKQo+ICAgICAgICAgYWRk ciA9ICh1bnNpZ25lZCBsb25nKWthc2FuX21lbV90b19zaGFkb3coc3RhcnQpOwo+ICAgICAgICAg ZW5kID0gYWRkciArIChzaXplID4+IEtBU0FOX1NIQURPV19TQ0FMRV9TSElGVCk7Cj4KPiAtICAg ICAgIGlmIChXQVJOX09OKCh1bnNpZ25lZCBsb25nKXN0YXJ0ICUKPiAtICAgICAgICAgICAgICAg ICAgICAgICAoS0FTQU5fR1JBTlVMRV9TSVpFICogUEFHRV9TSVpFKSkgfHwKPiAtICAgICAgICAg ICBXQVJOX09OKHNpemUgJSAoS0FTQU5fR1JBTlVMRV9TSVpFICogUEFHRV9TSVpFKSkpCj4gKyAg ICAgICBpZiAoV0FSTl9PTigodW5zaWduZWQgbG9uZylzdGFydCAlIEtBU0FOX0dSQU5VTEVfUEFH RSkgfHwKPiArICAgICAgICAgICBXQVJOX09OKHNpemUgJSBLQVNBTl9HUkFOVUxFX1BBR0UpKQo+ ICAgICAgICAgICAgICAgICByZXR1cm47Cj4KPiAgICAgICAgIGZvciAoOyBhZGRyIDwgZW5kOyBh ZGRyID0gbmV4dCkgewo+IEBAIC00NzYsOSArNDc1LDggQEAgaW50IGthc2FuX2FkZF96ZXJvX3No YWRvdyh2b2lkICpzdGFydCwgdW5zaWduZWQgbG9uZyBzaXplKQo+ICAgICAgICAgc2hhZG93X3N0 YXJ0ID0ga2FzYW5fbWVtX3RvX3NoYWRvdyhzdGFydCk7Cj4gICAgICAgICBzaGFkb3dfZW5kID0g c2hhZG93X3N0YXJ0ICsgKHNpemUgPj4gS0FTQU5fU0hBRE9XX1NDQUxFX1NISUZUKTsKPgo+IC0g ICAgICAgaWYgKFdBUk5fT04oKHVuc2lnbmVkIGxvbmcpc3RhcnQgJQo+IC0gICAgICAgICAgICAg ICAgICAgICAgIChLQVNBTl9HUkFOVUxFX1NJWkUgKiBQQUdFX1NJWkUpKSB8fAo+IC0gICAgICAg ICAgIFdBUk5fT04oc2l6ZSAlIChLQVNBTl9HUkFOVUxFX1NJWkUgKiBQQUdFX1NJWkUpKSkKPiAr ICAgICAgIGlmIChXQVJOX09OKCh1bnNpZ25lZCBsb25nKXN0YXJ0ICUgS0FTQU5fR1JBTlVMRV9Q QUdFKSB8fAo+ICsgICAgICAgICAgIFdBUk5fT04oc2l6ZSAlIEtBU0FOX0dSQU5VTEVfUEFHRSkp Cj4gICAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+Cj4gICAgICAgICByZXQgPSBrYXNh bl9wb3B1bGF0ZV9lYXJseV9zaGFkb3coc2hhZG93X3N0YXJ0LCBzaGFkb3dfZW5kKTsKPiBkaWZm IC0tZ2l0IGEvbW0va2FzYW4va2FzYW4uaCBiL21tL2thc2FuL2thc2FuLmgKPiBpbmRleCBjMzFl MmM3MzkzMDEuLjE4NjViYjkyZDQ3YSAxMDA2NDQKPiAtLS0gYS9tbS9rYXNhbi9rYXNhbi5oCj4g KysrIGIvbW0va2FzYW4va2FzYW4uaAo+IEBAIC03LDYgKzcsNyBAQAo+Cj4gICNkZWZpbmUgS0FT QU5fR1JBTlVMRV9TSVpFICAgICAoMVVMIDw8IEtBU0FOX1NIQURPV19TQ0FMRV9TSElGVCkKPiAg I2RlZmluZSBLQVNBTl9HUkFOVUxFX01BU0sgICAgIChLQVNBTl9HUkFOVUxFX1NJWkUgLSAxKQo+ ICsjZGVmaW5lIEtBU0FOX0dSQU5VTEVfUEFHRSAgICAgKEtBU0FOX0dSQU5VTEVfU0laRSA8PCBQ QUdFX1NISUZUKQo+Cj4gICNkZWZpbmUgS0FTQU5fVEFHX0tFUk5FTCAgICAgICAweEZGIC8qIG5h dGl2ZSBrZXJuZWwgcG9pbnRlcnMgdGFnICovCj4gICNkZWZpbmUgS0FTQU5fVEFHX0lOVkFMSUQg ICAgICAweEZFIC8qIGluYWNjZXNzaWJsZSBtZW1vcnkgdGFnICovCj4gZGlmZiAtLWdpdCBhL21t L2thc2FuL3NoYWRvdy5jIGIvbW0va2FzYW4vc2hhZG93LmMKPiBpbmRleCBjYTBjYzRjMzE0NTQu LjFmYWRkNDkzMGQ1NCAxMDA2NDQKPiAtLS0gYS9tbS9rYXNhbi9zaGFkb3cuYwo+ICsrKyBiL21t L2thc2FuL3NoYWRvdy5jCj4gQEAgLTE2MSw3ICsxNjEsNyBAQCBzdGF0aWMgaW50IF9fbWVtaW5p dCBrYXNhbl9tZW1fbm90aWZpZXIoc3RydWN0IG5vdGlmaWVyX2Jsb2NrICpuYiwKPiAgICAgICAg IHNoYWRvd19lbmQgPSBzaGFkb3dfc3RhcnQgKyBzaGFkb3dfc2l6ZTsKPgo+ICAgICAgICAgaWYg KFdBUk5fT04obWVtX2RhdGEtPm5yX3BhZ2VzICUgS0FTQU5fR1JBTlVMRV9TSVpFKSB8fAo+IC0g ICAgICAgICAgICAgICBXQVJOX09OKHN0YXJ0X2thZGRyICUgKEtBU0FOX0dSQU5VTEVfU0laRSA8 PCBQQUdFX1NISUZUKSkpCj4gKyAgICAgICAgICAgICAgIFdBUk5fT04oc3RhcnRfa2FkZHIgJSBL QVNBTl9HUkFOVUxFX1BBR0UpKQo+ICAgICAgICAgICAgICAgICByZXR1cm4gTk9USUZZX0JBRDsK Pgo+ICAgICAgICAgc3dpdGNoIChhY3Rpb24pIHsKPiBAQCAtNDMyLDIyICs0MzIsMjAgQEAgdm9p ZCBrYXNhbl9yZWxlYXNlX3ZtYWxsb2ModW5zaWduZWQgbG9uZyBzdGFydCwgdW5zaWduZWQgbG9u ZyBlbmQsCj4gICAgICAgICB1bnNpZ25lZCBsb25nIHJlZ2lvbl9zdGFydCwgcmVnaW9uX2VuZDsK PiAgICAgICAgIHVuc2lnbmVkIGxvbmcgc2l6ZTsKPgo+IC0gICAgICAgcmVnaW9uX3N0YXJ0ID0g QUxJR04oc3RhcnQsIFBBR0VfU0laRSAqIEtBU0FOX0dSQU5VTEVfU0laRSk7Cj4gLSAgICAgICBy ZWdpb25fZW5kID0gQUxJR05fRE9XTihlbmQsIFBBR0VfU0laRSAqIEtBU0FOX0dSQU5VTEVfU0la RSk7Cj4gKyAgICAgICByZWdpb25fc3RhcnQgPSBBTElHTihzdGFydCwgS0FTQU5fR1JBTlVMRV9Q QUdFKTsKPiArICAgICAgIHJlZ2lvbl9lbmQgPSBBTElHTl9ET1dOKGVuZCwgS0FTQU5fR1JBTlVM RV9QQUdFKTsKPgo+IC0gICAgICAgZnJlZV9yZWdpb25fc3RhcnQgPSBBTElHTihmcmVlX3JlZ2lv bl9zdGFydCwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUEFHRV9TSVpFICog S0FTQU5fR1JBTlVMRV9TSVpFKTsKPiArICAgICAgIGZyZWVfcmVnaW9uX3N0YXJ0ID0gQUxJR04o ZnJlZV9yZWdpb25fc3RhcnQsIEtBU0FOX0dSQU5VTEVfUEFHRSk7Cj4KPiAgICAgICAgIGlmIChz dGFydCAhPSByZWdpb25fc3RhcnQgJiYKPiAgICAgICAgICAgICBmcmVlX3JlZ2lvbl9zdGFydCA8 IHJlZ2lvbl9zdGFydCkKPiAtICAgICAgICAgICAgICAgcmVnaW9uX3N0YXJ0IC09IFBBR0VfU0la RSAqIEtBU0FOX0dSQU5VTEVfU0laRTsKPiArICAgICAgICAgICAgICAgcmVnaW9uX3N0YXJ0IC09 IEtBU0FOX0dSQU5VTEVfUEFHRTsKPgo+IC0gICAgICAgZnJlZV9yZWdpb25fZW5kID0gQUxJR05f RE9XTihmcmVlX3JlZ2lvbl9lbmQsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFBBR0VfU0laRSAqIEtBU0FOX0dSQU5VTEVfU0laRSk7Cj4gKyAgICAgICBmcmVlX3JlZ2lv bl9lbmQgPSBBTElHTl9ET1dOKGZyZWVfcmVnaW9uX2VuZCwgS0FTQU5fR1JBTlVMRV9QQUdFKTsK Pgo+ICAgICAgICAgaWYgKGVuZCAhPSByZWdpb25fZW5kICYmCj4gICAgICAgICAgICAgZnJlZV9y ZWdpb25fZW5kID4gcmVnaW9uX2VuZCkKPiAtICAgICAgICAgICAgICAgcmVnaW9uX2VuZCArPSBQ QUdFX1NJWkUgKiBLQVNBTl9HUkFOVUxFX1NJWkU7Cj4gKyAgICAgICAgICAgICAgIHJlZ2lvbl9l bmQgKz0gS0FTQU5fR1JBTlVMRV9QQUdFOwo+Cj4gICAgICAgICBzaGFkb3dfc3RhcnQgPSBrYXNh bl9tZW1fdG9fc2hhZG93KCh2b2lkICopcmVnaW9uX3N0YXJ0KTsKPiAgICAgICAgIHNoYWRvd19l bmQgPSBrYXNhbl9tZW1fdG9fc2hhZG93KCh2b2lkICopcmVnaW9uX2VuZCk7Cj4gLS0KPiAyLjI5 LjIuMjIyLmc1ZDJhOTJkMTBmOC1nb29nCj4KCgotLSAKQWxleGFuZGVyIFBvdGFwZW5rbwpTb2Z0 d2FyZSBFbmdpbmVlcgoKR29vZ2xlIEdlcm1hbnkgR21iSApFcmlrYS1NYW5uLVN0cmHDn2UsIDMz CjgwNjM2IE3DvG5jaGVuCgpHZXNjaMOkZnRzZsO8aHJlcjogUGF1bCBNYW5pY2xlLCBIYWxpbWFo IERlTGFpbmUgUHJhZG8KUmVnaXN0ZXJnZXJpY2h0IHVuZCAtbnVtbWVyOiBIYW1idXJnLCBIUkIg ODY4OTEKU2l0eiBkZXIgR2VzZWxsc2NoYWZ0OiBIYW1idXJnCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==