From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70356C25B4E for ; Tue, 24 Jan 2023 10:52:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233453AbjAXKwL (ORCPT ); Tue, 24 Jan 2023 05:52:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233482AbjAXKwJ (ORCPT ); Tue, 24 Jan 2023 05:52:09 -0500 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BF6044B1 for ; Tue, 24 Jan 2023 02:52:07 -0800 (PST) Received: by mail-il1-x12c.google.com with SMTP id g16so1376923ilr.1 for ; Tue, 24 Jan 2023 02:52:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PZZkl0nuhDOnpS6mpTFr8PbXxlSJ2XVVn7nhNW4knVE=; b=eysX+ECnIsH4FMjfUYT/LQAt9n6rglG6tqxiFcoAUICMiQfGdw6uRCYzxropjiIHWX aGm0Ai3CVpIR3vF+EduIDOySpa/9Cs7/A0TdpklPuDWKFUgQZpGb/QUx7y/gmG1+gJQT R0EgI2WlD8RTdP4mKPBp2BIR3O5cm0XeN7nPZ0SG8//AUcx383pwBNqlJlupg5yLuFLh /Bt4ywpI6JPeuzM6XnPuB0hUMriFJgSFDg1wnWsB4yXnlV+fcImKNZFnp8e56Zo2rLxF LM6SKfI/YCy26+jyb1ULwBcIRsTXvzHOZMkpI89Kjz5MQ29Qw33zMIR8Bf4V25RxB/nC pH4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PZZkl0nuhDOnpS6mpTFr8PbXxlSJ2XVVn7nhNW4knVE=; b=EB2KraxfnYRCqaDowJI4ZNFx4mEYeLfLXRjfuQLamp9PGWAZuDKx6Xsv3UXKXytVZ+ u9uhN2R6qYdrnUvlIIuUjA7FNzHSlJTUUSXP8I+bzPPVHWRp2l2lTM+bU8MDlXxpG1K7 o+K8RWYpXuO5jvwjniuG91MEJPXCNdiO6J2YRs2nppvNOLA0Jbsi60DHAbKFDWlhq/f7 Ywap2z3Dg0RxrGiWjacdAm+JEQqHZ3TKgB+aQUbyMKTe2YvF5sh+wMJOiG8pHuxndjFl jr4SVsno6RQRF8CRsNnE2tEO9rcd69mtkRXQh1F7ezGDAwoGvuOMhtPWDYNR3LpW+adb qGrg== X-Gm-Message-State: AFqh2kq1wcEjSou6qDMH0D8RQfT71wF9qtPVs7sbnvuSCjN52wxrBOK8 koc9dcX+Y/rucBt9JSHaDGF0SShaXtzxkDtLhJGDqfPtiDfDs+tSeBU= X-Google-Smtp-Source: AMrXdXs9ga503SwE+09dmDEVZS1/XV2RvPbDoA7tJR1Y92okF1PYzLfNb1qZ9UTKSZ00MIBxwWsvnEHJ4Bii4h03Zso= X-Received: by 2002:a05:6e02:88d:b0:30f:5d21:e56 with SMTP id z13-20020a056e02088d00b0030f5d210e56mr1230055ils.192.1674557526609; Tue, 24 Jan 2023 02:52:06 -0800 (PST) MIME-Version: 1.0 References: <20221121112134.407362-1-glider@google.com> <20221121112134.407362-4-glider@google.com> In-Reply-To: <20221121112134.407362-4-glider@google.com> From: Alexander Potapenko Date: Tue, 24 Jan 2023 11:51:30 +0100 Message-ID: Subject: Re: [PATCH 4/5] fs: hfs: initialize fsdata in hfs_file_truncate() To: glider@google.com Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, chao@kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 21, 2022 at 12:21 PM Alexander Potapenko wrote: > > When aops->write_begin() does not initialize fsdata, KMSAN may report > an error passing the latter to aops->write_end(). > > Fix this by unconditionally initializing fsdata. > > Suggested-by: Eric Biggers > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Alexander Potapenko Dear FS maintainers, HFS/HFSPLUS are orphaned, can someone take this patch to their tree? Thanks in advance! (same for "fs: hfsplus: initialize fsdata in hfsplus_file_truncate()": https://lore.kernel.org/all/20221121112134.407362-5-glider@google.com/) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD4EFC25B50 for ; Tue, 24 Jan 2023 11:15:37 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pKHH6-0002PK-Og; Tue, 24 Jan 2023 11:15:36 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pKHH4-0002PD-6R for linux-f2fs-devel@lists.sourceforge.net; Tue, 24 Jan 2023 11:15:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PZZkl0nuhDOnpS6mpTFr8PbXxlSJ2XVVn7nhNW4knVE=; b=KjAejuEGTrI6fRwWpdnVtLooDu UZw/Q7W7vAS0vbj75KqPFrZL5WMy6IaJUEq+XuDcjZ+70o4UR8pA5lhblwWsUZM1i4/9qTsOI8WLT zulWZoABKnVGScVMVNBhyFgdQil8/rg4P1X4gNAEabqC0mygOsf6FjRXmg/9mVfD+yCQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PZZkl0nuhDOnpS6mpTFr8PbXxlSJ2XVVn7nhNW4knVE=; b=Yget3UmDS2xQF0gyXkffijkTtj SOgEJe+Mrq0lgY15zGHB0RLM2Wocf3QFcNxuI5/yxk/lPZhSu1R4nRBWm0uu45U05NVmVwOY6Ku3p kMmfvOfArSg+KH6J+OFxCrbINmevfYqJ5CDTM+QRqUn9P74JqR9rKeLSJIdgzj71yM6A=; Received: from mail-il1-f173.google.com ([209.85.166.173]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1pKHGz-00EFJc-1G for linux-f2fs-devel@lists.sourceforge.net; Tue, 24 Jan 2023 11:15:33 +0000 Received: by mail-il1-f173.google.com with SMTP id v6so7276039ilq.3 for ; Tue, 24 Jan 2023 03:15:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PZZkl0nuhDOnpS6mpTFr8PbXxlSJ2XVVn7nhNW4knVE=; b=eysX+ECnIsH4FMjfUYT/LQAt9n6rglG6tqxiFcoAUICMiQfGdw6uRCYzxropjiIHWX aGm0Ai3CVpIR3vF+EduIDOySpa/9Cs7/A0TdpklPuDWKFUgQZpGb/QUx7y/gmG1+gJQT R0EgI2WlD8RTdP4mKPBp2BIR3O5cm0XeN7nPZ0SG8//AUcx383pwBNqlJlupg5yLuFLh /Bt4ywpI6JPeuzM6XnPuB0hUMriFJgSFDg1wnWsB4yXnlV+fcImKNZFnp8e56Zo2rLxF LM6SKfI/YCy26+jyb1ULwBcIRsTXvzHOZMkpI89Kjz5MQ29Qw33zMIR8Bf4V25RxB/nC pH4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PZZkl0nuhDOnpS6mpTFr8PbXxlSJ2XVVn7nhNW4knVE=; b=B1NYv+dptW+Xmu1WvzBuMSH2LGF05tN50KOiylfDIy3SLwXF+RT1VROeN1LxOSpHTK qhFwgwbH/5qZXrl3xQVgn/vuFaSu6caETSRH3oHL23lTeiXqIx6f7qvYO8zwIWPiQbyg vFpLygNUrZoMDeBKXTCn7C4Z+V0hABO22C4V9wM2pVxLxRjqioRC9yGaKqztsb2fy7Z3 jrvQhFexLmnZHj7pEILHP8/y1cOVS+29molh1VBsmgsgAIO7/v30rNy9c0fBeS9iWcOm yJyW5q5Ki6Bec6/MgUrj4egfJCqFL86JGGWrzRag6yAqkYLAxMhZhjrjBB481tqSlkLT GWCw== X-Gm-Message-State: AFqh2krDgzMBtIDm+AF57zoce6QkkIU34LpgrzOIEPW+6KOqnKMcomM8 rfm5hLD5lMzc7th8OQUAiH6Lghhb4w5MQtN5UtLE2jqa4dW6iIuOxAU= X-Google-Smtp-Source: AMrXdXs9ga503SwE+09dmDEVZS1/XV2RvPbDoA7tJR1Y92okF1PYzLfNb1qZ9UTKSZ00MIBxwWsvnEHJ4Bii4h03Zso= X-Received: by 2002:a05:6e02:88d:b0:30f:5d21:e56 with SMTP id z13-20020a056e02088d00b0030f5d210e56mr1230055ils.192.1674557526609; Tue, 24 Jan 2023 02:52:06 -0800 (PST) MIME-Version: 1.0 References: <20221121112134.407362-1-glider@google.com> <20221121112134.407362-4-glider@google.com> In-Reply-To: <20221121112134.407362-4-glider@google.com> Date: Tue, 24 Jan 2023 11:51:30 +0100 Message-ID: To: glider@google.com X-Headers-End: 1pKHGz-00EFJc-1G Subject: Re: [f2fs-dev] [PATCH 4/5] fs: hfs: initialize fsdata in hfs_file_truncate() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Potapenko via Linux-f2fs-devel Reply-To: Alexander Potapenko Cc: tytso@mit.edu, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , adilger.kernel@dilger.ca, linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org, akpm@linux-foundation.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, Nov 21, 2022 at 12:21 PM Alexander Potapenko wrote: > > When aops->write_begin() does not initialize fsdata, KMSAN may report > an error passing the latter to aops->write_end(). > > Fix this by unconditionally initializing fsdata. > > Suggested-by: Eric Biggers > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Alexander Potapenko Dear FS maintainers, HFS/HFSPLUS are orphaned, can someone take this patch to their tree? Thanks in advance! (same for "fs: hfsplus: initialize fsdata in hfsplus_file_truncate()": https://lore.kernel.org/all/20221121112134.407362-5-glider@google.com/) _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel