From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E6DCC433B4 for ; Thu, 22 Apr 2021 10:38:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18C6461452 for ; Thu, 22 Apr 2021 10:38:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235833AbhDVKjZ (ORCPT ); Thu, 22 Apr 2021 06:39:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235611AbhDVKjW (ORCPT ); Thu, 22 Apr 2021 06:39:22 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AB14C06138B for ; Thu, 22 Apr 2021 03:38:48 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id u20so13580452qku.10 for ; Thu, 22 Apr 2021 03:38:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+J6itTyY+KkRgMA362LXOYaefIx+9LEyUZfAGr8mPwo=; b=Y6LzoE9MQ29pOpR4e5aTX3nSt9DP3s6j3P2cBOWI7KZubEzmMncFO430/4XhPzImbe y577F1el00RFXVwjsZzIXXKPhK9nL0CIIdrEhpWkNFYPrFWJqDkuNY64ThgGzr39bxEd 8yv6Ci1r/5UceeVj85d2Z/j4dRyhgf6z0cGvaC6wAD2vfBh+qRn7djsDcYKFqcSyJi96 HhJu0jXzeLc6yW+X05mHgE0SnjLlj2+KxFbDaJp6GdV2VMjEtC78/JRsoI72gK3d/14J haF7Oae5BilnWZUIEYtHNYN+rWXpeaZr3pjZbyPv+FWpQLgI0oBWvUrNwMLd2xb0Po6y 7WkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+J6itTyY+KkRgMA362LXOYaefIx+9LEyUZfAGr8mPwo=; b=cp4dMbAts+SpQVh/ExryBnCNLT1WyFXTvJpP9GgTjJLvEh6I24MSettJgCzhKHkg4U MSBgVHeoLiPzG3R4UBdSqaw+vbzpjSglv1rR1A1tUhP9PBHKX7Kd7MUi2SmLTMK5OhlC lJpsa0GPHAsrjYmg9G+A/GU8ieXlxsAB+WmFT/OU3hSkKZO7/9Z1WKSo2ON6oiAAenst BXSNGTfJuUC24+zV/dk8/jO9R+CsoNH0B6FG79AmRZIcIh+/H/7Fz9Z0eb368ep3EQtF Zc+YPtJdzx6ZTjxrhokCLXxDDPdySfnaky/3X6sPO67fgYpjKRJi4/4J/2neGf9rxH6z NXxQ== X-Gm-Message-State: AOAM533F2SqNK0UmxxbpKwjnwgL/Hch0RUG/xDYaL6yx8OBj0Nyzrg5K bQlnTQ+HeMDN2gQxEl4Z0wp0BL9XWAAC4yy5WFwu2A== X-Google-Smtp-Source: ABdhPJyuYoOQC5R/9dwkvBwdx4uQn/Do6ceMOsPScMmfihQcn0YYEj6uhEo2Wu9qpSVU5F/DGS631ZbXVvxqr5jcHQE= X-Received: by 2002:a37:42c3:: with SMTP id p186mr2972199qka.352.1619087927256; Thu, 22 Apr 2021 03:38:47 -0700 (PDT) MIME-Version: 1.0 References: <1619079317-1131-1-git-send-email-maninder1.s@samsung.com> <1619079317-1131-2-git-send-email-maninder1.s@samsung.com> In-Reply-To: From: Alexander Potapenko Date: Thu, 22 Apr 2021 12:38:11 +0200 Message-ID: Subject: Re: [PATCH 2/2] mm/kasan: proc interface to read KASAN errors at any time To: Dmitry Vyukov Cc: Maninder Singh , Marco Elver , Andrey Ryabinin , Andrey Konovalov , Andrew Morton , kasan-dev , Linux-MM , LKML , AMIT SAHRAWAT , Vaneet Narang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Alex, Marco, can the recently added error_report_notify interface be > used for this? Looks like they are doing roughly the same thing with > the same intentions. We've recently attempted to build a universal library capturing every error report, but then were pointed to tracefs, which was just enough for our purpose (https://lkml.org/lkml/2021/1/15/609). Greg also stated that procfs is a bad place for storing reports: https://lkml.org/lkml/2021/1/15/929. Maninder, which exactly problem are you trying to solve? Note that KASAN already triggers a trace_error_report_end tracepoint on every error report: https://elixir.bootlin.com/linux/v5.12-rc8/source/mm/kasan/report.c#L90 Would it help if you used that one? It could probably be extended with more parameters. Another option if you want verbatim reports is to use the console tracepoints, as this is done in https://elixir.bootlin.com/linux/v5.12-rc8/source/mm/kfence/kfence_test.c Note that there are many caveats with error report collection (see the links above), but for testing purpose it might be enough. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71A63C433ED for ; Thu, 22 Apr 2021 10:38:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CAFD961452 for ; Thu, 22 Apr 2021 10:38:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAFD961452 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3CD176B006C; Thu, 22 Apr 2021 06:38:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37DB76B006E; Thu, 22 Apr 2021 06:38:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21F556B0070; Thu, 22 Apr 2021 06:38:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id 08B456B006C for ; Thu, 22 Apr 2021 06:38:49 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A89152DFC for ; Thu, 22 Apr 2021 10:38:48 +0000 (UTC) X-FDA: 78059654736.13.0663880 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by imf06.hostedemail.com (Postfix) with ESMTP id 454ABC0007D8 for ; Thu, 22 Apr 2021 10:38:51 +0000 (UTC) Received: by mail-qk1-f170.google.com with SMTP id 66so6191294qkf.2 for ; Thu, 22 Apr 2021 03:38:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+J6itTyY+KkRgMA362LXOYaefIx+9LEyUZfAGr8mPwo=; b=Y6LzoE9MQ29pOpR4e5aTX3nSt9DP3s6j3P2cBOWI7KZubEzmMncFO430/4XhPzImbe y577F1el00RFXVwjsZzIXXKPhK9nL0CIIdrEhpWkNFYPrFWJqDkuNY64ThgGzr39bxEd 8yv6Ci1r/5UceeVj85d2Z/j4dRyhgf6z0cGvaC6wAD2vfBh+qRn7djsDcYKFqcSyJi96 HhJu0jXzeLc6yW+X05mHgE0SnjLlj2+KxFbDaJp6GdV2VMjEtC78/JRsoI72gK3d/14J haF7Oae5BilnWZUIEYtHNYN+rWXpeaZr3pjZbyPv+FWpQLgI0oBWvUrNwMLd2xb0Po6y 7WkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+J6itTyY+KkRgMA362LXOYaefIx+9LEyUZfAGr8mPwo=; b=fQaj5PmekJnYOZ5c7IAHXinyJYx79Q+1zMailgPLV7chLDIftYDzGnIY9aUmlHd6qo I4JofkY0eQeBgM1cTVRdUuJN62C3HcjKa8HXdTAsYT3QicB117BYlfVORyYt+3HCFKv3 ZcwUYefdMRJ3ba2Ty5LnJ0TN5JnTyUJXXKznCbAALf6gVLu2ZpVdGoYsXvTUSqFUud7l Bi+dRE9uVtg4G3aDvj4HkPhpPItQb9EjkxfhfYPYwU/F4geYBLp4UJ3++1pO8we3Edqj zT7GIXJaca7smGxOgrlhXl++issBVQ/Ba+NDlaZDmIGUKt+EmiLQDyH/WdnqvhVDUp5k PoKQ== X-Gm-Message-State: AOAM532jNDbk/SSZJzEjmjcvJH6RZ71nc61aYxmImSjdQkwSn1ny0Ze+ cyHk0aDGzkZPNUDqzZjd6P1TQEDbu9MiMmPw3CQN6Q== X-Google-Smtp-Source: ABdhPJyuYoOQC5R/9dwkvBwdx4uQn/Do6ceMOsPScMmfihQcn0YYEj6uhEo2Wu9qpSVU5F/DGS631ZbXVvxqr5jcHQE= X-Received: by 2002:a37:42c3:: with SMTP id p186mr2972199qka.352.1619087927256; Thu, 22 Apr 2021 03:38:47 -0700 (PDT) MIME-Version: 1.0 References: <1619079317-1131-1-git-send-email-maninder1.s@samsung.com> <1619079317-1131-2-git-send-email-maninder1.s@samsung.com> In-Reply-To: From: Alexander Potapenko Date: Thu, 22 Apr 2021 12:38:11 +0200 Message-ID: Subject: Re: [PATCH 2/2] mm/kasan: proc interface to read KASAN errors at any time To: Dmitry Vyukov Cc: Maninder Singh , Marco Elver , Andrey Ryabinin , Andrey Konovalov , Andrew Morton , kasan-dev , Linux-MM , LKML , AMIT SAHRAWAT , Vaneet Narang Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 454ABC0007D8 X-Stat-Signature: 9qydoerkcqksehze7m85wkji6m3qhtub X-Rspamd-Server: rspam02 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=mail-qk1-f170.google.com; client-ip=209.85.222.170 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619087931-733069 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Alex, Marco, can the recently added error_report_notify interface be > used for this? Looks like they are doing roughly the same thing with > the same intentions. We've recently attempted to build a universal library capturing every error report, but then were pointed to tracefs, which was just enough for our purpose (https://lkml.org/lkml/2021/1/15/609). Greg also stated that procfs is a bad place for storing reports: https://lkml.org/lkml/2021/1/15/929. Maninder, which exactly problem are you trying to solve? Note that KASAN already triggers a trace_error_report_end tracepoint on every error report: https://elixir.bootlin.com/linux/v5.12-rc8/source/mm/kasan/report.c#L90 Would it help if you used that one? It could probably be extended with more parameters. Another option if you want verbatim reports is to use the console tracepoints, as this is done in https://elixir.bootlin.com/linux/v5.12-rc8/source/mm/kfence/kfence_test.c Note that there are many caveats with error report collection (see the links above), but for testing purpose it might be enough. Alex