From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752830AbbESDIp (ORCPT ); Mon, 18 May 2015 23:08:45 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:51305 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752454AbbESDIo (ORCPT ); Mon, 18 May 2015 23:08:44 -0400 MIME-Version: 1.0 In-Reply-To: <20150517145426.GL4004@lukather> References: <1431583811-25780-1-git-send-email-wens@csie.org> <1431583811-25780-5-git-send-email-wens@csie.org> <20150517145426.GL4004@lukather> From: Chen-Yu Tsai Date: Tue, 19 May 2015 11:08:15 +0800 Message-ID: Subject: Re: [RFC 4/7] ARM: dts: sun9i: Add PRCM device node for the A80 dtsi To: Maxime Ripard Cc: Chen-Yu Tsai , Nicolas Pitre , Dave Martin , linux-arm-kernel , linux-kernel , linux-sunxi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 17, 2015 at 10:54 PM, Maxime Ripard wrote: > On Thu, May 14, 2015 at 02:10:08PM +0800, Chen-Yu Tsai wrote: >> The PRCM is a collection of clock controls, reset controls, and various >> power switches/gates. Some of these can be independently listed and >> supported, while a number of CPU related ones are used in tandem with >> CPUCFG for SMP bringup and CPU hotplugging. >> >> Signed-off-by: Chen-Yu Tsai >> --- >> arch/arm/boot/dts/sun9i-a80.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi >> index c45735398f6a..1507bd2a88f0 100644 >> --- a/arch/arm/boot/dts/sun9i-a80.dtsi >> +++ b/arch/arm/boot/dts/sun9i-a80.dtsi >> @@ -797,6 +797,11 @@ >> interrupts = ; >> }; >> >> + prcm@01700000 { >> + compatible = "allwinner,sun9i-a80-prcm"; >> + reg = <0x08001400 0x200>; >> + }; >> + > > The unit address doesn't match the content of the reg property. Obvious copy-paste error (facepalm) ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Tue, 19 May 2015 11:08:15 +0800 Subject: [RFC 4/7] ARM: dts: sun9i: Add PRCM device node for the A80 dtsi In-Reply-To: <20150517145426.GL4004@lukather> References: <1431583811-25780-1-git-send-email-wens@csie.org> <1431583811-25780-5-git-send-email-wens@csie.org> <20150517145426.GL4004@lukather> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, May 17, 2015 at 10:54 PM, Maxime Ripard wrote: > On Thu, May 14, 2015 at 02:10:08PM +0800, Chen-Yu Tsai wrote: >> The PRCM is a collection of clock controls, reset controls, and various >> power switches/gates. Some of these can be independently listed and >> supported, while a number of CPU related ones are used in tandem with >> CPUCFG for SMP bringup and CPU hotplugging. >> >> Signed-off-by: Chen-Yu Tsai >> --- >> arch/arm/boot/dts/sun9i-a80.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun9i-a80.dtsi b/arch/arm/boot/dts/sun9i-a80.dtsi >> index c45735398f6a..1507bd2a88f0 100644 >> --- a/arch/arm/boot/dts/sun9i-a80.dtsi >> +++ b/arch/arm/boot/dts/sun9i-a80.dtsi >> @@ -797,6 +797,11 @@ >> interrupts = ; >> }; >> >> + prcm at 01700000 { >> + compatible = "allwinner,sun9i-a80-prcm"; >> + reg = <0x08001400 0x200>; >> + }; >> + > > The unit address doesn't match the content of the reg property. Obvious copy-paste error (facepalm) ChenYu