From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH 0/6] pinctrl: sunxi: Allow to configure pull-up / pull-down from GPIO flags Date: Fri, 15 Mar 2019 10:57:06 +0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Maxime Ripard Cc: Bartosz Golaszewski , Linus Walleij , Thomas Petazzoni , linux-arm-kernel , "open list:GPIO SUBSYSTEM" List-Id: linux-gpio@vger.kernel.org On Fri, Mar 15, 2019 at 3:33 AM Maxime Ripard wrote: > > Hi, > > Here is a series that addresses one of the issues we've had for some time > with our pinctrl driver, which is that while we should have had the strict > mode enabled, we didn't and now we have to deal with all the DT having GPIO > and pinctrl nodes for the same pins. > > This was partially due to cargo cult (which has been addressed since), but > also due to technical limitations of the GPIO DT bindings at the time which > didn't allow to specify the pull-up and pull-down resistors, and the drive > strength of the pins. > > Now that the former are supported, we can remove those users, and we will > deal with the latter eventually. > > Let me know what you think, > Maxime > > Maxime Ripard (6): > gpio: Set proper argument value to set_config > pinctrl: sunxi: implement pin_config_set > pinctrl: sunxi: Fix variable assignment syntax > pinctrl: sunxi: Declare set_config on the GPIO chip > ARM: dts: sunxi: Remove pinctrl groups setting bias > ARM: dts: sunxi: Remove useless pinctrl nodes Acked-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C301BC43381 for ; Fri, 15 Mar 2019 02:57:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9119321872 for ; Fri, 15 Mar 2019 02:57:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RG8z++kl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9119321872 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6a+8+ShTfJGQevx0GbY8yJ9m1M+SDvyM9fShCPvzgNQ=; b=RG8z++klqkbOT4 b2m55nmBa46qMEy11q8OpWMxuNnaTjaFc/kZF0Z389hz5wcLkfOC4JbW0IhVfTVW4sppGRnG6aywh 2EtK0VMF3wxg31K+RAB/u1T7vmdnljV5+2YljWCkVDXIuYxcCZrT495gNCEp/HM//j0pKP00zGqBj uorm324k8wU0Rt54JOBQbsnzcgQwMwdoc/t8lppnWJ4iG9r9vYOD8B5S9fgryqISQFrzy75ffzbEm i8wbKZw8NgsVKbYLuNt1pszdwsmugRuR8/FJhGQJsx9nlfHvmx1o2EnrI9CRQVLsMACiLMMHgGuzN hGP4Qb+O7GYnlRbAakgA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4d2B-0000GK-AF; Fri, 15 Mar 2019 02:57:23 +0000 Received: from mail-ed1-f66.google.com ([209.85.208.66]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4d27-0000FV-G4 for linux-arm-kernel@lists.infradead.org; Fri, 15 Mar 2019 02:57:20 +0000 Received: by mail-ed1-f66.google.com with SMTP id r23so6366673edm.7 for ; Thu, 14 Mar 2019 19:57:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iwYri1NPAFzGouoZEKdgQhEMMu4SC7wpGO54u8oNJ0M=; b=HsbvkEWgSj0YCAKCNUJY4Bw11cgxEBiqQGBZ1RN9hoUsBcWYhK2vIlyaqFh3Dis7pg f3Pw0ABj7mqWBmimbWQytsfmkrMI+NF7mx7z3PVCCfZ2juqzOqN4kjIbAbThIin8gJJ/ 5gQ5gAccxrB1MOZcrDINGG/2ICF1DOQMyLPThmMsRWuQcJ7JG9/sp39xCYu05vGnSJcI sNX397+K5yYa+i1MmMN+BlWgYd6/Y6OTt7pOEqdZb3sNOK+tKvVi5mnvWWFGyTzTSiP7 Y9ycohQiIIjaQESbydINhEGMg+GIxRrE0SDLW5BjeSp6YnySPFgELQEK31pcf/23qGt9 1c1A== X-Gm-Message-State: APjAAAWRA3fsyEiwShGOSz54dSaxeA40upEOSqxXw4IiCD5UJZKiRX23 SXW3cJGtl2fjO35n5PyrEr4/fZiaFMQ= X-Google-Smtp-Source: APXvYqz0V8o0sfeRYFxq+owE5xgQ3Gq39dWkY9ceIc2k7Z+93I3oaVHviVarv0RsFdi/W9TXdyPvXg== X-Received: by 2002:a50:976a:: with SMTP id d39mr1049210edb.289.1552618637719; Thu, 14 Mar 2019 19:57:17 -0700 (PDT) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com. [209.85.221.46]) by smtp.gmail.com with ESMTPSA id d3sm248454edv.76.2019.03.14.19.57.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Mar 2019 19:57:16 -0700 (PDT) Received: by mail-wr1-f46.google.com with SMTP id n9so3884654wrr.9 for ; Thu, 14 Mar 2019 19:57:16 -0700 (PDT) X-Received: by 2002:a05:6000:1181:: with SMTP id g1mr668300wrx.177.1552618636677; Thu, 14 Mar 2019 19:57:16 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Chen-Yu Tsai Date: Fri, 15 Mar 2019 10:57:06 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/6] pinctrl: sunxi: Allow to configure pull-up / pull-down from GPIO flags To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190314_195719_537583_CCA4D32E X-CRM114-Status: GOOD ( 14.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartosz Golaszewski , Linus Walleij , Thomas Petazzoni , linux-arm-kernel , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 15, 2019 at 3:33 AM Maxime Ripard wrote: > > Hi, > > Here is a series that addresses one of the issues we've had for some time > with our pinctrl driver, which is that while we should have had the strict > mode enabled, we didn't and now we have to deal with all the DT having GPIO > and pinctrl nodes for the same pins. > > This was partially due to cargo cult (which has been addressed since), but > also due to technical limitations of the GPIO DT bindings at the time which > didn't allow to specify the pull-up and pull-down resistors, and the drive > strength of the pins. > > Now that the former are supported, we can remove those users, and we will > deal with the latter eventually. > > Let me know what you think, > Maxime > > Maxime Ripard (6): > gpio: Set proper argument value to set_config > pinctrl: sunxi: implement pin_config_set > pinctrl: sunxi: Fix variable assignment syntax > pinctrl: sunxi: Declare set_config on the GPIO chip > ARM: dts: sunxi: Remove pinctrl groups setting bias > ARM: dts: sunxi: Remove useless pinctrl nodes Acked-by: Chen-Yu Tsai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel