From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Date: Tue, 5 Aug 2014 09:24:10 +0800 Subject: [U-Boot] [PATCH 6/7] sunxi: Kconfig: move common settings into a shared code block In-Reply-To: <1407187560.23472.9.camel@dagon.hellion.org.uk> References: <1406879207-12322-1-git-send-email-hdegoede@redhat.com> <1406879207-12322-6-git-send-email-hdegoede@redhat.com> <1407187560.23472.9.camel@dagon.hellion.org.uk> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Aug 5, 2014 at 5:26 AM, Ian Campbell wrote: > On Fri, 2014-08-01 at 09:46 +0200, Hans de Goede wrote: >> SYS_CPU, SYS_BOARD and SYS_SOC are identical for all sunxi boards, move >> them to a shared code block. >> >> Signed-off-by: Hans de Goede > > This is an improvement so: > Acked-by: Ian Campbell > > But eventually we could clean up even more, e.g. > > config SYS_CONFIG_NAME > string > default "sun4i" if TARGET_SUN4I > default "sun5i" if TARGET_SUN5I > etc > > Possibly even some things should be select'd rather than default'd. Selected sounds better. :)