From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932472AbdDRKih (ORCPT ); Tue, 18 Apr 2017 06:38:37 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:38536 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932147AbdDRKid (ORCPT ); Tue, 18 Apr 2017 06:38:33 -0400 MIME-Version: 1.0 In-Reply-To: <20170417115747.7300-10-icenowy@aosc.io> References: <20170417115747.7300-1-icenowy@aosc.io> <20170417115747.7300-10-icenowy@aosc.io> From: Chen-Yu Tsai Date: Tue, 18 Apr 2017 18:38:09 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH v3 09/12] mfd: axp20x: add axp20x-regulator cell for AXP803 To: Icenowy Zheng Cc: Lee Jones , Rob Herring , Chen-Yu Tsai , Maxime Ripard , Liam Girdwood , Mark Brown , devicetree , linux-kernel , linux-arm-kernel , linux-sunxi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 17, 2017 at 7:57 PM, Icenowy Zheng wrote: > As axp20x-regulator now supports AXP803, add a cell for it. > > Signed-off-by: Icenowy Zheng > --- > Changes in v3: > - Make the new cell one-liner. > > drivers/mfd/axp20x.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 1dc6235778eb..431b7f118606 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -848,7 +848,8 @@ static struct mfd_cell axp803_cells[] = { > .name = "axp20x-pek", > .num_resources = ARRAY_SIZE(axp803_pek_resources), > .resources = axp803_pek_resources, > - } > + }, > + { .name = "axp20x-regulator" } It's best to have a trailing comma, so we don't have to change the line again when we add more cells, like you just did with the previous line. Otherwise, Acked-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [linux-sunxi] [PATCH v3 09/12] mfd: axp20x: add axp20x-regulator cell for AXP803 Date: Tue, 18 Apr 2017 18:38:09 +0800 Message-ID: References: <20170417115747.7300-1-icenowy@aosc.io> <20170417115747.7300-10-icenowy@aosc.io> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20170417115747.7300-10-icenowy-h8G6r0blFSE@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Icenowy Zheng Cc: Lee Jones , Rob Herring , Chen-Yu Tsai , Maxime Ripard , Liam Girdwood , Mark Brown , devicetree , linux-kernel , linux-arm-kernel , linux-sunxi List-Id: devicetree@vger.kernel.org On Mon, Apr 17, 2017 at 7:57 PM, Icenowy Zheng wrote: > As axp20x-regulator now supports AXP803, add a cell for it. > > Signed-off-by: Icenowy Zheng > --- > Changes in v3: > - Make the new cell one-liner. > > drivers/mfd/axp20x.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 1dc6235778eb..431b7f118606 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -848,7 +848,8 @@ static struct mfd_cell axp803_cells[] = { > .name = "axp20x-pek", > .num_resources = ARRAY_SIZE(axp803_pek_resources), > .resources = axp803_pek_resources, > - } > + }, > + { .name = "axp20x-regulator" } It's best to have a trailing comma, so we don't have to change the line again when we add more cells, like you just did with the previous line. Otherwise, Acked-by: Chen-Yu Tsai -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Tue, 18 Apr 2017 18:38:09 +0800 Subject: [linux-sunxi] [PATCH v3 09/12] mfd: axp20x: add axp20x-regulator cell for AXP803 In-Reply-To: <20170417115747.7300-10-icenowy@aosc.io> References: <20170417115747.7300-1-icenowy@aosc.io> <20170417115747.7300-10-icenowy@aosc.io> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Apr 17, 2017 at 7:57 PM, Icenowy Zheng wrote: > As axp20x-regulator now supports AXP803, add a cell for it. > > Signed-off-by: Icenowy Zheng > --- > Changes in v3: > - Make the new cell one-liner. > > drivers/mfd/axp20x.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 1dc6235778eb..431b7f118606 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -848,7 +848,8 @@ static struct mfd_cell axp803_cells[] = { > .name = "axp20x-pek", > .num_resources = ARRAY_SIZE(axp803_pek_resources), > .resources = axp803_pek_resources, > - } > + }, > + { .name = "axp20x-regulator" } It's best to have a trailing comma, so we don't have to change the line again when we add more cells, like you just did with the previous line. Otherwise, Acked-by: Chen-Yu Tsai