From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751979AbcDZOSa (ORCPT ); Tue, 26 Apr 2016 10:18:30 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:47948 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbcDZOS3 (ORCPT ); Tue, 26 Apr 2016 10:18:29 -0400 MIME-Version: 1.0 In-Reply-To: <1461679251-25538-1-git-send-email-maxime.ripard@free-electrons.com> References: <1461679251-25538-1-git-send-email-maxime.ripard@free-electrons.com> From: Chen-Yu Tsai Date: Tue, 26 Apr 2016 22:18:04 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] regulator: axp20x: Fix LDO4 linear voltage range To: Maxime Ripard Cc: Mark Brown , Chen-Yu Tsai , Liam Girdwood , linux-kernel , linux-arm-kernel , Hans De Goede Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 26, 2016 at 10:00 PM, Maxime Ripard wrote: > The current linear voltage range for the LDO4 regulator found in the APX20X > PMICs assumes that the voltage is linear between 2.5 and 3.1V. > > However, the PMIC can output up to 3.3V on that regulator by skipping the > 2.6V and 2.9V steps. > > Fix the ranges to read and set the proper voltages. > > Fixes: 13d57e64352a ("regulator: axp20x: Use linear voltage ranges for AXP20X LDO4") > Signed-off-by: Maxime Ripard Acked-by: Chen-Yu Tsai Hans sent an identical patch (plus another fix) a month ago though. > --- > Hi Mark, > > This patch fixes a commit merged into 4.6-rc1, so it should probably go in > the next -rc release. > > Thanks! > Maxime > > drivers/regulator/axp20x-regulator.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c > index 40cd894e4df5..29ab0985b46e 100644 > --- a/drivers/regulator/axp20x-regulator.c > +++ b/drivers/regulator/axp20x-regulator.c > @@ -157,7 +157,9 @@ static struct regulator_ops axp20x_ops_sw = { > static const struct regulator_linear_range axp20x_ldo4_ranges[] = { > REGULATOR_LINEAR_RANGE(1250000, 0x0, 0x0, 0), > REGULATOR_LINEAR_RANGE(1300000, 0x1, 0x8, 100000), > - REGULATOR_LINEAR_RANGE(2500000, 0x9, 0xf, 100000), > + REGULATOR_LINEAR_RANGE(2500000, 0x9, 0x9, 0), > + REGULATOR_LINEAR_RANGE(2700000, 0xa, 0xb, 100000), > + REGULATOR_LINEAR_RANGE(3000000, 0xc, 0xf, 100000), > }; > > static const struct regulator_desc axp20x_regulators[] = { > -- > 2.8.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Tue, 26 Apr 2016 22:18:04 +0800 Subject: [PATCH] regulator: axp20x: Fix LDO4 linear voltage range In-Reply-To: <1461679251-25538-1-git-send-email-maxime.ripard@free-electrons.com> References: <1461679251-25538-1-git-send-email-maxime.ripard@free-electrons.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Apr 26, 2016 at 10:00 PM, Maxime Ripard wrote: > The current linear voltage range for the LDO4 regulator found in the APX20X > PMICs assumes that the voltage is linear between 2.5 and 3.1V. > > However, the PMIC can output up to 3.3V on that regulator by skipping the > 2.6V and 2.9V steps. > > Fix the ranges to read and set the proper voltages. > > Fixes: 13d57e64352a ("regulator: axp20x: Use linear voltage ranges for AXP20X LDO4") > Signed-off-by: Maxime Ripard Acked-by: Chen-Yu Tsai Hans sent an identical patch (plus another fix) a month ago though. > --- > Hi Mark, > > This patch fixes a commit merged into 4.6-rc1, so it should probably go in > the next -rc release. > > Thanks! > Maxime > > drivers/regulator/axp20x-regulator.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c > index 40cd894e4df5..29ab0985b46e 100644 > --- a/drivers/regulator/axp20x-regulator.c > +++ b/drivers/regulator/axp20x-regulator.c > @@ -157,7 +157,9 @@ static struct regulator_ops axp20x_ops_sw = { > static const struct regulator_linear_range axp20x_ldo4_ranges[] = { > REGULATOR_LINEAR_RANGE(1250000, 0x0, 0x0, 0), > REGULATOR_LINEAR_RANGE(1300000, 0x1, 0x8, 100000), > - REGULATOR_LINEAR_RANGE(2500000, 0x9, 0xf, 100000), > + REGULATOR_LINEAR_RANGE(2500000, 0x9, 0x9, 0), > + REGULATOR_LINEAR_RANGE(2700000, 0xa, 0xb, 100000), > + REGULATOR_LINEAR_RANGE(3000000, 0xc, 0xf, 100000), > }; > > static const struct regulator_desc axp20x_regulators[] = { > -- > 2.8.1 >