From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01F56C2D0A8 for ; Mon, 28 Sep 2020 06:51:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4DD62388B for ; Mon, 28 Sep 2020 06:51:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726632AbgI1GvP convert rfc822-to-8bit (ORCPT ); Mon, 28 Sep 2020 02:51:15 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:37773 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726412AbgI1GvP (ORCPT ); Mon, 28 Sep 2020 02:51:15 -0400 Received: by mail-lf1-f65.google.com with SMTP id z19so9815514lfr.4; Sun, 27 Sep 2020 23:51:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XTACXA1Hxtvq1CFGlNEl/z/KQP4lC3PCO/x6XgxWWX8=; b=V7eQwb6LblE8h1JrNXH8/t4NfFGI0br9OrvzsCdmyezqu0rNZBCnmgqDHu/bgpuc6F Q603R+lKWcBkHYtZX54Gh9nJ0ZfSZyRTmZ8XWIGuJkeEuBW4NN2H89J0xqpltdV9y8No D+VPcJcUmYaXYrYWih94236LwU2qwLxO++YC3KTNlO/LDRpZeSblsjbyLWsjix3y7jhu HIwWWedPmpprwO7JwasnOvFd/iWC4SYQZudLxIcavE7HwpsGSG36QlXdRowl7IrrkP4u umTFtranFfBBWgomSKf00AaN1+5HAxQIZLPdPdb1cqIm2VdN0FFTLpEfLX+AgOIUeLZ7 ak0Q== X-Gm-Message-State: AOAM533omfntJZO1XjrcOfBkUVMAu5zfUohzDX2aZFjNwzdTyw3ZgNIS lhSdUyIbkR7gFVdSDUk8RGni+2NAph9o0g== X-Google-Smtp-Source: ABdhPJzCUcu5YTnYniVU96z8QbzGl4WthNgNpeaZrYsMxv+avWQedwtb3ixZmsHLELz7cUnTUDGutg== X-Received: by 2002:a19:c7c1:: with SMTP id x184mr2954960lff.77.1601275872990; Sun, 27 Sep 2020 23:51:12 -0700 (PDT) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com. [209.85.167.41]) by smtp.gmail.com with ESMTPSA id f9sm7650ljc.129.2020.09.27.23.51.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Sep 2020 23:51:12 -0700 (PDT) Received: by mail-lf1-f41.google.com with SMTP id b12so9788086lfp.9; Sun, 27 Sep 2020 23:51:12 -0700 (PDT) X-Received: by 2002:ac2:5f63:: with SMTP id c3mr3139536lfc.283.1601275872275; Sun, 27 Sep 2020 23:51:12 -0700 (PDT) MIME-Version: 1.0 References: <20200927192912.46323-1-peron.clem@gmail.com> <20200927192912.46323-9-peron.clem@gmail.com> In-Reply-To: <20200927192912.46323-9-peron.clem@gmail.com> From: Chen-Yu Tsai Date: Mon, 28 Sep 2020 14:51:00 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH v5 08/20] ASoC: sun4i-i2s: Fix setting of FIFO modes To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Cc: Maxime Ripard , Rob Herring , Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Marcus Cooper , Jernej Skrabec , Linux-ALSA , devicetree , linux-arm-kernel , linux-kernel , linux-sunxi , Samuel Holland Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 28, 2020 at 3:29 AM Clément Péron wrote: > > From: Samuel Holland > > Because SUN4I_I2S_FIFO_CTRL_REG is volatile, writes done while the > regmap is cache-only are ignored. To work around this, move the > configuration to a callback that runs while the ASoC core has a > runtime PM reference to the device. > > Signed-off-by: Samuel Holland > Signed-off-by: Clément Péron Reviewed-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 191E4C2D0A8 for ; Mon, 28 Sep 2020 06:52:19 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14D302311C for ; Mon, 28 Sep 2020 06:52:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="JDq26dnM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14D302311C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 38B1A1B11; Mon, 28 Sep 2020 08:51:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 38B1A1B11 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1601275936; bh=XTACXA1Hxtvq1CFGlNEl/z/KQP4lC3PCO/x6XgxWWX8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JDq26dnMiGD6z4qYrxyrO4Ll57AFuCMkvhAKaWjCqSaQ5XiphmH+zpqHh3n447vuj XcBu1NU6Dal3ePlMu3StKTKVn+4OITdB7iOfT3ETgPAk5nDvyUN9ZXbFTy1I0xgpxA sg2FPPhljVUMR+6wiIrMJ5sPU/2LAtTRDtr5FmyI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CA4BDF800DF; Mon, 28 Sep 2020 08:51:25 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B1423F8023F; Mon, 28 Sep 2020 08:51:24 +0200 (CEST) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 70C79F800DF for ; Mon, 28 Sep 2020 08:51:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 70C79F800DF Received: by mail-lf1-f66.google.com with SMTP id q8so9802271lfb.6 for ; Sun, 27 Sep 2020 23:51:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XTACXA1Hxtvq1CFGlNEl/z/KQP4lC3PCO/x6XgxWWX8=; b=pt1aE9k22wMnmmEN+8OXpPD25X9MULWSXlnch5PGV9I9EA7uvKGJSBzXbGY7Bvlw67 qDFx9tVYO7F7CxCq7ddylR1HOQ3pWRss64CMhtUavnKufFYmVi2MAyILsmNg4QGMfLQ2 LPszWmZ62vEwl4U+ddWZqH3ZINaUz2ujeAEc80iba3KwEvqFCooWf79i9OjqZ3I1VipL kwi1JAGXZVDOYZvdUByGS6pv1OAW+8X3TpNC88VDHtK0VKiJOA5codBX+bgksiJ+ZKSf U1gyf6UXetqM8Y9v/p/pFH4ECgBq15F90h24LUw2Ie8+7kDtLRnjTmkR8WrRCbNfcbJG amNQ== X-Gm-Message-State: AOAM532DioWzWKnW1MIxMU1LKuG13RVJuFVXieSKFQuRVI5N0Ctn+O88 kVvsBUJUJuJ+6lRwsu9x6ma5jHmmJ5oZMA== X-Google-Smtp-Source: ABdhPJyBjIswdsllwgso88BPsT1mNE6JWr172fKAk6mIypoVOlLg+S6xn1L2jGJXSD1Jv6NLR9ER/w== X-Received: by 2002:ac2:4149:: with SMTP id c9mr3381705lfi.412.1601275873273; Sun, 27 Sep 2020 23:51:13 -0700 (PDT) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id w9sm2752076lfr.220.2020.09.27.23.51.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Sep 2020 23:51:12 -0700 (PDT) Received: by mail-lf1-f53.google.com with SMTP id y11so9811126lfl.5 for ; Sun, 27 Sep 2020 23:51:12 -0700 (PDT) X-Received: by 2002:ac2:5f63:: with SMTP id c3mr3139536lfc.283.1601275872275; Sun, 27 Sep 2020 23:51:12 -0700 (PDT) MIME-Version: 1.0 References: <20200927192912.46323-1-peron.clem@gmail.com> <20200927192912.46323-9-peron.clem@gmail.com> In-Reply-To: <20200927192912.46323-9-peron.clem@gmail.com> From: Chen-Yu Tsai Date: Mon, 28 Sep 2020 14:51:00 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH v5 08/20] ASoC: sun4i-i2s: Fix setting of FIFO modes To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: devicetree , Jernej Skrabec , Linux-ALSA , Samuel Holland , linux-kernel , Takashi Iwai , Rob Herring , Liam Girdwood , Marcus Cooper , linux-sunxi , Mark Brown , Maxime Ripard , linux-arm-kernel X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Sep 28, 2020 at 3:29 AM Cl=C3=A9ment P=C3=A9ron wrote: > > From: Samuel Holland > > Because SUN4I_I2S_FIFO_CTRL_REG is volatile, writes done while the > regmap is cache-only are ignored. To work around this, move the > configuration to a callback that runs while the ASoC core has a > runtime PM reference to the device. > > Signed-off-by: Samuel Holland > Signed-off-by: Cl=C3=A9ment P=C3=A9ron Reviewed-by: Chen-Yu Tsai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DA04C2D0A8 for ; Mon, 28 Sep 2020 06:52:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9C7323119 for ; Mon, 28 Sep 2020 06:52:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tORWEMLQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9C7323119 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aXjdve8O4Jy3DrdiJvbo5qgB7P3y0yOCNPduYEHrJxA=; b=tORWEMLQu86+Eq2msPV0Ho7Ip GowgNP6zf9PKpxqOOOR1p8rx+UKDmeVrnpkRInhDz690Zbox/HA40rIrvuLn7Ds3VRtGpXT6KUHow D4q8+AJdaTDZhr4cWFyqc2Yy/5jekL2kD6LV6qXnRzKa5FFjKXWk8u3C8qp2El9153o2hc4PurcOM +UwO12YuX4hQMlpSZQkOch4x7AG7Jijt4fmLQwOuv1OuzCVNikqAQ0VhmP67KWOlbahU0wXHOysil ii5lEipAtz+KSNhrJmycDqF41wNvDngS4+QSVw2roAzj9ea9FGhd/GRLliIK5beAT7bG2JX/+c9Km 3QfxLn38g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMn0N-000600-8p; Mon, 28 Sep 2020 06:51:23 +0000 Received: from mail-lj1-f194.google.com ([209.85.208.194]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMn0E-0005wm-Ie for linux-arm-kernel@lists.infradead.org; Mon, 28 Sep 2020 06:51:15 +0000 Received: by mail-lj1-f194.google.com with SMTP id c2so91873ljj.12 for ; Sun, 27 Sep 2020 23:51:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XTACXA1Hxtvq1CFGlNEl/z/KQP4lC3PCO/x6XgxWWX8=; b=CgWdsacAQfzQB3Dd1+viiYAs6fs2yJbx5O/D/t+OmZizYVC5uhvJJAXGyAZshCv0qB z6APAWgpMPK8RL4l1liqBPsAAdi/DfaIvrI5BH3kVDF6+w9Wqi7kk2oGwasVVnDm/vcb CcGB+IUB1maf6a1UtA5QVWMkxLspP5/fIw1RHHnpCHcVV9kCc8eb0tv9Psoy4QxBS+Ue fsN2y5hcBepsgG2pwVvLLqjISm67EsKaZg8WLYg12LZ/wXyUQQtNyiOc/mgQk/zgvv+s zZzAcIfTcOw6Qf0b99S2mFdaCrLS811a/Tm4FVh/SIFKVLGDnc+LAcdIbvuT8IR2EfHe 7hEQ== X-Gm-Message-State: AOAM530ZkISBqoSrcRmlh+gftVLXiklgMwQanQ6tSsJj9tVwBorb6+lL 5X8FV8DjU0dty6WYuXvTIRhN0ErXHXEV/A== X-Google-Smtp-Source: ABdhPJz8prshk+MYFM/ATe0RCB6OheTEFzfe8+lFo+qDvr+zP6VWG7SevSFNWt736aIf6bRjufmoWg== X-Received: by 2002:a2e:8ed2:: with SMTP id e18mr4152694ljl.466.1601275872915; Sun, 27 Sep 2020 23:51:12 -0700 (PDT) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com. [209.85.167.46]) by smtp.gmail.com with ESMTPSA id j8sm2743247lfr.80.2020.09.27.23.51.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Sep 2020 23:51:12 -0700 (PDT) Received: by mail-lf1-f46.google.com with SMTP id d15so9784801lfq.11 for ; Sun, 27 Sep 2020 23:51:12 -0700 (PDT) X-Received: by 2002:ac2:5f63:: with SMTP id c3mr3139536lfc.283.1601275872275; Sun, 27 Sep 2020 23:51:12 -0700 (PDT) MIME-Version: 1.0 References: <20200927192912.46323-1-peron.clem@gmail.com> <20200927192912.46323-9-peron.clem@gmail.com> In-Reply-To: <20200927192912.46323-9-peron.clem@gmail.com> From: Chen-Yu Tsai Date: Mon, 28 Sep 2020 14:51:00 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH v5 08/20] ASoC: sun4i-i2s: Fix setting of FIFO modes To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200928_025114_654213_235199AB X-CRM114-Status: GOOD ( 13.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Jernej Skrabec , Linux-ALSA , Samuel Holland , linux-kernel , Takashi Iwai , Rob Herring , Liam Girdwood , Marcus Cooper , linux-sunxi , Mark Brown , Maxime Ripard , Jaroslav Kysela , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgMjgsIDIwMjAgYXQgMzoyOSBBTSBDbMOpbWVudCBQw6lyb24gPHBlcm9uLmNs ZW1AZ21haWwuY29tPiB3cm90ZToKPgo+IEZyb206IFNhbXVlbCBIb2xsYW5kIDxzYW11ZWxAc2hv bGxhbmQub3JnPgo+Cj4gQmVjYXVzZSBTVU40SV9JMlNfRklGT19DVFJMX1JFRyBpcyB2b2xhdGls ZSwgd3JpdGVzIGRvbmUgd2hpbGUgdGhlCj4gcmVnbWFwIGlzIGNhY2hlLW9ubHkgYXJlIGlnbm9y ZWQuIFRvIHdvcmsgYXJvdW5kIHRoaXMsIG1vdmUgdGhlCj4gY29uZmlndXJhdGlvbiB0byBhIGNh bGxiYWNrIHRoYXQgcnVucyB3aGlsZSB0aGUgQVNvQyBjb3JlIGhhcyBhCj4gcnVudGltZSBQTSBy ZWZlcmVuY2UgdG8gdGhlIGRldmljZS4KPgo+IFNpZ25lZC1vZmYtYnk6IFNhbXVlbCBIb2xsYW5k IDxzYW11ZWxAc2hvbGxhbmQub3JnPgo+IFNpZ25lZC1vZmYtYnk6IENsw6ltZW50IFDDqXJvbiA8 cGVyb24uY2xlbUBnbWFpbC5jb20+CgpSZXZpZXdlZC1ieTogQ2hlbi1ZdSBUc2FpIDx3ZW5zQGNz aWUub3JnPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo=