From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752254AbcJYEKx (ORCPT ); Tue, 25 Oct 2016 00:10:53 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:52270 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750728AbcJYEKw (ORCPT ); Tue, 25 Oct 2016 00:10:52 -0400 MIME-Version: 1.0 In-Reply-To: <20161020170739.lgt2ywm346vm47zd@lukather> References: <0df42247c3348e7f6aed945e5669cec87f96f7ac.1476951078.git-series.maxime.ripard@free-electrons.com> <20161020170739.lgt2ywm346vm47zd@lukather> From: Chen-Yu Tsai Date: Tue, 25 Oct 2016 12:10:26 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 5/8] ARM: gr8: Add missing pwm channel 1 pin To: Maxime Ripard Cc: Chen-Yu Tsai , Boris Brezillon , Brian Norris , Richard Weinberger , linux-arm-kernel , linux-kernel , linux-mtd@lists.infradead.org, Mylene Josserand , Thomas Petazzoni Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 21, 2016 at 1:07 AM, Maxime Ripard wrote: > On Thu, Oct 20, 2016 at 10:10:03PM +0800, Chen-Yu Tsai wrote: >> On Thu, Oct 20, 2016 at 4:12 PM, Maxime Ripard >> wrote: >> > The PWM controller has two different channels, but only the first pin was >> > exposed in the DTSI. Add the other one. >> > >> > Signed-off-by: Maxime Ripard >> >> Acked-by: Chen-Yu Tsai >> >> > --- >> > arch/arm/boot/dts/ntc-gr8.dtsi | 7 +++++++ >> > 1 file changed, 7 insertions(+), 0 deletions(-) >> > >> > diff --git a/arch/arm/boot/dts/ntc-gr8.dtsi b/arch/arm/boot/dts/ntc-gr8.dtsi >> > index 74aff795e723..fad7381630f3 100644 >> > --- a/arch/arm/boot/dts/ntc-gr8.dtsi >> > +++ b/arch/arm/boot/dts/ntc-gr8.dtsi >> > @@ -854,6 +854,13 @@ >> > allwinner,pull = ; >> > }; >> > >> > + pwm1_pins_a: pwm1@0 { >> >> Nit: really don't need "_a" and "@0" here. > > Fixed and applied. Oops, you forgot to fix the label in the chip-pro dts: DTC arch/arm/boot/dts/ntc-gr8-chip-pro.dtb ERROR (phandle_references): Reference to non-existent node or label "pwm1_pins_a" ERROR: Input tree has errors, aborting (use -f to force output) scripts/Makefile.lib:313: recipe for target 'arch/arm/boot/dts/ntc-gr8-chip-pro.dtb' failed ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Tue, 25 Oct 2016 12:10:26 +0800 Subject: [PATCH 5/8] ARM: gr8: Add missing pwm channel 1 pin In-Reply-To: <20161020170739.lgt2ywm346vm47zd@lukather> References: <0df42247c3348e7f6aed945e5669cec87f96f7ac.1476951078.git-series.maxime.ripard@free-electrons.com> <20161020170739.lgt2ywm346vm47zd@lukather> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Oct 21, 2016 at 1:07 AM, Maxime Ripard wrote: > On Thu, Oct 20, 2016 at 10:10:03PM +0800, Chen-Yu Tsai wrote: >> On Thu, Oct 20, 2016 at 4:12 PM, Maxime Ripard >> wrote: >> > The PWM controller has two different channels, but only the first pin was >> > exposed in the DTSI. Add the other one. >> > >> > Signed-off-by: Maxime Ripard >> >> Acked-by: Chen-Yu Tsai >> >> > --- >> > arch/arm/boot/dts/ntc-gr8.dtsi | 7 +++++++ >> > 1 file changed, 7 insertions(+), 0 deletions(-) >> > >> > diff --git a/arch/arm/boot/dts/ntc-gr8.dtsi b/arch/arm/boot/dts/ntc-gr8.dtsi >> > index 74aff795e723..fad7381630f3 100644 >> > --- a/arch/arm/boot/dts/ntc-gr8.dtsi >> > +++ b/arch/arm/boot/dts/ntc-gr8.dtsi >> > @@ -854,6 +854,13 @@ >> > allwinner,pull = ; >> > }; >> > >> > + pwm1_pins_a: pwm1 at 0 { >> >> Nit: really don't need "_a" and "@0" here. > > Fixed and applied. Oops, you forgot to fix the label in the chip-pro dts: DTC arch/arm/boot/dts/ntc-gr8-chip-pro.dtb ERROR (phandle_references): Reference to non-existent node or label "pwm1_pins_a" ERROR: Input tree has errors, aborting (use -f to force output) scripts/Makefile.lib:313: recipe for target 'arch/arm/boot/dts/ntc-gr8-chip-pro.dtb' failed ChenYu