From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752417AbeEPGm0 (ORCPT ); Wed, 16 May 2018 02:42:26 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:54573 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbeEPGmY (ORCPT ); Wed, 16 May 2018 02:42:24 -0400 X-Google-Smtp-Source: AB8JxZps1Rhj/eiotUWy9F40ZOLFYdrfIVe05ymeZLt87l/LmetdWZyRAFa/7BUHhjwmuQNvokG9Ow== MIME-Version: 1.0 In-Reply-To: References: <20180419093225.614-1-wens@csie.org> <20180419093225.614-5-wens@csie.org> From: Chen-Yu Tsai Date: Tue, 15 May 2018 23:42:01 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel To: Jagan Teki Cc: Maxime Ripard , David Airlie , Thierry Reding , Rob Herring , Mark Rutland , dri-devel , linux-arm-kernel , linux-kernel , devicetree , Jonathan Liu Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 14, 2018 at 11:03 AM, Jagan Teki wrote: > On Thu, Apr 19, 2018 at 3:02 PM, Chen-Yu Tsai wrote: >> This panel is marketed as Banana Pi 7" LCD display. On the back is >> a sticker denoting the model name S070WV20-CT16. >> >> This is a 7" 800x480 panel connected through a 24-bit RGB interface. >> However the panel only does 262k colors. >> >> Signed-off-by: Chen-Yu Tsai >> --- >> .../display/panel/bananapi,s070wv20-ct16.txt | 7 ++++++ >> drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++ >> 2 files changed, 32 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >> >> diff --git a/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >> new file mode 100644 >> index 000000000000..2ec35ce36e9a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >> @@ -0,0 +1,7 @@ >> +Banana Pi 7" (S070WV20-CT16) TFT LCD Panel >> + >> +Required properties: >> +- compatible: should be "bananapi,s070wv20-ct16" >> + >> +This binding is compatible with the simple-panel binding, which is specified >> +in simple-panel.txt in this directory. >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c >> index cbf1ab404ee7..9bc037f74d6c 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -745,6 +745,28 @@ static const struct panel_desc avic_tm070ddh03 = { >> }, >> }; >> >> +static const struct drm_display_mode bananapi_s070wv20_ct16_mode = { >> + .clock = 30000, >> + .hdisplay = 800, >> + .hsync_start = 800 + 40, >> + .hsync_end = 800 + 40 + 48, >> + .htotal = 800 + 40 + 48 + 40, >> + .vdisplay = 480, >> + .vsync_start = 480 + 13, >> + .vsync_end = 480 + 13 + 3, >> + .vtotal = 480 + 13 + 3 + 29, >> +}; >> + >> +static const struct panel_desc bananapi_s070wv20_ct16 = { >> + .modes = &bananapi_s070wv20_ct16_mode, >> + .num_modes = 1, >> + .bpc = 6, >> + .size = { >> + .width = 154, >> + .height = 86, >> + }, >> +}; > > I think this parallel RGB interface right? I too have same display > with DSI I'm sure these setting will not useful right? do we need to > write separate panel driver for that? AFAIK the DSI model is an RGB panel with a MIPI DSI bridge on the connector board. The model I have is dual interface. ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel Date: Tue, 15 May 2018 23:42:01 -0700 Message-ID: References: <20180419093225.614-1-wens@csie.org> <20180419093225.614-5-wens@csie.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jagan Teki Cc: Mark Rutland , devicetree , Jonathan Liu , Rob Herring , Maxime Ripard , linux-kernel , dri-devel , David Airlie , Thierry Reding , linux-arm-kernel List-Id: devicetree@vger.kernel.org T24gTW9uLCBNYXkgMTQsIDIwMTggYXQgMTE6MDMgQU0sIEphZ2FuIFRla2kgPGphZ2FuQGFtYXJ1 bGFzb2x1dGlvbnMuY29tPiB3cm90ZToKPiBPbiBUaHUsIEFwciAxOSwgMjAxOCBhdCAzOjAyIFBN LCBDaGVuLVl1IFRzYWkgPHdlbnNAY3NpZS5vcmc+IHdyb3RlOgo+PiBUaGlzIHBhbmVsIGlzIG1h cmtldGVkIGFzIEJhbmFuYSBQaSA3IiBMQ0QgZGlzcGxheS4gT24gdGhlIGJhY2sgaXMKPj4gYSBz dGlja2VyIGRlbm90aW5nIHRoZSBtb2RlbCBuYW1lIFMwNzBXVjIwLUNUMTYuCj4+Cj4+IFRoaXMg aXMgYSA3IiA4MDB4NDgwIHBhbmVsIGNvbm5lY3RlZCB0aHJvdWdoIGEgMjQtYml0IFJHQiBpbnRl cmZhY2UuCj4+IEhvd2V2ZXIgdGhlIHBhbmVsIG9ubHkgZG9lcyAyNjJrIGNvbG9ycy4KPj4KPj4g U2lnbmVkLW9mZi1ieTogQ2hlbi1ZdSBUc2FpIDx3ZW5zQGNzaWUub3JnPgo+PiAtLS0KPj4gIC4u Li9kaXNwbGF5L3BhbmVsL2JhbmFuYXBpLHMwNzB3djIwLWN0MTYudHh0ICB8ICA3ICsrKysrKwo+ PiAgZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLXNpbXBsZS5jICAgICAgICAgIHwgMjUgKysr KysrKysrKysrKysrKysrKwo+PiAgMiBmaWxlcyBjaGFuZ2VkLCAzMiBpbnNlcnRpb25zKCspCj4+ ICBjcmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rp c3BsYXkvcGFuZWwvYmFuYW5hcGksczA3MHd2MjAtY3QxNi50eHQKPj4KPj4gZGlmZiAtLWdpdCBh L0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL2JhbmFuYXBp LHMwNzB3djIwLWN0MTYudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rp c3BsYXkvcGFuZWwvYmFuYW5hcGksczA3MHd2MjAtY3QxNi50eHQKPj4gbmV3IGZpbGUgbW9kZSAx MDA2NDQKPj4gaW5kZXggMDAwMDAwMDAwMDAwLi4yZWMzNWNlMzZlOWEKPj4gLS0tIC9kZXYvbnVs bAo+PiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9wYW5l bC9iYW5hbmFwaSxzMDcwd3YyMC1jdDE2LnR4dAo+PiBAQCAtMCwwICsxLDcgQEAKPj4gK0JhbmFu YSBQaSA3IiAoUzA3MFdWMjAtQ1QxNikgVEZUIExDRCBQYW5lbAo+PiArCj4+ICtSZXF1aXJlZCBw cm9wZXJ0aWVzOgo+PiArLSBjb21wYXRpYmxlOiBzaG91bGQgYmUgImJhbmFuYXBpLHMwNzB3djIw LWN0MTYiCj4+ICsKPj4gK1RoaXMgYmluZGluZyBpcyBjb21wYXRpYmxlIHdpdGggdGhlIHNpbXBs ZS1wYW5lbCBiaW5kaW5nLCB3aGljaCBpcyBzcGVjaWZpZWQKPj4gK2luIHNpbXBsZS1wYW5lbC50 eHQgaW4gdGhpcyBkaXJlY3RvcnkuCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcGFu ZWwvcGFuZWwtc2ltcGxlLmMgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMK Pj4gaW5kZXggY2JmMWFiNDA0ZWU3Li45YmMwMzdmNzRkNmMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0v cGFuZWwvcGFuZWwtc2ltcGxlLmMKPj4gQEAgLTc0NSw2ICs3NDUsMjggQEAgc3RhdGljIGNvbnN0 IHN0cnVjdCBwYW5lbF9kZXNjIGF2aWNfdG0wNzBkZGgwMyA9IHsKPj4gICAgICAgICB9LAo+PiAg fTsKPj4KPj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSBiYW5hbmFwaV9z MDcwd3YyMF9jdDE2X21vZGUgPSB7Cj4+ICsgICAgICAgLmNsb2NrID0gMzAwMDAsCj4+ICsgICAg ICAgLmhkaXNwbGF5ID0gODAwLAo+PiArICAgICAgIC5oc3luY19zdGFydCA9IDgwMCArIDQwLAo+ PiArICAgICAgIC5oc3luY19lbmQgPSA4MDAgKyA0MCArIDQ4LAo+PiArICAgICAgIC5odG90YWwg PSA4MDAgKyA0MCArIDQ4ICsgNDAsCj4+ICsgICAgICAgLnZkaXNwbGF5ID0gNDgwLAo+PiArICAg ICAgIC52c3luY19zdGFydCA9IDQ4MCArIDEzLAo+PiArICAgICAgIC52c3luY19lbmQgPSA0ODAg KyAxMyArIDMsCj4+ICsgICAgICAgLnZ0b3RhbCA9IDQ4MCArIDEzICsgMyArIDI5LAo+PiArfTsK Pj4gKwo+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBwYW5lbF9kZXNjIGJhbmFuYXBpX3MwNzB3djIw X2N0MTYgPSB7Cj4+ICsgICAgICAgLm1vZGVzID0gJmJhbmFuYXBpX3MwNzB3djIwX2N0MTZfbW9k ZSwKPj4gKyAgICAgICAubnVtX21vZGVzID0gMSwKPj4gKyAgICAgICAuYnBjID0gNiwKPj4gKyAg ICAgICAuc2l6ZSA9IHsKPj4gKyAgICAgICAgICAgICAgIC53aWR0aCA9IDE1NCwKPj4gKyAgICAg ICAgICAgICAgIC5oZWlnaHQgPSA4NiwKPj4gKyAgICAgICB9LAo+PiArfTsKPgo+IEkgdGhpbmsg dGhpcyBwYXJhbGxlbCBSR0IgaW50ZXJmYWNlIHJpZ2h0PyBJIHRvbyBoYXZlIHNhbWUgZGlzcGxh eQo+IHdpdGggRFNJIEknbSBzdXJlIHRoZXNlIHNldHRpbmcgd2lsbCBub3QgdXNlZnVsIHJpZ2h0 PyBkbyB3ZSBuZWVkIHRvCj4gd3JpdGUgc2VwYXJhdGUgcGFuZWwgZHJpdmVyIGZvciB0aGF0PwoK QUZBSUsgdGhlIERTSSBtb2RlbCBpcyBhbiBSR0IgcGFuZWwgd2l0aCBhIE1JUEkgRFNJIGJyaWRn ZSBvbiB0aGUKY29ubmVjdG9yIGJvYXJkLiBUaGUgbW9kZWwgSSBoYXZlIGlzIGR1YWwgaW50ZXJm YWNlLgoKQ2hlbll1Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Tue, 15 May 2018 23:42:01 -0700 Subject: [PATCH 4/6] drm/panel: simple: Add support for Banana Pi 7" S070WV20-CT16 panel In-Reply-To: References: <20180419093225.614-1-wens@csie.org> <20180419093225.614-5-wens@csie.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, May 14, 2018 at 11:03 AM, Jagan Teki wrote: > On Thu, Apr 19, 2018 at 3:02 PM, Chen-Yu Tsai wrote: >> This panel is marketed as Banana Pi 7" LCD display. On the back is >> a sticker denoting the model name S070WV20-CT16. >> >> This is a 7" 800x480 panel connected through a 24-bit RGB interface. >> However the panel only does 262k colors. >> >> Signed-off-by: Chen-Yu Tsai >> --- >> .../display/panel/bananapi,s070wv20-ct16.txt | 7 ++++++ >> drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++ >> 2 files changed, 32 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >> >> diff --git a/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >> new file mode 100644 >> index 000000000000..2ec35ce36e9a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.txt >> @@ -0,0 +1,7 @@ >> +Banana Pi 7" (S070WV20-CT16) TFT LCD Panel >> + >> +Required properties: >> +- compatible: should be "bananapi,s070wv20-ct16" >> + >> +This binding is compatible with the simple-panel binding, which is specified >> +in simple-panel.txt in this directory. >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c >> index cbf1ab404ee7..9bc037f74d6c 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -745,6 +745,28 @@ static const struct panel_desc avic_tm070ddh03 = { >> }, >> }; >> >> +static const struct drm_display_mode bananapi_s070wv20_ct16_mode = { >> + .clock = 30000, >> + .hdisplay = 800, >> + .hsync_start = 800 + 40, >> + .hsync_end = 800 + 40 + 48, >> + .htotal = 800 + 40 + 48 + 40, >> + .vdisplay = 480, >> + .vsync_start = 480 + 13, >> + .vsync_end = 480 + 13 + 3, >> + .vtotal = 480 + 13 + 3 + 29, >> +}; >> + >> +static const struct panel_desc bananapi_s070wv20_ct16 = { >> + .modes = &bananapi_s070wv20_ct16_mode, >> + .num_modes = 1, >> + .bpc = 6, >> + .size = { >> + .width = 154, >> + .height = 86, >> + }, >> +}; > > I think this parallel RGB interface right? I too have same display > with DSI I'm sure these setting will not useful right? do we need to > write separate panel driver for that? AFAIK the DSI model is an RGB panel with a MIPI DSI bridge on the connector board. The model I have is dual interface. ChenYu