From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7867C433DB for ; Fri, 22 Jan 2021 03:10:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 673E023884 for ; Fri, 22 Jan 2021 03:10:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726676AbhAVDKV convert rfc822-to-8bit (ORCPT ); Thu, 21 Jan 2021 22:10:21 -0500 Received: from mail-lf1-f43.google.com ([209.85.167.43]:44597 "EHLO mail-lf1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725283AbhAVDKN (ORCPT ); Thu, 21 Jan 2021 22:10:13 -0500 Received: by mail-lf1-f43.google.com with SMTP id p21so476640lfu.11; Thu, 21 Jan 2021 19:09:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4lGuVHhcKVrdOs4QmSKpbm9VyPli3VuiFPw1ljmvzq8=; b=L/Ldh4cAwdOzBnojn1SkXdRhQrnB/diqCyfUl1f7101YaBecaHRbHrb+2XcYcaD3Yq zVkEc2eleh+2Cbfp2ykt+KXwGSyo2IdoZ1FTQ+yz88YPPIa9K7YE0j/ggALK3mZcGzOX vM4AhbLoCDy0KpFMf8+OuOLdfLBXmVDwXnrwjACh3ikW74BScGySCvCA2JdxjvlJeAZ2 ZXGNt5AM+B+EbC/4ec8PgaZ+z0MfuR/0fDP5nLCP+zoidl4qOzVEtvquek4VRyho8QMr D35NoPiHE2YcHTA78OFcZdQkG2iBRv971pUrxpl3eKhQ/dp7t3sQOsq4GgRPP6wZlpXB /fCQ== X-Gm-Message-State: AOAM5312A+wqm2qQyfF2SwfK+CXVqiorV8lFxDs6NdLTm4OHz2jWW2no 34uFUAQdkSceglMLtAjvP4W1aQJe7IiEFw== X-Google-Smtp-Source: ABdhPJwAMT7pj6ch4+XSDnDbnteI3GHrnqnEd/hJfad2hwWZdCc2H+2SojojIp1xOdumYeMpfs30gw== X-Received: by 2002:a05:6512:b04:: with SMTP id w4mr1146186lfu.43.1611284970951; Thu, 21 Jan 2021 19:09:30 -0800 (PST) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com. [209.85.167.47]) by smtp.gmail.com with ESMTPSA id a8sm716338lfj.65.2021.01.21.19.09.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jan 2021 19:09:30 -0800 (PST) Received: by mail-lf1-f47.google.com with SMTP id o17so5588688lfg.4; Thu, 21 Jan 2021 19:09:30 -0800 (PST) X-Received: by 2002:a19:810:: with SMTP id 16mr1178235lfi.233.1611284969893; Thu, 21 Jan 2021 19:09:29 -0800 (PST) MIME-Version: 1.0 References: <20210121170836.GA4948@lemon.iwr.uni-heidelberg.de> <2438641.b0YrFlWa0f@kista> In-Reply-To: <2438641.b0YrFlWa0f@kista> From: Chen-Yu Tsai Date: Fri, 22 Jan 2021 11:09:18 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] ARM: dts: sun7i: a20: bananapro: Fix ethernet node To: Hermann Lauer Cc: Jernej Skrabec , linux-arm-kernel , Maxime Ripard , Rob Herring , devicetree , linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 22, 2021 at 3:54 AM Jernej Škrabec wrote: > > Dne četrtek, 21. januar 2021 ob 18:08:36 CET je Hermann Lauer napisal(a): > > BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high > > packet loss rates. The realtek phy driver overrides the settings of the > > pull ups for the delays, so fix this for Banana Pro. > > > > Signed-off-by: Hermann Lauer > > Much better. Now the only thing missing is "Fixes" tag, which references > commit which introduced the issue. Probably this will be the commit which > added ethernet node. This tag is important for deciding which commits should > be backported to stable releases. Take a look in v1 for M2U fixes tag. > > Btw, each version should have changelog under "---" line, so maintainers and > reviewers know what changed. The subject line should also be more concise. "Fix ethernet phy-mode" reads much better than "Fix ethernet node", which could mean a number of things. ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3FA8C433DB for ; Fri, 22 Jan 2021 03:11:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7017923884 for ; Fri, 22 Jan 2021 03:11:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7017923884 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9rzEQ2DrxWp64qs/GvO76Uaywj/RF8rJWbYi9dUd51M=; b=GBV2L/PDvG6h9FY03YF6jKqql d/dCaRIk7akv3+Bb3DZtCWrqCeKbaziUn5osxpoT+JtygRMZc4GlZIqmM1Ao/00TSmvP1revtOJCB aRdiSJ77mV0iTyqNok98iS1yu8N2VaZ7smyqToA2bDYgYB9HlOL3SNY04NAfenjNjBfUvd6z4K4nX IrUfvsmMMWlt0F7I17talv+HuYQHQAsI1WsTo5iW8nOZw9OJ0QDQJSSXd4JAIbNuhHikd3b9XnLA9 gQmA8qyGU8H3Wd4Rgccmj3IYEsB41hraHs9i6WTw5U2UgSPoPBeBJDAQkugV1bM4FwpNLY5Fc42XX gF1a3jOfQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2mpN-0001Ok-Br; Fri, 22 Jan 2021 03:09:37 +0000 Received: from mail-lf1-f42.google.com ([209.85.167.42]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2mpJ-0001OC-VZ for linux-arm-kernel@lists.infradead.org; Fri, 22 Jan 2021 03:09:35 +0000 Received: by mail-lf1-f42.google.com with SMTP id o17so5588713lfg.4 for ; Thu, 21 Jan 2021 19:09:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4lGuVHhcKVrdOs4QmSKpbm9VyPli3VuiFPw1ljmvzq8=; b=j1n+zJemdW/7F+gL8Plh0zQzEvOITbiH/5Q9GCakIjNTNlqqfabWHRg+KSEoXAmsAo ukgv7ExE13RTIGslryn8kNy3FeE1iypaMXRNHOsspWqOm70NN0W3NtV20ZJYPWLK/azQ 3q5T2Ccsik/YiuQexcH9DXLpocTsqnU0JtzZct9b4ayRO/6qpEAeC5LZ7wC3Vc2NF/gI LXIvo0Qf+z5Sw/s+/xBCmZYXOfPLZDxU423Gl2BXb1QHlxX1YUCVeL4VL6RnaNQ/DPBX WGM+YP0+zeuVb11KfzSN//TGHeNWplmKG2PQ4ioXxN7C6aU1oHJNNPB5Ga5KCclJJlmR eisQ== X-Gm-Message-State: AOAM533I8kQUKAj7fb56T9tq789cUsTjZovCthseQOIlLCrDwYSNmjGl /piKoqI9YBU/eK0HTP438XYJncaEFiR9fA== X-Google-Smtp-Source: ABdhPJzkwqf/nNXD7Sy4XxjHX1ZOy4MxKtLiWXE0T9F5fhMdQDXM81F5MskOTW/pd/DE8Cl0rP2KGQ== X-Received: by 2002:a19:760a:: with SMTP id c10mr83896lff.655.1611284970534; Thu, 21 Jan 2021 19:09:30 -0800 (PST) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id y3sm777668ljc.131.2021.01.21.19.09.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jan 2021 19:09:30 -0800 (PST) Received: by mail-lf1-f42.google.com with SMTP id a8so5571625lfi.8 for ; Thu, 21 Jan 2021 19:09:30 -0800 (PST) X-Received: by 2002:a19:810:: with SMTP id 16mr1178235lfi.233.1611284969893; Thu, 21 Jan 2021 19:09:29 -0800 (PST) MIME-Version: 1.0 References: <20210121170836.GA4948@lemon.iwr.uni-heidelberg.de> <2438641.b0YrFlWa0f@kista> In-Reply-To: <2438641.b0YrFlWa0f@kista> From: Chen-Yu Tsai Date: Fri, 22 Jan 2021 11:09:18 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] ARM: dts: sun7i: a20: bananapro: Fix ethernet node To: Hermann Lauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210121_220934_041156_7847755E X-CRM114-Status: GOOD ( 14.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Jernej Skrabec , linux-kernel , Maxime Ripard , Rob Herring , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKYW4gMjIsIDIwMjEgYXQgMzo1NCBBTSBKZXJuZWogxaBrcmFiZWMgPGplcm5lai5z a3JhYmVjQHNpb2wubmV0PiB3cm90ZToKPgo+IERuZSDEjWV0cnRlaywgMjEuIGphbnVhciAyMDIx IG9iIDE4OjA4OjM2IENFVCBqZSBIZXJtYW5uIExhdWVyIG5hcGlzYWwoYSk6Cj4gPiBCUGkgUHJv IG5lZWRzIFRYIGFuZCBSWCBkZWxheSBmb3IgR2JpdCB0byB3b3JrIHJlbGlhYmxlIGFuZCBhdm9p ZCBoaWdoCj4gPiBwYWNrZXQgbG9zcyByYXRlcy4gVGhlIHJlYWx0ZWsgcGh5IGRyaXZlciBvdmVy cmlkZXMgdGhlIHNldHRpbmdzIG9mIHRoZQo+ID4gcHVsbCB1cHMgZm9yIHRoZSBkZWxheXMsIHNv IGZpeCB0aGlzIGZvciBCYW5hbmEgUHJvLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IEhlcm1hbm4g TGF1ZXIgPEhlcm1hbm4uTGF1ZXJAdW5pLWhlaWRlbGJlcmcuZGU+Cj4KPiBNdWNoIGJldHRlci4g Tm93IHRoZSBvbmx5IHRoaW5nIG1pc3NpbmcgaXMgIkZpeGVzIiB0YWcsIHdoaWNoIHJlZmVyZW5j ZXMKPiBjb21taXQgd2hpY2ggaW50cm9kdWNlZCB0aGUgaXNzdWUuIFByb2JhYmx5IHRoaXMgd2ls bCBiZSB0aGUgY29tbWl0IHdoaWNoCj4gYWRkZWQgZXRoZXJuZXQgbm9kZS4gVGhpcyB0YWcgaXMg aW1wb3J0YW50IGZvciBkZWNpZGluZyB3aGljaCBjb21taXRzIHNob3VsZAo+IGJlIGJhY2twb3J0 ZWQgdG8gc3RhYmxlIHJlbGVhc2VzLiBUYWtlIGEgbG9vayBpbiB2MSBmb3IgTTJVIGZpeGVzIHRh Zy4KPgo+IEJ0dywgZWFjaCB2ZXJzaW9uIHNob3VsZCBoYXZlIGNoYW5nZWxvZyB1bmRlciAiLS0t IiBsaW5lLCBzbyBtYWludGFpbmVycyBhbmQKPiByZXZpZXdlcnMga25vdyB3aGF0IGNoYW5nZWQu CgpUaGUgc3ViamVjdCBsaW5lIHNob3VsZCBhbHNvIGJlIG1vcmUgY29uY2lzZS4gIkZpeCBldGhl cm5ldCBwaHktbW9kZSIgcmVhZHMKbXVjaCBiZXR0ZXIgdGhhbiAiRml4IGV0aGVybmV0IG5vZGUi LCB3aGljaCBjb3VsZCBtZWFuIGEgbnVtYmVyIG9mIHRoaW5ncy4KCkNoZW5ZdQoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=