From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Date: Wed, 7 Jun 2017 12:13:51 +0800 Subject: [U-Boot] [linux-sunxi] [RFC PATCH 4/8] sunxi: add SUNXI_R_CPUCFG_BASE for A83T SoC In-Reply-To: References: <20170607004721.24194-1-icenowy@aosc.io> <20170607004721.24194-5-icenowy@aosc.io> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jun 7, 2017 at 11:48 AM, Chen-Yu Tsai wrote: > On Wed, Jun 7, 2017 at 8:47 AM, Icenowy Zheng wrote: >> A83T SoC has two part of CPUCFG configurations -- one part is at >> 0x01700000, which contains most of the controls, and is like the one in >> A80; the another part is at 0x01f01c00 (like other post-sun6i SoCs), but >> contains now only a few registers. >> >> Call it SUNXI_R_CPUCFG_BASE, like what the BSP Linux source code did. >> >> Signed-off-by: Icenowy Zheng >> --- >> arch/arm/include/asm/arch-sunxi/cpu_sun4i.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm/include/asm/arch-sunxi/cpu_sun4i.h b/arch/arm/include/asm/arch-sunxi/cpu_sun4i.h >> index a96680d8e8..5c74714084 100644 >> --- a/arch/arm/include/asm/arch-sunxi/cpu_sun4i.h >> +++ b/arch/arm/include/asm/arch-sunxi/cpu_sun4i.h >> @@ -179,6 +179,8 @@ defined(CONFIG_MACH_SUN50I) >> !defined CONFIG_MACH_SUN8I_A83T && \ >> !defined CONFIG_MACH_SUN8I_R40 >> #define SUNXI_CPUCFG_BASE 0x01f01c00 >> +#elif defined CONFIG_MACH_SUN8I_A83T >> +#define SUNXI_R_CPUCFG_BASE 0x01f01c00 >> #endif > > Since this is unrelated to CPUCFG (which we might use later on), > Just put it in a separate #ifdef section, instead of with the > other CPUCFG ones. Also this looks like you don't define CPUCFG, which you later use in the implementation? Can you elaborate on that? ChenYu