From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2AEDC28CC6 for ; Mon, 3 Jun 2019 16:38:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D5BB2728F for ; Mon, 3 Jun 2019 16:38:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559579920; bh=do4LaCsAOPTd/xXZSnOPF8r9lTDiUPMdRTL2m5faea4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=lU9CGa2YM2tMyNlNg0L7t2K43C2mlHUW6/3XcTZjV5iWdQhzIaC2W+J4VZxhvgGHA AaTBqZRiRicHrgqdmwhfAtCly3aIigKtyz8dzMmUqaIPxwqXE/iBst8R5zczKEVIeU NN4DPjafAcVRylkBsTwcvr7TQzqQIMieI1LdKMhM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729360AbfFCQij (ORCPT ); Mon, 3 Jun 2019 12:38:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:42272 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727308AbfFCQij (ORCPT ); Mon, 3 Jun 2019 12:38:39 -0400 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1BDD27290; Mon, 3 Jun 2019 16:38:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559579918; bh=do4LaCsAOPTd/xXZSnOPF8r9lTDiUPMdRTL2m5faea4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=N70PghegSq3Sp1SpJr7jbTVhVknam2TQYZJLQdRm/w1+/4RPG1PxDgq1Ptja8yWvF O1Ek+RuJtu16YFsjFU//VyeEJQuMr6cbSPNwAg+o7/wAr9/lKPeAlxbfho7HgfcxhT Jsr+Sz0rNPsWOBm0Bz3ZtMK9Rr9pNLnl1Sp5D3RQ= Received: by mail-wm1-f44.google.com with SMTP id c6so8865091wml.0; Mon, 03 Jun 2019 09:38:37 -0700 (PDT) X-Gm-Message-State: APjAAAWIkHekPIgTOVk5h3xpAdE0+XFEhWZ3I6ZPgN4P2byVda6Ku/oJ zAtDX9MrAVpHJN8SQHEfaa0SmvbbyAiauFCdw1I= X-Google-Smtp-Source: APXvYqy25ZyORC+P1JYMxi3NB1dbh9LoPrE65NBWSWqDalu0KCqhu02yb8Ru6YZLqwSu8cBe8X729wUELaCmuy0rqT8= X-Received: by 2002:a1c:c545:: with SMTP id v66mr3207828wmf.51.1559579916334; Mon, 03 Jun 2019 09:38:36 -0700 (PDT) MIME-Version: 1.0 References: <20190520080421.12575-1-wens@kernel.org> <20190520090327.iejd3q7c3iwomzlz@flea> In-Reply-To: <20190520090327.iejd3q7c3iwomzlz@flea> From: Chen-Yu Tsai Date: Tue, 4 Jun 2019 00:38:22 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 00/25] clk: sunxi-ng: clk parent rewrite part 1 To: Stephen Boyd Cc: Maxime Ripard , Chen-Yu Tsai , Michael Turquette , linux-arm-kernel , linux-clk , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen, On Mon, May 20, 2019 at 5:03 PM Maxime Ripard wrote: > > On Mon, May 20, 2019 at 04:03:56PM +0800, Chen-Yu Tsai wrote: > > From: Chen-Yu Tsai > > > > Hi everyone, > > > > This is series is the first part of a large series (I haven't done the > > rest) of patches to rewrite the clk parent relationship handling within > > the sunxi-ng clk driver. This is based on Stephen's recent work allowing > > clk drivers to specify clk parents using struct clk_hw * or parsing DT > > phandles in the clk node. > > > > This series can be split into a few major parts: > > > > 1) The first patch is a small fix for clk debugfs representation. This > > was done before commit 1a079560b145 ("clk: Cache core in > > clk_fetch_parent_index() without names") was posted, so it might or > > might not be needed. Found this when checking my work using > > clk_possible_parents. > > > > 2) A bunch of CLK_HW_INIT_* helper macros are added. These cover the > > situations I encountered, or assume I will encounter, such as single > > internal (struct clk_hw *) parent, single DT (struct clk_parent_data > > .fw_name), multiple internal parents, and multiple mixed (internal + > > DT) parents. A special variant for just an internal single parent is > > added, CLK_HW_INIT_HWS, which lets the driver share the singular > > list, instead of having the compiler create a compound literal every > > time. It might even make sense to only keep this variant. > > > > 3) A bunch of CLK_FIXED_FACTOR_* helper macros are added. The rationale > > is the same as the single parent CLK_HW_INIT_* helpers. > > > > 4) Bulk conversion of CLK_FIXED_FACTOR to use local parent references, > > either struct clk_hw * or DT .fw_name types, whichever the hardware > > requires. > > > > 5) The beginning of SUNXI_CCU_GATE conversion to local parent > > references. This part is not done. They are included as justification > > and examples for the shared list of clk parents case. > > That series is pretty neat. As far as sunxi is concerned, you can add my > Acked-by: Maxime Ripard > > > I realize this is going to be many patches every time I convert a clock > > type. Going forward would the people involved prefer I send out > > individual patches like this series, or squash them all together? > > For bisection, I guess it would be good to keep the approach you've > had in this series. If this is really too much, I guess we can always > change oru mind later on. Any thoughts on this series and how to proceed? Thanks ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A8ADC04AB5 for ; Mon, 3 Jun 2019 16:38:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C26427310 for ; Mon, 3 Jun 2019 16:38:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VD1/oB9w"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="N70Pgheg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C26427310 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LAJiosjA0RnU1cSl7CzKAP3C1iA5YHOpvQYEnI1m2QA=; b=VD1/oB9wBkz+To KYTNhKZdx6qA0ir6K1ciqavsVSvov5FnJ6pxfzdlM06Zfv+REPC3TpS0NtecDilKd9zZjeNMsC//t lubzX+Efc5xysoKqYLKGSIWDCpHkLhrXJRV4GfnZSh7gXL2OKUcE7yS33+2Q+BNdyuz2GvIJOneAx doL3+vqBufq2IaXoJXcKcHdOvf9qpSRsLbW49ySI75Qstzq8tUPzk673BnNSMGcqqk3pc9novjVkZ ujqgOBuA+kezjMsQ8a9DU81q9rp034bzWraoRk32b7I3llBVEgAiTeyEqGpoaanSIt1iHFAgYmfYZ mddnwyh8jiZHOzoJzb1Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXpyr-0000tf-Qs; Mon, 03 Jun 2019 16:38:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXpyo-0000sz-Mn for linux-arm-kernel@lists.infradead.org; Mon, 03 Jun 2019 16:38:40 +0000 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C581027310 for ; Mon, 3 Jun 2019 16:38:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559579918; bh=do4LaCsAOPTd/xXZSnOPF8r9lTDiUPMdRTL2m5faea4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=N70PghegSq3Sp1SpJr7jbTVhVknam2TQYZJLQdRm/w1+/4RPG1PxDgq1Ptja8yWvF O1Ek+RuJtu16YFsjFU//VyeEJQuMr6cbSPNwAg+o7/wAr9/lKPeAlxbfho7HgfcxhT Jsr+Sz0rNPsWOBm0Bz3ZtMK9Rr9pNLnl1Sp5D3RQ= Received: by mail-wm1-f44.google.com with SMTP id s3so4588538wms.2 for ; Mon, 03 Jun 2019 09:38:37 -0700 (PDT) X-Gm-Message-State: APjAAAX3VntVHFCv/8NB+c5s9Sh07VnISIjBq1g/hC3tZ+wQfL5PMWVc 4pCaIWx0GF1AGLJAcGkFowNWNXGlb7w9vYDoh1w= X-Google-Smtp-Source: APXvYqy25ZyORC+P1JYMxi3NB1dbh9LoPrE65NBWSWqDalu0KCqhu02yb8Ru6YZLqwSu8cBe8X729wUELaCmuy0rqT8= X-Received: by 2002:a1c:c545:: with SMTP id v66mr3207828wmf.51.1559579916334; Mon, 03 Jun 2019 09:38:36 -0700 (PDT) MIME-Version: 1.0 References: <20190520080421.12575-1-wens@kernel.org> <20190520090327.iejd3q7c3iwomzlz@flea> In-Reply-To: <20190520090327.iejd3q7c3iwomzlz@flea> From: Chen-Yu Tsai Date: Tue, 4 Jun 2019 00:38:22 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 00/25] clk: sunxi-ng: clk parent rewrite part 1 To: Stephen Boyd X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190603_093838_772477_075EC110 X-CRM114-Status: GOOD ( 22.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Michael Turquette , linux-kernel , Chen-Yu Tsai , linux-clk , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stephen, On Mon, May 20, 2019 at 5:03 PM Maxime Ripard wrote: > > On Mon, May 20, 2019 at 04:03:56PM +0800, Chen-Yu Tsai wrote: > > From: Chen-Yu Tsai > > > > Hi everyone, > > > > This is series is the first part of a large series (I haven't done the > > rest) of patches to rewrite the clk parent relationship handling within > > the sunxi-ng clk driver. This is based on Stephen's recent work allowing > > clk drivers to specify clk parents using struct clk_hw * or parsing DT > > phandles in the clk node. > > > > This series can be split into a few major parts: > > > > 1) The first patch is a small fix for clk debugfs representation. This > > was done before commit 1a079560b145 ("clk: Cache core in > > clk_fetch_parent_index() without names") was posted, so it might or > > might not be needed. Found this when checking my work using > > clk_possible_parents. > > > > 2) A bunch of CLK_HW_INIT_* helper macros are added. These cover the > > situations I encountered, or assume I will encounter, such as single > > internal (struct clk_hw *) parent, single DT (struct clk_parent_data > > .fw_name), multiple internal parents, and multiple mixed (internal + > > DT) parents. A special variant for just an internal single parent is > > added, CLK_HW_INIT_HWS, which lets the driver share the singular > > list, instead of having the compiler create a compound literal every > > time. It might even make sense to only keep this variant. > > > > 3) A bunch of CLK_FIXED_FACTOR_* helper macros are added. The rationale > > is the same as the single parent CLK_HW_INIT_* helpers. > > > > 4) Bulk conversion of CLK_FIXED_FACTOR to use local parent references, > > either struct clk_hw * or DT .fw_name types, whichever the hardware > > requires. > > > > 5) The beginning of SUNXI_CCU_GATE conversion to local parent > > references. This part is not done. They are included as justification > > and examples for the shared list of clk parents case. > > That series is pretty neat. As far as sunxi is concerned, you can add my > Acked-by: Maxime Ripard > > > I realize this is going to be many patches every time I convert a clock > > type. Going forward would the people involved prefer I send out > > individual patches like this series, or squash them all together? > > For bisection, I guess it would be good to keep the approach you've > had in this series. If this is really too much, I guess we can always > change oru mind later on. Any thoughts on this series and how to proceed? Thanks ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel