All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@csie.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 1/2] sunxi: sun50i/a64: enabled GPIO via sunxi_gpio.c
Date: Tue, 21 Feb 2017 11:54:21 +0800	[thread overview]
Message-ID: <CAGb2v64b4q+_L+m-aOpMCrY2=k_SigwGVwcqqXWzO=Svr0=O_A@mail.gmail.com> (raw)
In-Reply-To: <0cd1782788c48b83294b932e013153ba6b1cef08.1487340650.git.philipp.tomsich@theobroma-systems.com>

On Sat, Feb 18, 2017 at 1:50 AM, Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:

Some description would be nice, such as:

The A64 has the standard Allwinner pin controller with pin banks B ~ L.

> X-AffectedPlatforms: A64-uQ7
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>  drivers/gpio/sunxi_gpio.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpio/sunxi_gpio.c b/drivers/gpio/sunxi_gpio.c
> index 8d2bb18..68dd9fe 100644
> --- a/drivers/gpio/sunxi_gpio.c
> +++ b/drivers/gpio/sunxi_gpio.c
> @@ -344,20 +344,26 @@ static const struct sunxi_gpio_soc_data soc_data_l_3 = {
>  static const struct udevice_id sunxi_gpio_ids[] = {
>         ID("allwinner,sun4i-a10-pinctrl",       a_all),
>         ID("allwinner,sun5i-a10s-pinctrl",      a_all),
>         ID("allwinner,sun5i-a13-pinctrl",       a_all),
>         ID("allwinner,sun6i-a31-pinctrl",       a_all),
>         ID("allwinner,sun6i-a31s-pinctrl",      a_all),
>         ID("allwinner,sun7i-a20-pinctrl",       a_all),
>         ID("allwinner,sun8i-a23-pinctrl",       a_all),
>         ID("allwinner,sun8i-a33-pinctrl",       a_all),
>         ID("allwinner,sun8i-a83t-pinctrl",      a_all),
>         ID("allwinner,sun8i-h3-pinctrl",        a_all),
>         ID("allwinner,sun9i-a80-pinctrl",       a_all),
> +       /* This is not strictly correct for the A64, as it is missing
> +        * bank 'A'. Yet, the register layout in the pinctrl block is
> +        * backward compatible and any accesses to the registers that
> +        * normally control bank 'A' will have no adverse effect.
> +        */

This is true for all the tablet oriented SoCs (Ax3) in the list.

> +       ID("allwinner,sun50i-a64-pinctrl",      a_all),
>         ID("allwinner,sun6i-a31-r-pinctrl",     l_2),
>         ID("allwinner,sun8i-a23-r-pinctrl",     l_1),
>         ID("allwinner,sun8i-a83t-r-pinctrl",    l_1),
>         ID("allwinner,sun8i-h3-r-pinctrl",      l_1),
>         ID("allwinner,sun9i-a80-r-pinctrl",     l_3),
>         { }
>  };
>
> --
> 1.9.1
>

  reply	other threads:[~2017-02-21  3:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-17 17:50 [U-Boot] [PATCH v1 0/2] sunxi: A64: support GPIO Philipp Tomsich
2017-02-17 17:50 ` [U-Boot] [PATCH v1 1/2] sunxi: sun50i/a64: enabled GPIO via sunxi_gpio.c Philipp Tomsich
2017-02-21  3:54   ` Chen-Yu Tsai [this message]
2017-02-17 17:50 ` [U-Boot] [PATCH v1 2/2] sunxi: sun50i/a64: add r_pio (bank 'L') gpio support Philipp Tomsich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGb2v64b4q+_L+m-aOpMCrY2=k_SigwGVwcqqXWzO=Svr0=O_A@mail.gmail.com' \
    --to=wens@csie.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.