From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 383A1C63798 for ; Mon, 23 Nov 2020 03:37:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F05C120738 for ; Mon, 23 Nov 2020 03:37:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727389AbgKWDhz (ORCPT ); Sun, 22 Nov 2020 22:37:55 -0500 Received: from mail-vk1-f194.google.com ([209.85.221.194]:42167 "EHLO mail-vk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726885AbgKWDhz (ORCPT ); Sun, 22 Nov 2020 22:37:55 -0500 Received: by mail-vk1-f194.google.com with SMTP id m184so3667017vkb.9; Sun, 22 Nov 2020 19:37:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TpCl0AHPXqvb+bYBrbLWHuQYiIdRgxs0amhLihMjzVE=; b=s9LcsGgpOIbUkqKPHkdoYk+PHqsx9nd0zd2AGXeVzkSBzo6IG2Pkf7hlO2MltO7Rx7 GBekil07DqswkbNlnEvNv2Hl2I+I0K7oCetgz+9OMX7EHfVATOZyLIppl9ecNyo+qqpD m3HtniSe6UKfyPTCSlP0X5J5HJCXot9Dg3R/ILve6/AvWRWzhGiiGKE2UjGp5N8s//3P f1hfxPQVjYLvu/uLnB6kh4Bm29HBkHMwBT/7Aj4sSF/CZY8KcP8dWDjlSk0xyqr8FCMV e9edq8+LAoCRenc9O5vt+/yoLlGKHmqunZXDCP4ji9mZHLfUmgqWlSxDnl2nHZpkGPfZ eC9g== X-Gm-Message-State: AOAM5313D2Agjio1IC3zUb3sUrTE2zi3Hiucy1hfgpkjmIAl0v0ZyIz1 ACaTiJgGrrWhLcvT93iuXS5n9URTS9RmF0b0 X-Google-Smtp-Source: ABdhPJyjRArppIwC+XRRAzDZDCWVkxoNEEnt92FwJj5Wy3PABmgFDAtd3BpuC92/jKDyYnUi+q8FgA== X-Received: by 2002:a1f:2757:: with SMTP id n84mr18785334vkn.4.1606102674350; Sun, 22 Nov 2020 19:37:54 -0800 (PST) Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com. [209.85.222.44]) by smtp.gmail.com with ESMTPSA id e22sm1208586vsa.10.2020.11.22.19.37.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Nov 2020 19:37:54 -0800 (PST) Received: by mail-ua1-f44.google.com with SMTP id q4so5239212ual.8; Sun, 22 Nov 2020 19:37:53 -0800 (PST) X-Received: by 2002:ab0:3881:: with SMTP id z1mr17757829uav.132.1606102673473; Sun, 22 Nov 2020 19:37:53 -0800 (PST) MIME-Version: 1.0 References: <20201122003841.1957034-1-icenowy@aosc.io> <20201122004011.1957325-1-icenowy@aosc.io> In-Reply-To: <20201122004011.1957325-1-icenowy@aosc.io> From: Chen-Yu Tsai Date: Mon, 23 Nov 2020 11:37:43 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH 2/3] ARM: dts: sun8i: v3s: enable EHCI/OHCI for Lichee Pi Zero To: Icenowy Zheng Cc: Maxime Ripard , Jernej Skrabec , devicetree , linux-arm-kernel , inux-kernel@vger.kernel.org, linux-sunxi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Nov 22, 2020 at 8:40 AM Icenowy Zheng wrote: > > As the USB port on Lichee Pi Zero works in the OTG mode, enable the > EHCI/OHCI controllers for it. You should probably mention that the host controllers work better than the OTG controller in host mode. Otherwise this change lacks justification for enabling two extra hardware blocks. ChenYu > Signed-off-by: Icenowy Zheng > --- > arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts > index 2e4587d26ce5..0cd969194acb 100644 > --- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts > +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts > @@ -77,6 +77,10 @@ red_led { > }; > }; > > +&ehci0 { > + status = "okay"; > +}; > + > &mmc0 { > broken-cd; > bus-width = <4>; > @@ -84,6 +88,10 @@ &mmc0 { > status = "okay"; > }; > > +&ohci0 { > + status = "okay"; > +}; > + > &uart0 { > pinctrl-0 = <&uart0_pb_pins>; > pinctrl-names = "default"; > -- > 2.28.0 > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20201122004011.1957325-1-icenowy%40aosc.io. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F2B5C5519F for ; Mon, 23 Nov 2020 03:39:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0031220738 for ; Mon, 23 Nov 2020 03:39:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UoGnu7vI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0031220738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/psPx6BOV7ggtd/TsaZyIt3Qdxq/7FjhAD+SHzCLjJ4=; b=UoGnu7vIpwnMv6YpD1q382M8I /NLGfvOSuXXqmjzV0kx2BaNtg6X4UnZKvEGGM8z43uGURqntNq+RfKsHM9qbaqN3kSjA8kn6sql4w 3F6oI3Z2QlCWz6cXhLh0eDqC+ilD/1oBEFmfna30ns98E2j8XiSaL2w9TLSkwCUW63SS5OQk32Gvn EvkgFe7aUlgbIZf+Ry7HPfhHPwehL4O+wdYWoLfF/VtVM75hujmMU62ukV6DcnQqFLPfg6/eprv2B wCbSWU2w3LFt4rlO74dATLIyl7cUAmZndoUE5EJqJT7XEe7ZvYoCcX/UGG4vm4wmfDjKjQD/JaCVM 3ulbDIlcg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kh2fw-0000Ux-Mu; Mon, 23 Nov 2020 03:38:00 +0000 Received: from mail-vs1-f65.google.com ([209.85.217.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kh2fr-0000UV-Ro for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 03:37:56 +0000 Received: by mail-vs1-f65.google.com with SMTP id r14so8365455vsa.13 for ; Sun, 22 Nov 2020 19:37:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TpCl0AHPXqvb+bYBrbLWHuQYiIdRgxs0amhLihMjzVE=; b=UIqpY9QEdg8Nkw0OuSRt4mSYu64toG/iOqtNxjm7wqoHDovbzIkbz59Eu9RSjkNBV7 gz6dYvqUQedU45kaxDowSFB4YLIcrpiuSU1F9l2bGsuGTfeELhlpcwWdxrrJHC4iZerG tbM8geR4wj4PNgB+g3WhAX+UQo+yT07FA7rZ5Y4zgMJTqrxDrkS4aPX3e77c6zrWh023 cjIzWuJoRVqpeXv6cJtQX+WXfJf7vgbHO225aYrpjmtX/o2CscpYyS12o9M37mCpxhSj SJX5IIZ88v73doUnBFaFWsvPkBW7EQ5djQfE7oScEL1vSmpVjSJVowpS9r7Ul1rj5ozd jZZg== X-Gm-Message-State: AOAM530FIFTWSZQ+g/G0D9YgXA91r5ns8tRZV9lYO3Ra4n8NwUoY4+p9 Fe/VXmSjFbJGTtLuw+PuT2KeKv8tJwBOC/1r X-Google-Smtp-Source: ABdhPJxYdEF/yMgkWqIi2jPDgfvOPndZExwvoaFzk3RPL5pWjd1vVUUtHCqbjb03O26jektnFycYbg== X-Received: by 2002:a67:d281:: with SMTP id z1mr19844514vsi.47.1606102674512; Sun, 22 Nov 2020 19:37:54 -0800 (PST) Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com. [209.85.222.43]) by smtp.gmail.com with ESMTPSA id e9sm1249656vso.32.2020.11.22.19.37.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Nov 2020 19:37:54 -0800 (PST) Received: by mail-ua1-f43.google.com with SMTP id v9so5220046uar.11 for ; Sun, 22 Nov 2020 19:37:53 -0800 (PST) X-Received: by 2002:ab0:3881:: with SMTP id z1mr17757829uav.132.1606102673473; Sun, 22 Nov 2020 19:37:53 -0800 (PST) MIME-Version: 1.0 References: <20201122003841.1957034-1-icenowy@aosc.io> <20201122004011.1957325-1-icenowy@aosc.io> In-Reply-To: <20201122004011.1957325-1-icenowy@aosc.io> From: Chen-Yu Tsai Date: Mon, 23 Nov 2020 11:37:43 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH 2/3] ARM: dts: sun8i: v3s: enable EHCI/OHCI for Lichee Pi Zero To: Icenowy Zheng X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201122_223755_967397_B64276DC X-CRM114-Status: GOOD ( 21.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Jernej Skrabec , inux-kernel@vger.kernel.org, Maxime Ripard , linux-sunxi , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Nov 22, 2020 at 8:40 AM Icenowy Zheng wrote: > > As the USB port on Lichee Pi Zero works in the OTG mode, enable the > EHCI/OHCI controllers for it. You should probably mention that the host controllers work better than the OTG controller in host mode. Otherwise this change lacks justification for enabling two extra hardware blocks. ChenYu > Signed-off-by: Icenowy Zheng > --- > arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts > index 2e4587d26ce5..0cd969194acb 100644 > --- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts > +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts > @@ -77,6 +77,10 @@ red_led { > }; > }; > > +&ehci0 { > + status = "okay"; > +}; > + > &mmc0 { > broken-cd; > bus-width = <4>; > @@ -84,6 +88,10 @@ &mmc0 { > status = "okay"; > }; > > +&ohci0 { > + status = "okay"; > +}; > + > &uart0 { > pinctrl-0 = <&uart0_pb_pins>; > pinctrl-names = "default"; > -- > 2.28.0 > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20201122004011.1957325-1-icenowy%40aosc.io. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel