From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F38DC433E9 for ; Mon, 18 Jan 2021 10:38:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DC0E229CA for ; Mon, 18 Jan 2021 10:38:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388444AbhARKhz (ORCPT ); Mon, 18 Jan 2021 05:37:55 -0500 Received: from mail-lf1-f47.google.com ([209.85.167.47]:39450 "EHLO mail-lf1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388775AbhARKXL (ORCPT ); Mon, 18 Jan 2021 05:23:11 -0500 Received: by mail-lf1-f47.google.com with SMTP id a12so23310020lfl.6 for ; Mon, 18 Jan 2021 02:22:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=etHR2nUpbx7OfSX6dc0Gj4zCnf0F4dHWRck6e+5f6Aw=; b=KjaldxHeJ+wwX+LmwDzuC3zKQ2jRn3yDURX4EM5eGCQiblvdP1TpU0VAwdLf3MFvmu H0QhmhnZsgK6f0VyqjL00U9SzCfXbbAZAlotlIrPfwM750mTu9aXe3p388LKJfSm3Rxg rM9l6aFI800LPrA+XdOG+/rgVzWhJIaU+ME9bp4DFGjmIirMXFu5q1EIaD2mYQhXF7Mg l7wgMtgBDNwUndincvl/VCJaj/oeI94/akNo4uCnS7uAxKcgCH4stT8jFU/VXV3nADWC iDMDqNUZgS4WflQrUunZ25m7unXZpbOqYvSuRzaenWPZCGa0s3ecJba5gmTQMU+QWW1P aNeg== X-Gm-Message-State: AOAM531mFTBVLTtB1KIfhE7288jxGXpu0+XOt77YGg+inbEazZzSg3+w eyJL2ta8gtTqr3mRre05gHgnUMBBhZJEUQ== X-Google-Smtp-Source: ABdhPJyvEz1tTDV3jNLzukIL2PzapKWCdCILD2LekJp9U6qNLySVQ/2APMNqdjLf2h4jxTTe/c/bqQ== X-Received: by 2002:a19:801:: with SMTP id 1mr11356273lfi.113.1610965348421; Mon, 18 Jan 2021 02:22:28 -0800 (PST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com. [209.85.167.54]) by smtp.gmail.com with ESMTPSA id y24sm1640917ljm.125.2021.01.18.02.22.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 02:22:28 -0800 (PST) Received: by mail-lf1-f54.google.com with SMTP id o10so23236957lfl.13 for ; Mon, 18 Jan 2021 02:22:27 -0800 (PST) X-Received: by 2002:a19:8041:: with SMTP id b62mr11440556lfd.496.1610965347757; Mon, 18 Jan 2021 02:22:27 -0800 (PST) MIME-Version: 1.0 References: <20210114113538.1233933-1-maxime@cerno.tech> <20210114113538.1233933-4-maxime@cerno.tech> <20210118100321.ktbnfpsxka2icbaa@gilmour> In-Reply-To: <20210118100321.ktbnfpsxka2icbaa@gilmour> From: Chen-Yu Tsai Date: Mon, 18 Jan 2021 18:22:15 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 04/19] dt-bindings: bridge: simple: Add corpro,gm7123 compatible To: Maxime Ripard Cc: Laurent Pinchart , Rob Herring , Frank Rowand , devicetree , Jernej Skrabec , linux-arm-kernel , Laurent Pinchart , Sam Ravnborg Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jan 18, 2021 at 6:03 PM Maxime Ripard wrote: > > Hi Laurent, > > On Fri, Jan 15, 2021 at 09:16:30AM +0200, Laurent Pinchart wrote: > > Thank you for the patch. > > > > On Thu, Jan 14, 2021 at 12:35:23PM +0100, Maxime Ripard wrote: > > > The corpro,gm7123 was in use in a DT but was never properly documented, > > > let's add it. > > > > > > Cc: Laurent Pinchart > > > Cc: Sam Ravnborg > > > Signed-off-by: Maxime Ripard > > > --- > > > .../devicetree/bindings/display/bridge/simple-bridge.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml > > > index 64e8a1c24b40..97ca07b56cbc 100644 > > > --- a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml > > > +++ b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml > > > @@ -22,6 +22,10 @@ properties: > > > - ti,ths8134a > > > - ti,ths8134b > > > - const: ti,ths8134 > > > + - items: > > > + - const: corpro,gm7123 > > > + - const: adi,adv7123 > > > > Do we need adi,adv7123 ? > > I'm not sure: it looks like having both the adv7123 and the dumb-vga-dac > compatible was never an option, so we can also change the DT to have > corpro,gm7123, dumb-vga-dac FYI I used the adi,adv7123 fallback because the gm7123 datasheet compares the two, with the gm7123 having lower standby current, but only limited to 3.3V power supply. Maximum resolution, conversion rate, and the range of output current are all the same. The package is the same as well. I believe the gm7123 is intended as a drop-in clone of the adv7123. ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B4FBC433E0 for ; Mon, 18 Jan 2021 10:24:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52829221EC for ; Mon, 18 Jan 2021 10:24:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52829221EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K8rytdqXnL6ArNzgyvKhGzr6wn67P/MdT2g18T0gC+M=; b=uvtfuJBKMWL6z0EnGxCQT3LUw RhriuMbb8J/TuMy34c4tnR/LIluIIUiNrplQdDBXbDR4Fb2nDfUYaq9FC/34exUczFZ2IAke+my2w scIW6IcQYIDlf8FpcIEbC7pqV8l514/9f72xoJL38legU+7BbEE5zQ8ujAMzjGvqLzZy9EjIXys8j XCbA4/wnPcx+FHS6XIAvO8nzhrA4h4TyjgOgnmjuryWot88lFSc62+8HxKnad4IMuBh/EW5TCRqI0 ZWHsZ97i/iwrD/Uhu+efd9czVnq4Z2hLYWYyvX/cdOJJMhi0LjFXazU5RBhUhcQ7+as8ENiQiZx+G nId00eQhQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1RgA-0005Sj-PV; Mon, 18 Jan 2021 10:22:34 +0000 Received: from mail-lj1-f170.google.com ([209.85.208.170]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1Rg7-0005SH-Fl for linux-arm-kernel@lists.infradead.org; Mon, 18 Jan 2021 10:22:33 +0000 Received: by mail-lj1-f170.google.com with SMTP id y22so17603017ljn.9 for ; Mon, 18 Jan 2021 02:22:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=etHR2nUpbx7OfSX6dc0Gj4zCnf0F4dHWRck6e+5f6Aw=; b=jnveKGFz1ulcxstyxLVWuGrVCIor1qhOmJrVh7u9a+7CuQ70ZfUvbHEOm4H6JKbQ7A riBfBmjaCZfFl8qxXOIvqUByZlRKnVnIe1k6+wu8vEglNQJ5qxslOshClFnUlGijq9r3 Dvc8tsej/9pBq+sywfM7fDDfaxt6fD8tHTt0BBsZpWqm6Igrc2wD9TFXZrIue/qN2pmz M+cuj3wcgjrCtFSJJr266q9NkIs3EHCi49UH7HrkWZlYF3JjaR0527TugE+6do3wEL6e HQiWd31/nKA9u/kRr2+bjI9LV/qxb3yjJvuJGuRP+4tYY6GgtT/pbCRe2Ezc7jGRgcjT /R7w== X-Gm-Message-State: AOAM532jYR9gYYC7+mbIZs1RmwE0qSu7TTFVF19zWbY3GUYZFg1zRPkQ 7iFz825afR2AKayQV6qS0dOoPKvXAMIM5Q== X-Google-Smtp-Source: ABdhPJz1+fjc1rZJRyf+iquig7scqZXNLBiYW0YaUb9ACQ5N3n2mgg5kEjJjEaL7Spongf9QlP164g== X-Received: by 2002:a2e:9787:: with SMTP id y7mr10012046lji.420.1610965349143; Mon, 18 Jan 2021 02:22:29 -0800 (PST) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com. [209.85.167.47]) by smtp.gmail.com with ESMTPSA id u14sm1681490ljo.72.2021.01.18.02.22.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 02:22:28 -0800 (PST) Received: by mail-lf1-f47.google.com with SMTP id u25so23304266lfc.2 for ; Mon, 18 Jan 2021 02:22:27 -0800 (PST) X-Received: by 2002:a19:8041:: with SMTP id b62mr11440556lfd.496.1610965347757; Mon, 18 Jan 2021 02:22:27 -0800 (PST) MIME-Version: 1.0 References: <20210114113538.1233933-1-maxime@cerno.tech> <20210114113538.1233933-4-maxime@cerno.tech> <20210118100321.ktbnfpsxka2icbaa@gilmour> In-Reply-To: <20210118100321.ktbnfpsxka2icbaa@gilmour> From: Chen-Yu Tsai Date: Mon, 18 Jan 2021 18:22:15 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 04/19] dt-bindings: bridge: simple: Add corpro, gm7123 compatible To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210118_052231_556385_B217878F X-CRM114-Status: GOOD ( 23.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Jernej Skrabec , Laurent Pinchart , Sam Ravnborg , Rob Herring , Laurent Pinchart , Frank Rowand , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 18, 2021 at 6:03 PM Maxime Ripard wrote: > > Hi Laurent, > > On Fri, Jan 15, 2021 at 09:16:30AM +0200, Laurent Pinchart wrote: > > Thank you for the patch. > > > > On Thu, Jan 14, 2021 at 12:35:23PM +0100, Maxime Ripard wrote: > > > The corpro,gm7123 was in use in a DT but was never properly documented, > > > let's add it. > > > > > > Cc: Laurent Pinchart > > > Cc: Sam Ravnborg > > > Signed-off-by: Maxime Ripard > > > --- > > > .../devicetree/bindings/display/bridge/simple-bridge.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml > > > index 64e8a1c24b40..97ca07b56cbc 100644 > > > --- a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml > > > +++ b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml > > > @@ -22,6 +22,10 @@ properties: > > > - ti,ths8134a > > > - ti,ths8134b > > > - const: ti,ths8134 > > > + - items: > > > + - const: corpro,gm7123 > > > + - const: adi,adv7123 > > > > Do we need adi,adv7123 ? > > I'm not sure: it looks like having both the adv7123 and the dumb-vga-dac > compatible was never an option, so we can also change the DT to have > corpro,gm7123, dumb-vga-dac FYI I used the adi,adv7123 fallback because the gm7123 datasheet compares the two, with the gm7123 having lower standby current, but only limited to 3.3V power supply. Maximum resolution, conversion rate, and the range of output current are all the same. The package is the same as well. I believe the gm7123 is intended as a drop-in clone of the adv7123. ChenYu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel