From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73992C433DB for ; Wed, 13 Jan 2021 10:44:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1653F22D58 for ; Wed, 13 Jan 2021 10:44:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727052AbhAMKoM convert rfc822-to-8bit (ORCPT ); Wed, 13 Jan 2021 05:44:12 -0500 Received: from mail-lj1-f173.google.com ([209.85.208.173]:39597 "EHLO mail-lj1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725681AbhAMKoM (ORCPT ); Wed, 13 Jan 2021 05:44:12 -0500 Received: by mail-lj1-f173.google.com with SMTP id b10so1982489ljp.6 for ; Wed, 13 Jan 2021 02:43:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=tgP/px9dEMduUnVn7Ii7SHYctPo6qFWBGOF3w2zM/rE=; b=M+vX9SD+lGIxNCtYjN5/35gQB1aPzTfygxiTt16ypqOKfn3zAYK8GyY9LmXcMZknlx pNMpfQ7JhWv0DizOCYdncF7NhLT6PLXdUiz4gku10aCAIIeZstjXuY1UmMAsugN55VDF TWjjVBonlJu8EcqcBOCydPGVyXp8WRZk8jTycQYhrKIfG5WhFAiuJyF50iWbBHJn7v1V ofW/fVMZgg9DUN+PocOCacld7zNkdA4LqZr1+2r0TeBgCba5Ii6/j7rjBqbZEBpVyiob 0xXI+WpWVzvTeV+aAXAUF2r9oyOY4YnqPdTQ/jghnN+5pmFKwgbCgF0gWHwkLgu4eC8X GcWw== X-Gm-Message-State: AOAM531hkNETVbXL6OiyNOpokR+y5HM0bwrWcUzKvvE1CFzc5FbOP1Ha Iur4P1nPAjBhECeGSP38KLwKA1hnEjaenw== X-Google-Smtp-Source: ABdhPJz2r77/efrKIU8StLx4VlsOjIL4Hrg4L5RtZRNM54+r7fbzz6b45ucE7hCaYs/ma6mQ18QaWA== X-Received: by 2002:a05:651c:2da:: with SMTP id f26mr690665ljo.252.1610534609682; Wed, 13 Jan 2021 02:43:29 -0800 (PST) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com. [209.85.167.52]) by smtp.gmail.com with ESMTPSA id h23sm145164ljh.115.2021.01.13.02.43.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jan 2021 02:43:29 -0800 (PST) Received: by mail-lf1-f52.google.com with SMTP id b26so2035084lff.9 for ; Wed, 13 Jan 2021 02:43:29 -0800 (PST) X-Received: by 2002:a19:810:: with SMTP id 16mr619252lfi.233.1610534609099; Wed, 13 Jan 2021 02:43:29 -0800 (PST) MIME-Version: 1.0 References: <20210106150525.15403-1-andre.przywara@arm.com> <20210106150525.15403-2-andre.przywara@arm.com> In-Reply-To: From: Chen-Yu Tsai Date: Wed, 13 Jan 2021 18:43:16 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH 1/7] arm64: dts: allwinner: H6/A64: properly connect USB PHY to port 0 To: =?UTF-8?Q?Andr=C3=A9_Przywara?= Cc: Maxime Ripard , Rob Herring , Jernej Skrabec , Icenowy Zheng , devicetree , linux-arm-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jan 13, 2021 at 6:30 PM André Przywara wrote: > > On 06/01/2021 15:56, Chen-Yu Tsai wrote: > > Hi, > > > > On Wed, Jan 6, 2021 at 11:05 PM Andre Przywara wrote: > >> > >> In recent Allwinner SoCs the first USB host controller (HCI0) shares > >> the first PHY with the MUSB controller. Probably to make this sharing > >> work, we were avoiding to declare this in the DT. This has two > >> shortcomings: > >> - U-Boot (which uses the same .dts) cannot use this port in host mode > >> without a PHY linked, so we were loosing one USB port there. > >> - It requires the MUSB driver to be enabled and loaded, although we > >> don't actually use it. > >> > >> To avoid those issues, let's add this PHY link to the A64 and H6 .dtsi > >> files. After all PHY port 0 *is* connected to HCI0, so we should describe > >> it as this. Remove the part from the boards which were already doing > >> that. > >> > >> This makes it work in U-Boot, also improves compatiblity when no MUSB > >> driver is loaded (for instance in distribution installers). > >> > >> Signed-off-by: Andre Przywara > >> --- > >> arch/arm64/boot/dts/allwinner/sun50i-a64-pinebook.dts | 4 ---- > >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 4 ++++ > >> arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 4 ++++ > > > > It would be better if the H6 parts were separated out. > > Sure. > > > > > Please also add a fixes tag, which helps with backporting. > > The whole concept of DT backports raises some eyebrows here, but it's > surely easy enough to do. Well, whether people choose to backport is their decision. But providing information used to decide whether to do so, and if yes, what else is needed, is IMHO something the author can help with. Likely backport scenarios are distribution kernels AFAICT. ChenYu > Thanks, > Andre. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AE23C433DB for ; Wed, 13 Jan 2021 10:45:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 267B422D58 for ; Wed, 13 Jan 2021 10:45:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 267B422D58 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D7OCpiPfkNZ0wP8JGm3D7sz21EwTNxUFvMuBgUniULA=; b=tysTwHwaFoKlDrQB7YD1k2s04 KceR6a7B57VxfO8d0ImWIVeVzOCYimctnKapkv5tWd1AEFlRkfR+NwzrsH0yvU5JqOvtCuF0m0TMV FSfIqJKfHjnu9NV78Xb1KkOCTrmSpWsuLOHnYsm4an+dRhgHOBlvS8DIxJaqfAJVR9sXKtXhQNEHZ xDKeL4iLVnZrle3kncq0QdZzPz2On5u0w5c4GYPMGKy9XP3gsWPGqrHE/m6PL293WfQA+x0RJ+y9U Kr+ouXQI94HGCg6Rf66NMLsvNmBWjTBIHcXZ8az2inyIaQxr8cdY4Oppg16VR43tkzwR6hWkRPAaP viNOZXBdg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzdcs-0001k9-3t; Wed, 13 Jan 2021 10:43:42 +0000 Received: from mail-lj1-f179.google.com ([209.85.208.179]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzdcn-0001jC-OV for linux-arm-kernel@lists.infradead.org; Wed, 13 Jan 2021 10:43:40 +0000 Received: by mail-lj1-f179.google.com with SMTP id f17so1946053ljg.12 for ; Wed, 13 Jan 2021 02:43:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=tgP/px9dEMduUnVn7Ii7SHYctPo6qFWBGOF3w2zM/rE=; b=o0cqBdqs0LEaSXu6LJK5E1cbL2TVYzlrIZ9sTPOvLVD5V7+sQwg70weVNcK12b1Mt+ HXyd/rCVjgE3xlxauyZe3B4/ddWXymp/1AzQ+7jH94EXdcfYeMeKZiA0PynBGjYuTGUu teG6BRP0PorEmUX9Khzvnb/2AikTpxAT0yWiA7VUOvFWPort5qelWGhc19GukDX1WtXQ SsPUlQrp2OXG5ST3JCZOSxGIBqEzoNOIuUEtqsJFfscGJYvv2g+DKUUHfzsj0ciNcmZd zWbq9LiRdPkpQkJBtGuh9iaEGmCORevO8YrrnCui21xktpKEfJWIS0L8Fb9EhBy0u0uQ c4fA== X-Gm-Message-State: AOAM533M3/gYvPMPCkQNlhR6zquqhM5MM9VqLrzbGSF54WP0zknQub9v 3f+idE24+XcEiW0ft4YQPU2vG4rdjrBzmw== X-Google-Smtp-Source: ABdhPJx44eZNJ2vh6rZx9foq64Ld0VI/cDR5+1BSnZdR0wbNiuuw3e3GxJerCYtvDp9mcox3yU8l2g== X-Received: by 2002:a2e:2202:: with SMTP id i2mr715918lji.306.1610534609904; Wed, 13 Jan 2021 02:43:29 -0800 (PST) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com. [209.85.167.49]) by smtp.gmail.com with ESMTPSA id x67sm169071lff.82.2021.01.13.02.43.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jan 2021 02:43:29 -0800 (PST) Received: by mail-lf1-f49.google.com with SMTP id o19so2082749lfo.1 for ; Wed, 13 Jan 2021 02:43:29 -0800 (PST) X-Received: by 2002:a19:810:: with SMTP id 16mr619252lfi.233.1610534609099; Wed, 13 Jan 2021 02:43:29 -0800 (PST) MIME-Version: 1.0 References: <20210106150525.15403-1-andre.przywara@arm.com> <20210106150525.15403-2-andre.przywara@arm.com> In-Reply-To: From: Chen-Yu Tsai Date: Wed, 13 Jan 2021 18:43:16 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH 1/7] arm64: dts: allwinner: H6/A64: properly connect USB PHY to port 0 To: =?UTF-8?Q?Andr=C3=A9_Przywara?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210113_054337_839825_7416013B X-CRM114-Status: GOOD ( 23.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Jernej Skrabec , Maxime Ripard , linux-sunxi , linux-arm-kernel , Icenowy Zheng Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKYW4gMTMsIDIwMjEgYXQgNjozMCBQTSBBbmRyw6kgUHJ6eXdhcmEgPGFuZHJlLnBy enl3YXJhQGFybS5jb20+IHdyb3RlOgo+Cj4gT24gMDYvMDEvMjAyMSAxNTo1NiwgQ2hlbi1ZdSBU c2FpIHdyb3RlOgo+ID4gSGksCj4gPgo+ID4gT24gV2VkLCBKYW4gNiwgMjAyMSBhdCAxMTowNSBQ TSBBbmRyZSBQcnp5d2FyYSA8YW5kcmUucHJ6eXdhcmFAYXJtLmNvbT4gd3JvdGU6Cj4gPj4KPiA+ PiBJbiByZWNlbnQgQWxsd2lubmVyIFNvQ3MgdGhlIGZpcnN0IFVTQiBob3N0IGNvbnRyb2xsZXIg KEhDSTApIHNoYXJlcwo+ID4+IHRoZSBmaXJzdCBQSFkgd2l0aCB0aGUgTVVTQiBjb250cm9sbGVy LiBQcm9iYWJseSB0byBtYWtlIHRoaXMgc2hhcmluZwo+ID4+IHdvcmssIHdlIHdlcmUgYXZvaWRp bmcgdG8gZGVjbGFyZSB0aGlzIGluIHRoZSBEVC4gVGhpcyBoYXMgdHdvCj4gPj4gc2hvcnRjb21p bmdzOgo+ID4+IC0gVS1Cb290ICh3aGljaCB1c2VzIHRoZSBzYW1lIC5kdHMpIGNhbm5vdCB1c2Ug dGhpcyBwb3J0IGluIGhvc3QgbW9kZQo+ID4+ICAgd2l0aG91dCBhIFBIWSBsaW5rZWQsIHNvIHdl IHdlcmUgbG9vc2luZyBvbmUgVVNCIHBvcnQgdGhlcmUuCj4gPj4gLSBJdCByZXF1aXJlcyB0aGUg TVVTQiBkcml2ZXIgdG8gYmUgZW5hYmxlZCBhbmQgbG9hZGVkLCBhbHRob3VnaCB3ZQo+ID4+ICAg ZG9uJ3QgYWN0dWFsbHkgdXNlIGl0Lgo+ID4+Cj4gPj4gVG8gYXZvaWQgdGhvc2UgaXNzdWVzLCBs ZXQncyBhZGQgdGhpcyBQSFkgbGluayB0byB0aGUgQTY0IGFuZCBINiAuZHRzaQo+ID4+IGZpbGVz LiBBZnRlciBhbGwgUEhZIHBvcnQgMCAqaXMqIGNvbm5lY3RlZCB0byBIQ0kwLCBzbyB3ZSBzaG91 bGQgZGVzY3JpYmUKPiA+PiBpdCBhcyB0aGlzLiBSZW1vdmUgdGhlIHBhcnQgZnJvbSB0aGUgYm9h cmRzIHdoaWNoIHdlcmUgYWxyZWFkeSBkb2luZwo+ID4+IHRoYXQuCj4gPj4KPiA+PiBUaGlzIG1h a2VzIGl0IHdvcmsgaW4gVS1Cb290LCBhbHNvIGltcHJvdmVzIGNvbXBhdGlibGl0eSB3aGVuIG5v IE1VU0IKPiA+PiBkcml2ZXIgaXMgbG9hZGVkIChmb3IgaW5zdGFuY2UgaW4gZGlzdHJpYnV0aW9u IGluc3RhbGxlcnMpLgo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogQW5kcmUgUHJ6eXdhcmEgPGFu ZHJlLnByenl3YXJhQGFybS5jb20+Cj4gPj4gLS0tCj4gPj4gIGFyY2gvYXJtNjQvYm9vdC9kdHMv YWxsd2lubmVyL3N1bjUwaS1hNjQtcGluZWJvb2suZHRzIHwgNCAtLS0tCj4gPj4gIGFyY2gvYXJt NjQvYm9vdC9kdHMvYWxsd2lubmVyL3N1bjUwaS1hNjQuZHRzaSAgICAgICAgIHwgNCArKysrCj4g Pj4gIGFyY2gvYXJtNjQvYm9vdC9kdHMvYWxsd2lubmVyL3N1bjUwaS1oNi5kdHNpICAgICAgICAg IHwgNCArKysrCj4gPgo+ID4gSXQgd291bGQgYmUgYmV0dGVyIGlmIHRoZSBINiBwYXJ0cyB3ZXJl IHNlcGFyYXRlZCBvdXQuCj4KPiBTdXJlLgo+Cj4gPgo+ID4gUGxlYXNlIGFsc28gYWRkIGEgZml4 ZXMgdGFnLCB3aGljaCBoZWxwcyB3aXRoIGJhY2twb3J0aW5nLgo+Cj4gVGhlIHdob2xlIGNvbmNl cHQgb2YgRFQgYmFja3BvcnRzIHJhaXNlcyBzb21lIGV5ZWJyb3dzIGhlcmUsIGJ1dCBpdCdzCj4g c3VyZWx5IGVhc3kgZW5vdWdoIHRvIGRvLgoKV2VsbCwgd2hldGhlciBwZW9wbGUgY2hvb3NlIHRv IGJhY2twb3J0IGlzIHRoZWlyIGRlY2lzaW9uLiBCdXQgcHJvdmlkaW5nCmluZm9ybWF0aW9uIHVz ZWQgdG8gZGVjaWRlIHdoZXRoZXIgdG8gZG8gc28sIGFuZCBpZiB5ZXMsIHdoYXQgZWxzZSBpcwpu ZWVkZWQsIGlzIElNSE8gc29tZXRoaW5nIHRoZSBhdXRob3IgY2FuIGhlbHAgd2l0aC4KCkxpa2Vs eSBiYWNrcG9ydCBzY2VuYXJpb3MgYXJlIGRpc3RyaWJ1dGlvbiBrZXJuZWxzIEFGQUlDVC4KCkNo ZW5ZdQoKPiBUaGFua3MsCj4gQW5kcmUuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==