From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934284AbdIYJTj convert rfc822-to-8bit (ORCPT ); Mon, 25 Sep 2017 05:19:39 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:56408 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932627AbdIYJTh (ORCPT ); Mon, 25 Sep 2017 05:19:37 -0400 X-Google-Smtp-Source: AOwi7QDUTFyy2L6YO/Du2yps2VwOGwZZcqayiPs8pYWv3Lf4f0HDMWgiCbDHy4hewEUulZ91ZuepY+3eFKgcsOCpafw= MIME-Version: 1.0 In-Reply-To: References: <20170920151814.22461-1-icenowy@aosc.io> <20170920151814.22461-7-icenowy@aosc.io> <7ce5c53e-70ba-456e-ecf7-5132ef2c2c64@free-electrons.com> From: Chen-Yu Tsai Date: Mon, 25 Sep 2017 17:19:07 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI To: Icenowy Zheng Cc: Quentin Schulz , Chen-Yu Tsai , Maxime Ripard , Jonathan Cameron , Lee Jones , "open list:THERMAL" , devicetree , linux-kernel , linux-arm-kernel , linux-iio@vger.kernel.org, linux-sunxi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 25, 2017 at 5:14 PM, Icenowy Zheng wrote: > > > 于 2017年9月25日 GMT+08:00 下午5:11:57, Quentin Schulz 写到: >>Hi Icenowy, >> >>On 20/09/2017 17:18, Icenowy Zheng wrote: >>> AXP803 PMIC features AC/USB/Battery power supplies. >>> >>> As we have now the device tree bindings for them, add device tree >>> nodes for them. >>> >>> Signed-off-by: Icenowy Zheng >>> --- >>> arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/allwinner/axp803.dtsi >>b/arch/arm64/boot/dts/allwinner/axp803.dtsi >>> index ff8af52743ff..3a8615231b7c 100644 >>> --- a/arch/arm64/boot/dts/allwinner/axp803.dtsi >>> +++ b/arch/arm64/boot/dts/allwinner/axp803.dtsi >>> @@ -49,6 +49,16 @@ >>> interrupt-controller; >>> #interrupt-cells = <1>; >>> >>> + ac_power_supply: ac-power-supply { >>> + compatible = "x-powers,axp221-ac-power-supply"; >>> + status = "disabled"; >>> + }; >>> + >>> + battery_power_supply: battery-power-supply { >>> + compatible = "x-powers,axp803-battery-power-supply"; >>> + status = "disabled"; >>> + }; >>> + >>> regulators { >>> /* Default work frequency for buck regulators */ >>> x-powers,dcdc-freq = <3000>; >>> @@ -147,4 +157,9 @@ >>> regulator-name = "rtc-ldo"; >>> }; >>> }; >>> + >>> + usb_power_supply: usb_power_supply { >>> + compatible = "x-powers,axp803-usb-power-supply"; >>> + status = "disabled"; >>> + }; >> >>No. You have added support for the AC and battery power supply drivers >>in this patchset, not for USB. > > But I added its device tree binding. Please do both at the same time. If you only add the binding without the driver, how can you be sure the binding would be a proper fit? Moreover, no one can actually test it. ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen-Yu Tsai Subject: Re: Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI Date: Mon, 25 Sep 2017 17:19:07 +0800 Message-ID: References: <20170920151814.22461-1-icenowy@aosc.io> <20170920151814.22461-7-icenowy@aosc.io> <7ce5c53e-70ba-456e-ecf7-5132ef2c2c64@free-electrons.com> Reply-To: wens-jdAy2FN1RRM@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Icenowy Zheng Cc: Quentin Schulz , Chen-Yu Tsai , Maxime Ripard , Jonathan Cameron , Lee Jones , "open list:THERMAL" , devicetree , linux-kernel , linux-arm-kernel , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi List-Id: devicetree@vger.kernel.org On Mon, Sep 25, 2017 at 5:14 PM, Icenowy Zheng wrote: > > > =E4=BA=8E 2017=E5=B9=B49=E6=9C=8825=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=88= 5:11:57, Quentin Schulz =E5=86=99=E5=88= =B0: >>Hi Icenowy, >> >>On 20/09/2017 17:18, Icenowy Zheng wrote: >>> AXP803 PMIC features AC/USB/Battery power supplies. >>> >>> As we have now the device tree bindings for them, add device tree >>> nodes for them. >>> >>> Signed-off-by: Icenowy Zheng >>> --- >>> arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/allwinner/axp803.dtsi >>b/arch/arm64/boot/dts/allwinner/axp803.dtsi >>> index ff8af52743ff..3a8615231b7c 100644 >>> --- a/arch/arm64/boot/dts/allwinner/axp803.dtsi >>> +++ b/arch/arm64/boot/dts/allwinner/axp803.dtsi >>> @@ -49,6 +49,16 @@ >>> interrupt-controller; >>> #interrupt-cells =3D <1>; >>> >>> + ac_power_supply: ac-power-supply { >>> + compatible =3D "x-powers,axp221-ac-power-supply"; >>> + status =3D "disabled"; >>> + }; >>> + >>> + battery_power_supply: battery-power-supply { >>> + compatible =3D "x-powers,axp803-battery-power-supply"; >>> + status =3D "disabled"; >>> + }; >>> + >>> regulators { >>> /* Default work frequency for buck regulators */ >>> x-powers,dcdc-freq =3D <3000>; >>> @@ -147,4 +157,9 @@ >>> regulator-name =3D "rtc-ldo"; >>> }; >>> }; >>> + >>> + usb_power_supply: usb_power_supply { >>> + compatible =3D "x-powers,axp803-usb-power-supply"; >>> + status =3D "disabled"; >>> + }; >> >>No. You have added support for the AC and battery power supply drivers >>in this patchset, not for USB. > > But I added its device tree binding. Please do both at the same time. If you only add the binding without the driver, how can you be sure the binding would be a proper fit? Moreover, no one can actually test it. ChenYu --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: References: <20170920151814.22461-1-icenowy@aosc.io> <20170920151814.22461-7-icenowy@aosc.io> <7ce5c53e-70ba-456e-ecf7-5132ef2c2c64@free-electrons.com> From: Chen-Yu Tsai Date: Mon, 25 Sep 2017 17:19:07 +0800 Message-ID: Subject: Re: [linux-sunxi] Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI To: Icenowy Zheng Cc: Quentin Schulz , Chen-Yu Tsai , Maxime Ripard , Jonathan Cameron , Lee Jones , "open list:THERMAL" , devicetree , linux-kernel , linux-arm-kernel , linux-iio@vger.kernel.org, linux-sunxi Content-Type: text/plain; charset="UTF-8" List-ID: On Mon, Sep 25, 2017 at 5:14 PM, Icenowy Zheng wrote: > > > =E4=BA=8E 2017=E5=B9=B49=E6=9C=8825=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=88= 5:11:57, Quentin Schulz =E5=86=99=E5=88= =B0: >>Hi Icenowy, >> >>On 20/09/2017 17:18, Icenowy Zheng wrote: >>> AXP803 PMIC features AC/USB/Battery power supplies. >>> >>> As we have now the device tree bindings for them, add device tree >>> nodes for them. >>> >>> Signed-off-by: Icenowy Zheng >>> --- >>> arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/allwinner/axp803.dtsi >>b/arch/arm64/boot/dts/allwinner/axp803.dtsi >>> index ff8af52743ff..3a8615231b7c 100644 >>> --- a/arch/arm64/boot/dts/allwinner/axp803.dtsi >>> +++ b/arch/arm64/boot/dts/allwinner/axp803.dtsi >>> @@ -49,6 +49,16 @@ >>> interrupt-controller; >>> #interrupt-cells =3D <1>; >>> >>> + ac_power_supply: ac-power-supply { >>> + compatible =3D "x-powers,axp221-ac-power-supply"; >>> + status =3D "disabled"; >>> + }; >>> + >>> + battery_power_supply: battery-power-supply { >>> + compatible =3D "x-powers,axp803-battery-power-supply"; >>> + status =3D "disabled"; >>> + }; >>> + >>> regulators { >>> /* Default work frequency for buck regulators */ >>> x-powers,dcdc-freq =3D <3000>; >>> @@ -147,4 +157,9 @@ >>> regulator-name =3D "rtc-ldo"; >>> }; >>> }; >>> + >>> + usb_power_supply: usb_power_supply { >>> + compatible =3D "x-powers,axp803-usb-power-supply"; >>> + status =3D "disabled"; >>> + }; >> >>No. You have added support for the AC and battery power supply drivers >>in this patchset, not for USB. > > But I added its device tree binding. Please do both at the same time. If you only add the binding without the driver, how can you be sure the binding would be a proper fit? Moreover, no one can actually test it. ChenYu From mboxrd@z Thu Jan 1 00:00:00 1970 From: wens@csie.org (Chen-Yu Tsai) Date: Mon, 25 Sep 2017 17:19:07 +0800 Subject: [linux-sunxi] Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI In-Reply-To: References: <20170920151814.22461-1-icenowy@aosc.io> <20170920151814.22461-7-icenowy@aosc.io> <7ce5c53e-70ba-456e-ecf7-5132ef2c2c64@free-electrons.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Sep 25, 2017 at 5:14 PM, Icenowy Zheng wrote: > > > ? 2017?9?25? GMT+08:00 ??5:11:57, Quentin Schulz ??: >>Hi Icenowy, >> >>On 20/09/2017 17:18, Icenowy Zheng wrote: >>> AXP803 PMIC features AC/USB/Battery power supplies. >>> >>> As we have now the device tree bindings for them, add device tree >>> nodes for them. >>> >>> Signed-off-by: Icenowy Zheng >>> --- >>> arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/allwinner/axp803.dtsi >>b/arch/arm64/boot/dts/allwinner/axp803.dtsi >>> index ff8af52743ff..3a8615231b7c 100644 >>> --- a/arch/arm64/boot/dts/allwinner/axp803.dtsi >>> +++ b/arch/arm64/boot/dts/allwinner/axp803.dtsi >>> @@ -49,6 +49,16 @@ >>> interrupt-controller; >>> #interrupt-cells = <1>; >>> >>> + ac_power_supply: ac-power-supply { >>> + compatible = "x-powers,axp221-ac-power-supply"; >>> + status = "disabled"; >>> + }; >>> + >>> + battery_power_supply: battery-power-supply { >>> + compatible = "x-powers,axp803-battery-power-supply"; >>> + status = "disabled"; >>> + }; >>> + >>> regulators { >>> /* Default work frequency for buck regulators */ >>> x-powers,dcdc-freq = <3000>; >>> @@ -147,4 +157,9 @@ >>> regulator-name = "rtc-ldo"; >>> }; >>> }; >>> + >>> + usb_power_supply: usb_power_supply { >>> + compatible = "x-powers,axp803-usb-power-supply"; >>> + status = "disabled"; >>> + }; >> >>No. You have added support for the AC and battery power supply drivers >>in this patchset, not for USB. > > But I added its device tree binding. Please do both at the same time. If you only add the binding without the driver, how can you be sure the binding would be a proper fit? Moreover, no one can actually test it. ChenYu